Re: [Xen-devel] [PATCH] xen/x86: Fix up rules when forcing -mno-sse

2015-08-12 Thread Jan Beulich
>>> On 12.08.15 at 18:12, wrote: > On 12/08/15 17:03, Doug Goldstein wrote: >> On Wed, Aug 12, 2015 at 10:38 AM, Jan Beulich wrote: >> On 12.08.15 at 17:23, wrote: From: Nathan Rossi * When forcing -mno-sse specify -mfpmath=387 to avoid the fallback warning >>> "the fa

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Wed, Aug 12, 2015 at 02:44:52PM -0400, Boris Ostrovsky wrote: > > On 08/12/2015 02:36 PM, Peter Zijlstra wrote: > > >On Wed, Aug 12, 2015 at 11:26:41AM -0700, H. Peter Anvin wrote: > > >>One option might be to do the addition in assembly, i.e.: > > >> > > >>"i" (key)

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-12 Thread Jan Beulich
>>> On 12.08.15 at 18:18, wrote: > On 12/08/15 16:58, Jan Beulich wrote: > On 12.08.15 at 17:51, wrote: >>> On Wed, Aug 12, 2015 at 5:45 PM, Jan Beulich wrote: >>> On 07.08.15 at 04:11, wrote: > All these tables will be copied to Dom0 memory except that the reused > tables(DSDT,

[Xen-devel] Ping: [PATCH] add page_get_owner_and_reference() related ASSERT()s

2015-08-12 Thread Jan Beulich
Folks on the To list: Ping? Wei: Now that all patches to go in need your ack, I'm Cc-ing you. Thanks, Jan >>> On 24.07.15 at 14:37, wrote: > The function shouldn't return NULL after having obtained a reference, > or else the caller won't know to drop it. > > Also its result shouldn't be ignore

Re: [Xen-devel] [PATCH v2 2/2] x86/HVM: correct page dirty marking in hvm_map_guest_frame_rw()

2015-08-12 Thread Jan Beulich
>>> On 12.08.15 at 19:24, wrote: > On 12/08/15 16:26, Jan Beulich wrote: > On 12.08.15 at 17:13, wrote: >>> On 12/08/15 15:19, Jan Beulich wrote: @@ -422,6 +423,14 @@ static int paging_log_dirty_op(struct do if ( !resuming ) { +/* + *

Re: [Xen-devel] [PATCH 1/2] xen: move perform_gunzip to common

2015-08-12 Thread Jan Beulich
>>> On 12.08.15 at 18:15, wrote: > On Wed, 12 Aug 2015, Jan Beulich wrote: >> >>> On 12.08.15 at 16:47, wrote: >> > @@ -31,8 +33,15 @@ typedef int decompress_fn(unsigned char *inbuf, >> > unsigned int len, >> > * dependent). >> > */ >> > >> > -decompress_fn bunzip2, unxz, unlzma, unlzo, un

Re: [Xen-devel] [PATCH] x86/p2m: clear_identity_p2m_entry() must cope with 'relaxed' RDM mode

2015-08-12 Thread Jan Beulich
>>> On 12.08.15 at 18:06, wrote: > On 12/08/15 16:05, Jan Beulich wrote: >> Tearing down a 1:1 mapping that was never established isn't really nice >> (and in fact hits an ASSERT() in p2m_remove_page()). Convert from a >> wrapper macro to a proper function which then can take care of the >> situat

[Xen-devel] [qemu-mainline test] 60664: tolerable FAIL - PUSHED

2015-08-12 Thread osstest service owner
flight 60664 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/60664/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 11 guest-start fail like 60616 Tests which did not succeed,

[Xen-devel] starting using xen

2015-08-12 Thread Zvclproject Zvclproject
Dear, In fact I'm very happy that I got emails from your mail list because i had tried many times to engage in this list but it did not work anyway it works now :). I'm currently a master student, working in virtualiztion my goal right now is to understand xen server and how it work and how I can

Re: [Xen-devel] OSSTEST -- nested test case development, RFC: ts-guest-destroy doesn't call guest_await_dhcp_tcp() if guest has fixed IP

2015-08-12 Thread Hu, Robert
> -Original Message- > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > Sent: Wednesday, August 12, 2015 11:27 PM > To: Hu, Robert > Cc: Ian Campbell; wei.l...@citrix.com; xen-devel@lists.xen.org > Subject: RE: OSSTEST -- nested test case development, RFC: ts-guest-destroy > doesn't c

[Xen-devel] [xen-unstable test] 60662: regressions - FAIL

2015-08-12 Thread osstest service owner
flight 60662 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/60662/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 16 guest-start/debian.repeat fail REGR. vs. 60647 Regressions which a

[Xen-devel] [libvirt test] 60663: tolerable FAIL - PUSHED

2015-08-12 Thread osstest service owner
flight 60663 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/60663/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-vhd 9 debian-di-installfail never pass test-armhf-armhf-libvirt-qcow2 9 debian-di

Re: [Xen-devel] [PATCH v5 11/17] vt-d: Add API to update IRTE when VT-d PI is used

2015-08-12 Thread Wu, Feng
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, August 13, 2015 1:41 AM > To: Wu, Feng; xen-devel@lists.xen.org > Cc: Zhang, Yang Z; Tian, Kevin; Keir Fraser; Jan Beulich > Subject: Re: [PATCH v5 11/17] vt-d: Add API to update IRTE when VT-d

Re: [Xen-devel] [PATCH v5 12/17] Update IRTE according to guest interrupt config changes

2015-08-12 Thread Wu, Feng
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: Thursday, August 13, 2015 12:43 AM > To: Wu, Feng > Cc: xen-devel@lists.xen.org; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v5 12/17] Update IRTE according to guest > interrupt config changes >

Re: [Xen-devel] [PATCH v5 14/17] vmx: Properly handle notification event when vCPU is running

2015-08-12 Thread Wu, Feng
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: Thursday, August 13, 2015 1:02 AM > To: Wu, Feng > Cc: xen-devel@lists.xen.org; Keir Fraser; Tian, Kevin; Jan Beulich; Andrew > Cooper > Subject: Re: [Xen-devel] [PATCH v5 14/17] vmx: Properly handl

Re: [Xen-devel] [PATCH v5 01/17] VT-d Posted-intterrupt (PI) design

2015-08-12 Thread Wu, Feng
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: Wednesday, August 12, 2015 11:35 PM > To: Wu, Feng > Cc: xen-devel@lists.xen.org; Tian, Kevin; Keir Fraser; George Dunlap; Andrew > Cooper; Jan Beulich; Zhang, Yang Z > Subject: Re: [Xen-devel] [PAT

Re: [Xen-devel] Failure to boot HVM guest with more than 32 VCPUS

2015-08-12 Thread Hao, Xudong
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, August 12, 2015 5:40 PM > To: Hao, Xudong > Cc: xen-devel@lists.xen.org > Subject: Re: [Xen-devel] Failure to boot HVM guest with more than 32 > VCPUS > > "Hao, Xudong" writes: > > > Hi, > > > >

[Xen-devel] [linux-linus test] 60659: regressions - FAIL

2015-08-12 Thread osstest service owner
flight 60659 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/60659/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl 14 guest-saverestore fail REGR. vs. 59254 test-amd64-i386-xl-xs

[Xen-devel] [ovmf test] 60661: all pass - PUSHED

2015-08-12 Thread osstest service owner
flight 60661 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/60661/ Perfect :-) All tests in this flight passed version targeted for testing: ovmf bc0f20c11a82e484cd160d5c4ddf1644653ffe2c baseline version: ovmf 5c02fc49aea514609bdb6ee21d6375fc66f

[Xen-devel] [TEST REPORT] 4.6.0-rc1 test results. (positive)

2015-08-12 Thread Konrad Rzeszutek Wilk
Hey, I ran a bunch of guests on a newly 4.6.0-rc1: F19-64 F19-32 F17-64 F17-32 F16-32 F16-64 F15-32 F15-64 NetBSD FreeBSD RHEL5-64 RHEL5-32 SLES11-32 SLES12-32 OL6_X86_64_PVHVM OL5_X86_64_PVHVM OL5_X86_PVHVM Debian7-64 and had no issues - this was on an Intel and AMD machines using an 32-bit a

[Xen-devel] [PATCH for-4.6 2/3] xl: fix vNUMA vcpus parsing

2015-08-12 Thread Wei Liu
Originally, if user didn't specify maxvcpus= in xl config file, the maximum size of vcpu bitmap was always equal to maximum number of pcpus. This might not be what user wants. Calculate the maximum number of vcpus before allocating vcpu bitmap. This requires parsing the same config options twice.

[Xen-devel] [PATCH for-4.6 1/3] xl: fix vNUMA vdistance parsing

2015-08-12 Thread Wei Liu
We should parse the output from splitting function, not the original string. Signed-off-by: Wei Liu --- tools/libxl/xl_cmdimpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 499a05c..078acd1 100644 --- a/tools/libxl

[Xen-devel] [PATCH for-4.6 3/3] libxc: fix vNUMA memory allocation

2015-08-12 Thread Wei Liu
We should use new_memflags in xc_domain_populate_physmap. That variable contains node information. Reported-by: Boris Ostrovsky Signed-off-by: Wei Liu --- tools/libxc/xc_hvm_build_x86.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/libxc/xc_hvm_build_x86.c b/to

[Xen-devel] [PATCH for-4.6 0/3] More vNUMA fixes

2015-08-12 Thread Wei Liu
Wei Liu (3): xl: fix vNUMA vdistance parsing xl: fix vNUMA vcpus parsing libxc: fix vNUMA memory allocation tools/libxc/xc_hvm_build_x86.c | 6 +- tools/libxl/xl_cmdimpl.c | 189 +++-- 2 files changed, 110 insertions(+), 85 deletions(-) -- 2.1.4

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread Peter Zijlstra
On Wed, Aug 12, 2015 at 02:44:52PM -0400, Boris Ostrovsky wrote: > On 08/12/2015 02:36 PM, Peter Zijlstra wrote: > >On Wed, Aug 12, 2015 at 11:26:41AM -0700, H. Peter Anvin wrote: > >>One option might be to do the addition in assembly, i.e.: > >> > >>"i" (key), "i" (index) > >> > >>... and put the

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread Boris Ostrovsky
On 08/12/2015 02:36 PM, Peter Zijlstra wrote: On Wed, Aug 12, 2015 at 11:26:41AM -0700, H. Peter Anvin wrote: One option might be to do the addition in assembly, i.e.: "i" (key), "i" (index) ... and put the addition into the assembly source. Like so? Seems to build on gcc-4.6. Yes, this bui

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread Peter Zijlstra
On Wed, Aug 12, 2015 at 11:26:41AM -0700, H. Peter Anvin wrote: > One option might be to do the addition in assembly, i.e.: > > "i" (key), "i" (index) > > ... and put the addition into the assembly source. Like so? Seems to build on gcc-4.6. --- arch/x86/include/asm/jump_label.h | 8

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread Boris Ostrovsky
On 08/12/2015 02:26 PM, Andy Lutomirski wrote: On Wed, Aug 12, 2015 at 11:17 AM, Boris Ostrovsky wrote: On 08/12/2015 01:46 PM, Peter Zijlstra wrote: On Wed, Aug 12, 2015 at 07:21:05PM +0200, Peter Zijlstra wrote: On Wed, Aug 12, 2015 at 09:27:38AM -0400, Boris Ostrovsky wrote: Incidentally

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread H. Peter Anvin
One option might be to do the addition in assembly, i.e.: "i" (key), "i" (index) ... and put the addition into the assembly source. On August 12, 2015 11:17:17 AM PDT, Boris Ostrovsky wrote: >On 08/12/2015 01:46 PM, Peter Zijlstra wrote: >> On Wed, Aug 12, 2015 at 07:21:05PM +0200, Peter Zijls

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread Andy Lutomirski
On Wed, Aug 12, 2015 at 11:17 AM, Boris Ostrovsky wrote: > On 08/12/2015 01:46 PM, Peter Zijlstra wrote: >> >> On Wed, Aug 12, 2015 at 07:21:05PM +0200, Peter Zijlstra wrote: >>> >>> On Wed, Aug 12, 2015 at 09:27:38AM -0400, Boris Ostrovsky wrote: >>> Incidentally, 11276d53 ("locking/static_k

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread Boris Ostrovsky
On 08/12/2015 01:46 PM, Peter Zijlstra wrote: On Wed, Aug 12, 2015 at 07:21:05PM +0200, Peter Zijlstra wrote: On Wed, Aug 12, 2015 at 09:27:38AM -0400, Boris Ostrovsky wrote: Incidentally, 11276d53 ("locking/static_keys: Add a new static_key interface") breaks old-ish compilers (gcc version 4.

Re: [Xen-devel] [PATCH] xen/x86: Fix up rules when forcing -mno-sse

2015-08-12 Thread Nathan Rossi
On Thu, Aug 13, 2015 at 2:34 AM, Doug Goldstein wrote: > On Wed, Aug 12, 2015 at 11:12 AM, Andrew Cooper > wrote: >> On 12/08/15 17:03, Doug Goldstein wrote: >>> On Wed, Aug 12, 2015 at 10:38 AM, Jan Beulich wrote: >>> On 12.08.15 at 17:23, wrote: > From: Nathan Rossi > > * Whe

Re: [Xen-devel] [PATCH] gitignore: Don't ignore *.rej

2015-08-12 Thread Daniel Kiper
On Wed, Aug 12, 2015 at 10:07:37AM +0100, Ian Campbell wrote: > These indicate a patch application went wrong, I want to see them in > "git status". This appears to have been imported from .hgignore where > it has been since 2005. > > Signed-off-by: Ian Campbell > Cc: Daniel Kiper > --- > Spotted

Re: [Xen-devel] [PATCH] x86/hvm: Fix non-onchangeonly CR write events logic

2015-08-12 Thread Razvan Cojocaru
On 08/12/2015 08:45 PM, Andrew Cooper wrote: > On 12/08/15 18:00, Razvan Cojocaru wrote: >> hvm_event_crX() already returns a bool_t to tell us whether an >> event will be sent out or not, so the extra check that value != old >> is not only useless, but also prevents non-onchangeonly events from >>

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread Peter Zijlstra
On Wed, Aug 12, 2015 at 07:21:05PM +0200, Peter Zijlstra wrote: > On Wed, Aug 12, 2015 at 09:27:38AM -0400, Boris Ostrovsky wrote: > > > Incidentally, 11276d53 ("locking/static_keys: Add a new static_key > > interface") breaks old-ish compilers (gcc version 4.4.4 20100503 (Red Hat > > 4.4.4-2) (GC

Re: [Xen-devel] [PATCH v5 01/17] VT-d Posted-intterrupt (PI) design

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 06:27:12PM +0100, Andrew Cooper wrote: > On 12/08/15 16:35, Konrad Rzeszutek Wilk wrote: > > On Wed, Aug 12, 2015 at 10:35:22AM +0800, Feng Wu wrote: > > > > The title has an extra 'i'. > > It does? It certainly has one-too-many t's. Indeed! _

Re: [Xen-devel] [PATCH] x86/hvm: Fix non-onchangeonly CR write events logic

2015-08-12 Thread Andrew Cooper
On 12/08/15 18:00, Razvan Cojocaru wrote: > hvm_event_crX() already returns a bool_t to tell us whether an > event will be sent out or not, so the extra check that value != old > is not only useless, but also prevents non-onchangeonly events from > being sent. > > Signed-off-by: Razvan Cojocaru R

Re: [Xen-devel] [PATCH v5 11/17] vt-d: Add API to update IRTE when VT-d PI is used

2015-08-12 Thread Andrew Cooper
On 12/08/15 03:35, Feng Wu wrote: > +GET_IREMAP_ENTRY(ir_ctrl->iremap_maddr, remap_index, iremap_entries, p); > + > +old_ire = new_ire = *p; > + > +/* Setup/Update interrupt remapping table entry. */ > +setup_posted_irte(&new_ire, pi_desc, gvec); > +ret = cmpxchg16b(p, &old_ire,

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread Peter Zijlstra
On Wed, Aug 12, 2015 at 07:21:05PM +0200, Peter Zijlstra wrote: > On Wed, Aug 12, 2015 at 09:27:38AM -0400, Boris Ostrovsky wrote: > > > Incidentally, 11276d53 ("locking/static_keys: Add a new static_key > > interface") breaks old-ish compilers (gcc version 4.4.4 20100503 (Red Hat > > 4.4.4-2) (GC

Re: [Xen-devel] [PATCH v5 01/17] VT-d Posted-intterrupt (PI) design

2015-08-12 Thread Andrew Cooper
On 12/08/15 16:35, Konrad Rzeszutek Wilk wrote: > On Wed, Aug 12, 2015 at 10:35:22AM +0800, Feng Wu wrote: > > The title has an extra 'i'. It does? It certainly has one-too-many t's. ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xen.org http://li

Re: [Xen-devel] [PATCH v2 2/2] x86/HVM: correct page dirty marking in hvm_map_guest_frame_rw()

2015-08-12 Thread Andrew Cooper
On 12/08/15 16:26, Jan Beulich wrote: On 12.08.15 at 17:13, wrote: >> On 12/08/15 15:19, Jan Beulich wrote: >>> +if ( writable && *writable ) >>> +{ >>> +struct hvm_write_map *track = xmalloc(struct hvm_write_map); >>> + >>> +if ( !track ) >>> +{ >>> +

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2015-08-12 Thread Peter Zijlstra
On Wed, Aug 12, 2015 at 09:27:38AM -0400, Boris Ostrovsky wrote: > Incidentally, 11276d53 ("locking/static_keys: Add a new static_key > interface") breaks old-ish compilers (gcc version 4.4.4 20100503 (Red Hat > 4.4.4-2) (GCC)): > > > > CC arch/x86/kernel/nmi.o > In file included from >

Re: [Xen-devel] [PATCH v5 17/17] Add a command line parameter for VT-d posted-interrupts

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:38AM +0800, Feng Wu wrote: > Enable VT-d Posted-Interrupts and add a command line > parameter for it. > > Signed-off-by: Feng Wu > Reviewed-by: Kevin Tian > --- > docs/misc/xen-command-line.markdown | 9 - > xen/drivers/passthrough/iommu.c | 3 +++ > 2

Re: [Xen-devel] [PATCH v5 16/17] VT-d: Dump the posted format IRTE

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:37AM +0800, Feng Wu wrote: > Add the utility to dump the posted format IRTE. > > CC: Yang Zhang > CC: Kevin Tian > Signed-off-by: Feng Wu > --- > v4: > - Newly added > > xen/drivers/passthrough/vtd/utils.c | 41 > - > 1 file c

Re: [Xen-devel] [PATCH v5 15/17] vmx: Add some scheduler hooks for VT-d posted interrupts

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:36AM +0800, Feng Wu wrote: > This patch adds the following arch hooks in scheduler: > - vmx_pre_ctx_switch_pi(): > It is called before context switch, we update the posted > interrupt descriptor when the vCPU is preempted, go to sleep, > or is blocked. > > - vmx_post_

Re: [Xen-devel] [Xen-users] "xl restore" leaks a file descriptor?

2015-08-12 Thread Wei Liu
On Wed, Aug 12, 2015 at 11:04:25AM +0100, Ian Campbell wrote: [...] > > > > > > As Andy says I think we want restore_fd in the check, I can't see any > > > reason we wouldn't want to close the socket too. > > > > > > > Do you mean migrate_fd when you say "socket"? > > In the migrate case we do

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-12 Thread Rafal Mielniczuk
On 12/08/15 11:17, Bob Liu wrote: > On 08/12/2015 01:32 AM, Jens Axboe wrote: >> On 08/11/2015 03:45 AM, Rafal Mielniczuk wrote: >>> On 11/08/15 07:08, Bob Liu wrote: On 08/10/2015 11:52 PM, Jens Axboe wrote: > On 08/10/2015 05:03 AM, Rafal Mielniczuk wrote: > ... >> Hello, >>

Re: [Xen-devel] [PATCH v5 08/17] vmx: Suppress posting interrupts when 'SN' is set

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:29AM +0800, Feng Wu wrote: > Currently, we don't support urgent interrupt, all interrupts > are recognized as non-urgent interrupt, so we cannot send > posted-interrupt when 'SN' is set. > > CC: Kevin Tian > CC: Keir Fraser > CC: Jan Beulich > CC: Andrew Cooper >

Re: [Xen-devel] [PATCH v5 09/17] VT-d: Remove pointless casts

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:30AM +0800, Feng Wu wrote: > Remove pointless casts. > > Signed-off-by: Feng Wu I am not even sure if it needs a review.. Reviewed-by: Konrad Rzeszutek Wilk > --- > v5: > - Newly added. > > xen/drivers/passthrough/vtd/utils.c | 16 +++- > 1 file chan

Re: [Xen-devel] [PATCH v5 07/17] vmx: Initialize VT-d Posted-Interrupts Descriptor

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:28AM +0800, Feng Wu wrote: > This patch initializes the VT-d Posted-interrupt Descriptor. > > CC: Kevin Tian > CC: Keir Fraser > CC: Jan Beulich > CC: Andrew Cooper > Signed-off-by: Feng Wu > Acked-by: Kevin Tian Reviewed-by: Konrad Rzeszutek Wilk > --- > v3:

Re: [Xen-devel] [PATCH v5 14/17] vmx: Properly handle notification event when vCPU is running

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:35AM +0800, Feng Wu wrote: > When a vCPU is running in Root mode and a notification event > has been injected to it. we need to set VCPU_KICK_SOFTIRQ for > the current cpu, so the pending interrupt in PIRR will be > synced to vIRR before VM-Exit in time. > > CC: Kevin

Re: [Xen-devel] [PATCH 2/2] xen/arm: support compressed kernels

2015-08-12 Thread Julien Grall
On 12/08/15 17:35, Andrew Cooper wrote: >> + >> +static int kernel_zimage64_compressed_probe(struct kernel_info *info, >> + paddr_t addr, paddr_t size) >> +{ >> +char *output, *input; >> +unsigned char magic[2]; >> +int rc; >> +unsigned kernel_order_i

[Xen-devel] [PATCH] x86/hvm: Fix non-onchangeonly CR write events logic

2015-08-12 Thread Razvan Cojocaru
hvm_event_crX() already returns a bool_t to tell us whether an event will be sent out or not, so the extra check that value != old is not only useless, but also prevents non-onchangeonly events from being sent. Signed-off-by: Razvan Cojocaru --- xen/arch/x86/hvm/hvm.c |9 +++-- 1 file ch

Re: [Xen-devel] [PATCH v5 13/17] vmx: posted-interrupt handling when vCPU is blocked

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:34AM +0800, Feng Wu wrote: > This patch includes the following aspects: > - Add a global vector to wake up the blocked vCPU > when an interrupt is being posted to it (This > part was sugguested by Yang Zhang ). > - Adds a new per-vCPU tasklet to wakeup the blocked

[Xen-devel] [PATCH for-4.6 v2] libxl: fix libxl__build_hvm error code return path

2015-08-12 Thread Wei Liu
In 25652f23 ("tools/libxl: detect and avoid conflicts with RDM"), new code was added to use rc to store libxl function call return value, which complied to libxl coding style. That patch, however, didn't change other locations where return value was stored in ret. In the end libxl__build_hvm could

Re: [Xen-devel] [PATCH v5 12/17] Update IRTE according to guest interrupt config changes

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:33AM +0800, Feng Wu wrote: > When guest changes its interrupt configuration (such as, vector, etc.) > for direct-assigned devices, we need to update the associated IRTE > with the new guest vector, so external interrupts from the assigned > devices can be injected to g

Re: [Xen-devel] [PATCH 1/2] tools: libxl: Remove unnecessary trailing \n from log messages.

2015-08-12 Thread Wei Liu
On Wed, Aug 12, 2015 at 02:56:01PM +0100, Ian Campbell wrote: > Both xl's LOG and the various libxl logging mechanisms automatically > include a trailing \n. > > Remove all unnecessary \n's from the logs messages with the following > semantic patch. > > spatch also reindents (I couldn't see how t

Re: [Xen-devel] [PATCH 2/2] xen/arm: support compressed kernels

2015-08-12 Thread Andrew Cooper
On 12/08/15 15:47, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini > CC: julien.gr...@citrix.com > CC: ian.campb...@citrix.com > --- > xen/arch/arm/kernel.c | 36 > xen/common/Makefile |2 +- > xen/include/asm-arm/byte

Re: [Xen-devel] [PATCH] xen/x86: Fix up rules when forcing -mno-sse

2015-08-12 Thread Doug Goldstein
On Wed, Aug 12, 2015 at 11:12 AM, Andrew Cooper wrote: > On 12/08/15 17:03, Doug Goldstein wrote: >> On Wed, Aug 12, 2015 at 10:38 AM, Jan Beulich wrote: >> On 12.08.15 at 17:23, wrote: From: Nathan Rossi * When forcing -mno-sse specify -mfpmath=387 to avoid the fallback

Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test each new baseline

2015-08-12 Thread Ian Campbell
On Wed, 2015-08-12 at 16:46 +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange > to test each new baseline"): > > diff --git a/cr-daily-branch b/cr-daily-branch > > index 4b9b525..f9edbd4 100755 > > --- a/cr-daily-branch > > +++ b/cr-daily-branch >

Re: [Xen-devel] [PATCH v5 11/17] vt-d: Add API to update IRTE when VT-d PI is used

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:32AM +0800, Feng Wu wrote: > This patch adds an API which is used to update the IRTE > for posted-interrupt when guest changes MSI/MSI-X information. > > CC: Yang Zhang > CC: Kevin Tian > CC: Keir Fraser > CC: Jan Beulich > CC: Andrew Cooper > Signed-off-by: Feng

[Xen-devel] [linux-3.4 test] 60657: regressions - FAIL

2015-08-12 Thread osstest service owner
flight 60657 linux-3.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/60657/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 6 xen-boot fail REGR. vs. 30511 Tests which are failing

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-12 Thread Julien Grall
On 12/08/15 16:58, Jan Beulich wrote: On 12.08.15 at 17:51, wrote: >> On Wed, Aug 12, 2015 at 5:45 PM, Jan Beulich wrote: >> On 07.08.15 at 04:11, wrote: All these tables will be copied to Dom0 memory except that the reused tables(DSDT, SPCR, etc) will be mapped to Dom0. >>> >

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-12 Thread Andrew Turner
On Wed, 12 Aug 2015 10:21:55 +0100 Julien Grall wrote: > Hi, > > (Cc Andrew Turner who worked on the ACPI port for FreeBSD ARM64) > > On 12/08/2015 09:52, Ian Campbell wrote: > > On Wed, 2015-08-12 at 11:04 +0800, Shannon Zhao wrote: > >> Hi Julien, > >> > >> On 2015/8/12 0:19, Julien Grall wro

Re: [Xen-devel] [PATCH 1/2] xen: move perform_gunzip to common

2015-08-12 Thread Stefano Stabellini
On Wed, 12 Aug 2015, Jan Beulich wrote: > >>> On 12.08.15 at 16:47, wrote: > > --- a/xen/common/decompress.c > > +++ b/xen/common/decompress.c > > @@ -16,6 +16,8 @@ int __init decompress(void *inbuf, unsigned int len, void > > *outbuf) > > (!memcmp(inbuf, "\037\213", 2) || !memcmp(inbuf

Re: [Xen-devel] [PATCH] xen/x86: Fix up rules when forcing -mno-sse

2015-08-12 Thread Andrew Cooper
On 12/08/15 17:03, Doug Goldstein wrote: > On Wed, Aug 12, 2015 at 10:38 AM, Jan Beulich wrote: > On 12.08.15 at 17:23, wrote: >>> From: Nathan Rossi >>> >>> * When forcing -mno-sse specify -mfpmath=387 to avoid the fallback >>> warning >> "the fallback warning" being what? I've never seen

[Xen-devel] [PATCH OSSTEST] ts-xen-install: Install netcat-openbsd

2015-08-12 Thread Ian Campbell
This is required by libvirt for live migration (netcat-traditional doesn't cut it). netcat-openbsd has higher update-alternatives priority, so it will be used if installed. Signed-off-by: Ian Campbell Cc: Jim Fehlig --- ts-xen-install | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

Re: [Xen-devel] [PATCH] x86/p2m: clear_identity_p2m_entry() must cope with 'relaxed' RDM mode

2015-08-12 Thread Andrew Cooper
On 12/08/15 16:05, Jan Beulich wrote: > Tearing down a 1:1 mapping that was never established isn't really nice > (and in fact hits an ASSERT() in p2m_remove_page()). Convert from a > wrapper macro to a proper function which then can take care of the > situation. > > Also take the opportunity to re

Re: [Xen-devel] [PATCH] xen/x86: Fix up rules when forcing -mno-sse

2015-08-12 Thread Doug Goldstein
On Wed, Aug 12, 2015 at 10:38 AM, Jan Beulich wrote: On 12.08.15 at 17:23, wrote: >> From: Nathan Rossi >> >> * When forcing -mno-sse specify -mfpmath=387 to avoid the fallback >> warning > > "the fallback warning" being what? I've never seen any, and I don't > think I've ever heard anyon

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-12 Thread Jan Beulich
>>> On 12.08.15 at 17:51, wrote: > On Wed, Aug 12, 2015 at 5:45 PM, Jan Beulich wrote: > On 07.08.15 at 04:11, wrote: >>> All these tables will be copied to Dom0 memory except that the reused >>> tables(DSDT, SPCR, etc) will be mapped to Dom0. >> >> Which again seems odd - such tables should

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-12 Thread Christoffer Dall
On Wed, Aug 12, 2015 at 5:45 PM, Jan Beulich wrote: On 07.08.15 at 04:11, wrote: >> 1. Copy and change some EFI and ACPI tables >> --- > > A key thing I'm missing here is reasoning of why this copying approach > is needed in the first place. Remember t

Re: [Xen-devel] [PATCH for-4.6] libxl: fix libxl__build_hvm error code return path

2015-08-12 Thread Ian Jackson
Wei Liu writes ("[PATCH for-4.6] libxl: fix libxl__build_hvm error code return path"): > In 25652f23 ("tools/libxl: detect and avoid conflicts with RDM"), new > code was added to use rc to store libxl function call return value, > which complied to libxl coding style. That patch, however, didn't c

Re: [Xen-devel] [PATCH OSSTEST 3/7] ts-debian-di-install: Install pv-menu-list in ARM guests, always.

2015-08-12 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH OSSTEST 3/7] ts-debian-di-install: Install pv-menu-list in ARM guests, always."): > On Wed, 2015-08-12 at 16:35 +0100, Ian Jackson wrote: > > "pvgrub" here is pvgrub1, not pv grub2. This could perhaps be > > clearer... > > Yes, although pvgrub is what we use in p

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-12 Thread Jan Beulich
>>> On 11.08.15 at 16:12, wrote: > On Fri, 2015-08-07 at 10:11 +0800, Shannon Zhao wrote: >> > [...] >> 3. Dom0 gets grant table and event channel irq information >> --- >> As said above, we assign the hypervisor_id be "XenVMM" to tell Dom0

Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test each new baseline

2015-08-12 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test each new baseline"): > diff --git a/cr-daily-branch b/cr-daily-branch > index 4b9b525..f9edbd4 100755 > --- a/cr-daily-branch > +++ b/cr-daily-branch > @@ -100,6 +100,13 @@ if [ "x$OSSTEST_BASELINES_ONLY" = xy ] ; then

Re: [Xen-devel] [PATCH v5 06/17] vmx: Add some helper functions for Posted-Interrupts

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:27AM +0800, Feng Wu wrote: > This patch adds some helper functions to manipulate the > Posted-Interrupts Descriptor. > > CC: Kevin Tian > CC: Keir Fraser > CC: Jan Beulich > CC: Andrew Cooper > Signed-off-by: Feng Wu Reviewed-by: Konrad Rzeszutek Wilk > --- > v

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 2

2015-08-12 Thread Jan Beulich
>>> On 07.08.15 at 04:11, wrote: > 1. Copy and change some EFI and ACPI tables > --- A key thing I'm missing here is reasoning of why this copying approach is needed in the first place. Remember that on the x86 side we get away without any such copying-and-

Re: [Xen-devel] [PATCH v5 05/17] vmx: Extend struct pi_desc to support VT-d Posted-Interrupts

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:26AM +0800, Feng Wu wrote: > Extend struct pi_desc according to VT-d Posted-Interrupts Spec. > > CC: Kevin Tian > CC: Keir Fraser > CC: Jan Beulich > CC: Andrew Cooper > Signed-off-by: Feng Wu > Reviewed-by: Andrew Cooper > Acked-by: Kevin Tian Reviewed-by: Ko

Re: [Xen-devel] [PATCH OSSTEST 3/7] ts-debian-di-install: Install pv-menu-list in ARM guests, always.

2015-08-12 Thread Ian Campbell
On Wed, 2015-08-12 at 16:35 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST 3/7] ts-debian-di-install: Install > pv-menu-list in ARM guests, always."): > > Signed-off-by: Ian Campbell > > This package seems to be called `pv-grub-menu', not `pv-menu-list'. I get that wrong more

Re: [Xen-devel] [PATCH v2 1/2] x86/HVM: hvm_map_guest_frame_rw() adjustments

2015-08-12 Thread Andrew Cooper
On 12/08/15 15:16, Jan Beulich wrote: > ... and its callers. > > While all non-nested users are made fully honor the semantics of that > type, doing so in the nested case seemed insane (if doable at all, > considering VMCS shadowing), and hence there the respective operations > are simply made fail

Re: [Xen-devel] [PATCH 2/2] xen/arm: support compressed kernels

2015-08-12 Thread Ian Campbell
On Wed, 2015-08-12 at 16:22 +0100, Stefano Stabellini wrote: > -obj-bin-$(CONFIG_X86) += $(foreach n,decompress gunzip bunzip2 unxz > > > unlzma unlzo unlz4 earlycpio,$(n).init.o) > > > +obj-bin-y += $(foreach n,decompress gunzip bunzip2 unxz unlzma unlzo > > > unlz4 earlycpio,$(n).init.o) > > >

Re: [Xen-devel] [PATCH OSSTEST 7/7] Debian: Create /boot/boot -> . symlink on ARM when PvMenuLst enabled

2015-08-12 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST 7/7] Debian: Create /boot/boot -> . symlink on ARM when PvMenuLst enabled"): > Signed-off-by: Ian Campbell Can this please be conditional on the suite ? Thanks, Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.

Re: [Xen-devel] [PATCH 2/2] xen/arm: support compressed kernels

2015-08-12 Thread Stefano Stabellini
On Wed, 12 Aug 2015, Jan Beulich wrote: > >>> On 12.08.15 at 17:22, wrote: > > On Wed, 12 Aug 2015, Ian Campbell wrote: > >> On Wed, 2015-08-12 at 15:47 +0100, Stefano Stabellini wrote: > >> > --- a/xen/common/Makefile > >> > +++ b/xen/common/Makefile > >> > @@ -56,7 +56,7 @@ obj-y += vsprintf.o >

Re: [Xen-devel] [PATCH OSSTEST] Toolstack/libvirt: use URI in migration command

2015-08-12 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH OSSTEST] Toolstack/libvirt: use URI in migration command"): > Sounds like we should just add it to the list of packages which we install > either at host install time or as part of preparing a host for use. I'm > inclined just to add it at install time,

Re: [Xen-devel] [PATCH OSSTEST 6/7] Debian: ARM has no bootloader (for Xen) even in Stretch.

2015-08-12 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST 6/7] Debian: ARM has no bootloader (for Xen) even in Stretch."): > Realistically this isn't going to change until we have either u-boot > or UEFI in an arm32 guest. Acked-by: Ian Jackson ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH OSSTEST 5/7] Debian: ARM: only apply no bootloader workaround if xopts{PvMenuLst}

2015-08-12 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST 5/7] Debian: ARM: only apply no bootloader workaround if xopts{PvMenuLst}"): > This workaround is only necessary because of how pv-menu-list works, > so we should only apply both or neither of them. > > This results in a long line and I'm about to add a second

Re: [Xen-devel] [PATCH v5 04/17] vt-d: VT-d Posted-Interrupts feature detection

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:25AM +0800, Feng Wu wrote: > VT-d Posted-Interrupts is an enhancement to CPU side Posted-Interrupt. > With VT-d Posted-Interrupts enabled, external interrupts from > direct-assigned devices can be delivered to guests without VMM > intervention when guest is running in

Re: [Xen-devel] [PATCH v5 03/17] iommu: Add iommu_intpost to control VT-d Posted-Interrupts feature

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:24AM +0800, Feng Wu wrote: > VT-d Posted-Interrupts is an enhancement to CPU side Posted-Interrupt. > With VT-d Posted-Interrupts enabled, external interrupts from > direct-assigned devices can be delivered to guests without VMM > intervention when guest is running in

Re: [Xen-devel] [PATCH OSSTEST 4/7] ts-debian-di-install: Use the suite in the default hostname

2015-08-12 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST 4/7] ts-debian-di-install: Use the suite in the default hostname"): > This is more useful in standalone mode than having everything be > "debian". ... > -our $guesthost= "$gn.guest.osstest"; > +our $guesthost= ($r{"${gn}_suite"}//$gn).".guest.osstest"; So if G

Re: [Xen-devel] [PATCH] xen/x86: Fix up rules when forcing -mno-sse

2015-08-12 Thread Jan Beulich
>>> On 12.08.15 at 17:23, wrote: > From: Nathan Rossi > > * When forcing -mno-sse specify -mfpmath=387 to avoid the fallback > warning "the fallback warning" being what? I've never seen any, and I don't think I've ever heard anyone else say there was one. Apart from that I don't think -mfpma

Re: [Xen-devel] [PATCH v5 02/17] Add cmpxchg16b support for x86-64

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:23AM +0800, Feng Wu wrote: > This patch adds cmpxchg16b support for x86-64, so software > can perform 128-bit atomic write/read. > > CC: Keir Fraser > CC: Jan Beulich > CC: Andrew Cooper > Signed-off-by: Feng Wu > --- > v5: > - Change back the parameters of __cmpx

Re: [Xen-devel] [PATCH OSSTEST 3/7] ts-debian-di-install: Install pv-menu-list in ARM guests, always.

2015-08-12 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST 3/7] ts-debian-di-install: Install pv-menu-list in ARM guests, always."): > Signed-off-by: Ian Campbell This package seems to be called `pv-grub-menu', not `pv-menu-list'. > @@ -190,9 +190,18 @@ END > > $method_cfg = setup_netboot($tmpdir, $arch, $su

Re: [Xen-devel] [PATCH 2/2] xen/arm: support compressed kernels

2015-08-12 Thread Jan Beulich
>>> On 12.08.15 at 17:22, wrote: > On Wed, 12 Aug 2015, Ian Campbell wrote: >> On Wed, 2015-08-12 at 15:47 +0100, Stefano Stabellini wrote: >> > --- a/xen/common/Makefile >> > +++ b/xen/common/Makefile >> > @@ -56,7 +56,7 @@ obj-y += vsprintf.o >> > obj-y += wait.o >> > obj-y += xmalloc_tlsf.o >

Re: [Xen-devel] [PATCH v5 01/17] VT-d Posted-intterrupt (PI) design

2015-08-12 Thread Konrad Rzeszutek Wilk
On Wed, Aug 12, 2015 at 10:35:22AM +0800, Feng Wu wrote: The title has an extra 'i'. > Add the design doc for VT-d PI. > > CC: Kevin Tian > CC: Yang Zhang > CC: Jan Beulich > CC: Keir Fraser > CC: Andrew Cooper > CC: George Dunlap > Signed-off-by: Feng Wu > Reviewed-by: Kevin Tian > ---

Re: [Xen-devel] [PATCH OSSTEST 2/7] ts-debian-di-install: Use exit/poweroff in preference to exit/always_halt

2015-08-12 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST 2/7] ts-debian-di-install: Use exit/poweroff in preference to exit/always_halt"): > always_halt results in d-i calling "halt", which does not necessarily > poweroff the host (it seems to for x86/PV Xen guests, but does not for > ARM). Using exit/poweroff calls

[Xen-devel] [PATCH OSSTEST 1/7] ts-logs-capture: Collect /var/log/xen/bootloader.*.log

2015-08-12 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST 1/7] ts-logs-capture: Collect /var/log/xen/bootloader.*.log"): > This is the pygrub debug log. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 2/2] xen/arm: support compressed kernels

2015-08-12 Thread Julien Grall
On 12/08/15 16:22, Stefano Stabellini wrote: >>> obj-$(perfc) += perfc.o >>> obj-$(crash_debug) += gdbstub.o >>> diff --git a/xen/include/asm-arm/byteorder.h b/xen/include/asm >>> -arm/byteorder.h >>> index 9c712c4..3b7feda 100644 >>> --- a/xen/include/asm-arm/byteorder.h >>> +++ b/xen/incl

Re: [Xen-devel] OSSTEST -- nested test case development, RFC: ts-guest-destroy doesn't call guest_await_dhcp_tcp() if guest has fixed IP

2015-08-12 Thread Ian Jackson
Hu, Robert writes ("RE: OSSTEST -- nested test case development, RFC: ts-guest-destroy doesn't call guest_await_dhcp_tcp() if guest has fixed IP"): > So shall I conclude as following?: > 1. Xen install shall create xenbr0 bridge with dhcp mode; Apply to > both L0 and L1. I think ts-xen-install

Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test each new baseline

2015-08-12 Thread Ian Campbell
On Wed, 2015-08-12 at 15:08 +0100, Ian Campbell wrote: > I think I need to do something with check_tested to find a flight in the > database. I came up with this incremental patch. I need to generate an up to date baseline for a flight on the Cambridge infra in order to fully test all the cases so

Re: [Xen-devel] [PATCH v2 2/2] x86/HVM: correct page dirty marking in hvm_map_guest_frame_rw()

2015-08-12 Thread Jan Beulich
>>> On 12.08.15 at 17:13, wrote: > On 12/08/15 15:19, Jan Beulich wrote: >> +if ( writable && *writable ) >> +{ >> +struct hvm_write_map *track = xmalloc(struct hvm_write_map); >> + >> +if ( !track ) >> +{ >> +put_page(page); >> +return NULL;

  1   2   3   >