Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-10 Thread Chun Yan Liu
>>> On 11/11/2015 at 02:11 AM, in message <22082.13115.276320.572...@mariner.uk.xensource.com>, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API"): > > On Tue, Nov 10, 2015 at 8:41 AM, Chun Yan Liu wrote: > > > Which cast? Here, we want to get a

Re: [Xen-devel] ovmf fail to compile

2015-11-10 Thread Hao, Xudong
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: Friday, November 6, 2015 6:24 PM > To: Hao, Xudong > Cc: Wei Liu ; xen-devel@lists.xen.org > Subject: Re: [Xen-devel] ovmf fail to compile > > On Fri, Nov 06, 2015 at 08:53:27AM +, Hao, Xudong wrote: > > > -

Re: [Xen-devel] Osstest nested patch v15 (was RE: [OSSTEST PATCH v14 PART 2 10-26/26] Nested HVM testing)

2015-11-10 Thread Hu, Robert
> -Original Message- > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > Sent: Wednesday, November 11, 2015 3:46 AM > To: Hu, Robert > Cc: Ian Campbell ; Jin, Gordon > ; xen-de...@lists.xenproject.org > Subject: Osstest nested patch v15 (was RE: [OSSTEST PATCH v14 PART 2 > 10-26/26] N

[Xen-devel] [linux-4.1 baseline-only test] 38265: trouble: blocked/broken/fail/pass

2015-11-10 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 38265 linux-4.1 real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38265/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-10 Thread Chun Yan Liu
>>> On 11/11/2015 at 01:57 AM, in message , George Dunlap wrote: > On Tue, Nov 10, 2015 at 8:41 AM, Chun Yan Liu wrote: > >> > +void libxl__device_usbctrl_add(libxl__egc *egc, uint32_t domid, > >> > + libxl_device_usbctrl *usbctrl, > >> > +

Re: [Xen-devel] [PATCH v9 15/17] vmx: VT-d posted-interrupt core logic handling

2015-11-10 Thread Wu, Feng
> -Original Message- > From: Dario Faggioli [mailto:dario.faggi...@citrix.com] > Sent: Wednesday, November 11, 2015 12:59 AM > To: Wu, Feng ; xen-devel@lists.xen.org > Cc: Tian, Kevin ; Keir Fraser ; George > Dunlap ; Andrew Cooper > ; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v9 15/

Re: [Xen-devel] [libvirt] [vbox-dev] Assert with libvirt + xen hvm

2015-11-10 Thread Cole Robinson
Reviving old thread, this came up again via a Fedora bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1278847 https://retrace.fedoraproject.org/faf/reports/597209/ I took a cursory look at libxl's sigchld handling... it's intense to say the least, but there's some driver options that tweak

Re: [Xen-devel] [RFC 03/29] build: hookup initial Kconfig usage

2015-11-10 Thread Doug Goldstein
On 10/6/15 7:36 AM, Jan Beulich wrote: On 06.10.15 at 11:58, wrote: >> On 05/10/15 23:03, Doug Goldstein wrote: >>> new file mode 100644 >>> index 000..e69de29 >>> diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig >>> new file mode 100644 >>> index 000..5e34f4e >>> --- /dev/nul

[Xen-devel] [linux-4.1 test] 63996: tolerable FAIL - PUSHED

2015-11-10 Thread osstest service owner
flight 63996 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/63996/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-rumpuserxen-amd64 15 rumpuserxen-demo-xenstorels/xenstorels.repeat fail REGR. vs. 63341 test-

Re: [Xen-devel] [PATCH v2 2/8] xen: arm: fix typo in the description of struct pending_irq->desc

2015-11-10 Thread Julien Grall
Hi Ian, On 10/11/2015 16:21, Ian Campbell wrote: s/it/if/ makes more sense. Signed-off-by: Ian Campbell Reviewed-by: Julien Grall Regards, --- xen/include/asm-arm/vgic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-ar

Re: [Xen-devel] [PATCH v2 1/8] xen: arm: fix indendation of struct vtimer

2015-11-10 Thread Julien Grall
Hi Ian, On 10/11/2015 16:21, Ian Campbell wrote: Signed-off-by: Ian Campbell Reviewed-by: Julien Grall Regards, --- xen/include/asm-arm/domain.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h in

[Xen-devel] [PATCH RESEND] xen/gntdev: Grant maps should not be subject to NUMA balancing

2015-11-10 Thread Boris Ostrovsky
Doing so will cause the grant to be unmapped and then, during fault handling, the fault to be mistakenly treated as NUMA hint fault. In addition, even if those maps could partcipate in NUMA balancing, it wouldn't provide any benefit since we are unable to determine physical page's node (even if/wh

[Xen-devel] [OSSTEST PATCH 07/22] target_check_ip: Rename and improve from guest_check_ip

2015-11-10 Thread Ian Jackson
Make this function suitable for running on targets with static IP addresses. (Ie, on physical hosts.) Accordingly, rename it and adjust all call sites. Signed-off-by: Ian Jackson Tested-by: Robert Ho --- v14: New patch --- Osstest/TestSupport.pm | 11 ++- ts-guest-localmigrate |

[Xen-devel] [OSSTEST PATCH 10/22] Toolstack::xl: Provide block_attach method

2015-11-10 Thread Ian Jackson
It is possible that this may work some of the time with xm, so I have taken no measures to prevent it running then. Signed-off-by: Ian Jackson Signed-off-by: Robert Hu Tested-by: Robert Hu v14: New patch v15: Fix missing $ho assignment in block-attach method --- Osstest/Toolstack/xl.pm |

[Xen-devel] [OSSTEST PATCH 05/22] Nested hosts: Provide PDU power method

2015-11-10 Thread Ian Jackson
From: Robert Ho This `guest' power method uses VM create/destroy. It is automatically used for nested hosts. It would not make much sense to configure it manually. For nested host/guest, its power on/off method shall be its host invoke $(toolstack)->create/destroy method. Signed-off-by: Rober

Re: [Xen-devel] [PATCH] xen/gntdev: Grant maps should not be subject to NUMA balancing

2015-11-10 Thread Boris Ostrovsky
On 11/10/2015 02:36 PM, Konrad Rzeszutek Wilk wrote: On Tue, Nov 10, 2015 at 02:22:44PM -0500, Boris Ostrovsky wrote: Doing so will cause the grant to be unmapped and then, during fault handling, the fault to be mistakenly treated as NUMA hint fault. In addition, even if we those maps could par

[Xen-devel] [OSSTEST PATCH 01/22] cs-adjust-flight: Add some missing doc comment info

2015-11-10 Thread Ian Jackson
Signed-off-by: Ian Jackson --- v14: New patch --- cs-adjust-flight |8 1 file changed, 8 insertions(+) diff --git a/cs-adjust-flight b/cs-adjust-flight index 4bfef48..d70abf7 100755 --- a/cs-adjust-flight +++ b/cs-adjust-flight @@ -24,6 +24,14 @@ # . means all job

[Xen-devel] [OSSTEST PATCH 12/22] sg-run-job: Provide infrastructure for layers of nesting

2015-11-10 Thread Ian Jackson
Provides nested-layer-descend, which can be called in an individual test job at the appropriate point (after the L1 has been set up). The inner host is a guest of the outer host; powering it off means destroying it. Putting the poweroff at this point in the loop, rather than in per-host-finish, a

[Xen-devel] [OSSTEST PATCH 11/22] sg-run-job: Break out per-host-prep and per-host-finish

2015-11-10 Thread Ian Jackson
No functional change. We now call the per-host-ts finish steps unconditionally, rather than only if !$need_build_host, per-host-ts is (complicated) no-op if $need_build_host, since in that case $need_xen_hosts is {}. Signed-off-by: Ian Jackson Tested by: Robert Ho --- v14: Squash typo fix from

[Xen-devel] [OSSTEST PATCH 20/22] HVM guests: Use qemu "pipe:" for serial output logging

2015-11-10 Thread Ian Jackson
Modern qemu has the "pipe:/PATH" character driver. This opens /PATH.in for reading and /PATH.out for writing. In my tests, I found that: - contrary to the documentation, they do not need to be pipes (at least, /PATH.out can be a file) - but they must both already exist - qemu will follo

[Xen-devel] [OSSTEST PATCH 21/22] Serial: Factor out Osstest::Serial::keys_real

2015-11-10 Thread Ian Jackson
The sympathy and xenuse serial modules had too much in common. Factor out the common code, which is now responsible for - knowledge of the Xen console switch - splitting strings up into individual keys - timing decisions - error trapping and logging This new class is an abstract base clas

[Xen-devel] [OSSTEST PATCH 16/22] ts-xen-install: Properly handle hosts without a static IP address

2015-11-10 Thread Ian Jackson
From: Robert Ho Check IpStatic, and if it is not set, provide a dhcp stanza in /etc/network/interfaces, rather than an `inet static' one. This is necessary for L1 nested hosts, because they don't have a static IP address. In principle this makes matters more correct for physical hosts without s

[Xen-devel] [OSSTEST PATCH 17/22] ts-xen-install: networking: Rename `nodhcp' to `ensurebridge'

2015-11-10 Thread Ian Jackson
This function does not (now) always undo the DHCP configuration. Sometimes it leaves it. Its main function is to ensure that we have a bridge for use by guests. So rename the function. Signed-off-by: Ian Jackson Tested-by: Robert Ho --- v14: This patch was previously 4/4 of a miniature series

[Xen-devel] [OSSTEST PATCH 08/22] await_tcp(): Run check_ip on each loop iteration

2015-11-10 Thread Ian Jackson
From: Robert Ho await_tcp is often invoked after a reboot. In this situation the target's IP address may change. If this happens while await_tcp is running, we would continue to poll the old IP address. Fix this by running target_check_ip on each iteration. Signed-off-by: Robert Ho Signed-off

[Xen-devel] [OSSTEST PATCH 06/22] DhcpWatch::leases: Fix a reporting message

2015-11-10 Thread Ian Jackson
This talks about `guest_check_ip', but this code is now factored out into a method. Use the correct method name in reporting. Signed-off-by: Ian Jackson Tested-by: Robert Ho --- v14: New patch --- Osstest/DhcpWatch/leases.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Xen-devel] [OSSTEST PATCH v16 00/22] Nested HVM

2015-11-10 Thread Ian Jackson
This series is also available at: git://xenbits.xen.org/people/iwj/osstest.git http://xenbits.xen.org/git-http/people/iwj/osstest.git in wip.nested-hvm.v16..wip.nested-hvm.v16 The first three of these patches are IMO ready to go in whenever. The rest of them are ready, but are part of the Nes

[Xen-devel] [OSSTEST PATCH 15/22] Nested HVM: Add test job to appropriate flights

2015-11-10 Thread Ian Jackson
From: Robert Ho Signed-off-by: longtao.pang Signed-off-by: Robert Ho Signed-off-by: Ian Jackson Tested-by: Robert Ho --- v14: Use default gueststorage_size, rather than setting runvar. Dropped acked from Ian Campbell. --- make-flight | 28 1 file changed,

[Xen-devel] [OSSTEST PATCH 03/22] selecthost: Minor cleanups

2015-11-10 Thread Ian Jackson
Document the syntax for $ident. Log the ident as well as the selected hostname. Signed-off-by: Ian Jackson Tested-by: Robert Ho --- v14: New patch --- Osstest/TestSupport.pm | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/Osstest/TestSupport.pm b/Osstest/

[Xen-devel] [OSSTEST PATCH 09/22] LVM: Break out lv_create

2015-11-10 Thread Ian Jackson
We are going to want to reuse this. Signed-off-by: Ian Jackson Signed-off-by: Robert Ho Tested-by: Robert Ho --- v14: New patch v15: Change some trivial typo, so to resolve conflicts with production tree. --- Osstest/TestSupport.pm | 15 +++ 1 file changed, 11 insertions(+),

[Xen-devel] [OSSTEST PATCH 14/22] Nested HVM: Provide test-nested recipe

2015-11-10 Thread Ian Jackson
From: Robert Ho Signed-off-by: Robert Ho Signed-off-by: Ian Jackson Tested-by: Robert Ho --- v14: ts-nested-setup command line syntax updated. v15: (Robert Ho) remove the unnecessary l1 destroy; as it will implicitly powered off by framework as a nested host. This change hasn't been

[Xen-devel] [OSSTEST PATCH 02/22] cs-adjust-flight: Allow adjusting "this" flight

2015-11-10 Thread Ian Jackson
This allows cs-adjust-flight to be run by hand to adjust runvars, in a flight being used with hand-invocation of ./ts-* scripts. Signed-off-by: Ian Jackson --- v14: New patch --- cs-adjust-flight |8 1 file changed, 8 insertions(+) diff --git a/cs-adjust-flight b/cs-adjust-flight i

[Xen-devel] [OSSTEST PATCH 18/22] Osstest/Testsupport.pm: change target's default kernkind to 'pvops'

2015-11-10 Thread Ian Jackson
This is safe only if no existing flights would be affected. (That is, the meaning of no existing sets of runvars would be changed.) To check whether this would make any difference I did some database searches. Since any time target_kernkind_check is called it sets a corresponding `console' runva

[Xen-devel] [OSSTEST PATCH 13/22] Nested HVM: Provide ts-nested-setup to help make L1 usable as a host

2015-11-10 Thread Ian Jackson
From: Robert Ho * Provide the L1 with some storage for its own guests' disks * Install some packages in the L1 * Optionally, set a runvar defining the L1 for the rest of the job The recipe is going to run ts-xen-install etc. Signed-off-by: longtao.pang Signed-off-by: Robert Ho Signed-off-by:

[Xen-devel] [OSSTEST PATCH 22/22] Serial: Add new serial method object for `guest' type

2015-11-10 Thread Ian Jackson
From: Robert Ho L1 guests' serial ports are owned by qemu in L0. We can send them debug keys by writing to the qemu pipe. (xl debug-key looks like it would be useful but it actually sends debug keys to the hypervisor of the host it is running on. We want to send the debug keys to the hyperviso

[Xen-devel] [OSSTEST PATCH 04/22] selecthost: Support nested hosts (guests which are also hosts)

2015-11-10 Thread Ian Jackson
We introduce a new syntax: instead of a hostname (which might appear in a command line argument to a ts-* script and hence be passed to selecthost, or which might be in a runvar), we now support :. Such `hosts' (let us refer to such a thing as an L1, although in principle further nesting may be po

[Xen-devel] [OSSTEST PATCH 19/22] Osstest/Testsupport.pm: use get_target_property() for some host setup

2015-11-10 Thread Ian Jackson
From: Robert Ho For nested cases, nested host can inherit its host's property for dhcp watch setup and ether_prefix property setup. Signed-off-by: Robert Ho Tested-by: Robert Ho --- v15: New patch --- Osstest/TestSupport.pm |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

Re: [Xen-devel] [PATCH v2 1/3] xsm/xen_version: Add XSM for the xen_version hypercall.

2015-11-10 Thread Daniel De Graaf
On 06/11/15 14:36, Konrad Rzeszutek Wilk wrote: All of XENVER_* have now an XSM check. The subops for XENVER_[compile_info|changeset|commandline| extraversion] are now priviliged operations. To not break guests we still return an string - but it is just ''. The rest: XENVER_[version|capabilitie

[Xen-devel] Osstest nested patch v15 (was RE: [OSSTEST PATCH v14 PART 2 10-26/26] Nested HVM testing)

2015-11-10 Thread Ian Jackson
Hu, Robert writes ("Osstest nested patch v15 (was RE: [OSSTEST PATCH v14 PART 2 10-26/26] Nested HVM testing)"): > I here hand over to you the v15 patch bundle as attached. Hope it can pass > your pretest soon. Thanks. (CCing the list.) All of your fixes were good. Thank you. I have incorpor

[Xen-devel] [qemu-mainline test] 63957: regressions - FAIL

2015-11-10 Thread osstest service owner
flight 63957 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/63957/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 7 host-ping-check-xen fail REGR. vs. 63705 Regressions which a

Re: [Xen-devel] [PATCH] xen/gntdev: Grant maps should not be subject to NUMA balancing

2015-11-10 Thread Konrad Rzeszutek Wilk
On Tue, Nov 10, 2015 at 02:22:44PM -0500, Boris Ostrovsky wrote: > Doing so will cause the grant to be unmapped and then, during > fault handling, the fault to be mistakenly treated as NUMA hint > fault. > > In addition, even if we those maps could partcipate in NUMA > balancing it wouldn't provid

Re: [Xen-devel] [PATCH v2 2/2] arm: export platform_op XENPF_settime64

2015-11-10 Thread Daniel De Graaf
On 09/11/15 12:32, sstabell...@kernel.org wrote: From: Stefano Stabellini Call update_domain_wallclock_time at domain initialization, specifically in arch_set_info_guest for vcpu0, like we do on x86. Set time_offset_seconds to the number of seconds between phisical boot and domain initializatio

[Xen-devel] [PATCH] xen/gntdev: Grant maps should not be subject to NUMA balancing

2015-11-10 Thread Boris Ostrovsky
Doing so will cause the grant to be unmapped and then, during fault handling, the fault to be mistakenly treated as NUMA hint fault. In addition, even if we those maps could partcipate in NUMA balancing it wouldn't provide any benefit since we wouldn't be able to determine physical page's node (ev

[Xen-devel] Updated Xen Contributor Training

2015-11-10 Thread Lars Kurth
I Updated XP Contributor Training - Pt 2 Processes and Conventions v1.1.pdf and had to split it into two files due to the file size See http://wiki.xenproject.org/wiki/Contributor_Training, http://www.slideshare.net/xen_com_mgr/xenprojectcontributortrainingpart2processesandconventionsv11-2 and

Re: [Xen-devel] [PATCH 3/4] x86/SVM: don't exceed segment limit when fetching instruction bytes

2015-11-10 Thread Boris Ostrovsky
On 11/10/2015 12:40 PM, Jan Beulich wrote: Also consistently use the vmcb local variable whenever possible. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/svm/emulate.c +++ b/xen/arch/x86/hvm/svm/emulate.c Reviewed-by: Boris Ostrovsky ___ Xe

Re: [Xen-devel] [PATCH 4/4] x86/traps: honor EXT bit in error codes

2015-11-10 Thread Andrew Cooper
On 10/11/15 17:40, Jan Beulich wrote: > The specification does not explicitly limit the use of this bit to > exceptions that can have selector style error codes, so to be on the > safe side we should deal with it being set even on error codes formally > documented to be always zero (if they're inde

Re: [Xen-devel] [PATCH v9 15/17] vmx: VT-d posted-interrupt core logic handling

2015-11-10 Thread Dario Faggioli
On Tue, 2015-11-03 at 16:43 +0800, Feng Wu wrote: > This patch includes the following aspects: > - Handling logic when vCPU is blocked: > * Add a global vector to wake up the blocked vCPU > when an interrupt is being posted to it (This part > was sugguested by Yang Zhang ). > *

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-10 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API"): > On Tue, Nov 10, 2015 at 8:41 AM, Chun Yan Liu wrote: > > Which cast? Here, we want to get a uint_8 value, but buf is a string, > > we need to do atoi. > > atoi() isn't a cast, it's a function call. The cast is the (c

[Xen-devel] [xen-4.3-testing test] 63948: regressions - FAIL

2015-11-10 Thread osstest service owner
flight 63948 xen-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/63948/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-migrupgrade 21 guest-migrate/src_host/dst_host fail REGR. vs. 63212 Regression

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-10 Thread George Dunlap
On Tue, Nov 10, 2015 at 8:41 AM, Chun Yan Liu wrote: >> > +void libxl__device_usbctrl_add(libxl__egc *egc, uint32_t domid, >> > + libxl_device_usbctrl *usbctrl, >> > + libxl__ao_device *aodev) >> > +{ >> >> Thanks for adjusting the error-

Re: [Xen-devel] [PATCH 2/4] x86/HVM: unify and fix #UD intercept

2015-11-10 Thread Andrew Cooper
On 10/11/15 17:39, Jan Beulich wrote: > The SVM and VMX versions really were identical, so instead of fixing > the same issue in two places, fold them at once. The issue fixed is the > missing seg:off -> linear translation of the current code address. > > Signed-off-by: Jan Beulich Reviewed-by: A

[Xen-devel] [PATCH v3 4/4] docs: Document xenstore paths for domain network address information

2015-11-10 Thread Paul Durrant
It is useful to be able to see the network addresses in use by a domain for a particular vif in xenstore, for example so that ssh can be invoked by a toolstack to log into the guest domain. This patch documents paths to allow a domain to advertise MAC (unicast and multicast) and IP (versions 4 and

[Xen-devel] [PATCH v3 2/4] docs: Document a xenstore path for PV driver version information...

2015-11-10 Thread Paul Durrant
...to be advertised by a guest. For domain management purposes it is convenient to be able to see PV driver version information in xenstore. The XAPI toolstack in XenServer has always created a ~/drivers path for this purpose. This patch documents that path and also adds a specification of how it

Re: [Xen-devel] [PATCH 1/4] x86/HVM: don't inject #DB with error code

2015-11-10 Thread Andrew Cooper
On 10/11/15 17:38, Jan Beulich wrote: > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH v3 0/4] docs: Document xenstore paths

2015-11-10 Thread Paul Durrant
Patch #1 documents paths, some already in used by XenServer, which can be used by guests to advertise contol capabilities. Patch #2 documents paths which can be used to advertise PV driver versions. Patch #3 documents paths which can be used by guests to advertise hotplug capabilities. Patch #4

[Xen-devel] [PATCH v3 3/4] docs: Document xenstore paths for domain hotplug features

2015-11-10 Thread Paul Durrant
Without some indication from a domain it is not possible for a toolstack to know whether instantiation of a new vbd or vif should result in a new PV device of the appropriate type being instantiated in a guest. (In other words whether PV drivers are present and functioning). This patch documents t

[Xen-devel] [PATCH v3 1/4] docs: Document control features the can be advertised by guests...

2015-11-10 Thread Paul Durrant
...via xenstore. XenServer already makes use of ~/control/feature-suspend being written to advertise guest capability of responding to 'suspend' when written to ~/control/shutdown and, since they are derived from XenServer drivers, the Xen Project Windows PV drivers attempt to write this value. Th

[Xen-devel] [PATCH 4/4] x86/traps: honor EXT bit in error codes

2015-11-10 Thread Jan Beulich
The specification does not explicitly limit the use of this bit to exceptions that can have selector style error codes, so to be on the safe side we should deal with it being set even on error codes formally documented to be always zero (if they're indeed always zero, the change is simply dead code

[Xen-devel] [PATCH 3/4] x86/SVM: don't exceed segment limit when fetching instruction bytes

2015-11-10 Thread Jan Beulich
Also consistently use the vmcb local variable whenever possible. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/svm/emulate.c +++ b/xen/arch/x86/hvm/svm/emulate.c @@ -47,12 +47,17 @@ static unsigned int is_prefix(u8 opc) return 0; } -static unsigned long svm_rip2pointer(struct vcpu *v

[Xen-devel] [PATCH 1/4] x86/HVM: don't inject #DB with error code

2015-11-10 Thread Jan Beulich
Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4133,7 +4133,7 @@ void hvm_task_switch( goto out; if ( (tss.trace & 1) && !exn_raised ) -hvm_inject_hw_exception(TRAP_debug, tss_sel & 0xfff8); +hvm_inject_hw_exception(TRAP_de

[Xen-devel] [PATCH 2/4] x86/HVM: unify and fix #UD intercept

2015-11-10 Thread Jan Beulich
The SVM and VMX versions really were identical, so instead of fixing the same issue in two places, fold them at once. The issue fixed is the missing seg:off -> linear translation of the current code address. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@

[Xen-devel] [PATCH 0/4] x86: XSA-156 follow-ups

2015-11-10 Thread Jan Beulich
Not much interrelation between them other than all having been noticed while looking into the various aspects of XSA-156 (including the investigations regarding possible further similar exploit mechanisms). 1: x86/HVM: don't inject #DB with error code 2: x86/HVM: unify and fix #UD intercept 3: x86

Re: [Xen-devel] [PATCH v9 15/17] vmx: VT-d posted-interrupt core logic handling

2015-11-10 Thread Dario Faggioli
On Tue, 2015-11-03 at 09:07 +, Wu, Feng wrote: > BTW, In the previous discussion, we will do the PI state adjustment > in vmx_do_resume, however, seems this is not a good place to do this, > since this function gets called only if the scheduling occurs, no > matter it switches to another vCPU o

Re: [Xen-devel] [PATCH v8 18/21] libxc/xen: introduce a start info structure for HVMlite guests

2015-11-10 Thread Jan Beulich
>>> On 06.11.15 at 17:05, wrote: > --- a/xen/include/public/xen.h > +++ b/xen/include/public/xen.h > @@ -784,6 +784,29 @@ struct start_info { > }; > typedef struct start_info start_info_t; > > +/* > + * Start of day structure passed to PVH guests in %ebx. > + * > + * NOTE: nothing will be load

Re: [Xen-devel] [PATCH v2 2/3] XENVER_build_id: Provide ld-embedded build-ids

2015-11-10 Thread Jan Beulich
>>> On 06.11.15 at 20:36, wrote: > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -109,15 +109,19 @@ $(TARGET)-syms: prelink.o xen.lds > $(BASEDIR)/common/symbols-dummy.o > $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ > | $(BASEDIR)/tools/symbols --sysv --sort >$(@

Re: [Xen-devel] [PATCH v8 13/21] xen/x86: make sure the HVM callback vector is correctly set

2015-11-10 Thread Jan Beulich
>>> On 06.11.15 at 17:05, wrote: > --- a/xen/arch/x86/hvm/irq.c > +++ b/xen/arch/x86/hvm/irq.c > @@ -330,6 +330,10 @@ void hvm_set_callback_via(struct domain *d, uint64_t via) > (via_type > HVMIRQ_callback_vector) ) > via_type = HVMIRQ_callback_none; > > +if ( via_type !=

Re: [Xen-devel] [RFC PATCH v2 01/16] hvmloader: Fix scratch_alloc to avoid overlaps

2015-11-10 Thread Jan Beulich
>>> On 26.10.15 at 17:03, wrote: > --- a/tools/firmware/hvmloader/util.c > +++ b/tools/firmware/hvmloader/util.c > @@ -479,7 +479,7 @@ void *scratch_alloc(uint32_t size, uint32_t align) > align = 16; > > s = (scratch_start + align - 1) & ~(align - 1); > -e = s + size - 1; > +

[Xen-devel] [PATCH v2 4/8] xen: arm: remove vgic_vcpu_inject_spi()

2015-11-10 Thread Ian Campbell
Currently this has only a single caller, which I intend to teach about injecting PPIs shortly. This helper doesn't add much so remove it. Drop a stray tab from the comment immediately preceding this change. Signed-off-by: Ian Campbell --- xen/arch/arm/irq.c | 7 +-- xen/arch/arm/vg

[Xen-devel] [PATCH v2 1/8] xen: arm: fix indendation of struct vtimer

2015-11-10 Thread Ian Campbell
Signed-off-by: Ian Campbell --- xen/include/asm-arm/domain.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index e7e40da..c56f06e 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain

[Xen-devel] [PATCH v2 8/8] HACK: Force virt timer to PPI0 (IRQ16)

2015-11-10 Thread Ian Campbell
Just for testing so the guest vtimer ppi it isn't the same as the physical virt timer PPI on my platform, and therefore allows to exercise the non-1:1 bits of the code. --- xen/include/public/arch-arm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/public/arch-arm

[Xen-devel] [PATCH v2 6/8] xen: arm: supporting routing a PPI to the current vcpu.

2015-11-10 Thread Ian Campbell
That is whichever vcpu is resident when the interrupt fires. An interrupt is in this state when both IRQ_GUEST and IRQ_PER_CPU are set in the descriptor status. Only PPIs can be in this mode. This requires some peripheral specific code to make use of the previously introduced functionality to save

[Xen-devel] [PATCH v2 3/8] xen: arm: Refactor route_irq_to_guest

2015-11-10 Thread Ian Campbell
Split out the bit which allocates the struct irqaction and calls __setup_irq into a new function (setup_guest_irq). I'm going to want to call this a second time in a subsequent patch. Note that the action is now allocated and initialised with the desc lock held (since it is taken by the caller). I

[Xen-devel] [PATCH v2 5/8] xen: arm: add interfaces to save/restore the state of a PPI.

2015-11-10 Thread Ian Campbell
Make use of the GICD I[SC]ACTIVER registers to save and restore the active state of the interrupt. For edge triggered interrupts we also need to context switch the pending bit via I[SC]PENDR. Note that for level triggered interrupts SPENDR sets a latch which is only cleared by ICPENDR (and not by

[Xen-devel] [PATCH v2 7/8] xen: arm: context switch vtimer PPI state.

2015-11-10 Thread Ian Campbell
... instead of artificially masking the timer interrupt in the timer state and relying on the guest to unmask (which it isn't required to do per the h/w spec, although Linux does). By using the newly added hwppi save/restore functionality we make use of the GICD I[SC]ACTIVER registers to save and

[Xen-devel] [PATCH v2 2/8] xen: arm: fix typo in the description of struct pending_irq->desc

2015-11-10 Thread Ian Campbell
s/it/if/ makes more sense. Signed-off-by: Ian Campbell --- xen/include/asm-arm/vgic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h index cb51a9e..7d580cc 100644 --- a/xen/include/asm-arm/vgic.h +++ b/xen/include/asm-a

[Xen-devel] [PATCH v2] xen: arm: context switch vtimer PPI state.

2015-11-10 Thread Ian Campbell
... instead of artificially masking the timer interrupt in the timer state and relying on the guest to unmask which it isn't required to do per the h/w spec, although Linux does, other OSes (FreeRTOS?) needed changes. Making the vtimer follow the h/w spec is the main driving force here although it

Re: [Xen-devel] [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall

2015-11-10 Thread Stefano Stabellini
On Tue, 10 Nov 2015, Arnd Bergmann wrote: > On Tuesday 10 November 2015 11:57:55 Stefano Stabellini wrote: > > + op.u.settime64.nsecs = now.tv_nsec; > > + op.u.settime64.system_time = arch_timer_read_counter() * > > (u64)NSEC_PER_SEC; > > + do_div(op.u.settime64.system_time, arch

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread Thomas Gleixner
On Tue, 10 Nov 2015, John Stultz wrote: > I'm sort of objecting to a different issue, where the > __current_kernel_time() implementation probably shouldn't be grabbing > the tk_core.timekeeper directly, and instead should take a passed > pointer to a timekeeper. The vdso/pv_clock usage should have

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread John Stultz
On Tue, Nov 10, 2015 at 7:31 AM, Thomas Gleixner wrote: > On Tue, 10 Nov 2015, John Stultz wrote: >> On Tue, Nov 10, 2015 at 7:10 AM, Stefano Stabellini >> wrote: >> > On Tue, 10 Nov 2015, Arnd Bergmann wrote: >> >> On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote: >> >> > __current_

[Xen-devel] [PATCH v2 4/8] util: add virDiskNameParse to handle disk and partition idx

2015-11-10 Thread Joao Martins
Introduce a new helper function "virDiskNameParse" which extends virDiskNameToIndex but handling both disk index and partition index. Also rework virDiskNameToIndex to be based on virDiskNameParse. A test is also added for this function testing both valid and invalid disk names. Signed-off-by: Joa

[Xen-devel] [PATCH v2 0/8] libxl: domain statistics support

2015-11-10 Thread Joao Martins
Hey, This series bring support for various statistics about domains regarding CPU, Memory, Network Interfaces, Block and Jobs. Not all of the statistics are implemented: qdisk support is missing in this series and some of the memory statistics aren't available. With this series we further impleme

[Xen-devel] [PATCH v2 6/8] libxl: implement virConnectGetAllDomainStats

2015-11-10 Thread Joao Martins
Introduce support for connectGetAllDomainStats call that allow us to _all_ domain(s) statistics including network, block, cpus and memory. Changes are rather mechanical and mostly take care of the format to export the data. Signed-off-by: Joao Martins --- Changes since v1: - Rework flags checkin

[Xen-devel] [PATCH v2 7/8] libxl: implement virDomainGetJobInfo

2015-11-10 Thread Joao Martins
Introduce support for domainGetJobInfo to get info about the ongoing job. If the job is active it will update the timeElapsed which is computed with the "started" field added to struct libxlDomainJobObj. For now we support just the very basic info and all jobs have VIR_DOMAIN_JOB_UNBOUNDED (i.e. n

[Xen-devel] [PATCH v2 5/8] libxl: implement virDomainBlockStats

2015-11-10 Thread Joao Martins
Introduce initial support for domainBlockStats API call that allow us to query block device statistics. openstack nova uses this API call to query block statistics, alongside virDomainMemoryStats and virDomainInterfaceStats. Note that this patch only introduces it for VBD for starters. QDisk will

[Xen-devel] [PATCH v2 8/8] libxl: implement virDomainGetJobStats

2015-11-10 Thread Joao Martins
Introduces support for domainGetJobStats which has the same info as domainGetJobInfo but in a slightly different format. Another difference is that virDomainGetJobStats can also retrieve info on the most recently completed job. Though so far this is only used in the source node to know if the migra

[Xen-devel] [PATCH v2 1/8] libxl: implement virDomainGetCPUStats

2015-11-10 Thread Joao Martins
Introduce support for domainGetCPUStats API call and consequently allow us to use `virsh cpu-stats`. The latter returns a more brief output than the one provided by`virsh vcpuinfo`. Signed-off-by: Joao Martins --- Changes since v1: - Remove libxl_vcpuinfo_dispose() in favor or using libxl_vcpui

[Xen-devel] [PATCH v2] libxl: add p2p migration

2015-11-10 Thread Joao Martins
Introduce support for VIR_MIGRATE_PEER2PEER in libxl driver for supporting migration in Openstack. Most of the changes occur at the source and no modifications at the receiver. In P2P mode there is only the Perform phase so we must handle the connection with the destination and actually perform th

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread Thomas Gleixner
On Tue, 10 Nov 2015, John Stultz wrote: > On Tue, Nov 10, 2015 at 7:10 AM, Stefano Stabellini > wrote: > > On Tue, 10 Nov 2015, Arnd Bergmann wrote: > >> On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote: > >> > __current_kernel_time64 returns a struct timespec64, without taking the >

[Xen-devel] [PATCH v2 2/8] libxl: implement virDomainMemorystats

2015-11-10 Thread Joao Martins
Introduce support for domainMemoryStats API call, which consequently enables the use of `virsh dommemstat` command to query for memory statistics of a domain. We support the following statistics: balloon info, available and currently in use. swap-in, swap-out, major-faults, minor-faults require coo

[Xen-devel] [PATCH v2 3/8] libxl: implement virDomainInterfaceStats

2015-11-10 Thread Joao Martins
Introduce support for domainInterfaceStats API call for querying network interface statistics. Consequently it also enables the use of `virsh domifstat ` command. After succesful guest creation we fill the network interfaces names based on domain, device id and append suffix if it's emulated in t

[Xen-devel] [linux-next test] 63942: tolerable FAIL

2015-11-10 Thread osstest service owner
flight 63942 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/63942/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-libvirt-xsm 6 xen-boot fail blocked in 63747 test-amd64-i386-xl-qemuu-win7-a

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread John Stultz
On Tue, Nov 10, 2015 at 7:10 AM, Stefano Stabellini wrote: > On Tue, 10 Nov 2015, Arnd Bergmann wrote: >> On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote: >> > __current_kernel_time64 returns a struct timespec64, without taking the >> > xtime lock. Mirrors __current_kernel_time/curre

Re: [Xen-devel] [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64

2015-11-10 Thread Stefano Stabellini
On Tue, 10 Nov 2015, Arnd Bergmann wrote: > On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote: > > __current_kernel_time64 returns a struct timespec64, without taking the > > xtime lock. Mirrors __current_kernel_time/current_kernel_time. > > > > Actually it doesn't mirror __current_ke

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Samuel Thibault
Wei Liu, on Tue 10 Nov 2015 15:09:33 +, wrote: > On Tue, Nov 10, 2015 at 04:06:13PM +0100, Samuel Thibault wrote: > > Wei Liu, on Tue 10 Nov 2015 14:59:17 +, wrote: > > > I think I will port this patch to cxenstored at some point. As far as I > > > can tell cxenstored's data / space calcula

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Wei Liu
On Tue, Nov 10, 2015 at 04:06:13PM +0100, Samuel Thibault wrote: > Wei Liu, on Tue 10 Nov 2015 14:59:17 +, wrote: > > I think I will port this patch to cxenstored at some point. As far as I > > can tell cxenstored's data / space calculation is bogus in the same way. > > The low-level function

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Samuel Thibault
Wei Liu, on Tue 10 Nov 2015 14:59:17 +, wrote: > I think I will port this patch to cxenstored at some point. As far as I > can tell cxenstored's data / space calculation is bogus in the same way. The low-level function return short reads and writes, yes, but that is handled at a higher level:

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

2015-11-10 Thread Wei Liu
On Tue, Nov 10, 2015 at 10:46:44AM +, Andrew Cooper wrote: > ml_interface_{read,write}() would miscalculate the quantity of > data/space in the ring if it crossed the ring boundary, and incorrectly > return a short read/write. > > This causes a protocol stall, as either side of the ring ends u

Re: [Xen-devel] [PATCH v9 01/17] VT-d Posted-intterrupt (PI) design

2015-11-10 Thread Dario Faggioli
On Tue, 2015-11-03 at 16:43 +0800, Feng Wu wrote: > diff --git a/docs/misc/vtd-pi.txt b/docs/misc/vtd-pi.txt > new file mode 100644 > index 000..f9b4637 > --- /dev/null > +++ b/docs/misc/vtd-pi.txt > +With VT-d Posted-interrupt we can get the following advantages: > +- Direct delivery of exte

Re: [Xen-devel] [PATCH v2 5/6] multiboot2: Add support for relocatable images

2015-11-10 Thread Daniel Kiper
On Mon, Nov 09, 2015 at 09:08:35PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 20.07.2015 16:35, Daniel Kiper wrote: > > Signed-off-by: Daniel Kiper > What is handling the actual relocation? In Xen we get image offset from GRUB2 and using this value we calculate relative addresses.

Re: [Xen-devel] [PATCH v2 4/7] xen: introduce XENPF_settime64

2015-11-10 Thread Arnd Bergmann
On Tuesday 10 November 2015 14:43:26 Stefano Stabellini wrote: > On Tue, 10 Nov 2015, Arnd Bergmann wrote: > > On Tuesday 10 November 2015 11:57:52 Stefano Stabellini wrote: > > > Rename the current XENPF_settime hypercall and related struct to > > > XENPF_settime32. > > > > > > Signed-off-by: Ste

Re: [Xen-devel] [PATCH 2/2] arm: export platform_op XENPF_settime

2015-11-10 Thread Julien Grall
On 10/11/15 14:27, Stefano Stabellini wrote: > On Tue, 10 Nov 2015, Julien Grall wrote: >> Hi Stefano, >> >> On 09/11/15 17:09, Stefano Stabellini wrote: >>> On Thu, 5 Nov 2015, Julien Grall wrote: For instance we may want to call update_domain_wallclock_time in construct_dom0 before clea

  1   2   >