Re: [Xen-devel] [PATCH v2] xen: xen-pciback: Remove create_workqueue

2016-06-28 Thread Bhaktipriya Shridhar
Ping! Thanks, Bhaktipriya On Wed, Jun 1, 2016 at 9:15 PM, Tejun Heo wrote: > On Wed, Jun 01, 2016 at 07:45:08PM +0530, Bhaktipriya Shridhar wrote: >> System workqueues have been able to handle high level of concurrency >> for a long time now and there's no reason to use

Re: [Xen-devel] [PATCH v2] xen: xenbus: Remove create_workqueue

2016-06-28 Thread Bhaktipriya Shridhar
Ping! Thanks, Bhaktipriya On Tue, May 31, 2016 at 10:59 PM, Tejun Heo wrote: > On Tue, May 31, 2016 at 10:26:30PM +0530, Bhaktipriya Shridhar wrote: >> System workqueues have been able to handle high level of concurrency >> for a long time now and there's no reason to use

[Xen-devel] [PATCH v2] xen: xen-pciback: Remove create_workqueue

2016-06-01 Thread Bhaktipriya Shridhar
nce. Since the work items could be pending, flush_work() has been used in xen_pcibk_disconnect(). xen_pcibk_xenbus_remove() calls free_pdev() which in turn calls xen_pcibk_disconnect() for every pdev to ensure that there is no pending task while disconnecting the driver. Signed-off-by: Bhakt

[Xen-devel] [PATCH v2] xen: xenbus: Remove create_workqueue

2016-05-31 Thread Bhaktipriya Shridhar
rence. In this case, there is only a single work item, increase of concurrency level by switching to system_wq should not make any difference. Signed-off-by: Bhaktipriya Shridhar --- drivers/xen/xenbus/xenbus_probe_frontend.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-

Re: [Xen-devel] [PATCH] xen: xenbus: Remove create_workqueue

2016-05-31 Thread Bhaktipriya Shridhar
Sorry about that. Will make the corrections in v2. Thanks, Bhaktipriya On Tue, May 31, 2016 at 9:48 PM, David Vrabel wrote: > On 27/05/16 19:50, Bhaktipriya Shridhar wrote: >> With concurrency managed workqueues, use of dedicated workqueues can be >> replaced by using

[Xen-devel] [PATCH] xen: xenbus: Remove create_workqueue

2016-05-27 Thread Bhaktipriya Shridhar
pending and the code expects it to run once scheduled, flush_work() has been used in xenbus_dev_suspend() Signed-off-by: Bhaktipriya Shridhar --- drivers/xen/xenbus/xenbus_probe.c | 2 ++ drivers/xen/xenbus/xenbus_probe_frontend.c | 15 +-- 2 files changed, 3 insertions

[Xen-devel] [PATCH] xen: xen-pciback: Remove create_workqueue

2016-05-27 Thread Bhaktipriya Shridhar
sed in xen_pcibk_disconnect() to ensure that work item is not pending or executing by the time exit path runs. Signed-off-by: Bhaktipriya Shridhar --- drivers/xen/xen-pciback/pciback.h | 1 - drivers/xen/xen-pciback/pciback_ops.c | 2 +- drivers/xen/xen-pciback/xenbus.c | 10 +-