[Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory

2015-11-25 Thread Jan Beulich
The use of $(basename ...) here was wrong (yet I'm sure I tested it). Signed-off-by: Jan Beulich --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -105,7 +105,7 @@ include Makefile DEPS = .*.d define gendep ifneq ($(1),$(subst /,:,$(1))) -DEPS += $(dir $(1)).$(basename $(notdir $(1))).d +

Re: [Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory

2015-11-25 Thread Ian Campbell
On Wed, 2015-11-25 at 09:16 -0700, Jan Beulich wrote: > The use of $(basename ...) here was wrong (yet I'm sure I tested it). Is the issue here that xen/arch/x86/x86_64/.compat.o.d ought really to be xen/arch/x86/.x86_64.compat.o.d? Otherwise xen/arch/x86/Makefile (which contains obj-y := ... x86

Re: [Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory

2015-11-25 Thread Jan Beulich
>>> On 25.11.15 at 17:26, wrote: > On Wed, 2015-11-25 at 09:16 -0700, Jan Beulich wrote: >> The use of $(basename ...) here was wrong (yet I'm sure I tested it). > > Is the issue here that xen/arch/x86/x86_64/.compat.o.d ought really to be > xen/arch/x86/.x86_64.compat.o.d? No, xen/arch/x86/x86_

Re: [Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory

2015-11-26 Thread Ian Campbell
On Thu, 2015-11-26 at 00:43 -0700, Jan Beulich wrote: > > > > On 25.11.15 at 17:26, wrote: > > On Wed, 2015-11-25 at 09:16 -0700, Jan Beulich wrote: > > > The use of $(basename ...) here was wrong (yet I'm sure I tested it). > > > > Is the issue here that xen/arch/x86/x86_64/.compat.o.d ought rea

Re: [Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory

2015-11-26 Thread Jan Beulich
>>> On 26.11.15 at 10:51, wrote: > On Thu, 2015-11-26 at 00:43 -0700, Jan Beulich wrote: >> > > > On 25.11.15 at 17:26, wrote: >> > On Wed, 2015-11-25 at 09:16 -0700, Jan Beulich wrote: >> > > The use of $(basename ...) here was wrong (yet I'm sure I tested it). >> > >> > Is the issue here that

Re: [Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory

2015-11-26 Thread Ian Campbell
On Thu, 2015-11-26 at 03:38 -0700, Jan Beulich wrote: > > > > On 26.11.15 at 10:51, wrote: > > On Thu, 2015-11-26 at 00:43 -0700, Jan Beulich wrote: > > > > > > On 25.11.15 at 17:26, wrote: > > > > On Wed, 2015-11-25 at 09:16 -0700, Jan Beulich wrote: > > > > > The use of $(basename ...) here was

Re: [Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory

2015-11-30 Thread Jonathan Creekmore
On Wed, Nov 25, 2015 at 10:16 AM, Jan Beulich wrote: > The use of $(basename ...) here was wrong (yet I'm sure I tested it). > > Signed-off-by: Jan Beulich > > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -105,7 +105,7 @@ include Makefile > DEPS = .*.d > define gendep > ifneq ($(1),$(subst

Re: [Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory

2015-11-30 Thread Jan Beulich
>>> On 30.11.15 at 17:31, wrote: > On Wed, Nov 25, 2015 at 10:16 AM, Jan Beulich wrote: >> The use of $(basename ...) here was wrong (yet I'm sure I tested it). >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/Rules.mk >> +++ b/xen/Rules.mk >> @@ -105,7 +105,7 @@ include Makefile >> DEPS = .*.d