[Xen-devel] [PATCH 1/2] x86/svm: Alias the VMCB segment registers as an array

2017-07-26 Thread Andrew Cooper
This allows svm_{get,set}_segment_register() to access the user segments by array index, capitalising on x86_seg_* matches the hardware encoding. While making this alteration, add some newlines for clarity, switch an int for a bool, and make the functions fail safe in a release build, rather than

Re: [Xen-devel] [PATCH 1/2] x86/svm: Alias the VMCB segment registers as an array

2017-07-27 Thread Boris Ostrovsky
On 07/26/2017 07:56 AM, Andrew Cooper wrote: > This allows svm_{get,set}_segment_register() to access the user segments by > array index, capitalising on x86_seg_* matches the hardware encoding. This does read correctly to me, I think some sort of preposition is missing. "capitalising on x86_seg_

Re: [Xen-devel] [PATCH 1/2] x86/svm: Alias the VMCB segment registers as an array

2017-07-27 Thread Andrew Cooper
On 27/07/17 16:20, Boris Ostrovsky wrote: > On 07/26/2017 07:56 AM, Andrew Cooper wrote: >> This allows svm_{get,set}_segment_register() to access the user segments by >> array index, capitalising on x86_seg_* matches the hardware encoding. > This does read correctly to me, I think some sort of pre