Re: [Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

2016-04-08 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH 1/4] a fix in libxl_device_usbdev_list"): > We won't fix that bad API pattern for 4.7. So > > Acked-by: Ian Jackson Queued. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

2016-04-08 Thread Ian Jackson
Chun Yan Liu writes ("Re: [PATCH 1/4] a fix in libxl_device_usbdev_list"): > On 4/8/2016 at 12:45 AM, in message > <22278.36492.245114.295...@mariner.uk.xensource.com>, Ian Jackson > wrote: > > If libxl__device_usbdev_list_for_usbctrl fails, shouldn't > > libxl_device_usbdev_list fail too ? >

Re: [Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

2016-04-07 Thread Chun Yan Liu
>>> On 4/8/2016 at 12:45 AM, in message <22278.36492.245114.295...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH 1/4] a fix in libxl_device_usbdev_list"): > > In testing with libvirt pvusb functionality, found a rc check > > error in libxl_device_usbdev_list. Cor

Re: [Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

2016-04-07 Thread Ian Jackson
Chunyan Liu writes ("[PATCH 1/4] a fix in libxl_device_usbdev_list"): > In testing with libvirt pvusb functionality, found a rc check > error in libxl_device_usbdev_list. Correct it. This function > is not used by xl. Thanks for these. I have applied 2,3, and 4. But not 1, as I had comments on i

Re: [Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

2016-04-07 Thread Ian Jackson
Chunyan Liu writes ("[PATCH 1/4] a fix in libxl_device_usbdev_list"): > In testing with libvirt pvusb functionality, found a rc check > error in libxl_device_usbdev_list. Correct it. Thanks. But now that I look at this code I'm not sure your fix is complete. > diff --git a/tools/libxl/libxl_pvus

[Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

2016-04-07 Thread Chunyan Liu
In testing with libvirt pvusb functionality, found a rc check error in libxl_device_usbdev_list. Correct it. This function is not used by xl. Signed-off-by: Chunyan Liu CC: Simon Cao CC: George Dunlap CC: Ian Jackson --- tools/libxl/libxl_pvusb.c | 6 +++--- 1 file changed, 3 insertions(+), 3