Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-09 Thread Corneliu ZUZU
On 2/9/2016 7:40 PM, Tamas K Lengyel wrote: On Tue, Feb 9, 2016 at 5:32 AM, Corneliu ZUZU > wrote: There are already directories w/ just one/a few files in them, even small (e.g. common/gcov/gcov.c). IMHO no harm is done if a

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-09 Thread Stefano Stabellini
On Mon, 8 Feb 2016, Corneliu ZUZU wrote: > X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, > also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. Why are we doing this? These are not header files, their paths don't necessarily need to be the same and xen/arch/x86/hvm/hvm.c is

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-09 Thread Corneliu ZUZU
On 2/9/2016 1:03 PM, Stefano Stabellini wrote: On Mon, 8 Feb 2016, Corneliu ZUZU wrote: X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. Why are we doing this? These are not header files, their paths don't necessarily need

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-09 Thread Jan Beulich
>>> On 09.02.16 at 12:28, wrote: > On 2/9/2016 1:03 PM, Stefano Stabellini wrote: >> On Mon, 8 Feb 2016, Corneliu ZUZU wrote: >>> X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, >>> also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. >> Why are we doing

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-09 Thread Stefano Stabellini
On Tue, 9 Feb 2016, Jan Beulich wrote: > >>> On 09.02.16 at 12:28, wrote: > > On 2/9/2016 1:03 PM, Stefano Stabellini wrote: > >> On Mon, 8 Feb 2016, Corneliu ZUZU wrote: > >>> X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, > >>> also move

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-09 Thread Corneliu ZUZU
On 2/9/2016 1:55 PM, Jan Beulich wrote: On 09.02.16 at 12:28, wrote: On 2/9/2016 1:03 PM, Stefano Stabellini wrote: On Mon, 8 Feb 2016, Corneliu ZUZU wrote: X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, also move arch/arm/hvm.c to

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-09 Thread Tamas K Lengyel
On Tue, Feb 9, 2016 at 5:32 AM, Corneliu ZUZU wrote: > On 2/9/2016 1:55 PM, Jan Beulich wrote: > >> On 09.02.16 at 12:28, wrote: > On 2/9/2016 1:03 PM, Stefano Stabellini wrote: >>> On Mon, 8 Feb 2016, Corneliu ZUZU wrote: >

[Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-08 Thread Corneliu ZUZU
X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. Signed-off-by: Corneliu ZUZU --- xen/arch/arm/Makefile | 2 +- xen/arch/arm/hvm.c| 67 ---

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-08 Thread Andrew Cooper
On 08/02/16 16:57, Corneliu ZUZU wrote: > X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, > also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. > > Signed-off-by: Corneliu ZUZU For future reference, constructing your patches with -M (detect renames)

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-08 Thread Andrew Cooper
On 08/02/16 17:12, Corneliu ZUZU wrote: > On 2/8/2016 7:04 PM, Andrew Cooper wrote: >> On 08/02/16 16:57, Corneliu ZUZU wrote: >>> X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, >>> also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. >>> >>> Signed-off-by: Corneliu ZUZU

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-08 Thread Corneliu ZUZU
On 2/8/2016 7:04 PM, Andrew Cooper wrote: On 08/02/16 16:57, Corneliu ZUZU wrote: X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. Signed-off-by: Corneliu ZUZU For future reference, constructing