Re: [Xen-devel] [PATCH RFC OSSTEST v1 05/12] make-*flight: Abolish $defsuite and $guestdefsuite

2016-01-15 Thread Ian Campbell
On Tue, 2016-01-12 at 14:18 +, Ian Jackson wrote: > Ian Campbell writes ("[PATCH RFC OSSTEST v1 05/12] make-*flight: Abolish > $defsuite and $guestdefsuite"): > > Instead have mfi-common set $suite or $guestsuite if it is unset. When > > doing so move the use of local to this point, using

Re: [Xen-devel] [PATCH RFC OSSTEST v1 05/12] make-*flight: Abolish $defsuite and $guestdefsuite

2016-01-12 Thread Ian Jackson
Ian Campbell writes ("[PATCH RFC OSSTEST v1 05/12] make-*flight: Abolish $defsuite and $guestdefsuite"): > Instead have mfi-common set $suite or $guestsuite if it is unset. When > doing so move the use of local to this point, using local at the top > of the function would shadow any attempt to

[Xen-devel] [PATCH RFC OSSTEST v1 05/12] make-*flight: Abolish $defsuite and $guestdefsuite

2016-01-08 Thread Ian Campbell
Instead have mfi-common set $suite or $guestsuite if it is unset. When doing so move the use of local to this point, using local at the top of the function would shadow any attempt to set a global value, while restricting it only to when setting the default means it doesn't leak. NB "local" scopes