Re: [Xen-devel] [PATCH v1] xen/arm: Manage pl011 uart TX interrupt correctly

2015-01-20 Thread Ian Campbell
On Thu, 2015-01-08 at 14:59 +, Ian Campbell wrote: > On Thu, 2014-12-11 at 13:15 +0100, Tim Deegan wrote: > > At 10:09 +0530 on 09 Dec (1418116195), vijay.kil...@gmail.com wrote: > > > From: Vijaya Kumar K > > > > > > In pl011.c, when TX interrupt is received > > > serial_tx_interrupt() is ca

Re: [Xen-devel] [PATCH v1] xen/arm: Manage pl011 uart TX interrupt correctly

2015-01-08 Thread Ian Campbell
On Thu, 2014-12-11 at 13:15 +0100, Tim Deegan wrote: > At 10:09 +0530 on 09 Dec (1418116195), vijay.kil...@gmail.com wrote: > > From: Vijaya Kumar K > > > > In pl011.c, when TX interrupt is received > > serial_tx_interrupt() is called to push next > > characters. If TX buffer is empty, serial_tx_

Re: [Xen-devel] [PATCH v1] xen/arm: Manage pl011 uart TX interrupt correctly

2014-12-15 Thread Julien Grall
On 11/12/14 12:24, Ian Campbell wrote: > These last two changes require that you cc the common serial maintainer, > not just the ARM maintainers. In this case that means Keir, who I have > CCd. > ./scripts/get_maintainers.pl can help automate this. The serial code lives in the "THE REST" category

Re: [Xen-devel] [PATCH v1] xen/arm: Manage pl011 uart TX interrupt correctly

2014-12-11 Thread Ian Campbell
On Tue, 2014-12-09 at 10:09 +0530, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > In pl011.c, when TX interrupt is received > serial_tx_interrupt() is called to push next > characters. If TX buffer is empty, serial_tx_interrupt() > does not disable TX interrupt and hence pl011 UART > ir

Re: [Xen-devel] [PATCH v1] xen/arm: Manage pl011 uart TX interrupt correctly

2014-12-11 Thread Tim Deegan
At 10:09 +0530 on 09 Dec (1418116195), vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > In pl011.c, when TX interrupt is received > serial_tx_interrupt() is called to push next > characters. If TX buffer is empty, serial_tx_interrupt() > does not disable TX interrupt and hence pl011 UART

[Xen-devel] [PATCH v1] xen/arm: Manage pl011 uart TX interrupt correctly

2014-12-08 Thread vijay . kilari
From: Vijaya Kumar K In pl011.c, when TX interrupt is received serial_tx_interrupt() is called to push next characters. If TX buffer is empty, serial_tx_interrupt() does not disable TX interrupt and hence pl011 UART irq handler pl011_interrupt() always sees TX interrupt status set in MIS register