Re: [Xen-devel] [PATCH v2 04/12] x86emul/test: use x86-vendors.h

2017-01-31 Thread Wei Liu
On Tue, Jan 31, 2017 at 08:16:00AM -0700, Jan Beulich wrote: > >>> On 31.01.17 at 15:36, wrote: > > On Tue, Jan 31, 2017 at 05:50:09AM -0700, Jan Beulich wrote: > >> >>> On 31.01.17 at 12:08, wrote: > >> > --- a/tools/tests/x86_emulator/x86_emulate.h > >> > +++ b/tools/tests/x86_emulator/x86_emul

Re: [Xen-devel] [PATCH v2 04/12] x86emul/test: use x86-vendors.h

2017-01-31 Thread Jan Beulich
>>> On 31.01.17 at 15:36, wrote: > On Tue, Jan 31, 2017 at 05:50:09AM -0700, Jan Beulich wrote: >> >>> On 31.01.17 at 12:08, wrote: >> > --- a/tools/tests/x86_emulator/x86_emulate.h >> > +++ b/tools/tests/x86_emulator/x86_emulate.h >> > @@ -6,6 +6,8 @@ >> > #include >> > #include >> > >> >

Re: [Xen-devel] [PATCH v2 04/12] x86emul/test: use x86-vendors.h

2017-01-31 Thread Wei Liu
On Tue, Jan 31, 2017 at 05:50:09AM -0700, Jan Beulich wrote: > >>> On 31.01.17 at 12:08, wrote: > > --- a/tools/tests/x86_emulator/x86_emulate.h > > +++ b/tools/tests/x86_emulator/x86_emulate.h > > @@ -6,6 +6,8 @@ > > #include > > #include > > > > +#include "../../../xen/include/asm-x86/x86-

Re: [Xen-devel] [PATCH v2 04/12] x86emul/test: use x86-vendors.h

2017-01-31 Thread Jan Beulich
>>> On 31.01.17 at 12:08, wrote: > --- a/tools/tests/x86_emulator/x86_emulate.h > +++ b/tools/tests/x86_emulator/x86_emulate.h > @@ -6,6 +6,8 @@ > #include > #include > > +#include "../../../xen/include/asm-x86/x86-vendors.h" I think we'd better avoid includes of this style. May I suggest s

[Xen-devel] [PATCH v2 04/12] x86emul/test: use x86-vendors.h

2017-01-31 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper --- tools/tests/x86_emulator/x86_emulate.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/tests/x86_emulator/x86_emulate.h b/tools/tests/x86_emulator/x86_emulate.h index 3a6bad