Re: [Xen-devel] [PATCH v2 2/6] libxc/restore: Bail if unknown options are found

2015-05-11 Thread David Vrabel
On 08/05/15 22:14, Andrew Cooper wrote: When restoring a domain, check for unknown options in Image Header. Nothing good will come from attempting to continue. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com CC: David Vrabel david.vra...@citrix.com CC: Ian Campbell

Re: [Xen-devel] [PATCH v2 2/6] libxc/restore: Bail if unknown options are found

2015-05-11 Thread David Vrabel
On 11/05/15 10:23, David Vrabel wrote: The image header provides information about the format of the image. I suppose one could make an argument that an checkpointed stream is an infinite stream vs finite, but I think a CHECKPOINT_ENABLE record might be better? Sorry, this was supposed to

Re: [Xen-devel] [PATCH v2 2/6] libxc/restore: Bail if unknown options are found

2015-05-11 Thread David Vrabel
On 08/05/15 22:14, Andrew Cooper wrote: When restoring a domain, check for unknown options in Image Header. Nothing good will come from attempting to continue. Section 2.3 (Fields) explicitly states that Padding and reserved fields are set to zero on save and must be ignored during restore. I

[Xen-devel] [PATCH v2 2/6] libxc/restore: Bail if unknown options are found

2015-05-08 Thread Andrew Cooper
When restoring a domain, check for unknown options in Image Header. Nothing good will come from attempting to continue. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com CC: David Vrabel david.vra...@citrix.com CC: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson