Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

>>> On 10.02.16 at 21:56, wrote: > On 10/02/2016 17:11, Jan Beulich wrote: > On 10.02.16 at 18:04, wrote: >>> On 2/10/2016 6:18 PM, Jan Beulich wrote: >>> On 10.02.16 at 16:50, wrote: > ---

[Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

This patch merges almost identical functions hvm_event_int3 and hvm_event_single_step into a single function called hvm_event_breakpoint. Signed-off-by: Corneliu ZUZU --- xen/arch/x86/hvm/event.c| 76 +++--

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

On 10/02/16 16:18, Jan Beulich wrote: > >> --- a/xen/include/asm-x86/hvm/event.h >> +++ b/xen/include/asm-x86/hvm/event.h >> @@ -17,6 +17,12 @@ >> #ifndef __ASM_X86_HVM_EVENT_H__ >> #define __ASM_X86_HVM_EVENT_H__ >> >> +enum hvm_event_breakpoint_type >> +{ >> +

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

On 2/10/2016 6:18 PM, Jan Beulich wrote: On 10.02.16 at 16:50, wrote: @@ -151,61 +154,52 @@ void hvm_event_guest_request(void) } } -int hvm_event_int3(unsigned long rip) +static inline +uint64_t gfn_of_rip(unsigned long rip) This should be a single line and

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

On 02/10/2016 07:04 PM, Corneliu ZUZU wrote: >>> @@ -27,9 +33,8 @@ bool_t hvm_event_cr(unsigned int index, unsigned >>> long value, >>> #define hvm_event_crX(what, new, old) \ >>> hvm_event_cr(VM_EVENT_X86_##what, new, old) >>> void hvm_event_msr(unsigned int msr, uint64_t value); >>>

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

>>> On 10.02.16 at 17:37, wrote: > On 10/02/16 16:18, Jan Beulich wrote: >> >>> --- a/xen/include/asm-x86/hvm/event.h >>> +++ b/xen/include/asm-x86/hvm/event.h >>> @@ -17,6 +17,12 @@ >>> #ifndef __ASM_X86_HVM_EVENT_H__ >>> #define __ASM_X86_HVM_EVENT_H__ >>> >>>

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

>>> On 10.02.16 at 16:50, wrote: > @@ -151,61 +154,52 @@ void hvm_event_guest_request(void) > } > } > > -int hvm_event_int3(unsigned long rip) > +static inline > +uint64_t gfn_of_rip(unsigned long rip) This should be a single line and the return value should be

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

>>> On 10.02.16 at 18:04, wrote: > On 2/10/2016 6:18 PM, Jan Beulich wrote: > On 10.02.16 at 16:50, wrote: >>> --- a/xen/include/asm-x86/hvm/event.h >>> +++ b/xen/include/asm-x86/hvm/event.h >>> @@ -17,6 +17,12 @@ >>> #ifndef

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

On Wed, Feb 10, 2016 at 10:28 AM, Razvan Cojocaru wrote: > On 02/10/2016 07:04 PM, Corneliu ZUZU wrote: > >>> @@ -27,9 +33,8 @@ bool_t hvm_event_cr(unsigned int index, unsigned > >>> long value, > >>> #define hvm_event_crX(what, new, old) \ > >>>

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

On 10/02/2016 17:11, Jan Beulich wrote: On 10.02.16 at 18:04, wrote: >> On 2/10/2016 6:18 PM, Jan Beulich wrote: >> On 10.02.16 at 16:50, wrote: --- a/xen/include/asm-x86/hvm/event.h +++ b/xen/include/asm-x86/hvm/event.h @@

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

On 2/10/2016 7:11 PM, Jan Beulich wrote: On 10.02.16 at 18:04, wrote: On 2/10/2016 6:18 PM, Jan Beulich wrote: On 10.02.16 at 16:50, wrote: --- a/xen/include/asm-x86/hvm/event.h +++ b/xen/include/asm-x86/hvm/event.h @@ -17,6 +17,12 @@ #ifndef

Re: [Xen-devel] [PATCH v2 2/7] xen/x86: merge 2 hvm_event_... functions into 1

On 2/10/2016 7:11 PM, Jan Beulich wrote: On 10.02.16 at 18:04, wrote: On 2/10/2016 6:18 PM, Jan Beulich wrote: On 10.02.16 at 16:50, wrote: --- a/xen/include/asm-x86/hvm/event.h +++ b/xen/include/asm-x86/hvm/event.h @@ -17,6 +17,12 @@ #ifndef