Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

On 2/12/2016 8:05 AM, Corneliu ZUZU wrote: On 2/11/2016 5:44 PM, Tamas K Lengyel wrote: * the #ifdefs make it possible for that code to be put in common => that makes it *clear* that those code parts are NOT architecture specific and their implementation can be safely used for

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

On 2/11/2016 5:44 PM, Tamas K Lengyel wrote: * the #ifdefs make it possible for that code to be put in common => that makes it *clear* that those code parts are NOT architecture specific and their implementation can be safely used for all architectures. The current practice

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

> > * the #ifdefs make it possible for that code to be put in common => that > makes it *clear* that those code parts are NOT > architecture specific and their implementation can be safely used for all > architectures. > The current practice has been to put empty static inline functions into

[Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

1. Kconfig: * Added Kconfigs for common monitor vm-events: # see files: common/Kconfig, x86/Kconfig HAS_VM_EVENT_WRITE_CTRLREG HAS_VM_EVENT_SINGLESTEP HAS_VM_EVENT_SOFTWARE_BREAKPOINT HAS_VM_EVENT_GUEST_REQUEST 2. Moved monitor_domctl from arch-side to common-side 2.1. Moved

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

On 2/10/2016 6:26 PM, Jan Beulich wrote: On 10.02.16 at 16:52, wrote: xen/arch/x86/Kconfig | 4 + xen/arch/x86/Makefile | 2 +- xen/arch/x86/hvm/event.c | 2 +-

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

On 2/10/2016 6:39 PM, Tamas K Lengyel wrote: On Wed, Feb 10, 2016 at 8:52 AM, Corneliu ZUZU > wrote: 1. Kconfig: * Added Kconfigs for common monitor vm-events: # see files: common/Kconfig, x86/Kconfig

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

>>> On 10.02.16 at 16:52, wrote: > xen/arch/x86/Kconfig | 4 + > xen/arch/x86/Makefile | 2 +- > xen/arch/x86/hvm/event.c | 2 +- > xen/arch/x86/hvm/hvm.c|

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

>>> On 10.02.16 at 17:26, wrote: On 10.02.16 at 16:52, wrote: >> xen/arch/x86/Kconfig | 4 + >> xen/arch/x86/Makefile | 2 +- >> xen/arch/x86/hvm/event.c | 2 +-

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

On Wed, Feb 10, 2016 at 8:52 AM, Corneliu ZUZU wrote: > 1. Kconfig: > * Added Kconfigs for common monitor vm-events: > # see files: common/Kconfig, x86/Kconfig > HAS_VM_EVENT_WRITE_CTRLREG > HAS_VM_EVENT_SINGLESTEP > HAS_VM_EVENT_SOFTWARE_BREAKPOINT >

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

On 2/10/2016 6:30 PM, Jan Beulich wrote: On 10.02.16 at 17:26, wrote: On 10.02.16 at 16:52, wrote: xen/arch/x86/Kconfig | 4 + xen/arch/x86/Makefile | 2 +- xen/arch/x86/hvm/event.c

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

On Wed, Feb 10, 2016 at 10:34 AM, Corneliu ZUZU wrote: > > On 2/10/2016 6:39 PM, Tamas K Lengyel wrote: > > > > On Wed, Feb 10, 2016 at 8:52 AM, Corneliu ZUZU > wrote: > >> 1. Kconfig: >> * Added Kconfigs for common monitor vm-events: >> # see

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

On 2/10/2016 7:56 PM, Tamas K Lengyel wrote: On Wed, Feb 10, 2016 at 10:34 AM, Corneliu ZUZU > wrote: On 2/10/2016 6:39 PM, Tamas K Lengyel wrote: diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

On 2/10/2016 6:39 PM, Tamas K Lengyel wrote: I think it would be better if this function just had a single rc instead of two (not passing one rc as a pointer on input). Good point. Would it be ok if: * I remove the rc param * make return type int * rc = 0 if arch-side didn't handle the event,