Re: [Xen-devel] [PATCH v2 5/5] xl: improve return and exit codes of parse related functions

2015-10-26 Thread Dario Faggioli
On Sat, 2015-10-24 at 11:01 +0530, Harmandeep Kaur wrote: > turning parsing related functions xl exit codes towards using the > EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary > numbers > or libxl return codes. > I think the changelog, in this case, can be restructured and

Re: [Xen-devel] [PATCH v2 5/5] xl: improve return and exit codes of parse related functions

2015-10-26 Thread Dario Faggioli
On Sat, 2015-10-24 at 11:01 +0530, Harmandeep Kaur wrote: > turning parsing related functions xl exit codes towards using the > EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary > numbers > or libxl return codes. > > it doesn't include parse_config_data() which is big enough to

Re: [Xen-devel] [PATCH v2 5/5] xl: improve return and exit codes of parse related functions

2015-10-26 Thread Wei Liu
On Sat, Oct 24, 2015 at 11:01:36AM +0530, Harmandeep Kaur wrote: > turning parsing related functions xl exit codes towards using the > EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary numbers They are constants, not macros -- I'm a being pedantic here. :-) > or libxl return codes.

[Xen-devel] [PATCH v2 5/5] xl: improve return and exit codes of parse related functions

2015-10-23 Thread Harmandeep Kaur
turning parsing related functions xl exit codes towards using the EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary numbers or libxl return codes. it doesn't include parse_config_data() which is big enough to deserve its own patch Signed-off-by: Harmandeep Kaur