On 22/09/15 11:34, Vijay Kilari wrote:
> On Mon, Sep 21, 2015 at 4:53 PM, Julien Grall wrote:
>> Maybe you want to add the suffix _cmd to everyone to avoid having only
>> one because of C spec issue.
>
> suffixing _cmd will look ugly ( as below ex) where "cmd" is repeated twice.
Well, you alread
On Mon, Sep 21, 2015 at 4:53 PM, Julien Grall wrote:
> Hi Vijay,
>
> The only things I haven't check on this patch was the ITS command structure.
>
> On 18/09/15 14:08, vijay.kil...@gmail.com wrote:
>> +/* ITS command structure */
>> +typedef union {
>
> Can you please sort this union by command n
Hi Vijay,
On 22/09/2015 10:55, Vijay Kilari wrote:
On Mon, Sep 21, 2015 at 4:53 PM, Julien Grall wrote:
Hi Vijay,
The only things I haven't check on this patch was the ITS command structure.
[...]
Why a padding of only 56 bits? Shouldn't it be 248 bits (i.e 31 * 8
bits) to fit all the comm
On Mon, Sep 21, 2015 at 4:53 PM, Julien Grall wrote:
> Hi Vijay,
>
> The only things I haven't check on this patch was the ITS command structure.
[...]
> Why a padding of only 56 bits? Shouldn't it be 248 bits (i.e 31 * 8
> bits) to fit all the command?
>
>> +} hdr;
>> +struct __packed {
>
On 18/09/15 14:08, vijay.kil...@gmail.com wrote:
> +static void its_lpi_free(struct its_device *dev)
> +{
> +int lpi;
> +
> +spin_lock(&lpi_lock);
> +
> +for ( lpi = dev->event_map.lpi_base;
> + lpi < (dev->event_map.lpi_base + dev->event_map.nr_lpis);
> + lpi += IRQS_
Hi Vijay,
The only things I haven't check on this patch was the ITS command structure.
On 18/09/15 14:08, vijay.kil...@gmail.com wrote:
> +/* ITS command structure */
> +typedef union {
Can you please sort this union by command name in alphabetical order.
It's way easier to find a command in the
From: Vijaya Kumar K
The linux driver is based on 4.1 with below commit id
591e5bec13f15feb13fc445b6c9c59954711c4ac
Only following code from Linux ITS driver is ported
and compiled
- LPI initialization
- ITS configuration code
- Physical command queue management
- ITS command building
Also