Re: [Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-11 Thread Han, Huaitong
Get it, thanks On Mon, 2015-05-11 at 09:00 +0100, Jan Beulich wrote: > >>> On 11.05.15 at 08:50, wrote: > > On Fri, 2015-05-08 at 11:11 +0100, Jan Beulich wrote: > >> >>> On 08.05.15 at 11:40, wrote: > >> > All comments has been addressed, just changelog is written partly. > >> > >> Certainly n

Re: [Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-11 Thread Jan Beulich
>>> On 11.05.15 at 08:50, wrote: > On Fri, 2015-05-08 at 11:11 +0100, Jan Beulich wrote: >> >>> On 08.05.15 at 11:40, wrote: >> > All comments has been addressed, just changelog is written partly. >> >> Certainly not. There are still hard tabs in the patch, and there was >> still a pointless ini

Re: [Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-10 Thread Han, Huaitong
On Fri, 2015-05-08 at 11:11 +0100, Jan Beulich wrote: > >>> On 08.05.15 at 11:40, wrote: > > All comments has been addressed, just changelog is written partly. > > Certainly not. There are still hard tabs in the patch, and there was > still a pointless initializer that I had pointed out before.

Re: [Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-08 Thread Jan Beulich
>>> On 08.05.15 at 11:40, wrote: > All comments has been addressed, just changelog is written partly. Certainly not. There are still hard tabs in the patch, and there was still a pointless initializer that I had pointed out before. I didn't look further. Jan > On Fri, 2015-05-08 at 09:35 +0100,

Re: [Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-08 Thread Han, Huaitong
All comments has been addressed, just changelog is written partly. On Fri, 2015-05-08 at 09:35 +0100, Jan Beulich wrote: > >>> On 08.05.15 at 10:11, wrote: > > When checking the ACPI funciton of C-status, after 100 seconds sleep, > > the sampling value of C0 status from the xenpm tool decreases.

Re: [Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-08 Thread Jan Beulich
>>> On 08.05.15 at 10:11, wrote: > When checking the ACPI funciton of C-status, after 100 seconds sleep, > the sampling value of C0 status from the xenpm tool decreases. > Because C0=NOW()-C1-C2-C3-C4, when NOW() value is during idle time, > NOW() value is bigger than last C-status update time, an

[Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-08 Thread Huaitong Han
When checking the ACPI funciton of C-status, after 100 seconds sleep, the sampling value of C0 status from the xenpm tool decreases. Because C0=NOW()-C1-C2-C3-C4, when NOW() value is during idle time, NOW() value is bigger than last C-status update time, and C0 value is also bigger than ture value.