[Xen-devel] [xen-unstable bisection] complete test-amd64-i386-xl-xsm

2018-09-20 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-xsm testid xen-boot Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu

Re: [Xen-devel] [PATCH 00/12] add per-domain and per-cpupool generic parameters

2018-09-20 Thread Juergen Gross
On 20/09/18 18:06, Wei Liu wrote: > On Wed, Sep 19, 2018 at 07:58:50PM +0200, Juergen Gross wrote: >> >> Did you look into the patches, especially patch 10? The parameters set >> are all stored in domain config via libxl__arch_domain_save_config(). > > No, I didn't. > > I think the general idea

[Xen-devel] [libvirt test] 127828: regressions - FAIL

2018-09-20 Thread osstest service owner
flight 127828 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/127828/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 123814 build-amd64-libvirt

Re: [Xen-devel] [PATCH net-next 17/22] hv_netvsc: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
On 2018/9/20 22:43, Stephen Hemminger wrote: > On Thu, 20 Sep 2018 20:33:01 +0800 > YueHaibing wrote: > >> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', >> which is a typedef for an enum type, so make sure the implementation in >> this driver has returns 'netdev_tx_t'

Re: [Xen-devel] [PATCH net-next 17/22] hv_netvsc: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
On 2018/9/20 22:50, Haiyang Zhang wrote: > > >> -Original Message- >> From: Stephen Hemminger >> Sent: Thursday, September 20, 2018 10:44 AM >> To: YueHaibing >> Cc: da...@davemloft.net; dmitry.tarnya...@lockless.no; >> w...@grandegger.com; m...@pengutronix.de; michal.si...@xilinx.com;

Re: [Xen-devel] [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
On 2018/9/20 23:50, David Miller wrote: > From: YueHaibing > Date: Thu, 20 Sep 2018 20:32:44 +0800 > >> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', >> which is a typedef for an enum type, so make sure the implementation in >> this driver has returns 'netdev_tx_t' value,

Re: [Xen-devel] [PATCH 6/7] vtd: change lookup_page failure semantics

2018-09-20 Thread Tian, Kevin
> From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: Thursday, September 20, 2018 10:12 PM > > Commit 43d1622b "vtd: add lookup_page method to iommu_ops" added a > lookup method in to the VT-d IOMMU implementation. In some cases (such > as > when shared EPT is in operation) that function

[Xen-devel] [linux-linus test] 127793: regressions - FAIL

2018-09-20 Thread osstest service owner
flight 127793 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127793/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 10 debian-hvm-install fail REGR. vs. 125898

[Xen-devel] [xen-4.6-testing baseline-only test] 75257: trouble: blocked/broken

2018-09-20 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75257 xen-4.6-testing real [real] http://osstest.xensource.com/osstest/logs/75257/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64

Re: [Xen-devel] tools/fuzz fails due build, osstest did not notice

2018-09-20 Thread Christopher Clark
On Tue, Sep 4, 2018 at 2:07 AM Jan Beulich wrote: > > >>> On 04.09.18 at 09:32, wrote: > > Am Mon, 03 Sep 2018 06:35:42 -0600 > > schrieb "Jan Beulich" : > > > >> what is the actual problem? The mere > >> listing of compiler flags passed does not make clear to me where the clash > >> is, or how

Re: [Xen-devel] [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function

2018-09-20 Thread Grygorii Strashko
On 09/20/2018 07:32 AM, YueHaibing wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_t. > May

Re: [Xen-devel] [PATCH v2] xen: issue warning message when out of grant maptrack entries

2018-09-20 Thread Boris Ostrovsky
On 9/19/18 9:42 AM, Juergen Gross wrote: > When a driver domain (e.g. dom0) is running out of maptrack entries it > can't map any more foreign domain pages. Instead of silently stalling > the affected domUs issue a rate limited warning in this case in order > to make it easier to detect that

Re: [Xen-devel] [PATCH] xen/x86/vpmu: Zero struct pt_regs before calling into sample handling code

2018-09-20 Thread Boris Ostrovsky
On 7/13/18 4:41 AM, Juergen Gross wrote: > On 12/07/18 19:27, Boris Ostrovsky wrote: >> Otherwise we may leak kernel stack for events that sample user >> registers. >> >> Reported-by: Mark Rutland >> Signed-off-by: Boris Ostrovsky >> Cc: sta...@vger.kernel.org > Reviewed-by: Juergen Gross >

Re: [Xen-devel] [PATCH v4 2/2] libxl: made vm mac address assignment deterministic

2018-09-20 Thread Wei Liu
On Wed, Sep 12, 2018 at 05:40:37PM +, Joshua Perrett wrote: [...] > +int libxl__get_host_mac(libxl__gc *gc, unsigned char *buf) > +{ > +int rc = ERROR_FAIL; > + > +struct ifaddrs *iface_list; > +uint8_t largest[6] = {0}; > + > +if (getifaddrs(_list) == 0) { > +for

Re: [Xen-devel] [PATCH v4 1/2] Created tools/shared directory containing MD5 files

2018-09-20 Thread Wei Liu
On Wed, Sep 12, 2018 at 05:40:36PM +, Joshua Perrett wrote: > MD5 code is originally from the public domain (written by Colin Plumb in > 1993), files taken from xen/tools/blktap2/drivers/. They have been > modified slightly (useful functions made public). > > Signed-off-by: Joshua perrett >

Re: [Xen-devel] [PATCH 7/7] amd-iommu: add lookup_page method to iommu_ops

2018-09-20 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Jan Beulich > Sent: 20 September 2018 16:04 > To: Paul Durrant > Cc: Andrew Cooper ; Brian Woods > ; Wei Liu ; Suravee > Suthikulpanit ; xen-devel de...@lists.xenproject.org> > Subject:

Re: [Xen-devel] PXE boot with e1000 using OVMF

2018-09-20 Thread Wei Liu
On Thu, Sep 20, 2018 at 12:33:42PM +0100, Anthony PERARD wrote: > On Wed, Sep 19, 2018 at 11:04:22AM -0600, Tamas K Lengyel wrote: > > On Wed, Sep 19, 2018 at 10:36 AM Wei Liu wrote: > > > > > > On Wed, Sep 12, 2018 at 11:54:02AM -0600, Tamas K Lengyel wrote: > > > > HI all, > > > > I'm

Re: [Xen-devel] [PATCH 00/12] add per-domain and per-cpupool generic parameters

2018-09-20 Thread Wei Liu
On Wed, Sep 19, 2018 at 07:58:50PM +0200, Juergen Gross wrote: > > Did you look into the patches, especially patch 10? The parameters set > are all stored in domain config via libxl__arch_domain_save_config(). No, I didn't. I think the general idea of what you do in patch 10 should work.

Re: [Xen-devel] null scheduler bug

2018-09-20 Thread Dario Faggioli
Hey, Sorry for not having followed up. I was (and still am) planning to, but am also a bit busy. On Thu, 2018-09-20 at 15:04 +0200, Milan Boberic wrote: > I ran some more tests and managed to successfully create and destroy > domU as many times as I want, without any delay between destroy and >

Re: [Xen-devel] [PATCH v2 3/4] x86/HVM: implement memory read caching

2018-09-20 Thread Wei Liu
On Thu, Sep 20, 2018 at 12:39:59AM -0600, Jan Beulich wrote: > >>> On 19.09.18 at 17:57, wrote: > > On Tue, Sep 11, 2018 at 07:15:19AM -0600, Jan Beulich wrote: > >> Emulation requiring device model assistance uses a form of instruction > >> re-execution, assuming that the second (and any

Re: [Xen-devel] [PATCH v2] iommu: setup inclusive mappings before enabling iommu

2018-09-20 Thread Julien Grall
Hi Roger, On 09/14/2018 02:58 PM, Roger Pau Monne wrote: Or else it can lead to freezes when enabling the iommu on certain Intel hardware: [...] (XEN) ELF: addresses: (XEN) virt_base= 0x8000 (XEN) elf_paddr_offset = 0x0 (XEN) virt_offset =

Re: [Xen-devel] [PATCH net-next 17/22] hv_netvsc: fix return type of ndo_start_xmit function

2018-09-20 Thread Haiyang Zhang
> -Original Message- > From: YueHaibing > Sent: Thursday, September 20, 2018 8:33 AM > To: da...@davemloft.net; dmitry.tarnya...@lockless.no; > w...@grandegger.com; m...@pengutronix.de; michal.si...@xilinx.com; > hswee...@visionengravers.com; madalin.bu...@nxp.com; >

Re: [Xen-devel] [PATCH net-next 17/22] hv_netvsc: fix return type of ndo_start_xmit function

2018-09-20 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, September 20, 2018 10:44 AM > To: YueHaibing > Cc: da...@davemloft.net; dmitry.tarnya...@lockless.no; > w...@grandegger.com; m...@pengutronix.de; michal.si...@xilinx.com; > hswee...@visionengravers.com;

Re: [Xen-devel] [PATCH v5 2/3] x86/altp2m: Add a hvmop for setting the suppress #VE bit

2018-09-20 Thread Razvan Cojocaru
On 9/20/18 2:34 PM, George Dunlap wrote: >> +int p2m_set_suppress_ve(struct domain *d, gfn_t gfn, bool suppress_ve, >> +unsigned int altp2m_idx) > This should clearly be in p2m.c, and... > >> +{ >> +struct p2m_domain *host_p2m = p2m_get_hostp2m(d); >> +struct

Re: [Xen-devel] [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function

2018-09-20 Thread David Miller
From: YueHaibing Date: Thu, 20 Sep 2018 20:32:44 +0800 > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to

Re: [Xen-devel] [PATCH] xen: Make XEN_BACKEND selectable by DomU

2018-09-20 Thread Jason Andryuk
On Thu, Sep 20, 2018 at 10:54 AM Jan Beulich wrote: > > >>> On 20.09.18 at 16:32, wrote: > > --- a/drivers/xen/Kconfig > > +++ b/drivers/xen/Kconfig > > @@ -101,8 +101,7 @@ config XEN_DEV_EVTCHN > > > > config XEN_BACKEND > > bool "Backend driver support" > > - depends on XEN_DOM0 > >

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-20 Thread George Dunlap
On Thu, Sep 20, 2018 at 3:55 PM Razvan Cojocaru wrote: > > On 9/20/18 5:42 PM, George Dunlap wrote: > > I do have a question about your proposed use case. You're running > > this in 'mixed' mode, right, and using the altp2m to hide a secure bit > > of code from the operating system? What's to

[Xen-devel] [freebsd-master test] 127804: all pass - PUSHED

2018-09-20 Thread osstest service owner
flight 127804 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/127804/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd fb80e9f8be0c30110a80d98247b82f1d42dd909d baseline version: freebsd

[Xen-devel] [distros-debian-wheezy test] 75255: trouble: blocked/broken

2018-09-20 Thread Platform Team regression test user
flight 75255 distros-debian-wheezy real [real] http://osstest.xensource.com/osstest/logs/75255/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] [PATCH 7/7] amd-iommu: add lookup_page method to iommu_ops

2018-09-20 Thread Jan Beulich
>>> On 20.09.18 at 16:11, wrote: > This patch adds a new method to the AMD IOMMU implementation to find the > MFN currently mapped by the specified DFN. This is analogous to the > method added for VT-d IOMMU by commit 43d1622b. Please don't provide commit IDs from (presumably) your private repo,

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-20 Thread Razvan Cojocaru
On 9/20/18 5:42 PM, George Dunlap wrote: > I do have a question about your proposed use case. You're running > this in 'mixed' mode, right, and using the altp2m to hide a secure bit > of code from the operating system? What's to stop a rogue operating > system that doesn't want to be

Re: [Xen-devel] [PATCH] xen: Make XEN_BACKEND selectable by DomU

2018-09-20 Thread Jan Beulich
>>> On 20.09.18 at 16:32, wrote: > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -101,8 +101,7 @@ config XEN_DEV_EVTCHN > > config XEN_BACKEND > bool "Backend driver support" > - depends on XEN_DOM0 > - default y > + default y if XEN_DOM0 Why not the simpler

Re: [Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-20 Thread Jan Beulich
>>> On 20.09.18 at 16:13, wrote: > On 20/09/18 14:39, Jan Beulich wrote: > On 20.09.18 at 14:41, wrote: >>> On 13/09/18 11:12, Jan Beulich wrote: The function does two translations in one go for a single guest access. Any failure of the first translation step (guest linear -> guest

Re: [Xen-devel] [PATCH net-next 17/22] hv_netvsc: fix return type of ndo_start_xmit function

2018-09-20 Thread Stephen Hemminger
On Thu, 20 Sep 2018 20:33:01 +0800 YueHaibing wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-20 Thread George Dunlap
On Tue, Sep 4, 2018 at 6:00 AM Adrian Pop wrote: > > In a classic HVI + Xen setup, the introspection engine would monitor > legacy guest page-tables by marking them read-only inside the EPT; this > way any modification explicitly made by the guest or implicitly made by > the CPU page walker would

Re: [Xen-devel] clean up physical merging helpers

2018-09-20 Thread Jens Axboe
On 9/20/18 12:29 AM, Christoph Hellwig wrote: > On Sat, Sep 15, 2018 at 08:47:13AM -0600, Jens Axboe wrote: this series moves various helpers related to merging based on physical addresses from the public headers into block/, moves the Xen special case from arch hooks into common

[Xen-devel] [xen-4.6-testing test] 127792: tolerable FAIL - PUSHED

2018-09-20 Thread osstest service owner
flight 127792 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/127792/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-xtf-amd64-amd64-5 50 xtf/test-hvm64-lbr-tsx-vmentry fail in 127746 pass in 127792

[Xen-devel] [PATCH] xen: Make XEN_BACKEND selectable by DomU

2018-09-20 Thread Jason Andryuk
XEN_BACKEND doesn't actually depend on XEN_DOM0. DomUs can serve backends to other DomUs. One example is a service VM providing network backends. The original Kconfig defaulted Dom0 to y and it could be disabled. DomU could not select the option. With the new Kconfig, we default y for Dom0

Re: [Xen-devel] [PATCH v1] x86/hvm: Change return error for offline vcpus

2018-09-20 Thread Isaila Alexandru
On Thu, 2018-09-20 at 07:55 -0600, Jan Beulich wrote: > > > > On 20.09.18 at 14:54, wrote: > > > > --- a/xen/arch/x86/hvm/save.c > > +++ b/xen/arch/x86/hvm/save.c > > @@ -165,7 +165,7 @@ int hvm_save_one(struct domain *d, unsigned int > > typecode, unsigned int instance, > > if ( (rv =

Re: [Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-20 Thread Andrew Cooper
On 20/09/18 14:39, Jan Beulich wrote: On 20.09.18 at 14:41, wrote: >> On 13/09/18 11:12, Jan Beulich wrote: >>> The function does two translations in one go for a single guest access. >>> Any failure of the first translation step (guest linear -> guest >>> physical), resulting in #PF, ought

[Xen-devel] [PATCH 1/7] amd-iommu: don't domain_crash() inside map/unmap_page()

2018-09-20 Thread Paul Durrant
Commit c210cafb "iommu: don't domain_crash() inside iommu_map/unmap_page()" removed the implicit domain_crash() from the iommu_ops wrapper functions. This patch does the same thing in the AMD IOMMU implementation. This is a necessary pre-requisite for implementation of PV IOMMU. Signed-off-by:

[Xen-devel] [PATCH 3/7] amd-iommu: convert all bool_t to bool

2018-09-20 Thread Paul Durrant
Fix assignments to use 'false' rather than '0'. Signed-off-by: Paul Durrant --- Cc: Suravee Suthikulpanit Cc: Brian Woods --- xen/drivers/passthrough/amd/iommu_map.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[Xen-devel] [PATCH 2/7] amd-iommu: re-name u8/16/32/64 to uint8/16/32/64_t

2018-09-20 Thread Paul Durrant
This patch is largely cosmetic. The only non-cosmetic changes are to re-define the local pde variable as a uint32_t pointer (rather than a uint64_t pointer) in iommu_merge_pages() and iommu_pde_from_dfn() to allow the removal of rather excessive amounts of casting. NOTE: This patch also adds

[Xen-devel] [PATCH 4/7] amd-iommu: reduce code duplication...

2018-09-20 Thread Paul Durrant
...by calling update_paging_mode() inside iommu_pde_from_dfn(). Also have iommu_pde_from_dfn() return -EFAULT if pt_mfn[1] is zero, to avoid the callers having to explictly test it. NOTE: The return value of iommu_pde_from_dfn() is ignored by amd_iommu_map_page(). Instead, to preserve the

[Xen-devel] [PATCH 6/7] vtd: change lookup_page failure semantics

2018-09-20 Thread Paul Durrant
Commit 43d1622b "vtd: add lookup_page method to iommu_ops" added a lookup method in to the VT-d IOMMU implementation. In some cases (such as when shared EPT is in operation) that function simply passes back an identity MFN (i.e. an MFN with the same value as the DFN that was passed in), but this

[Xen-devel] [PATCH 0/7] amd-iommu: cleanup and add lookup_page method

2018-09-20 Thread Paul Durrant
The aim of this series is to add a lookup_page method for AMD IOMMU analogous to that recently added for VT-d. That is done by the last patch. The first five patches are cleanup of the AMD IOMMU code, and patch six modifies the VT-d code to remove a semantic problem. Paul Durrant (7):

[Xen-devel] [PATCH 5/7] amd-iommu: introduce new get/set_iommu_pde_info() functions...

2018-09-20 Thread Paul Durrant
...and use set_iommu_pde_info() in set_iommu_pde_present(). set_iommu_pde_info() only sets the address and read/write flags in the PDE, leaving the (PTE-only) FC bit, level value and presence bit to be subsequently set by set_iommu_pde_present(). A memory barrier is added to ensure that the

[Xen-devel] [PATCH net-next 22/22] net: hsr: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 05/22] net: sgi: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 07/22] net: i825xx: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 06/22] net: wiznet: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 10/22] net: ti: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. YueHaibing (22): net: micrel: fix return type of

[Xen-devel] [PATCH net-next 02/22] net: freescale: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 01/22] net: micrel: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 20/22] rionet: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 14/22] net: caif: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 13/22] net: xen-netback: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 04/22] net: cirrus: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 03/22] net: seeq: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 21/22] l2tp: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 17/22] hv_netvsc: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 18/22] can: xilinx: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 09/22] net: smsc: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 15/22] net: hamradio: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 19/22] net: plip: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 11/22] net: faraday: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Found by coccinelle. Signed-off-by: YueHaibing --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++--

[Xen-devel] [PATCH net-next 12/22] net: ovs: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 16/22] usbnet: ipheth: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

[Xen-devel] [PATCH net-next 08/22] net: apple: fix return type of ndo_start_xmit function

2018-09-20 Thread YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return type to netdev_tx_t. Found by coccinelle. Signed-off-by: YueHaibing ---

Re: [Xen-devel] [PATCH net-next 13/22] net: xen-netback: fix return type of ndo_start_xmit function

2018-09-20 Thread Wei Liu
On Thu, Sep 20, 2018 at 08:32:57PM +0800, YueHaibing wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to

Re: [Xen-devel] PXE boot with e1000 using OVMF

2018-09-20 Thread Tamas K Lengyel
On Thu, Sep 20, 2018 at 5:34 AM Anthony PERARD wrote: > > On Wed, Sep 19, 2018 at 11:04:22AM -0600, Tamas K Lengyel wrote: > > On Wed, Sep 19, 2018 at 10:36 AM Wei Liu wrote: > > > > > > On Wed, Sep 12, 2018 at 11:54:02AM -0600, Tamas K Lengyel wrote: > > > > HI all, > > > > I'm experimenting

Re: [Xen-devel] [PATCH v1] x86/hvm: Change return error for offline vcpus

2018-09-20 Thread Jan Beulich
>>> On 20.09.18 at 14:54, wrote: > --- a/xen/arch/x86/hvm/save.c > +++ b/xen/arch/x86/hvm/save.c > @@ -165,7 +165,7 @@ int hvm_save_one(struct domain *d, unsigned int typecode, > unsigned int instance, > if ( (rv = hvm_sr_handlers[typecode].save(v, )) != 0 ) > printk(XENLOG_G_ERR

Re: [Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-20 Thread Jan Beulich
>>> On 20.09.18 at 14:41, wrote: > On 13/09/18 11:12, Jan Beulich wrote: >> The function does two translations in one go for a single guest access. >> Any failure of the first translation step (guest linear -> guest >> physical), resulting in #PF, ought to take precedence over any failure >> of

Re: [Xen-devel] [PATCH v2] x86/AMD: write PAT after ucode update

2018-09-20 Thread Andrew Cooper
On 20/09/18 09:40, Jan Beulich wrote: > The increased number of messages (spec_ctrl.c:print_details()) within a > certain time window made me notice some slowness of boot time screen > output. Experimentally I've narrowed the time window to be from > immediately after the early ucode update on the

Re: [Xen-devel] [PATCH] x86/mm: re-indent after "re-arrange get_page_from_le() vs pv_l1tf_check_le()"

2018-09-20 Thread Andrew Cooper
On 10/09/18 15:01, Jan Beulich wrote: > That earlier change introduced two "else switch ()" constructs which now > get converted back to "normal" style (indentation). To limit indentation > depth, a conditional gets inverted in ptwr_emulated_update(). > > No functional change intended. > >

Re: [Xen-devel] null scheduler bug

2018-09-20 Thread Milan Boberic
I ran some more tests and managed to successfully create and destroy domU as many times as I want, without any delay between destroy and create. I added: printk("End of a domain_destroy function"); in domain_destroy function and printk("End of a complete_domain_destroy function"); in

[Xen-devel] [PATCH v1] x86/hvm: Change return error for offline vcpus

2018-09-20 Thread Alexandru Isaila
This patch is needed in order to have a different return error for invalid vcpu and offline vcpu. Signed-off-by: Alexandru Isaila --- xen/arch/x86/hvm/save.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/save.c b/xen/arch/x86/hvm/save.c index

Re: [Xen-devel] [PATCH v5 3/3] x86/altp2m: Add a hvmop for querying the suppress #VE bit

2018-09-20 Thread George Dunlap
On 09/03/2018 04:48 PM, Adrian Pop wrote: > Signed-off-by: Adrian Pop > --- > tools/libxc/include/xenctrl.h | 2 ++ > tools/libxc/xc_altp2m.c | 26 +++ > xen/arch/x86/hvm/hvm.c | 19 ++ > xen/arch/x86/mm/mem_access.c| 45

Re: [Xen-devel] x86 Community Call - Wed Sept 12, 14:00 - 15:00 UTC - Minutes

2018-09-20 Thread Lars Kurth
Hi all: I just noticed that the Minutes link at https://docs.google.com/document/d/1VUPdWwd1raDOPhjReVVkmb6YoQB3X5oU12E4ExjO1n0/edit?usp=sharing did not allow people to edit the page. Apologies. This is fixed now. Feel free to make corrections. I will wait for a couple of days before sending

[Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-20 Thread Andrew Cooper
On 13/09/18 11:12, Jan Beulich wrote: > The function does two translations in one go for a single guest access. > Any failure of the first translation step (guest linear -> guest > physical), resulting in #PF, ought to take precedence over any failure > of the second step (guest physical -> host

[Xen-devel] [seabios baseline-only test] 75254: trouble: blocked/broken

2018-09-20 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75254 seabios real [real] http://osstest.xensource.com/osstest/logs/75254/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm

Re: [Xen-devel] [PATCH v5 2/3] x86/altp2m: Add a hvmop for setting the suppress #VE bit

2018-09-20 Thread Razvan Cojocaru
On 9/20/18 2:34 PM, George Dunlap wrote: > On 09/03/2018 04:48 PM, Adrian Pop wrote: >> Introduce a new hvmop, HVMOP_altp2m_set_suppress_ve, which allows a >> domain to change the value of the #VE suppress bit for a page. >> >> Add a libxc wrapper for invoking this hvmop. >> >> Signed-off-by:

Re: [Xen-devel] [PATCH v5 2/3] x86/altp2m: Add a hvmop for setting the suppress #VE bit

2018-09-20 Thread George Dunlap
On 09/03/2018 04:48 PM, Adrian Pop wrote: > Introduce a new hvmop, HVMOP_altp2m_set_suppress_ve, which allows a > domain to change the value of the #VE suppress bit for a page. > > Add a libxc wrapper for invoking this hvmop. > > Signed-off-by: Adrian Pop > Acked-by: Wei Liu > Acked-by: Tamas

Re: [Xen-devel] PXE boot with e1000 using OVMF

2018-09-20 Thread Anthony PERARD
On Wed, Sep 19, 2018 at 11:04:22AM -0600, Tamas K Lengyel wrote: > On Wed, Sep 19, 2018 at 10:36 AM Wei Liu wrote: > > > > On Wed, Sep 12, 2018 at 11:54:02AM -0600, Tamas K Lengyel wrote: > > > HI all, > > > I'm experimenting with OVMF and I checked to see if OVMF can do PXE > > > boot out-of-the

[Xen-devel] [xen-unstable-smoke test] 127835: tolerable all pass - PUSHED

2018-09-20 Thread osstest service owner
flight 127835 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127835/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [PATCH] libxl: keep assigned pci devices across domain reboots

2018-09-20 Thread Roger Pau Monne
Fill the from_xenstore libxl_device_type hook for PCI devices so that libxl_retrieve_domain_configuration can properly retrieve PCI devices from xenstore. This fixes disappearing pci devices across domain reboots. Reported-by: Andreas Kinzler Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson

[Xen-devel] [xen-4.10-testing baseline-only test] 75251: trouble: blocked/broken

2018-09-20 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75251 xen-4.10-testing real [real] http://osstest.xensource.com/osstest/logs/75251/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64

[Xen-devel] [xen-unstable bisection] complete test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm

2018-09-20 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm testid xen-boot Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu

Re: [Xen-devel] [PATCH] x86/mm: re-indent after "re-arrange get_page_from_le() vs pv_l1tf_check_le()"

2018-09-20 Thread Wei Liu
On Mon, Sep 10, 2018 at 08:01:39AM -0600, Jan Beulich wrote: > That earlier change introduced two "else switch ()" constructs which now > get converted back to "normal" style (indentation). To limit indentation > depth, a conditional gets inverted in ptwr_emulated_update(). > > No functional

[Xen-devel] [xen-4.11-testing baseline-only test] 75252: trouble: blocked/broken

2018-09-20 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75252 xen-4.11-testing real [real] http://osstest.xensource.com/osstest/logs/75252/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64

[Xen-devel] [PATCH v2] x86/AMD: write PAT after ucode update

2018-09-20 Thread Jan Beulich
The increased number of messages (spec_ctrl.c:print_details()) within a certain time window made me notice some slowness of boot time screen output. Experimentally I've narrowed the time window to be from immediately after the early ucode update on the BSP to the PAT write in cpu_init(). For that

Re: [Xen-devel] [PATCH v5 3/3] x86/altp2m: Add a hvmop for querying the suppress #VE bit

2018-09-20 Thread Wei Liu
On Thu, Sep 20, 2018 at 08:53:26AM +0100, Wei Liu wrote: > On Thu, Sep 20, 2018 at 10:46:01AM +0300, Razvan Cojocaru wrote: > > On 9/19/18 5:48 PM, Wei Liu wrote: > > > On Mon, Sep 03, 2018 at 06:48:36PM +0300, Adrian Pop wrote: > > >> Signed-off-by: Adrian Pop > > > > > > Acked-by: Wei Liu > >

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-20 Thread Razvan Cojocaru
On 9/20/18 11:31 AM, Wei Liu wrote: Reviewed-by: Tamas K Lengyel >>> Are there any issues preventing this patch to go in? Possibly missing acks? >> Well, afaics the patch has no x86 maintainer ack, nor - considering it's >> an mm function sitting in the "wrong" file, at least one from the mm

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-20 Thread Jan Beulich
>>> On 20.09.18 at 10:11, wrote: > Are there any issues preventing this patch to go in? Possibly missing acks? Oh, and btw - irrespective what MAINTAINERS says - patches to this function would better also be Cc-ed to George as the mm maintainer. Even more so that I think it has become clear from

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-20 Thread Wei Liu
On Thu, Sep 20, 2018 at 02:22:29AM -0600, Jan Beulich wrote: > >>> On 20.09.18 at 10:11, wrote: > > On 9/6/18 1:27 AM, Tamas K Lengyel wrote: > >> On Wed, Sep 5, 2018 at 12:45 PM Andrew Cooper > > wrote: > >>> > >>> On 05/09/18 19:40, Tamas K Lengyel wrote: > On Wed, Sep 5, 2018 at 10:40

Re: [Xen-devel] [PATCH v3] x86/pvh: copy data from low 1MB to Dom0 physmap instead of mapping it

2018-09-20 Thread Jan Beulich
>>> On 19.09.18 at 11:13, wrote: > Identity mapping RAM regions on the low 1MB for Dom0 is not ideal, > since there's data there that could be used by Xen during runtime > (like the AP trampoline), so instead of identity mapping the low 1MB > into the Dom0 physmap populate those RAM regions and

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-20 Thread Jan Beulich
>>> On 20.09.18 at 10:11, wrote: > On 9/6/18 1:27 AM, Tamas K Lengyel wrote: >> On Wed, Sep 5, 2018 at 12:45 PM Andrew Cooper > wrote: >>> >>> On 05/09/18 19:40, Tamas K Lengyel wrote: On Wed, Sep 5, 2018 at 10:40 AM Razvan Cojocaru wrote: > On 9/5/18 7:28 PM, Tamas K Lengyel

Re: [Xen-devel] [PATCH RFC] x86/lapic: remove the PIT usage to calibrate the lapic timer

2018-09-20 Thread Jan Beulich
>>> On 19.09.18 at 18:25, wrote: > And instead use NOW which is based on the TSC. This was already used > when running in shim mode, since there's likely no PIT in that > environment. > > Remove printing the CPU frequency, since it's already printed earlier > at boot, and getting the CPU

Re: [Xen-devel] [PATCH v2] x86/altp2m: Allow setting the #VE info page for an arbitrary VCPU

2018-09-20 Thread Razvan Cojocaru
On 9/20/18 11:14 AM, Wei Liu wrote: >>> Reviewed-by: Tamas K Lengyel >> Are there any issues preventing this patch to go in? Possibly missing acks? > I don't think so, unless an explicit ack for the deletion of that > comment is required. In any case: > > Acked-by: Wei Liu > > I will commit

  1   2   >