[Xen-devel] [ovmf test] 148052: all pass - PUSHED

2020-03-04 Thread osstest service owner
flight 148052 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/148052/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0980779a9ddcd9c98a68d57d214b4f466bb680b0 baseline version: ovmf

Re: [Xen-devel] [PATCH v6 09/12] xen: add runtime parameter access support to hypfs

2020-03-04 Thread Jürgen Groß
On 04.03.20 17:56, Jan Beulich wrote: On 04.03.2020 17:31, Jürgen Groß wrote: On 04.03.20 16:19, Jan Beulich wrote: On 04.03.2020 16:07, Jürgen Groß wrote: On 04.03.20 12:32, Jan Beulich wrote: On 26.02.2020 13:47, Juergen Gross wrote: +static void update_ept_param_append(const char *str,

[Xen-devel] [linux-4.14 bisection] complete test-amd64-amd64-xl-qemuu-ovmf-amd64

2020-03-04 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemuu-ovmf-amd64 testid debian-hvm-install Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf

[Xen-devel] [xen-unstable test] 148033: regressions - FAIL

2020-03-04 Thread osstest service owner
flight 148033 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/148033/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 12 guest-start/redhat.repeat fail REGR. vs. 147600

Re: [Xen-devel] [PATCH v3 11/20] hw/ide/internal: Remove unused DMARestartFunc typedef

2020-03-04 Thread John Snow
On 2/20/20 8:05 AM, Philippe Mathieu-Daudé wrote: > The IDE DMA restart callback has been removed in commit fe09c7c9f0. > > Fixes: fe09c7c9f0 > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/ide/internal.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [Xen-devel] [PATCH v3 12/20] hw/ide: Let the DMAIntFunc prototype use a boolean 'is_write' argument

2020-03-04 Thread John Snow
On 2/20/20 8:05 AM, Philippe Mathieu-Daudé wrote: > The 'is_write' argument is either 0 or 1. > Convert it to a boolean type. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/ide/internal.h | 2 +- > hw/dma/rc4030.c | 6 +++--- > hw/ide/ahci.c | 2 +- >

Re: [Xen-devel] [PATCH] block: refactor duplicated macros

2020-03-04 Thread Matteo Croce
On Wed, Mar 4, 2020 at 9:57 PM Dan Williams wrote: > > On Sun, Feb 23, 2020 at 9:04 AM Matteo Croce wrote: > > > > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > > several times in different flavours across the whole tree. > > Define them just once in a common header.

[Xen-devel] [linux-4.14 test] 147966: regressions - FAIL

2020-03-04 Thread osstest service owner
flight 147966 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/147966/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 7 xen-boot fail REGR. vs. 142849

Re: [Xen-devel] [PATCH] block: refactor duplicated macros

2020-03-04 Thread Dan Williams
On Sun, Feb 23, 2020 at 9:04 AM Matteo Croce wrote: > > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > Signed-off-by: Matteo Croce > --- > block/blk-lib.c

Re: [Xen-devel] [PATCH v2 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-04 Thread John Snow
On 3/4/20 10:38 AM, Philippe Mathieu-Daudé wrote: > v2: > - do not modify qed.h (structure with single member) > - based on hw/scsi/spapr_vscsi fix series: > https://mid.mail-archive.com/20200304153311.22959-1-philmd@redhat.com > > This is a tree-wide cleanup inspired by a Linux kernel commit

Re: [Xen-devel] [PATCH] x86/cpuid: Untangle Invariant TSC handling

2020-03-04 Thread Andrew Cooper
On 04/03/2020 10:25, Jan Beulich wrote: > On 03.03.2020 19:24, Andrew Cooper wrote: >> ITSC being visible to the guest is currently implicit with the toolstack >> unconditionally asking for it, and Xen clipping it based on the vTSC and/or >> XEN_DOMCTL_disable_migrate settings. >> >> This is

Re: [Xen-devel] [PATCH v5 2/2] docs/designs: Add a design document for migration of xenstore data

2020-03-04 Thread Julien Grall
Hi Paul, On 13/02/2020 10:53, Paul Durrant wrote: This patch details proposes extra migration data and xenstore protocol extensions to support non-cooperative live migration of guests. Signed-off-by: Paul Durrant --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc:

Re: [Xen-devel] [PATCH v2] golang/xenlight: implement constructor generation

2020-03-04 Thread George Dunlap
On 3/2/20 8:10 PM, Nick Rosbrook wrote: > Generate constructors for generated Go types. Call libxl__init so > the Go type can be properly initialized. > > If a type has a keyed union field, add a parameter to the function > signature to set the key variable, and call the init function for the >

[Xen-devel] xen boot PVH guest with linux 5.6.0-rc4-ish kernel: general protection fault, RIP: 0010:__pv_queued_spin_lock_slowpath

2020-03-04 Thread Sander Eikelenboom
[1.921031] general protection fault, probably for non-canonical address 0x344a3feab7bf8: [#1] SMP NOPTI [1.921090] CPU: 1 PID: 1686 Comm: systemd-udevd Tainted: GW 5.6.0-rc4-20200304-doflr-mac80211debug+ #1 [1.921134] RIP: 0010:__pv_queued_spin_lock_slowpath

Re: [Xen-devel] [PATCH] x86/cpuid: Untangle Invariant TSC handling

2020-03-04 Thread Andrew Cooper
On 04/03/2020 09:33, Durrant, Paul wrote: >> -Original Message- >> From: Xen-devel On Behalf Of Andrew >> Cooper >> Sent: 03 March 2020 18:25 >> To: Xen-devel >> Cc: Wei Liu ; Andrew Cooper ; Jan >> Beulich ; >> Anthony PERARD ; Ian Jackson >> ; Roger Pau Monné >> >> Subject:

Re: [Xen-devel] [PATCH] libxenstat: fixed Makefile for building python-bindings

2020-03-04 Thread Jonas Licht
Am 04.03.20 um 11:31 schrieb Wei Liu: > Hi Jonas Hi Wei > Thanks for this patch. > > On Mon, Mar 02, 2020 at 06:53:38PM +0100, jonas.li...@fem.tu-ilmenau.de wrote: >> Fixes the libxenstat Makefile to determine the correct paths >> of python includes when building python-bindings. >> Also replaces

Re: [Xen-devel] [PATCH v6 09/12] xen: add runtime parameter access support to hypfs

2020-03-04 Thread Jan Beulich
On 04.03.2020 17:31, Jürgen Groß wrote: > On 04.03.20 16:19, Jan Beulich wrote: >> On 04.03.2020 16:07, Jürgen Groß wrote: >>> On 04.03.20 12:32, Jan Beulich wrote: On 26.02.2020 13:47, Juergen Gross wrote: > +static void update_ept_param_append(const char *str, int val) > +{ > +

Re: [Xen-devel] [PATCH v6 09/12] xen: add runtime parameter access support to hypfs

2020-03-04 Thread Jürgen Groß
On 04.03.20 16:19, Jan Beulich wrote: On 04.03.2020 16:07, Jürgen Groß wrote: On 04.03.20 12:32, Jan Beulich wrote: On 26.02.2020 13:47, Juergen Gross wrote: +static void update_ept_param_append(const char *str, int val) +{ +char *pos = opt_ept_setting + strlen(opt_ept_setting); + +

Re: [Xen-devel] [PATCH v5 1/2] docs/designs: Add a design document for non-cooperative live migration

2020-03-04 Thread Durrant, Paul
> -Original Message- > >>> +HVM guests can already be migrated on Xen without guest co-operation but > >>> only > >>> +if they don’t have PV drivers installed[1] or are in power state S3. The > >> > >> S3 is very ACPI centric, so I would prefer if we avoid the term. I think > >> the

Re: [Xen-devel] [XEN PATCH v3 21/23] xen/build: Use if_changed for prelink*.o

2020-03-04 Thread Jan Beulich
On 27.02.2020 14:16, Roger Pau Monné wrote: > On Wed, Feb 26, 2020 at 11:33:53AM +, Anthony PERARD wrote: >> We change the dependencies of prelink-efi.o so that we can use the >> same command line. The dependency on efi/built_in.o isn't needed >> because, we already have: >> efi/*.o:

Re: [Xen-devel] [XEN PATCH v3 19/23] xen/build: Use if_changed_rules with %.o:%.c targets

2020-03-04 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > Use $(dot-target) to have the target name prefix with a dot. > > Now, when the CC command has run, it is recorded in .*.cmd > file, then if_changed_rules will compare it on subsequent runs. > > Signed-off-by: Anthony PERARD Reviewed-by: Jan Beulich

Re: [Xen-devel] [BUG] panic: "IO-APIC + timer doesn't work" - several people have reproduced

2020-03-04 Thread Jason Andryuk
On Wed, Feb 19, 2020 at 3:25 AM Jan Beulich wrote: > > On 18.02.2020 22:45, Andrew Cooper wrote: > > On 18/02/2020 18:43, Jason Andryuk wrote: > >> On Mon, Feb 17, 2020, 8:22 PM Andrew Cooper > >> wrote: > >>> On 17/02/2020 20:41, Jason Andryuk wrote: > On Mon, Feb 17, 2020 at 2:46 PM

Re: [Xen-devel] [BUG] panic: "IO-APIC + timer doesn't work" - several people have reproduced

2020-03-04 Thread Jason Andryuk
> > >>> One other thing that might be noteworthy. Linux only prints ACPI IRQ0 > > >>> and IRQ9 used by override where Xen lists IRQ 0, 2 & 9. > > >> Huh - this is supposed to come directly from the ACPI tables, so Linux > > >> and Xen should be using the same source of information. Both Xen and

Re: [Xen-devel] [XEN PATCH v3 18/23] xen/build: use if_changed on built_in.o

2020-03-04 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -126,14 +126,21 @@ include $(BASEDIR)/arch/$(TARGET_ARCH)/Rules.mk > c_flags += $(CFLAGS-y) > a_flags += $(CFLAGS-y) $(AFLAGS-y) > > -built_in.o: $(obj-y) $(extra-y) > +quiet_cmd_ld_builtin = LD $@ >

Re: [Xen-devel] [XEN PATCH v3 17/23] xen/build: Start using if_changed

2020-03-04 Thread Jan Beulich
On 27.02.2020 14:09, Roger Pau Monné wrote: > On Wed, Feb 26, 2020 at 11:33:49AM +, Anthony PERARD wrote: >> @@ -161,29 +173,47 @@ else >> $(CC) $(c_flags) -c $< -o $@ >> endif >> >> -%.o: %.S Makefile >> -$(CC) $(a_flags) -c $< -o $@ >> +quiet_cmd_cc_o_S = CC $@ >>

Re: [Xen-devel] [PATCH v2 1/4] qapi: net: Add query-netdevs command

2020-03-04 Thread Laurent Vivier
On 04/03/2020 14:06, Alexey Kirillov wrote: > Add a qmp command that provides information about currently attached > network devices and their configuration. > > Signed-off-by: Alexey Kirillov > --- > include/net/net.h | 1 + > net/hub.c | 8 +++ > net/l2tpv3.c | 19 +++ >

Re: [Xen-devel] [XEN PATCH v3 16/23] xen/build: introduce if_changed and if_changed_rule

2020-03-04 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > The if_changed macro from Linux can record the command used to build a > target then compare it on rebuild. Thus if a command has changed, for > example due to introducing new flags in CFLAGS or due to using a > different compiler, the target will be

Re: [Xen-devel] [PATCH v5 1/2] docs/designs: Add a design document for non-cooperative live migration

2020-03-04 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of Julien > Grall > Sent: 04 March 2020 15:11 > To: Durrant, Paul ; xen-devel@lists.xenproject.org > Cc: Stefano Stabellini ; Wei Liu ; > Konrad Rzeszutek Wilk > ; George Dunlap ; Andrew > Cooper > ; Ian Jackson ; Jan > Beulich >

Re: [Xen-devel] [PATCH v2 4/4] net: Remove field info_str of NetClientState

2020-03-04 Thread Laurent Vivier
On 04/03/2020 14:06, Alexey Kirillov wrote: > Completely remove the info_str field of struct NetClientState because > it is no longer required due to the addition of the QMP query-netdevs command. > > Signed-off-by: Alexey Kirillov > --- > hw/net/allwinner_emac.c | 2 +- > hw/net/dp8393x.c

[Xen-devel] [PATCH v2 2/2] misc: Replace zero-length arrays with flexible array member (manual)

2020-03-04 Thread Philippe Mathieu-Daudé
Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a

[Xen-devel] [PATCH v2 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Philippe Mathieu-Daudé
Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a

[Xen-devel] [PATCH v2 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-04 Thread Philippe Mathieu-Daudé
v2: - do not modify qed.h (structure with single member) - based on hw/scsi/spapr_vscsi fix series: https://mid.mail-archive.com/20200304153311.22959-1-philmd@redhat.com This is a tree-wide cleanup inspired by a Linux kernel commit (from Gustavo A. R. Silva). --v-- description start --v--

Re: [Xen-devel] [PATCH 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 4:35 PM, Philippe Mathieu-Daudé wrote: v2: - do not modify qed.h (structure with single member) - based on hw/scsi/spapr_vscsi fix series This is a tree-wide cleanup inspired by a Linux kernel commit (from Gustavo A. R. Silva). Please ignore, for some reason the 'v2' tag is missing.

Re: [Xen-devel] [PATCH v5 1/2] docs/designs: Add a design document for non-cooperative live migration

2020-03-04 Thread Julien Grall
Hi Paul, On 04/03/2020 15:23, Durrant, Paul wrote: -Original Message- From: Xen-devel On Behalf Of Julien Grall Sent: 04 March 2020 15:11 To: Durrant, Paul ; xen-devel@lists.xenproject.org Cc: Stefano Stabellini ; Wei Liu ; Konrad Rzeszutek Wilk ; George Dunlap ; Andrew Cooper ; Ian

[Xen-devel] [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Philippe Mathieu-Daudé
Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a

[Xen-devel] [PATCH 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-04 Thread Philippe Mathieu-Daudé
v2: - do not modify qed.h (structure with single member) - based on hw/scsi/spapr_vscsi fix series This is a tree-wide cleanup inspired by a Linux kernel commit (from Gustavo A. R. Silva). --v-- description start --v-- The current codebase makes use of the zero-length array language

Re: [Xen-devel] [PATCH] block: refactor duplicated macros

2020-03-04 Thread Ulf Hansson
On Sun, 23 Feb 2020 at 17:57, Matteo Croce wrote: > > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > Signed-off-by: Matteo Croce For mmc: Acked-by: Ulf Hansson

[Xen-devel] [PATCH v3] x86/cpu: Sync any remaining RCU callbacks before CPU up/down

2020-03-04 Thread Igor Druzhinin
During CPU down operation RCU callbacks are scheduled to finish off some actions later as soon as CPU is fully dead (the same applies to CPU up operation in case error path is taken). If in the same grace period another CPU up operation is performed on the same CPU, RCU callback will be called

Re: [Xen-devel] [PATCH v6 04/12] xen: add basic hypervisor filesystem support

2020-03-04 Thread Jan Beulich
On 04.03.2020 16:14, Jürgen Groß wrote: > On 04.03.20 16:07, Jan Beulich wrote: >> On 04.03.2020 15:39, Jürgen Groß wrote: >>> On 04.03.20 14:03, Jan Beulich wrote: On 04.03.2020 13:00, Jürgen Groß wrote: > On 03.03.20 17:59, Jan Beulich wrote: >> On 26.02.2020 13:46, Juergen Gross

Re: [Xen-devel] [PATCH v6 09/12] xen: add runtime parameter access support to hypfs

2020-03-04 Thread Jan Beulich
On 04.03.2020 16:07, Jürgen Groß wrote: > On 04.03.20 12:32, Jan Beulich wrote: >> On 26.02.2020 13:47, Juergen Gross wrote: >>> +static void update_ept_param_append(const char *str, int val) >>> +{ >>> +char *pos = opt_ept_setting + strlen(opt_ept_setting); >>> + >>> +snprintf(pos,

Re: [Xen-devel] [PATCH v6 04/12] xen: add basic hypervisor filesystem support

2020-03-04 Thread Jürgen Groß
On 04.03.20 16:07, Jan Beulich wrote: On 04.03.2020 15:39, Jürgen Groß wrote: On 04.03.20 14:03, Jan Beulich wrote: On 04.03.2020 13:00, Jürgen Groß wrote: On 03.03.20 17:59, Jan Beulich wrote: On 26.02.2020 13:46, Juergen Gross wrote: --- /dev/null +++ b/xen/common/hypfs.c @@ -0,0 +1,349

Re: [Xen-devel] [PATCH v5 1/2] docs/designs: Add a design document for non-cooperative live migration

2020-03-04 Thread Julien Grall
Hi Paul, The proposal looks sensible to me. Some NITpicking below. On 13/02/2020 10:53, Paul Durrant wrote: It has become apparent to some large cloud providers that the current model of cooperative migration of guests under Xen is not usable as it relies on software running inside the guest,

Re: [Xen-devel] [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-03-04 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 23.02.2020 11:55, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and >>> does corresponding changes in code (look for details in >>> include/qapi/error.h) >>> >>>

Re: [Xen-devel] [PATCH v6 09/12] xen: add runtime parameter access support to hypfs

2020-03-04 Thread Jürgen Groß
On 04.03.20 12:32, Jan Beulich wrote: On 26.02.2020 13:47, Juergen Gross wrote: --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -70,6 +70,30 @@ integer_param("ple_window", ple_window); static bool __read_mostly opt_ept_pml = true; static s8 __read_mostly opt_ept_ad =

Re: [Xen-devel] [PATCH v6 04/12] xen: add basic hypervisor filesystem support

2020-03-04 Thread Jan Beulich
On 04.03.2020 15:39, Jürgen Groß wrote: > On 04.03.20 14:03, Jan Beulich wrote: >> On 04.03.2020 13:00, Jürgen Groß wrote: >>> On 03.03.20 17:59, Jan Beulich wrote: On 26.02.2020 13:46, Juergen Gross wrote: > --- /dev/null > +++ b/xen/common/hypfs.c > @@ -0,0 +1,349 @@ >

Re: [Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

2020-03-04 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > @@ -113,6 +115,64 @@ $(KCONFIG_CONFIG): > include/config/%.conf include/config/%.conf.cmd: $(KCONFIG_CONFIG) > $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) > SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)"

[Xen-devel] Fwd: [ANNOUNCE] Call for agenda items for 2020 March Community Call @ 16:00 UTC

2020-03-04 Thread George Dunlap
Hi all, The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/BiXRb0cAnVSfFjedd73D--oh/ and you can edit to add items Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name besides items if you edit the document.

Re: [Xen-devel] [XEN PATCH v3 14/23] xen/build: use new $(c_flags) and $(a_flags) instead of $(CFLAGS)

2020-03-04 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > --- a/xen/scripts/Kbuild.include > +++ b/xen/scripts/Kbuild.include > @@ -10,7 +10,7 @@ DEPS_INCLUDE = $(addsuffix .d2, $(basename $(wildcard > $(DEPS > # as-insn: Check whether assembler supports an instruction. > # Usage: cflags-y += $(call

Re: [Xen-devel] [PATCH v6 12/12] xen: remove XEN_SYSCTL_set_parameter support

2020-03-04 Thread Jürgen Groß
On 04.03.20 12:45, Jan Beulich wrote: On 26.02.2020 13:47, Juergen Gross wrote: The functionality of XEN_SYSCTL_set_parameter is available via hypfs now, so it can be removed. This allows to remove the kernel_param structure for runtime parameters by putting the now only used structure element

Re: [Xen-devel] [PATCH v6 04/12] xen: add basic hypervisor filesystem support

2020-03-04 Thread Jürgen Groß
On 04.03.20 14:03, Jan Beulich wrote: On 04.03.2020 13:00, Jürgen Groß wrote: On 03.03.20 17:59, Jan Beulich wrote: On 26.02.2020 13:46, Juergen Gross wrote: --- /dev/null +++ b/xen/common/hypfs.c @@ -0,0 +1,349 @@

[Xen-devel] [libvirt test] 147981: regressions - FAIL

2020-03-04 Thread osstest service owner
flight 147981 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/147981/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

Re: [Xen-devel] [PATCH 0/5] IOMMU: restrict visibility/scope if certain variables

2020-03-04 Thread Julien Grall
Hi Jan, Adding Paul in CC as he now co-maintain the IOMMU code. On 28/02/2020 12:24, Jan Beulich wrote: A number of the command line controlled variables are x86- or even x86-HVM-specific. Don't have those variables elsewhere in the first place (in some cases replace them by a #define), and

Re: [Xen-devel] [XEN PATCH v3 13/23] xen/build: include include/config/auto.conf in main Makefile

2020-03-04 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -49,7 +49,71 @@ default: build > .PHONY: dist > dist: install > > -build install:: include/config/auto.conf > + > +ifeq ($(root-make-done),) This getting communicated between make recursion instances via

Re: [Xen-devel] [PATCH V6] x86/altp2m: Hypercall to set altp2m view visibility

2020-03-04 Thread Alexandru Stefan ISAILA
Hi, Any thoughts on this patch are appreciated. Thanks, Alex On 03.03.2020 14:23, Alexandru Stefan ISAILA wrote: > At this moment a guest can call vmfunc to change the altp2m view. This > should be limited in order to avoid any unwanted view switch. > > The new xc_altp2m_set_visibility()

[Xen-devel] [linux-4.19 test] 147953: regressions - FAIL

2020-03-04 Thread osstest service owner
flight 147953 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/147953/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 142932

Re: [Xen-devel] [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Paolo Bonzini
On 04/03/20 15:12, Philippe Mathieu-Daudé wrote: > I'll send a fix for the dangerous code. > Do you want to drop this series, or only the change in 'struct srp_rsp' > (or in all hw/scsi/srp.h). Actually I guess it makes sense I move the > 'hw/scsi/srp.h' changes with the series cleaning dangerous

Re: [Xen-devel] [XEN PATCH v3 12/23] xen/build: Move as-option-add to xen/

2020-03-04 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > Only xen/ uses as-option-add and as-insn, so there aren't needed in > Config.mk. > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [XEN PATCH v3 10/23] xen/build: run targets csopes, tags, .. without Rules.mk

2020-03-04 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > Those targets make use of $(all_sources) which depends on TARGET_ARCH, > so we just need to set TARGET_ARCH earlier and once. > > XEN_TARGET_ARCH isn't expected to change during the build, so > TARGET_SUBARCH and TARGET_ARCH aren't going to change

Re: [Xen-devel] [XEN PATCH v3 07/23] xen/build: Use obj-y += subdir/ instead of subdir-y

2020-03-04 Thread Jan Beulich
On 27.02.2020 10:43, Jan Beulich wrote: > On 26.02.2020 12:33, Anthony PERARD wrote: >> --- a/xen/Rules.mk >> +++ b/xen/Rules.mk >> @@ -111,17 +111,14 @@ define gendep >> endef >> $(foreach o,$(filter-out %/,$(obj-y) $(obj-bin-y) $(extra-y)),$(eval $(call >> gendep,$(o >> >> -# Ensure

Re: [Xen-devel] [XEN PATCH v3 09/23] xen/build: extract clean target from Rules.mk

2020-03-04 Thread Jan Beulich
On 26.02.2020 12:33, Anthony PERARD wrote: > From: Anthony PERARD > > Most of the code executed by Rules.mk isn't necessary for the clean > target, especially not the CFLAGS. This patch makes running make clean > much faster. > > The patch extract the clean target into a different Makefile, >

Re: [Xen-devel] [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 2:44 PM, Paolo Bonzini wrote: On 04/03/20 14:12, Philippe Mathieu-Daudé wrote: hw/scsi/spapr_vscsi.c:69:29: error: field 'iu' with variable sized type 'union viosrp_iu' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]     union

Re: [Xen-devel] [PATCH V6] x86/altp2m: Hypercall to set altp2m view visibility

2020-03-04 Thread Alexandru Stefan ISAILA
On 04.03.2020 16:07, Jan Beulich wrote: > On 04.03.2020 14:57, Alexandru Stefan ISAILA wrote: >> Hi George, >> >> This is a kind reminder if you can take a look at this patch when you >> have the time. > > Are you perhaps not aware of the recent maintainer change on > xen/arch/x86/mm/? What you

Re: [Xen-devel] [PATCH] iommu: fix check for autotranslated hardware domain

2020-03-04 Thread Jan Beulich
On 04.03.2020 15:00, Roger Pau Monne wrote: > The current position of the check_hwdom_reqs is wrong, as there's a > is_iommu_enabled at the top of the function that will prevent getting > to the check on systems without an IOMMU, because the hardware domain > won't have the XEN_DOMCTL_CDF_iommu

Re: [Xen-devel] [PATCH V6] x86/altp2m: Hypercall to set altp2m view visibility

2020-03-04 Thread Jan Beulich
On 04.03.2020 14:57, Alexandru Stefan ISAILA wrote: > Hi George, > > This is a kind reminder if you can take a look at this patch when you > have the time. Are you perhaps not aware of the recent maintainer change on xen/arch/x86/mm/? What you need to go hunt is ... > On 03.03.2020 14:23,

Re: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-03-04 Thread Julien Grall
On 03/03/2020 13:25, Jan Beulich wrote: On 04.02.2020 14:06, Julien Grall wrote: From: Julien Grall Unlike shadow_enable(), hap_enable() can only be called once during domain creation and with the mode equal to mode equal to PG_external | PG_translate | PG_refcounts. If it were called

[Xen-devel] [PATCH] iommu: fix check for autotranslated hardware domain

2020-03-04 Thread Roger Pau Monne
The current position of the check_hwdom_reqs is wrong, as there's a is_iommu_enabled at the top of the function that will prevent getting to the check on systems without an IOMMU, because the hardware domain won't have the XEN_DOMCTL_CDF_iommu flag set. Move the position of the check so it's done

Re: [Xen-devel] [PATCH V6] x86/altp2m: Hypercall to set altp2m view visibility

2020-03-04 Thread Alexandru Stefan ISAILA
Hi George, This is a kind reminder if you can take a look at this patch when you have the time. Thanks, Alex On 03.03.2020 14:23, Alexandru Stefan ISAILA wrote: > At this moment a guest can call vmfunc to change the altp2m view. This > should be limited in order to avoid any unwanted view

Re: [Xen-devel] [PATCH v3 2/2] xenbus: req->err should be updated before req->state

2020-03-04 Thread Julien Grall
Hi, On 03/03/2020 22:14, Dongli Zhang wrote: This patch adds the barrier to guarantee that req->err is always updated before req->state. Otherwise, read_reply() would not return ERR_PTR(req->err) but req->body, when process_writes()->xb_write() is failed. Signed-off-by: Dongli Zhang

Re: [Xen-devel] [PATCH v3 1/2] xenbus: req->body should be updated before req->state

2020-03-04 Thread Julien Grall
Hi, On 03/03/2020 22:14, Dongli Zhang wrote: The req->body should be updated before req->state is updated and the order should be guaranteed by a barrier. Otherwise, read_reply() might return req->body = NULL. Below is sample callstack when the issue is reproduced on purpose by reordering the

Re: [Xen-devel] [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Paolo Bonzini
On 04/03/20 14:12, Philippe Mathieu-Daudé wrote: > > hw/scsi/spapr_vscsi.c:69:29: error: field 'iu' with variable sized type > 'union viosrp_iu' not at the end of a struct or class is a GNU extension > [-Werror,-Wgnu-variable-sized-type-not-at-end] >     union viosrp_iu iu; >  

Re: [Xen-devel] [PATCH v3 5/6] xen/rcu: add assertions to debug build

2020-03-04 Thread Julien Grall
Hi, On 04/03/2020 06:32, Juergen Gross wrote: diff --git a/xen/include/xen/rcupdate.h b/xen/include/xen/rcupdate.h index 31c8b86d13..9f6d420898 100644 --- a/xen/include/xen/rcupdate.h +++ b/xen/include/xen/rcupdate.h @@ -34,10 +34,40 @@ #include #include #include -#include +#include

Re: [Xen-devel] [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp

2020-03-04 Thread Vladimir Sementsov-Ogievskiy
23.02.2020 11:55, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in include/qapi/error.h) Usage example: spatch --sp-file

[Xen-devel] [PATCH v2 0/4] Introducing QMP query-netdevs command

2020-03-04 Thread Alexey Kirillov
This patch series introduces a new QMP command "query-netdevs" to get information about currently attached network devices. Also, since the "info_str" field of "NetClientState" is now deprecated, it has been completely removed. The HMP command "info network" now also uses the new QMP command

[Xen-devel] [PATCH v2 3/4] hmp: Use QMP query-netdevs in hmp_info_network

2020-03-04 Thread Alexey Kirillov
Replace legacy field info_str of NetClientState with result of QMP command query-netdevs. Signed-off-by: Alexey Kirillov --- include/net/net.h | 3 +- net/clients.h | 1 + net/hub.c | 4 +- net/hub.h | 2 +- net/net.c | 175

[Xen-devel] [PATCH v2 4/4] net: Remove field info_str of NetClientState

2020-03-04 Thread Alexey Kirillov
Completely remove the info_str field of struct NetClientState because it is no longer required due to the addition of the QMP query-netdevs command. Signed-off-by: Alexey Kirillov --- hw/net/allwinner_emac.c | 2 +- hw/net/dp8393x.c| 2 +- hw/net/e1000.c | 4 ++--

[Xen-devel] [PATCH v2 1/4] qapi: net: Add query-netdevs command

2020-03-04 Thread Alexey Kirillov
Add a qmp command that provides information about currently attached network devices and their configuration. Signed-off-by: Alexey Kirillov --- include/net/net.h | 1 + net/hub.c | 8 +++ net/l2tpv3.c | 19 +++ net/net.c | 91 +

[Xen-devel] [PATCH v2 2/4] tests: Add tests for query-netdevs command

2020-03-04 Thread Alexey Kirillov
Signed-off-by: Alexey Kirillov --- tests/qtest/Makefile.include | 2 + tests/qtest/test-query-netdevs.c | 120 +++ 2 files changed, 122 insertions(+) create mode 100644 tests/qtest/test-query-netdevs.c diff --git a/tests/qtest/Makefile.include

Re: [Xen-devel] [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 1:51 AM, Philippe Mathieu-Daudé wrote: Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to

Re: [Xen-devel] [PATCH v6 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-03-04 Thread Jan Beulich
On 04.03.2020 13:06, Jürgen Groß wrote: > On 04.03.20 11:49, Jan Beulich wrote: >> On 26.02.2020 13:47, Juergen Gross wrote: >>> +config_data.o: config.gz >> >> Is this really needed? You need to add config.gz as a >> dependency ... >> >>> +config_data.S: $(XEN_ROOT)/xen/tools/binfile >> >> ...

[Xen-devel] [xen-unstable-smoke test] 148059: tolerable all pass - PUSHED

2020-03-04 Thread osstest service owner
flight 148059 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148059/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH v6 04/12] xen: add basic hypervisor filesystem support

2020-03-04 Thread Jan Beulich
On 04.03.2020 13:00, Jürgen Groß wrote: > On 03.03.20 17:59, Jan Beulich wrote: >> On 26.02.2020 13:46, Juergen Gross wrote: >>> --- /dev/null >>> +++ b/xen/common/hypfs.c >>> @@ -0,0 +1,349 @@ >>> +/** >>> + * >>> + *

Re: [Xen-devel] [PATCH v6 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-03-04 Thread Jürgen Groß
On 04.03.20 11:49, Jan Beulich wrote: On 26.02.2020 13:47, Juergen Gross wrote: Add the /buildinfo/config entry to the hypervisor filesystem. This entry contains the .config file used to build the hypervisor. Signed-off-by: Juergen Gross --- V3: - store data in gzip format - use binfile

Re: [Xen-devel] [PATCH v6 04/12] xen: add basic hypervisor filesystem support

2020-03-04 Thread Jürgen Groß
On 03.03.20 17:59, Jan Beulich wrote: On 26.02.2020 13:46, Juergen Gross wrote: --- /dev/null +++ b/xen/common/hypfs.c @@ -0,0 +1,349 @@ +/** + * + * hypfs.c + * + * Simple sysfs-like file system for the hypervisor. +

Re: [Xen-devel] [PATCH v6 12/12] xen: remove XEN_SYSCTL_set_parameter support

2020-03-04 Thread Jan Beulich
On 26.02.2020 13:47, Juergen Gross wrote: > The functionality of XEN_SYSCTL_set_parameter is available via hypfs > now, so it can be removed. > > This allows to remove the kernel_param structure for runtime parameters > by putting the now only used structure element into the hypfs node >

Re: [Xen-devel] [PATCH v6 09/12] xen: add runtime parameter access support to hypfs

2020-03-04 Thread Jan Beulich
On 26.02.2020 13:47, Juergen Gross wrote: > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -70,6 +70,30 @@ integer_param("ple_window", ple_window); > static bool __read_mostly opt_ept_pml = true; > static s8 __read_mostly opt_ept_ad = -1; > int8_t __read_mostly

Re: [Xen-devel] [PATCH 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-04 Thread Paolo Bonzini
On 04/03/20 01:51, Philippe Mathieu-Daudé wrote: > This is a tree-wide cleanup inspired by a Linux kernel commit > (from Gustavo A. R. Silva). > > --v-- description start --v-- > > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the

Re: [Xen-devel] [PATCH v2] x86/dom0: improve PVH initrd and metadata placement

2020-03-04 Thread Roger Pau Monné
On Tue, Mar 03, 2020 at 06:47:35PM +, Andrew Cooper wrote: > On 03/03/2020 11:52, Roger Pau Monne wrote: > > Don't assume there's going to be enough space at the tail of the > > loaded kernel and instead try to find a suitable memory area where the > > initrd and metadata can be loaded. > > >

Re: [Xen-devel] [PATCH v6 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-03-04 Thread Jan Beulich
On 26.02.2020 13:47, Juergen Gross wrote: > Add the /buildinfo/config entry to the hypervisor filesystem. This > entry contains the .config file used to build the hypervisor. > > Signed-off-by: Juergen Gross > --- > V3: > - store data in gzip format > - use binfile mechanism to create data file

Re: [Xen-devel] [PATCH v2] xen/sched: fix cpu offlining with core scheduling

2020-03-04 Thread Jürgen Groß
On 04.03.20 10:53, Jan Beulich wrote: On 03.03.2020 18:39, Juergen Gross wrote: --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -2299,6 +2299,10 @@ void sched_context_switched(struct vcpu *vprev, struct vcpu *vnext) rcu_read_unlock(_res_rculock); } +/* + * Switch to

[Xen-devel] [xen-unstable-coverity test] 148055: all pass - PUSHED

2020-03-04 Thread osstest service owner
flight 148055 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/148055/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 0c35d446047aa632ec3a03221814ad5a6a37af97 baseline version: xen

Re: [Xen-devel] [PATCH v3] x86/dom0: improve PVH initrd and metadata placement

2020-03-04 Thread Roger Pau Monné
On Wed, Mar 04, 2020 at 11:31:23AM +0100, Jan Beulich wrote: > On 04.03.2020 11:25, Roger Pau Monne wrote: > > Don't assume there's going to be enough space at the tail of the > > loaded kernel and instead try to find a suitable memory area where the > > initrd and metadata can be loaded. > > > >

Re: [Xen-devel] [PATCH v3] x86/dom0: improve PVH initrd and metadata placement

2020-03-04 Thread Jan Beulich
On 04.03.2020 11:25, Roger Pau Monne wrote: > Don't assume there's going to be enough space at the tail of the > loaded kernel and instead try to find a suitable memory area where the > initrd and metadata can be loaded. > > Reported-by: Andrew Cooper > Signed-off-by: Roger Pau Monné

Re: [Xen-devel] [PATCH] libxenstat: fixed Makefile for building python-bindings

2020-03-04 Thread Wei Liu
Hi Jonas Thanks for this patch. On Mon, Mar 02, 2020 at 06:53:38PM +0100, jonas.li...@fem.tu-ilmenau.de wrote: > Fixes the libxenstat Makefile to determine the correct paths > of python includes when building python-bindings. > Also replaces the -lxenstat linking to correct object files > and

[Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-credit2

2020-03-04 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-credit2 testid guest-start Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git

Re: [Xen-devel] [XEN PATCH v4] libxl: wait for console path before firing console_available

2020-03-04 Thread Wei Liu
On Tue, Mar 03, 2020 at 03:51:04PM +, Anthony PERARD wrote: > On Tue, Mar 03, 2020 at 02:28:20PM +0100, Paweł Marczewski wrote: > > If the path doesn't become available after LIBXL_INIT_TIMEOUT > > seconds, fail the domain creation. > > > > If we skip the bootloader, the TTY path will be set

[Xen-devel] [PATCH v3] x86/dom0: improve PVH initrd and metadata placement

2020-03-04 Thread Roger Pau Monne
Don't assume there's going to be enough space at the tail of the loaded kernel and instead try to find a suitable memory area where the initrd and metadata can be loaded. Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v2: - Simplify checks since the kernel used

Re: [Xen-devel] [PATCH] x86/cpuid: Untangle Invariant TSC handling

2020-03-04 Thread Jan Beulich
On 03.03.2020 19:24, Andrew Cooper wrote: > ITSC being visible to the guest is currently implicit with the toolstack > unconditionally asking for it, and Xen clipping it based on the vTSC and/or > XEN_DOMCTL_disable_migrate settings. > > This is problematic for several reasons. > > First, the

Re: [Xen-devel] [PATCH v2] x86/dom0: improve PVH initrd and metadata placement

2020-03-04 Thread Roger Pau Monné
On Wed, Mar 04, 2020 at 11:00:18AM +0100, Jan Beulich wrote: > On 04.03.2020 10:53, Roger Pau Monné wrote: > > On Tue, Mar 03, 2020 at 04:40:36PM +0100, Jan Beulich wrote: > >> On 03.03.2020 12:52, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/hvm/dom0_build.c > >>> +++

Re: [Xen-devel] [PATCH v2] x86/dom0: improve PVH initrd and metadata placement

2020-03-04 Thread Jan Beulich
On 04.03.2020 10:53, Roger Pau Monné wrote: > On Tue, Mar 03, 2020 at 04:40:36PM +0100, Jan Beulich wrote: >> On 03.03.2020 12:52, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/dom0_build.c >>> +++ b/xen/arch/x86/hvm/dom0_build.c >>> @@ -490,6 +490,45 @@ static int __init

Re: [Xen-devel] [PATCH v2] x86/dom0: improve PVH initrd and metadata placement

2020-03-04 Thread Roger Pau Monné
On Tue, Mar 03, 2020 at 04:40:36PM +0100, Jan Beulich wrote: > On 03.03.2020 12:52, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/dom0_build.c > > +++ b/xen/arch/x86/hvm/dom0_build.c > > @@ -490,6 +490,45 @@ static int __init pvh_populate_p2m(struct domain *d) > > #undef MB1_PAGES > > } > >

  1   2   >