[linux-linus test] 162340: regressions - FAIL

2021-06-02 Thread osstest service owner
flight 162340 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/162340/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332

RE: [PATCH 07/10] xen/arm: intruduce alloc_domstatic_pages

2021-06-02 Thread Penny Zheng
Hi Jan > -Original Message- > From: Jan Beulich > Sent: Friday, May 21, 2021 3:09 PM > To: Penny Zheng > Cc: Bertrand Marquis ; Wei Chen > ; nd ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org; jul...@xen.org > Subject: Re: [PATCH 07/10] xen/arm: intruduce

[ovmf test] 162341: all pass - PUSHED

2021-06-02 Thread osstest service owner
flight 162341 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/162341/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 75e9154f818a58ffc3a28db9f8c97279e723f02d baseline version: ovmf

[qemu-mainline test] 162339: regressions - FAIL

2021-06-02 Thread osstest service owner
flight 162339 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/162339/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631

Re: [PATCH 20/30] nullb: use blk_mq_alloc_disk

2021-06-02 Thread Chaitanya Kulkarni
On 6/1/21 23:56, Christoph Hellwig wrote: > Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and > request_queue allocation. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/null_blk/main.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff

Re: [PATCH 18/30] loop: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Chaitanya Kulkarni
On 6/1/21 23:56, Christoph Hellwig wrote: > Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and > request_queue allocation. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 15/30] blk-mq: remove blk_mq_init_sq_queue

2021-06-02 Thread Chaitanya Kulkarni
On 6/1/21 23:55, Christoph Hellwig wrote: > All users are gone now. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 03/30] blk-mq: add the blk_mq_alloc_disk APIs

2021-06-02 Thread Chaitanya Kulkarni
On 6/1/21 23:54, Christoph Hellwig wrote: > Add a new API to allocate a gendisk including the request_queue for use > with blk-mq based drivers. This is to avoid boilerplate code in drivers. > > Signed-off-by: Christoph Hellwig This would be a nice API to get rid of the couple initialization

[PATCH v7 2/2] xen: Add files needed for minimal riscv build

2021-06-02 Thread Connor Davis
Add arch-specific makefiles and configs needed to build for riscv. Also add a minimal head.S that is a simple infinite loop. head.o can be built with $ make XEN_TARGET_ARCH=riscv64 SUBSYSTEMS=xen -C xen tiny64_defconfig $ make XEN_TARGET_ARCH=riscv64 SUBSYSTEMS=xen -C xen TARGET=riscv64/head.o

[PATCH v7 1/2] xen/char: Default HAS_NS16550 to y only for X86 and ARM

2021-06-02 Thread Connor Davis
Defaulting to yes only for X86 and ARM reduces the requirements for a minimal build when porting new architectures. Signed-off-by: Connor Davis Acked-by: Jan Beulich --- xen/drivers/char/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/char/Kconfig

[PATCH v7 0/2] Minimal build for RISCV

2021-06-02 Thread Connor Davis
Hi all, This series introduces a minimal build for RISCV. It is based on Bobby's previous work from last year[0] rebased onto current Xen. This series provides the patches necessary to get a minimal build working. The build is "minimal" in the sense that it only supports building

Re: [PATCH v5 0/2] Minimal build for RISCV

2021-06-02 Thread Connor Davis
Sigh.. lets try this again with the version numbers in sync On 6/2/21 5:20 PM, Connor Davis wrote: Hi all, This series introduces a minimal build for RISCV. It is based on Bobby's previous work from last year[0] rebased onto current Xen. This series provides the patches necessary to get a

[PATCH v6 2/2] xen: Add files needed for minimal riscv build

2021-06-02 Thread Connor Davis
Add arch-specific makefiles and configs needed to build for riscv. Also add a minimal head.S that is a simple infinite loop. head.o can be built with $ make XEN_TARGET_ARCH=riscv64 SUBSYSTEMS=xen -C xen tiny64_defconfig $ make XEN_TARGET_ARCH=riscv64 SUBSYSTEMS=xen -C xen TARGET=riscv64/head.o

[PATCH v6 1/2] xen/char: Default HAS_NS16550 to y only for X86 and ARM

2021-06-02 Thread Connor Davis
Defaulting to yes only for X86 and ARM reduces the requirements for a minimal build when porting new architectures. Signed-off-by: Connor Davis Acked-by: Jan Beulich --- xen/drivers/char/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/char/Kconfig

[PATCH v5 0/2] Minimal build for RISCV

2021-06-02 Thread Connor Davis
Hi all, This series introduces a minimal build for RISCV. It is based on Bobby's previous work from last year[0] rebased onto current Xen. This series provides the patches necessary to get a minimal build working. The build is "minimal" in the sense that it only supports building

Re: [PATCH v5 1/2] xen/char: Default HAS_NS16550 to y only for X86 and ARM

2021-06-02 Thread Connor Davis
On 6/2/21 9:52 AM, Jan Beulich wrote: On 02.06.2021 17:08, Connor Davis wrote: Defaulting to yes only for X86 and ARM reduces the requirements for a minimal build when porting new architectures. Signed-off-by: Connor Davis Please can you accumulate tags you've already got into

[xen-unstable test] 162337: tolerable FAIL

2021-06-02 Thread osstest service owner
flight 162337 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/162337/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 162330 pass in 162337

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2021-06-02 Thread Anchal Agarwal
On Tue, Jun 01, 2021 at 10:18:36AM -0400, Boris Ostrovsky wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 5/28/21 5:50 PM, Anchal Agarwal wrote: > >

[ovmf test] 162338: all pass - PUSHED

2021-06-02 Thread osstest service owner
flight 162338 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/162338/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1f515342d8d83ef0fff0c3f4ac67232dd8c97565 baseline version: ovmf

[linux-linus test] 162333: regressions - FAIL

2021-06-02 Thread osstest service owner
flight 162333 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/162333/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332

Re: [RFC PATCH V3 09/11] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM

2021-06-02 Thread Boris Ostrovsky
On 6/2/21 11:01 AM, Tianyu Lan wrote: > Hi Boris: > Thanks for your review. > > On 6/2/2021 9:16 AM, Boris Ostrovsky wrote: >> >> On 5/30/21 11:06 AM, Tianyu Lan wrote: >>> @@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void) >>>   EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late); >>>    

Re: [PATCH v5 1/2] xen/char: Default HAS_NS16550 to y only for X86 and ARM

2021-06-02 Thread Jan Beulich
On 02.06.2021 17:08, Connor Davis wrote: > Defaulting to yes only for X86 and ARM reduces the requirements > for a minimal build when porting new architectures. > > Signed-off-by: Connor Davis Please can you accumulate tags you've already got into re-submissions, so the status of patches is

Re: [PATCH v2 0/6] tools/libs: add missing support of linear p2m_list, cleanup

2021-06-02 Thread Juergen Gross
On 25.05.21 09:32, Juergen Gross wrote: On 12.05.21 08:58, Juergen Gross wrote: Ping? Now each patch has an Ack by Wei. Could the series be either applied or get more comments, please? And another PING. Do I need to setup a cron job pinging each day to get a reaction? Juergen Juergen

Re: [PATCH v20210602 02/38] xl: fix description of migrate --debug

2021-06-02 Thread Juergen Gross
On 02.06.21 14:32, Olaf Hering wrote: xl migrate --debug used to track every pfn in every batch of pages. But these times are gone. The code in xc_domain_save is the consumer of this knob, but it considers it only for the remus and colo case. Adjust the help text to tell what --debug does

Re: [PATCH v20210601 07/38] tools: unify type checking for data pfns in migration stream

2021-06-02 Thread Juergen Gross
On 02.06.21 13:21, Olaf Hering wrote: Am Wed, 2 Jun 2021 08:59:13 +0200 schrieb Juergen Gross : What about XEN_DOMCTL_PFINFO_XALLOC? Is this case impossible here, or are you changing behavior? I think XEN_DOMCTL_PFINFO_XALLOC is a type that does not exist in practice. Oh, indeed. It was

Re: [PATCH v20210601 05/38] tools: add xc_is_known_page_type to libxenctrl

2021-06-02 Thread Juergen Gross
On 02.06.21 13:10, Olaf Hering wrote: Am Wed, 2 Jun 2021 08:51:45 +0200 schrieb Juergen Gross : I think you should not imply the planned use case here. It would be better to use "switch (type & XEN_DOMCTL_PFINFO_LTAB_MASK)". I'm on the edge regarding putting the new function into

Re: [PATCH v20210601 00/38] leftover from 2020

2021-06-02 Thread Juergen Gross
On 02.06.21 14:07, Olaf Hering wrote: Am Wed, 2 Jun 2021 09:00:49 +0200 schrieb Juergen Gross : IMO this will make it more probable to get at least parts committed. It depends all on patch #3, so further split can not be done anymore at this point. I don't see the dependency e.g. in patch

Re: [PATCH v20210601 02/38] xl: fix description of migrate --debug

2021-06-02 Thread Juergen Gross
On 02.06.21 12:43, Olaf Hering wrote: Am Wed, 2 Jun 2021 08:09:00 +0200 schrieb Juergen Gross : -if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN ) +if ( ctx->save.debug ) This is no documentation change IMO. You should either mention this modification in the commit

Re: [PATCH v20210601 24/38] tools/guest: restore: split record processing

2021-06-02 Thread Juergen Gross
On 01.06.21 18:11, Olaf Hering wrote: handle_page_data must be able to read directly into mapped guest memory. This will avoid unneccesary memcpy calls for data which can be consumed verbatim. Rearrange the code to allow decisions based on the incoming record. This change is preparation for

Re: [PATCH v20210601 09/38] tools/guest: prepare to allocate arrays once

2021-06-02 Thread Juergen Gross
On 02.06.21 14:03, Olaf Hering wrote: Am Wed, 2 Jun 2021 09:29:08 +0200 schrieb Juergen Gross : +ctx->restore.m = malloc(sizeof(*ctx->restore.m)); +if ( !ctx->restore.m ) { ... this case might trigger without the full series applied, due to allocating zero bytes (same for the save

Re: [PATCH v20210601 04/38] tools: add readv_exact to libxenctrl

2021-06-02 Thread Juergen Gross
On 02.06.21 12:57, Olaf Hering wrote: Am Wed, 2 Jun 2021 08:30:08 +0200 schrieb Juergen Gross : On 01.06.21 18:10, Olaf Hering wrote: +int readv_exact(int fd, const struct iovec *iov, int iovcnt) +if ( len <= 0 ) +{ +rc = -1; Is EOF really an error? I think

[PATCH v5 2/2] xen: Add files needed for minimal riscv build

2021-06-02 Thread Connor Davis
Add arch-specific makefiles and configs needed to build for riscv. Also add a minimal head.S that is a simple infinite loop. head.o can be built with $ make XEN_TARGET_ARCH=riscv64 SUBSYSTEMS=xen -C xen tiny64_defconfig $ make XEN_TARGET_ARCH=riscv64 SUBSYSTEMS=xen -C xen TARGET=riscv64/head.o

[PATCH v5 1/2] xen/char: Default HAS_NS16550 to y only for X86 and ARM

2021-06-02 Thread Connor Davis
Defaulting to yes only for X86 and ARM reduces the requirements for a minimal build when porting new architectures. Signed-off-by: Connor Davis --- xen/drivers/char/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index

[PATCH v5 0/2] Minimal build for RISCV

2021-06-02 Thread Connor Davis
Hi all, This series introduces a minimal build for RISCV. It is based on Bobby's previous work from last year[0] rebased onto current Xen. This series provides the patches necessary to get a minimal build working. The build is "minimal" in the sense that it only supports building

Re: [RFC PATCH V3 09/11] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM

2021-06-02 Thread Tianyu Lan
Hi Boris: Thanks for your review. On 6/2/2021 9:16 AM, Boris Ostrovsky wrote: On 5/30/21 11:06 AM, Tianyu Lan wrote: @@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void) EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late); IOMMU_INIT_FINISH(2, - NULL, +

[PATCH] x86emul: pad blob-execution "okay" messages

2021-06-02 Thread Jan Beulich
We already do so in the native execution case, and a few descriptions (I did notice this with SHA ones) are short enough for the output to look slightly odd. Signed-off-by: Jan Beulich --- Many descriptions are longer than 37 characters, so I wonder whether we wouldn't want to bump the padding

[PATCH] x86emul: avoid using _PRE_EFLAGS() in a few cases

2021-06-02 Thread Jan Beulich
The macro expanding to quite a few insns, replace its use by simply clearing the status flags when the to be executed insn doesn't depend on their initial state, in cases where this is easily possible. (There are more cases where the uses are hidden inside macros, and where some of the users of

[qemu-mainline test] 162331: regressions - FAIL

2021-06-02 Thread osstest service owner
flight 162331 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/162331/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631

[ovmf test] 162334: all pass - PUSHED

2021-06-02 Thread osstest service owner
flight 162334 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/162334/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b233eb1849ac01bdd5b24ea84460a2e481a4c5a9 baseline version: ovmf

[PATCH v20210602 02/38] xl: fix description of migrate --debug

2021-06-02 Thread Olaf Hering
xl migrate --debug used to track every pfn in every batch of pages. But these times are gone. The code in xc_domain_save is the consumer of this knob, but it considers it only for the remus and colo case. Adjust the help text to tell what --debug does today: Nothing. Signed-off-by: Olaf Hering

Re: [PATCH 27/30] scm_blk: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Niklas Schnelle
On Wed, 2021-06-02 at 09:53 +0300, Christoph Hellwig wrote: > Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and > request_queue allocation. > > Signed-off-by: Christoph Hellwig > --- > drivers/s390/block/scm_blk.c | 21 ++--- > 1 file changed, 6

Re: [PATCH v20210601 00/38] leftover from 2020

2021-06-02 Thread Olaf Hering
Am Wed, 2 Jun 2021 09:00:49 +0200 schrieb Juergen Gross : > IMO this will make it more probable to get at least parts committed. It depends all on patch #3, so further split can not be done anymore at this point. Olaf pgpx07YWbOPyG.pgp Description: Digitale Signatur von OpenPGP

Re: [PATCH v20210601 09/38] tools/guest: prepare to allocate arrays once

2021-06-02 Thread Olaf Hering
Am Wed, 2 Jun 2021 09:29:08 +0200 schrieb Juergen Gross : > > +ctx->restore.m = malloc(sizeof(*ctx->restore.m)); > > +if ( !ctx->restore.m ) { > > ... this case might trigger without the full series applied, due to > allocating zero bytes (same for the save side below). Such bisection

Re: [PATCH v2] firmware/shim: UNSUPPORTED=n

2021-06-02 Thread Ian Jackson
Dario Faggioli writes ("Re: [PATCH v2] firmware/shim: UNSUPPORTED=n"): > I can try to put something together, but I don't currently have an > OSSTest development environment up and running any longer, so it may > take a couple of iterations... (bit late with this but) You could use your account

Re: [PATCH v20210601 07/38] tools: unify type checking for data pfns in migration stream

2021-06-02 Thread Olaf Hering
Am Wed, 2 Jun 2021 08:59:13 +0200 schrieb Juergen Gross : > What about XEN_DOMCTL_PFINFO_XALLOC? Is this case impossible here, or > are you changing behavior? I think XEN_DOMCTL_PFINFO_XALLOC is a type that does not exist in practice. So, no change in behavior. Olaf pgp8VqRW1f2ga.pgp

Re: [Xen-devel] [PATCH RFC v2 00/23] Design document and performance evaluation for post-copy live migration

2021-06-02 Thread Olaf Hering
Am Sun, 17 Jun 2018 03:18:11 -0700 schrieb Joshua Otto : > A little over a year ago, I posted a patch series implementing support for > post-copy live migration via xenpaging [1]. That that went anywhere, or was this a wasted effort? Olaf pgpzG1SmRuO0w.pgp Description: Digitale Signatur von

Re: [PATCH v20210601 05/38] tools: add xc_is_known_page_type to libxenctrl

2021-06-02 Thread Olaf Hering
Am Wed, 2 Jun 2021 08:51:45 +0200 schrieb Juergen Gross : > I think you should not imply the planned use case here. It would be > better to use "switch (type & XEN_DOMCTL_PFINFO_LTAB_MASK)". > > I'm on the edge regarding putting the new function into xc_private.h. > In the end your use case is

Re: [PATCH v20210601 04/38] tools: add readv_exact to libxenctrl

2021-06-02 Thread Olaf Hering
Am Wed, 2 Jun 2021 12:57:10 +0200 schrieb Olaf Hering : > > This will stop the loop, even if idx hasn't reached iovcnt. > > Yes, it will trigger yet another readv(). > > The "while" might be a leftover from a variant which used repeated read_exact > to finish the function. It should become a

Re: [PATCH v20210601 04/38] tools: add readv_exact to libxenctrl

2021-06-02 Thread Olaf Hering
Am Wed, 2 Jun 2021 08:30:08 +0200 schrieb Juergen Gross : > On 01.06.21 18:10, Olaf Hering wrote: > > +int readv_exact(int fd, const struct iovec *iov, int iovcnt) > > +if ( len <= 0 ) > > +{ > > +rc = -1; > Is EOF really an error? I think yes, that's what "exact"

[ANNOUNCE] Call for agenda items for 3 June Community Call @ 1500 UTC

2021-06-02 Thread George Dunlap
Hi all, I know we just had the XenSummit last week, but it was suggested there that the primary agenda item be making sure that all of the responsibilities for my current role have been delegated appropriately, in preparation for my upcoming parental leave (which will start 26 July and go

Re: [PATCH v20210601 02/38] xl: fix description of migrate --debug

2021-06-02 Thread Olaf Hering
Am Wed, 2 Jun 2021 08:09:00 +0200 schrieb Juergen Gross : > > -if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN ) > > +if ( ctx->save.debug ) > This is no documentation change IMO. You should either mention this > modification in the commit message, or put it into a separate

[xen-unstable test] 162330: tolerable FAIL - PUSHED

2021-06-02 Thread osstest service owner
flight 162330 xen-unstable real [real] flight 162336 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/162330/ http://logs.test-lab.xenproject.org/osstest/logs/162336/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

RE: [PATCH 01/10] xen/arm: introduce domain on Static Allocation

2021-06-02 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Thursday, May 20, 2021 4:51 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org > Cc: Bertrand Marquis ; Wei Chen > ; nd > Subject: Re: [PATCH 01/10] xen/arm: introduce domain on Static Allocation >

[xen-unstable-coverity test] 162335: all pass - PUSHED

2021-06-02 Thread osstest service owner
flight 162335 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/162335/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 5268b2dcf7e5342c8a51ceb4bed3e7740c69f5c1 baseline version: xen

Re: [PATCH 3/3] x86/ept: force WB cache attributes for grant and foreign maps

2021-06-02 Thread Roger Pau Monné
On Mon, May 31, 2021 at 09:21:25AM +0200, Jan Beulich wrote: > On 28.05.2021 19:39, Roger Pau Monne wrote: > > --- a/xen/arch/x86/mm/p2m-ept.c > > +++ b/xen/arch/x86/mm/p2m-ept.c > > @@ -487,11 +487,12 @@ static int ept_invalidate_emt_range(struct p2m_domain > > *p2m, > > } > > > > int

Re: [edk2-devel] [PATCH 00/43] OvmfPkg: remove Xen support from OvmfPkg*.dsc, in favor of OvmfXen.dsc

2021-06-02 Thread Laszlo Ersek
Anthony, Julien, (or anyone else subscribed to xen-devel -- CC'd now), On 05/26/21 22:14, Laszlo Ersek wrote: > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Repo: https://pagure.io/lersek/edk2.git > Branch: xen_split_bz_2122 can you please build the OvmfXen platform on

Re: [XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype

2021-06-02 Thread Jan Beulich
On 01.06.2021 17:41, Anthony PERARD wrote: > Commit cf8c4d3d13b8 made some preparation to have one day > variable-length-array argument, but didn't declare the array in the > function prototype the same way as in the function definition. And now > GCC 11 complains about it. > > Fixes:

[libvirt test] 162332: regressions - FAIL

2021-06-02 Thread osstest service owner
flight 162332 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/162332/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v20210601 23/38] tools/guest: restore: move pfns array in populate_pfns

2021-06-02 Thread Juergen Gross
On 01.06.21 18:11, Olaf Hering wrote: Remove allocation from hotpath, move populate_pfns' pfns array into preallocated space. Use some prefix to avoid conflict with an array used in handle_page_data. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen

Re: [PATCH v20210601 22/38] tools/guest: restore: move mfns array in populate_pfns

2021-06-02 Thread Juergen Gross
On 01.06.21 18:11, Olaf Hering wrote: Remove allocation from hotpath, move populate_pfns mfns array into preallocated space. Use some prefix to avoid conflict with an array used in handle_page_data. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen

Re: [PATCH v20210601 21/38] tools/guest: restore: move map_errs array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:11, Olaf Hering wrote: Remove allocation from hotpath, move map_errs array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital

Re: [PATCH v20210601 20/38] tools/guest: restore: move mfns array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:11, Olaf Hering wrote: Remove allocation from hotpath, move mfns array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital

Re: [PATCH v20210601 19/38] tools/guest: restore: move types array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Remove allocation from hotpath, move types array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital

Re: [PATCH v20210601 18/38] tools/guest: restore: move pfns array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Remove allocation from hotpath, move pfns array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital

Re: [PATCH 23/30] rnbd: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Jinpu Wang
On Wed, Jun 2, 2021 at 8:55 AM Christoph Hellwig wrote: > > Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and > request_queue allocation. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/rnbd/rnbd-clt.c | 35 --- > 1 file changed, 8

Re: [PATCH v20210601 17/38] tools/guest: save: move local_pages array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Remove allocation from hotpath, move local_pages array into preallocated space. Adjust the code to use the src page as is in case of HVM. In case of PV the page may need to be normalised, use an private memory area for this purpose. Signed-off-by: Olaf

Re: [PATCH v20210601 16/38] tools/guest: save: move guest_data array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Remove allocation from hotpath, move guest_data array into preallocated space. Because this was allocated with calloc: Adjust the loop to clear unused entries as needed. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen

Re: [PATCH v20210601 15/38] tools/guest: save: move rec_pfns array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Remove allocation from hotpath, move rec_pfns array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP

Re: [PATCH v20210601 14/38] tools/guest: save: move iov array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Remove allocation from hotpath, move iov array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital

Re: [PATCH v20210601 13/38] tools/guest: save: move errors array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Remove allocation from hotpath, move errors array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital

Re: [PATCH v20210601 12/38] tools/guest: save: move types array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Remove allocation from hotpath, move types array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital

Re: [PATCH v20210601 11/38] tools/guest: save: move mfns array

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Remove allocation from hotpath, move mfns array into preallocated space. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital

Re: [PATCH v20210601 10/38] tools/guest: save: move batch_pfns

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: The batch_pfns array is already allocated in advance. Move it into the preallocated area. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description:

Re: [PATCH v20210601 09/38] tools/guest: prepare to allocate arrays once

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: The hotpath 'send_dirty_pages' is supposed to do just one thing: sending. The other end 'handle_page_data' is supposed to do just receiving. But instead both do other costly work like memory allocations and data moving. Do the allocations once, the array

Re: [PATCH v20210601 08/38] tools: show migration transfer rate in send_dirty_pages

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Show how fast domU pages are transferred in each iteration. The relevant data is how fast the pfns travel, not so much how much protocol overhead exists. So the reported MiB/sec is just for pfns. Signed-off-by: Olaf Hering ---

[PATCH 23/30] rnbd: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/rnbd/rnbd-clt.c | 35 --- 1 file changed, 8 insertions(+), 27 deletions(-) diff --git

[PATCH 19/30] nbd: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/nbd.c | 53 ++--- 1 file changed, 21 insertions(+), 32 deletions(-) diff --git a/drivers/block/nbd.c

[PATCH 14/30] gdrom: use blk_mq_alloc_disk

2021-06-02 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/cdrom/gdrom.c | 45 --- 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/drivers/cdrom/gdrom.c

[PATCH 28/30] amiflop: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/amiflop.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c

[PATCH 29/30] ataflop: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/ataflop.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c

[PATCH 15/30] blk-mq: remove blk_mq_init_sq_queue

2021-06-02 Thread Christoph Hellwig
All users are gone now. Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 22 -- include/linux/blk-mq.h | 4 2 files changed, 26 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 1e6036e6fd66..25e25177c2b1 100644 --- a/block/blk-mq.c +++

[PATCH 10/30] ps3disk: use blk_mq_alloc_disk

2021-06-02 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/ps3disk.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/drivers/block/ps3disk.c

[PATCH 22/30] rbd: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/rbd.c | 52 - 1 file changed, 18 insertions(+), 34 deletions(-) diff --git a/drivers/block/rbd.c

[PATCH 26/30] ubi: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/mtd/ubi/block.c | 68 ++--- 1 file changed, 29 insertions(+), 39 deletions(-) diff --git a/drivers/mtd/ubi/block.c

[PATCH 30/30] z2ram: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/z2ram.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index

[PATCH 16/30] aoe: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/aoe/aoeblk.c | 33 - drivers/block/aoe/aoedev.c | 3 +-- 2 files changed, 13 insertions(+), 23 deletions(-) diff

[PATCH 20/30] nullb: use blk_mq_alloc_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/null_blk/main.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/block/null_blk/main.c

[PATCH 25/30] xen-blkfront: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/xen-blkfront.c | 96 +++- 1 file changed, 39 insertions(+), 57 deletions(-) diff --git

[PATCH 13/30] sunvdc: use blk_mq_alloc_disk

2021-06-02 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/sunvdc.c | 47 -- 1 file changed, 13 insertions(+), 34 deletions(-) diff --git a/drivers/block/sunvdc.c

[PATCH 18/30] loop: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index

Re: [PATCH v20210601 07/38] tools: unify type checking for data pfns in migration stream

2021-06-02 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Introduce a helper which decides if a given pfn type has data for the migration stream. No change in behavior intended. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 17 tools/libs/saverestore/restore.c | 34

[PATCH 27/30] scm_blk: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/s390/block/scm_blk.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/s390/block/scm_blk.c

[PATCH 12/30] swim: use blk_mq_alloc_disk

2021-06-02 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/swim.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/block/swim.c b/drivers/block/swim.c

[PATCH 24/30] sx8: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/sx8.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c index

[PATCH 21/30] pd: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/paride/pd.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/block/paride/pd.c

[PATCH 09/30] mtd_blkdevs: use blk_mq_alloc_disk

2021-06-02 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/mtd/mtd_blkdevs.c | 48 ++- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c

[PATCH 11/30] swim3: use blk_mq_alloc_disk

2021-06-02 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/swim3.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c

[PATCH 17/30] floppy: use blk_mq_alloc_disk and blk_cleanup_disk

2021-06-02 Thread Christoph Hellwig
Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/floppy.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c

Re: [PATCH v20210601 00/38] leftover from 2020

2021-06-02 Thread Juergen Gross
On 02.06.21 08:54, Olaf Hering wrote: Am Wed, 2 Jun 2021 08:10:21 +0200 schrieb Juergen Gross : Would it be possible to split this into multiple independent patches/series? Sure, I can send each individual part that was already sent over and over again. IMO this will make it more probable

[PATCH 08/30] mspro: use blk_mq_alloc_disk

2021-06-02 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/memstick/core/mspro_block.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/memstick/core/mspro_block.c

  1   2   >