Re: [PATCH] x86: correct asm() constraints when dealing with immediate selector values

2021-09-09 Thread Jan Beulich
On 09.09.2021 21:31, Andrew Cooper wrote: > On 09/09/2021 15:56, Jan Beulich wrote: >> asm() constraints need to fit both the intended insn(s) which the >> respective operands are going to be used with as well as the actual kind >> of value specified. "m" (alone) together with a constant, however,

Re: [PATCH] mini-os: xenbus: support large messages

2021-09-09 Thread Juergen Gross
On 18.08.21 17:26, Juergen Gross wrote: Today the implementation of the xenbus protocol in Mini-OS will only allow to transfer the complete message to or from the ring page buffer. This is limiting the maximum message size to lower values as the xenbus protocol normally would allow. Change that

Re: [PATCH v5 05/10] xsm: apply coding style

2021-09-09 Thread Jan Beulich
On 10.09.2021 04:12, Daniel P. Smith wrote: > @@ -70,7 +73,7 @@ void __xsm_action_mismatch_detected(void); > #endif /* CONFIG_XSM */ > > static always_inline int xsm_default_action( > -xsm_default_t action, struct domain *src, struct domain *target) > + xsm_default_t action, struct doma

Re: [PATCH v5 03/10] xsm: remove remnants of xsm_memtype hook

2021-09-09 Thread Jan Beulich
On 10.09.2021 04:12, Daniel P. Smith wrote: > In c/s fcb8baddf00e the xsm_memtype hook was removed but some remnants were > left behind. This commit cleans up those remnants. > > Signed-off-by: Daniel P. Smith Acked-by: Jan Beulich

Re: [PATCH v5 01/10] xen: Implement xen/alternative-call.h for use in common code

2021-09-09 Thread Jan Beulich
On 10.09.2021 04:12, Daniel P. Smith wrote: > From: Andrew Cooper > > The alternative call infrastructure is x86-only for now, but the common iommu > code has a variant and more common code wants to use the infrastructure. > > Introduce CONFIG_ALTERNATIVE_CALL and a conditional implemetnation so

[PATCH v3 3/3] tools: disable building qemu-trad per default

2021-09-09 Thread Juergen Gross
Using qemu-traditional as device model is deprecated for some time now. So change the default for building it to "disable". This will affect ioemu-stubdom, too, as there is a direct dependency between the two. Today it is possible to use a PVH/HVM Linux-based stubdom as device model. Additionally

[PATCH v3 2/3] stubdom: disable building pv-grub

2021-09-09 Thread Juergen Gross
The stubdom based pv-grub is using a very outdated version of grub (0.97) and should not be used any longer. Mainline grub has support for PV guests for a long time now, so that should be used as a boot loader of a PV domain. So disable building pv-grub per default. In case someone really wants to

[PATCH v3 0/3] disable building of pv-grub and qemu-trad per default

2021-09-09 Thread Juergen Gross
This is a first step of deprecating pv-grub and qemu-trad including ioemu-stubdom. Switch the default to not building it. Changes in V3: - rename pv-grub32 make target Changes in V2: - new patch 3 - added CHANGELOG.md entry in patch 2 Juergen Gross (3): stubdom: fix build with disabled pv-grub

[PATCH v3 1/3] stubdom: fix build with disabled pv-grub

2021-09-09 Thread Juergen Gross
Today the build will fail if --disable-pv-grub as a parameter of configure, as the main Makefile will unconditionally try to build a 32-bit pv-grub stubdom. Fix that by introducing a pv-grub-if-enabled target in stubdom/Makefile taking care of this situation. Signed-off-by: Juergen Gross Reviewe

Re: [PATCH v2 1/3] stubdom: fix build with disabled pv-grub

2021-09-09 Thread Juergen Gross
On 09.09.21 18:08, Ian Jackson wrote: Juergen Gross writes ("Re: [PATCH v2 1/3] stubdom: fix build with disabled pv-grub"): On 09.09.21 15:23, Ian Jackson wrote: How about "pv-grub-maybe" ? Or something. What about "pv-grub-if-enabled"? Fine by me. And could that be done when committing

[ovmf test] 164913: all pass - PUSHED

2021-09-09 Thread osstest service owner
flight 164913 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164913/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d248516b3a190c5cb5d51164b5721ead9d24469a baseline version: ovmf a7cf2c5664b9605162b20

[xen-4.13-testing test] 164898: tolerable FAIL - PUSHED

2021-09-09 Thread osstest service owner
flight 164898 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/164898/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 163761 test-amd64-i386-xl-qemuu-win7-am

[PATCH] xen-blkback: Remove needless request_queue NULL pointer check

2021-09-09 Thread Xu Wang
The request_queue pointer returned from bdev_get_queue() shall never be NULL, so the null check is unnecessary, just remove it. Signed-off-by: Xu Wang --- drivers/block/xen-blkback/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/

[PATCH v2] xen-blkback: Remove needless request_queue NULL pointer check

2021-09-09 Thread Xu Wang
The request_queue pointer returned from bdev_get_queue() shall never be NULL, so the null check is unnecessary, just remove it. Signed-off-by: Xu Wang --- Changes since v2: - Add missing parenthesis. - Remove another null pointer check. --- drivers/block/xen-blkback/xenbus.c | 4 ++-- 1 file cha

Re: [OSSTEST PATCH 4/4] mfi-common: Drop Linux dom0 i386 tests for newer Linux branches

2021-09-09 Thread Juergen Gross
On 09.09.21 18:47, Ian Jackson wrote: This makes radical changes to the test ste for the linux-linus and linux-next branches. Mostly, tests are dropped but some 64-bit dom0 tests are added to replace them. Requested-by: Juergen Gross Signed-off-by: Ian Jackson Thanks! Reviewed-by: Juergen

Re: Enabling hypervisor agnosticism for VirtIO backends

2021-09-09 Thread AKASHI Takahiro
Hi Christopher, On Tue, Sep 07, 2021 at 11:09:34AM -0700, Christopher Clark wrote: > On Tue, Sep 7, 2021 at 4:55 AM AKASHI Takahiro > wrote: > > > Hi, > > > > I have not covered all your comments below yet. > > So just one comment: > > > > On Mon, Sep 06, 2021 at 05:57:43PM -0700, Christopher Cl

[PATCH v7 7/7] xen/arm: introduce allocate_static_memory

2021-09-09 Thread Penny Zheng
This commit introduces a new function allocate_static_memory to allocate static memory as guest RAM for domains on Static Allocation. It uses acquire_domstatic_pages to acquire pre-configured static memory for the domain, and uses guest_physmap_add_pages to set up the P2M table. These pre-defined

[PATCH v7 5/7] xen: re-define assign_pages and introduce a new function assign_page

2021-09-09 Thread Penny Zheng
In order to deal with the trouble of count-to-order conversion when page number is not in a power-of-two, this commit re-define assign_pages for nr pages and assign_page for original page with a single order. Backporting confusion could be helped by altering the order of assign_pages parameters, s

[PATCH v7 6/7] xen/arm: introduce acquire_staticmem_pages and acquire_domstatic_pages

2021-09-09 Thread Penny Zheng
New function acquire_staticmem_pages aims to acquire nr_mfns contiguous pages of static memory, starting at #smfn. And it is the equivalent of alloc_heap_pages for static memory. For each page, it shall check if the page is reserved(PGC_reserved) and free. It shall also do a set of necessary initi

[PATCH v7 4/7] xen/arm: static memory initialization

2021-09-09 Thread Penny Zheng
This patch introduces static memory initialization, during system boot-up. The new function init_staticmem_pages is responsible for static memory initialization. Helper free_staticmem_pages is the equivalent of free_heap_pages, to free nr_mfns pages of static memory. This commit also introduces

[PATCH v7 3/7] xen: introduce mark_page_free

2021-09-09 Thread Penny Zheng
This commit defines a new helper mark_page_free to extract common code, like following the same cache/TLB coherency policy, between free_heap_pages and the new function free_staticmem_pages, which will be introduced later. The PDX compression makes that conversion between the MFN and the page can

[PATCH v7 2/7] xen/arm: introduce domain on Static Allocation

2021-09-09 Thread Penny Zheng
Static Allocation refers to system or sub-system(domains) for which memory areas are pre-defined by configuration using physical address ranges. Those pre-defined memory, -- Static Memory, as parts of RAM reserved in the beginning, shall never go to heap allocator or boot allocator for any use. M

[PATCH v7 1/7] xen/arm: introduce new helper device_tree_get_meminfo

2021-09-09 Thread Penny Zheng
This commit creates a new helper device_tree_get_meminfo to iterate over a device tree property to get memory info, like "reg". Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- xen/arch/arm/bootfdt.c | 83 -- 1 file changed, 47 insertions(+)

[PATCH v7 0/7] Domain on Static Allocation

2021-09-09 Thread Penny Zheng
Static Allocation refers to system or sub-system(domains) for which memory areas are pre-defined by configuration using physical address ranges. Those pre-defined memory, -- Static Memory, as parts of RAM reserved in the beginning, shall never go to heap allocator or boot allocator for any use. M

Re: [Stratos-dev] Enabling hypervisor agnosticism for VirtIO backends

2021-09-09 Thread AKASHI Takahiro
On Mon, Sep 06, 2021 at 07:41:48PM -0700, Christopher Clark wrote: > On Sun, Sep 5, 2021 at 7:24 PM AKASHI Takahiro via Stratos-dev < > stratos-...@op-lists.linaro.org> wrote: > > > Alex, > > > > On Fri, Sep 03, 2021 at 10:28:06AM +0100, Alex Benn??e wrote: > > > > > > AKASHI Takahiro writes: > >

Re: [PATCH] xen-blkback: Remove needless request_queue NULL pointer check

2021-09-09 Thread Damien Le Moal
On 2021/09/10 11:32, Xu Wang wrote: > The request_queue pointer returned from bdev_get_queue() shall > never be NULL, so the null check is unnecessary, just remove it. > > Signed-off-by: Xu Wang > --- > drivers/block/xen-blkback/xenbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[xen-4.12-testing test] 164896: regressions - FAIL

2021-09-09 Thread osstest service owner
flight 164896 xen-4.12-testing real [real] flight 164928 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/164896/ http://logs.test-lab.xenproject.org/osstest/logs/164928/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

Re: [PATCH v1 14/14] xen/arm: Add linux,pci-domain property for hwdom if not available.

2021-09-09 Thread Stefano Stabellini
On Thu, 19 Aug 2021, Rahul Singh wrote: > If the property is not present in the device tree node for host bridge, > XEN while creating the dtb for hwdom will create this property and > assigns the already allocated segment to the host bridge > so that XEN and linux will have the same segment for th

Re: [PATCH v1 12/14] arm/libxl: Emulated PCI device tree node in libxl

2021-09-09 Thread Stefano Stabellini
On Thu, 19 Aug 2021, Rahul Singh wrote: > libxl will create an emulated PCI device tree node in the device tree to > enable the guest OS to discover the virtual PCI during guest boot. > Emulated PCI device tree node will only be created when there is any > device assigned to guest. > > A new area

Re: [PATCH v1 11/14] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-09-09 Thread Stefano Stabellini
On Thu, 19 Aug 2021, Rahul Singh wrote: > The existing VPCI support available for X86 is adapted for Arm. > When the device is added to XEN via the hyper call > “PHYSDEVOP_pci_device_add”, VPCI handler for the config space > access is added to the Xen to emulate the PCI devices config space. This

[PATCH AUTOSEL 4.14 16/19] xen: remove stray preempt_disable() from PV AP startup code

2021-09-09 Thread Sasha Levin
From: Juergen Gross [ Upstream commit 58e636039b512697554b579c2bb23774061877f5 ] In cpu_bringup() there is a call of preempt_disable() without a paired preempt_enable(). This is not needed as interrupts are off initially. Additionally this will result in early boot messages like: BUG: schedulin

[PATCH AUTOSEL 4.19 22/25] xen: remove stray preempt_disable() from PV AP startup code

2021-09-09 Thread Sasha Levin
From: Juergen Gross [ Upstream commit 58e636039b512697554b579c2bb23774061877f5 ] In cpu_bringup() there is a call of preempt_disable() without a paired preempt_enable(). This is not needed as interrupts are off initially. Additionally this will result in early boot messages like: BUG: schedulin

[PATCH AUTOSEL 5.4 34/37] xen: remove stray preempt_disable() from PV AP startup code

2021-09-09 Thread Sasha Levin
From: Juergen Gross [ Upstream commit 58e636039b512697554b579c2bb23774061877f5 ] In cpu_bringup() there is a call of preempt_disable() without a paired preempt_enable(). This is not needed as interrupts are off initially. Additionally this will result in early boot messages like: BUG: schedulin

[PATCH AUTOSEL 5.10 49/53] xen: remove stray preempt_disable() from PV AP startup code

2021-09-09 Thread Sasha Levin
From: Juergen Gross [ Upstream commit 58e636039b512697554b579c2bb23774061877f5 ] In cpu_bringup() there is a call of preempt_disable() without a paired preempt_enable(). This is not needed as interrupts are off initially. Additionally this will result in early boot messages like: BUG: schedulin

[PATCH AUTOSEL 5.13 76/88] xen: remove stray preempt_disable() from PV AP startup code

2021-09-09 Thread Sasha Levin
From: Juergen Gross [ Upstream commit 58e636039b512697554b579c2bb23774061877f5 ] In cpu_bringup() there is a call of preempt_disable() without a paired preempt_enable(). This is not needed as interrupts are off initially. Additionally this will result in early boot messages like: BUG: schedulin

[PATCH AUTOSEL 5.14 85/99] xen: remove stray preempt_disable() from PV AP startup code

2021-09-09 Thread Sasha Levin
From: Juergen Gross [ Upstream commit 58e636039b512697554b579c2bb23774061877f5 ] In cpu_bringup() there is a call of preempt_disable() without a paired preempt_enable(). This is not needed as interrupts are off initially. Additionally this will result in early boot messages like: BUG: schedulin

Re: [PATCH v1 09/14] xen/arm: Add cmdline boot option "pci=on"

2021-09-09 Thread Stefano Stabellini
On Thu, 19 Aug 2021, Rahul Singh wrote: > Add cmdline boot option "pci=on" to enable/disable the PCI init during > boot. > > Signed-off-by: Rahul Singh > --- > xen/arch/arm/pci/pci.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/xen/arch/arm/pci/pci.c

Re: [PATCH v1 09/14] xen/arm: Add cmdline boot option "pci=on"

2021-09-09 Thread Stefano Stabellini
On Fri, 20 Aug 2021, Jan Beulich wrote: > On 20.08.2021 16:34, Julien Grall wrote: > > On 20/08/2021 13:19, Rahul Singh wrote: > >>> On 19 Aug 2021, at 1:31 pm, Julien Grall wrote: > >>> On 19/08/2021 13:02, Rahul Singh wrote: > Add cmdline boot option "pci=on" to enable/disable the PCI init

Re: [PATCH v1 08/14] xen:arm: Implement pci access functions

2021-09-09 Thread Stefano Stabellini
On Thu, 19 Aug 2021, Rahul Singh wrote: > Implement generic pci access functions to read/write the configuration > space. > > Signed-off-by: Rahul Singh > --- > xen/arch/arm/pci/pci-access.c | 31 +- > xen/arch/arm/pci/pci-host-common.c | 19 ++ >

Re: [PATCH v1 07/14] xen/arm: Add support for Xilinx ZynqMP PCI host controller

2021-09-09 Thread Stefano Stabellini
On Thu, 19 Aug 2021, Rahul Singh wrote: > From: Oleksandr Andrushchenko > > Add support for Xilinx ZynqMP PCI host controller to map the PCI config > space to the XEN memory. > > Signed-off-by: Oleksandr Andrushchenko > --- > xen/arch/arm/pci/Makefile | 1 + > xen/arch/arm/pci/pci-ho

Re: [PATCH v1 06/14] xen/arm: Add support for PCI ecam operations

2021-09-09 Thread Stefano Stabellini
On Thu, 19 Aug 2021, Rahul Singh wrote: > Add support for PCI ecam operations to access the PCI > configuration space. > > Signed-off-by: Rahul Singh > --- > xen/arch/arm/pci/Makefile | 1 + > xen/arch/arm/pci/ecam.c | 63 + > xen/arch/arm/pci/p

Re: [RFC PATCH 0/3] Add handling of extended regions (safe ranges) on Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space")

2021-09-09 Thread Oleksandr
Hello all On 07.09.21 20:09, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko You can find an initial discussion at [1]. The extended region (safe range) is a region of guest physical address space which is unused and could be safely used to create grant/foreign mappings instead of wa

[RFC PATCH] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-09-09 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Rework Arm implementation to store grant table frame GFN in struct page_info directly instead of keeping it in standalone status/shared arrays. To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the new field to hold 52-bit/28-bit respectively. In order to not grow the

Re: [PATCH v2 3/3] tools: disable building qemu-trad per default

2021-09-09 Thread Samuel Thibault
Juergen Gross, le jeu. 09 sept. 2021 14:49:24 +0200, a ecrit: > Using qemu-traditional as device model is deprecated for some time now. > > So change the default for building it to "disable". This will affect > ioemu-stubdom, too, as there is a direct dependency between the two. > > Today it is p

Re: [PATCH v1 05/14] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-09 Thread Stefano Stabellini
On Thu, 19 Aug 2021, Rahul Singh wrote: > XEN during boot will read the PCI device tree node “reg” property > and will map the PCI config space to the XEN memory. > > As of now "pci-host-ecam-generic" compatible board is supported. > > "linux,pci-domain" device tree property assigns a fixed PCI d

[PATCH v5 10/10] xsm: remove alternate xsm hook interface

2021-09-09 Thread Daniel P. Smith
Hidden behind macro magic is an alternative xsm hook interface dedicated for use when the dummy/default policy is the only one built. This alternative interface increases code complexity and code size in the core security framework of Xen. This results in code requiring additional maintanence and

[PATCH v5 09/10] kconfig: update xsm config to reflect reality

2021-09-09 Thread Daniel P. Smith
It has been a very long time since XSM Flask was the only XSM module, yet the concenpt of turning XSM on/off continues to be synonymous with enabling and disabling XSM Flask. Even when XSM Flask was the only module, turning XSM on/off did not disable or remove the XSM hooks but simply controlled wh

[PATCH v5 08/10] xsm: decouple xsm header inclusion selection

2021-09-09 Thread Daniel P. Smith
Multiple preprocessor defines were used as a mechanism to selective include parts of the xsm.h header file. This makes it difficult to know which portion is being included at any one time. This commit works to simplify this by separating the core structures and functions of XSM into xsm-core.h away

[PATCH v5 07/10] xsm: convert xsm_ops hook calls to alternative call

2021-09-09 Thread Daniel P. Smith
To reduce retpolines convert all the pointer function calls of the xsm_ops hooks over to the alternative_call infrastructure. Signed-off-by: Daniel P. Smith Acked-by: Andrew Cooper --- xen/include/xsm/xsm.h | 191 +- 1 file changed, 96 insertions(+), 95 d

[PATCH v5 06/10] xsm: refactor xsm_ops handling

2021-09-09 Thread Daniel P. Smith
This renames the `struct xsm_operations` to the shorter `struct xsm_ops` and converts the global xsm_ops from being a pointer to an explicit instance. As part of this conversion, it reworks the XSM modules init function to return their xsm_ops struct which is copied in to the global xsm_ops instanc

[PATCH v5 05/10] xsm: apply coding style

2021-09-09 Thread Daniel P. Smith
Instead of intermixing coding style changes with code changes as they are come upon in this patch set, moving all coding style changes into a single commit. The focus of coding style changes here are, - move trailing comments to line above - ensuring line length does not exceed 80 chars - ensur

[PATCH v5 04/10] xsm: drop dubious xsm_op_t type

2021-09-09 Thread Daniel P. Smith
The type xsm_op_t masks the use of void pointers. This commit drops the xsm_op_t type and replaces it and all its uses with an explicit void. Signed-off-by: Daniel P. Smith Acked-by: Andrew Cooper --- xen/include/xen/hypercall.h | 4 ++-- xen/include/xsm/dummy.h | 4 ++-- xen/include/xsm/

[PATCH v5 03/10] xsm: remove remnants of xsm_memtype hook

2021-09-09 Thread Daniel P. Smith
In c/s fcb8baddf00e the xsm_memtype hook was removed but some remnants were left behind. This commit cleans up those remnants. Signed-off-by: Daniel P. Smith --- xen/include/xsm/xsm.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index ad3

[PATCH v5 02/10] xsm: remove the ability to disable flask

2021-09-09 Thread Daniel P. Smith
On Linux when SELinux is put into permissive mode the descretionary access controls are still in place. Whereas for Xen when the enforcing state of flask is set to permissive, all operations for all domains would succeed, i.e. it does not fall back to the default access controls. To provide a means

[PATCH v5 01/10] xen: Implement xen/alternative-call.h for use in common code

2021-09-09 Thread Daniel P. Smith
From: Andrew Cooper The alternative call infrastructure is x86-only for now, but the common iommu code has a variant and more common code wants to use the infrastructure. Introduce CONFIG_ALTERNATIVE_CALL and a conditional implemetnation so common code can use the optimisation when available, wi

[PATCH v5 00/10] xsm: refactoring xsm hooks

2021-09-09 Thread Daniel P. Smith
Based on feedback from 2021 Xen Developers Summit the xsm-roles RFC patch set is being split into two separate patch sets. This is the first patch set and is focused purely on the clean up and refactoring of the XSM hooks. This patch set refactors the xsm_ops wrapper hooks to use the alternative_c

[xen-unstable test] 164892: tolerable FAIL - PUSHED

2021-09-09 Thread osstest service owner
flight 164892 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164892/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 164883 Tests which did not succeed

Re: Disable IOMMU in Dom0

2021-09-09 Thread Stefano Stabellini
I am fine with adding this functionality only to device tree initially. It is certainly true that if a DMA-capable device is behind an IOMMU, then we can skip swiotlb-xen for foreign pages address transactions. Those addresses will be translated just fine thanks to the IOMMU. Skipping swiotlb-xen

Re: [PATCH] x86: correct asm() constraints when dealing with immediate selector values

2021-09-09 Thread Andrew Cooper
On 09/09/2021 15:56, Jan Beulich wrote: > asm() constraints need to fit both the intended insn(s) which the > respective operands are going to be used with as well as the actual kind > of value specified. "m" (alone) together with a constant, however, leads > to gcc saying > > error: memory input

Re: [PATCH v4 09/11] silo: remove circular xsm hook call

2021-09-09 Thread Daniel P. Smith
On 9/9/21 11:45 AM, Jan Beulich wrote: > On 03.09.2021 21:06, Daniel P. Smith wrote: >> SILO implements a few XSM hooks to extended the decision logic beyond >> what is defined in the dummy/default policy. For each of the hooks, it >> falls back to the dummy/default policy. The fall back is done a

Re: [RFC PATCH 03/10] block: Use qemu_security_policy_taint() API

2021-09-09 Thread Eric Blake
On Thu, Sep 09, 2021 at 01:20:17AM +0200, Philippe Mathieu-Daudé wrote: > Add the BlockDriver::bdrv_taints_security_policy() handler. > Drivers implementing it might taint the global QEMU security > policy. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/block/block_int.h | 6 +- >

Re: [RFC PATCH 02/10] accel: Use qemu_security_policy_taint(), mark KVM and Xen as safe

2021-09-09 Thread Eric Blake
On Thu, Sep 09, 2021 at 01:20:16AM +0200, Philippe Mathieu-Daudé wrote: > Add the AccelClass::secure_policy_supported field to classify > safe (within security boundary) vs unsafe accelerators. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qemu/accel.h | 5 + > accel/kvm/kvm-all.

Re: [RFC PATCH 01/10] sysemu: Introduce qemu_security_policy_taint() API

2021-09-09 Thread Eric Blake
On Thu, Sep 09, 2021 at 01:20:15AM +0200, Philippe Mathieu-Daudé wrote: > Introduce qemu_security_policy_taint() which allows unsafe (read > "not very maintained") code to 'taint' QEMU security policy. > > The "security policy" is the @SecurityPolicy QAPI enum, composed of: > - "none" (no policy

Re: [PATCH 10/11] xen/arm: Do not map PCI ECAM space to Domain-0's p2m

2021-09-09 Thread Julien Grall
Hi Oleksandr, On 03/09/2021 09:33, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Host bridge controller's ECAM space is mapped into Domain-0's p2m, thus it is not possible to trap the same for vPCI via MMIO handlers. For this to work we need to not map those while constructing t

Re: [PATCH 09/11] xen/arm: Setup MMIO range trap handlers for hardware domain

2021-09-09 Thread Julien Grall
Hi Oleksandr, On 03/09/2021 09:33, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko In order vPCI to work it needs all access to PCI configuration space (ECAM) to be synchronized among all entities, e.g. hardware domain and guests. I am not entirely sure what you mean by "synchro

[libvirt test] 164895: regressions - FAIL

2021-09-09 Thread osstest service owner
flight 164895 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164895/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

Re: [PATCH 01/11] xen/arm: Add new device type for PCI

2021-09-09 Thread Julien Grall
Hi Oleksandr, On 03/09/2021 09:33, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Add new device type (DEV_PCI) to distinguish PCI devices from platform DT devices, so some drivers, like IOMMU, can handle PCI devices differently. I think it would be better to fold this change i

Re: [PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS

2021-09-09 Thread Andrew Cooper
On 09/09/2021 17:34, Kevin Stefanov wrote: > The spec requires 64-byte alignment, not 16. > > Signed-off-by: Kevin Stefanov > --- > CC: Jan Beulich > CC: Andrew Cooper > > Note: This does not fix the FACS alignment inside guests yet. See next > patch. The history here is complex. c/s 938cee9d4

[OSSTEST PATCH 3/4] fmtarches: Use dom0arches, not hardcoded arch list

2021-09-09 Thread Ian Jackson
This will make us reallocate fmt tests when the arch list changes. It's not ideal because it means tests jumping about across arches and might let regressions go through but it's better than just dropping them, and doing a better approach is complex. This changes some jobs and adds others, roughly

[OSSTEST PATCH 2/4] mfi-common: Change dom0arch list order (nfc)

2021-09-09 Thread Ian Jackson
Change the order to match fmtarches_outer in do_pv_debian_tests. We are going to want to add an indirection here but not change anything. No change to output from standalone-generate-dump-flight-runvars. Signed-off-by: Ian Jackson --- mfi-common | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[OSSTEST PATCH 4/4] mfi-common: Drop Linux dom0 i386 tests for newer Linux branches

2021-09-09 Thread Ian Jackson
This makes radical changes to the test ste for the linux-linus and linux-next branches. Mostly, tests are dropped but some 64-bit dom0 tests are added to replace them. Requested-by: Juergen Gross Signed-off-by: Ian Jackson --- mfi-common | 5 + 1 file changed, 5 insertions(+) diff --git a

[OSSTEST PATCH 1/4] mfi-common: break out dom0arches variable (nfc)

2021-09-09 Thread Ian Jackson
This will allow test choices to depend on the actual rather than entire dom0arches. No change to output from standalone-generate-dump-flight-runvars. Signed-off-by: Ian Jackson --- mfi-common | 6 ++ 1 file changed, 6 insertions(+) diff --git a/mfi-common b/mfi-common index 2834411f..70e17

Re: [PATCH v4 08/11] xsm: drop generic event channel labeling exclusion

2021-09-09 Thread Daniel P. Smith
On 9/9/21 11:35 AM, Jan Beulich wrote: > On 03.09.2021 21:06, Daniel P. Smith wrote: >> The internal define flag is not used by any XSM module, removing the #ifdef >> leaving the generic event channel labeling as always present. > > Already on v2 I did ask > > "I'm not fully convinced of this rem

[PATCH 3/3] tools/libxl: Only allocate 64 bytes for RSDP

2021-09-09 Thread Kevin Stefanov
RSDP's size is 64 bytes and later in the function, its buffer is hardcoded to be 64 bytes long. Don't bother to allocate a whole page. Signed-off-by: Kevin Stefanov --- CC: Andrew Cooper CC: Ian Jackson CC: Wei Liu CC: Anthony PERARD --- tools/libs/light/libxl_x86_acpi.c | 2 +- 1 file chang

[PATCH 2/3] tools/libxl: Correctly aligned buffer for ACPI tables

2021-09-09 Thread Kevin Stefanov
The pointer resulting from libxl__malloc() has no explicit alignment. As an implementation detail, it has 16-byte alignment. When this buffer is used by libacpi aligning ACPI tables to greater than 16 does not work correctly. This causes the FACS to not be 64-byte aligned when the ACPI tables are

[PATCH 0/3] Fix alignment of FACS in guests

2021-09-09 Thread Kevin Stefanov
When booting Xen as a PVH guest, it currently complains: (XEN) ACPI: SLEEP INFO: pm1x_cnt[1:b004,1:0], pm1x_evt[1:b000,1:0] (XEN) ACPI: FACS is not 64-byte aligned: 0xfc001010 (XEN) ACPI: wakeup_vec[fc00101c], vec_size[20] (XEN) ACPI: Local APIC address 0xfee0 This is caused by severa

[PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS

2021-09-09 Thread Kevin Stefanov
The spec requires 64-byte alignment, not 16. Signed-off-by: Kevin Stefanov --- CC: Jan Beulich CC: Andrew Cooper Note: This does not fix the FACS alignment inside guests yet. See next patch. --- tools/libacpi/build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/li

Re: [PATCH v2 1/3] stubdom: fix build with disabled pv-grub

2021-09-09 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH v2 1/3] stubdom: fix build with disabled pv-grub"): > On 09.09.21 15:23, Ian Jackson wrote: > > How about "pv-grub-maybe" ? Or something. > > What about "pv-grub-if-enabled"? Fine by me. > And could that be done when committing, or should I send another round?

[xen-unstable-smoke test] 164912: tolerable all pass - PUSHED

2021-09-09 Thread osstest service owner
flight 164912 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/164912/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v4 09/11] silo: remove circular xsm hook call

2021-09-09 Thread Jan Beulich
On 03.09.2021 21:06, Daniel P. Smith wrote: > SILO implements a few XSM hooks to extended the decision logic beyond > what is defined in the dummy/default policy. For each of the hooks, it > falls back to the dummy/default policy. The fall back is done a slight > round-about way. This commit makes

Re: [PATCH v4 08/11] xsm: drop generic event channel labeling exclusion

2021-09-09 Thread Jan Beulich
On 03.09.2021 21:06, Daniel P. Smith wrote: > The internal define flag is not used by any XSM module, removing the #ifdef > leaving the generic event channel labeling as always present. Already on v2 I did ask "I'm not fully convinced of this removal: Does it get in the way of anything?" I have

[PATCH] x86: correct asm() constraints when dealing with immediate selector values

2021-09-09 Thread Jan Beulich
asm() constraints need to fit both the intended insn(s) which the respective operands are going to be used with as well as the actual kind of value specified. "m" (alone) together with a constant, however, leads to gcc saying error: memory input is not directly addressable while clang complains

[linux-linus test] 164890: regressions - FAIL

2021-09-09 Thread osstest service owner
flight 164890 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164890/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-09 Thread Jan Beulich
While LLVM's lld is supposed to be a drop-in replacement for GNU ld [1], it appears to not understand quoted section names as operands to e.g. ADDR(). Therefore the original workaround broke the build in environments where ld is actually LLVM's, like on FreeBSD. Fixes: 58ad654ebce7 ("x86: work aro

[XEN PATCH v2] build: add --full to version.sh to guess $(XEN_FULLVERSION)

2021-09-09 Thread Anthony PERARD
Running $(MAKE) like that in a $(shell ) while parsing the Makefile doesn't work reliably. In some case, make will complain with "jobserver unavailable: using -j1. Add '+' to parent make rule.". Also, it isn't possible to distinguish between the output produced by the target "xenversion" and `make

Re: Disable IOMMU in Dom0

2021-09-09 Thread Roman Skakun
Hi Julien, Thanks for the clarification! I aim towards to prepare implementation for upstream to disable SWIOTLB for IOMMU-protected devices in Dom0. To provide this functionality need to add additional binding for each protected device in device-tree. After this step, I will also prepare the p

Re: [PATCH v2 1/3] stubdom: fix build with disabled pv-grub

2021-09-09 Thread Juergen Gross
On 09.09.21 15:23, Ian Jackson wrote: Juergen Gross writes ("[PATCH v2 1/3] stubdom: fix build with disabled pv-grub"): Today the build will fail if --disable-pv-grub as a parameter of configure, as the main Makefile will unconditionally try to build a 32-bit pv-grub stubdom. Fix that by intro

Re: [PATCH v1 12/14] arm/libxl: Emulated PCI device tree node in libxl

2021-09-09 Thread Julien Grall
On 20/08/2021 17:03, Rahul Singh wrote: Hi Julien, Hi Rahul, On 19 Aug 2021, at 2:00 pm, Julien Grall wrote: Hi Rahul, On 19/08/2021 13:02, Rahul Singh wrote: libxl will create an emulated PCI device tree node in the device tree to enable the guest OS to discover the virtual PCI during

Re: [PATCH v1 11/14] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-09-09 Thread Julien Grall
Hi Rahul, On 19/08/2021 13:02, Rahul Singh wrote: The existing VPCI support available for X86 is adapted for Arm. When the device is added to XEN via the hyper call “PHYSDEVOP_pci_device_add”, VPCI handler for the config space access is added to the Xen to emulate the PCI devices config space.

Re: [PATCH v2 1/3] stubdom: fix build with disabled pv-grub

2021-09-09 Thread Ian Jackson
Juergen Gross writes ("[PATCH v2 1/3] stubdom: fix build with disabled pv-grub"): > Today the build will fail if --disable-pv-grub as a parameter of > configure, as the main Makefile will unconditionally try to build a > 32-bit pv-grub stubdom. > > Fix that by introducing a pv-grub32 target in st

Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices

2021-09-09 Thread Oleksandr Andrushchenko
On 09.09.21 15:47, Jan Beulich wrote: > On 09.09.2021 14:42, Oleksandr Andrushchenko wrote: >> On 09.09.21 14:53, Jan Beulich wrote: >>> On 09.09.2021 13:48, Oleksandr Andrushchenko wrote: On 09.09.21 12:21, Jan Beulich wrote: > For the bit in question, where the goal appears to be to hav

Re: [PATCH v1 02/14] xen/pci: solve compilation error on ARM with HAS_PCI enabled

2021-09-09 Thread Julien Grall
Hi, On 19/08/2021 13:02, Rahul Singh wrote: Compilation error is observed when HAS_PCI is enabled for ARM architecture. Add definition for arch_iommu_use_permitted() and arch_pci_clean_pirqs().Implement dummy functions for pci_conf_read*() to fix compilation error. pci.c: In function ‘deassign

[PATCH v2 3/3] tools: disable building qemu-trad per default

2021-09-09 Thread Juergen Gross
Using qemu-traditional as device model is deprecated for some time now. So change the default for building it to "disable". This will affect ioemu-stubdom, too, as there is a direct dependency between the two. Today it is possible to use a PVH/HVM Linux-based stubdom as device model. Additionally

[PATCH v2 0/3] disable building of pv-grub and qemu-trad per default

2021-09-09 Thread Juergen Gross
This is a first step of deprecating pv-grub and qemu-trad including ioemu-stubdom. Switch the default to not building it. Changes in V2: - new patch 3 - added CHANGELOG.md entry in patch 2 Juergen Gross (3): stubdom: fix build with disabled pv-grub stubdom: disable building pv-grub tools: d

[PATCH v2 2/3] stubdom: disable building pv-grub

2021-09-09 Thread Juergen Gross
The stubdom based pv-grub is using a very outdated version of grub (0.97) and should not be used any longer. Mainline grub has support for PV guests for a long time now, so that should be used as a boot loader of a PV domain. So disable building pv-grub per default. In case someone really wants to

[PATCH v2 1/3] stubdom: fix build with disabled pv-grub

2021-09-09 Thread Juergen Gross
Today the build will fail if --disable-pv-grub as a parameter of configure, as the main Makefile will unconditionally try to build a 32-bit pv-grub stubdom. Fix that by introducing a pv-grub32 target in stubdom/Makefile taking care of this situation. Signed-off-by: Juergen Gross Reviewed-by: Sam

Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices

2021-09-09 Thread Oleksandr Andrushchenko
On 09.09.21 15:47, Jan Beulich wrote: > On 09.09.2021 14:42, Oleksandr Andrushchenko wrote: >> On 09.09.21 14:53, Jan Beulich wrote: >>> On 09.09.2021 13:48, Oleksandr Andrushchenko wrote: On 09.09.21 12:21, Jan Beulich wrote: > For the bit in question, where the goal appears to be to hav

Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices

2021-09-09 Thread Jan Beulich
On 09.09.2021 14:42, Oleksandr Andrushchenko wrote: > On 09.09.21 14:53, Jan Beulich wrote: >> On 09.09.2021 13:48, Oleksandr Andrushchenko wrote: >>> On 09.09.21 12:21, Jan Beulich wrote: For the bit in question, where the goal appears to be to have hardware hold the OR of guest and host

Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices

2021-09-09 Thread Oleksandr Andrushchenko
On 09.09.21 14:53, Jan Beulich wrote: > On 09.09.2021 13:48, Oleksandr Andrushchenko wrote: >> On 09.09.21 12:21, Jan Beulich wrote: >>> For the bit in question, where the goal appears to be to have hardware >>> hold the OR of guest and host values, an approach similar to that used >>> for some of

[xen-4.15-testing test] 164889: tolerable FAIL - PUSHED

2021-09-09 Thread osstest service owner
flight 164889 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/164889/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 163759 test-armhf-armhf-xl-rtd

  1   2   >