[ovmf test] 169169: regressions - FAIL

2022-04-04 Thread osstest service owner
flight 169169 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169169/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[xen-unstable test] 169163: tolerable FAIL - PUSHED

2022-04-04 Thread osstest service owner
flight 169163 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/169163/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 169151 test-armhf-armhf-libvirt 16 save

[xen-4.15-testing test] 169162: tolerable FAIL - PUSHED

2022-04-04 Thread osstest service owner
flight 169162 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/169162/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 168502 Tests which did not suc

Re: PCI passthrough: possible bug in memory relocation

2022-04-04 Thread Mateusz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 > I'm afraid answering this requires debugging the issue. Yet you don't > share any technical details (as to how things don't work, logs, and > alike), and the provided link also doesn't look to point to any such > information (and as an aside I cons

[xen-4.14-testing test] 169158: regressions - FAIL

2022-04-04 Thread osstest service owner
flight 169158 xen-4.14-testing real [real] flight 169168 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169158/ http://logs.test-lab.xenproject.org/osstest/logs/169168/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

[ovmf test] 169165: regressions - FAIL

2022-04-04 Thread osstest service owner
flight 169165 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169165/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [PATCH] of: of_property_read_string return -ENODATA when !length

2022-04-04 Thread Frank Rowand
On 4/4/22 10:28, Rob Herring wrote: > On Fri, Apr 01, 2022 at 03:43:42PM -0700, Stefano Stabellini wrote: >> On Fri, 1 Apr 2022, Rob Herring wrote: >>> On Fri, Apr 1, 2022 at 3:49 PM Stefano Stabellini >>> wrote: On Fri, 1 Apr 2022, Rob Herring wrote: > On Thu, Mar 31, 2022 at 7:46 P

[ovmf test] 169161: regressions - FAIL

2022-04-04 Thread osstest service owner
flight 169161 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169161/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[linux-linus test] 169157: regressions - FAIL

2022-04-04 Thread osstest service owner
flight 169157 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/169157/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 169145 Tests which did not

[xen-unstable-smoke test] 169160: tolerable all pass - PUSHED

2022-04-04 Thread osstest service owner
flight 169160 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/169160/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

RE: [PATCH 09/15] swiotlb: make the swiotlb_init interface more useful

2022-04-04 Thread Michael Kelley (LINUX)
From: Christoph Hellwig Sent: Sunday, April 3, 2022 10:06 PM > > Pass a bool to pass if swiotlb needs to be enabled based on the Wording problems. I'm not sure what you meant to say. > addressing needs and replace the verbose argument with a set of > flags, including one to force enable bounce

Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged

2022-04-04 Thread Daniel P. Smith
On 4/4/22 11:12, Roger Pau Monné wrote: > On Mon, Apr 04, 2022 at 10:21:18AM -0400, Daniel P. Smith wrote: >> On 3/31/22 08:36, Roger Pau Monné wrote: >>> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote: There are now instances where internal hypervisor logic needs to make >>>

Re: [PATCH v4 1/8] x86/boot: make "vga=current" work with graphics modes

2022-04-04 Thread Jan Beulich
(reducing Cc list some) On 04.04.2022 16:49, Roger Pau Monné wrote: > On Thu, Mar 31, 2022 at 11:44:10AM +0200, Jan Beulich wrote: >> GrUB2 can be told to leave the screen in the graphics mode it has been >> using (or any other one), via "set gfxpayload=keep" (or suitable >> variants thereof). In

Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged

2022-04-04 Thread Daniel P. Smith
On 3/31/22 09:16, Jason Andryuk wrote: > On Wed, Mar 30, 2022 at 3:05 PM Daniel P. Smith > wrote: >> >> There are now instances where internal hypervisor logic needs to make >> resource >> allocation calls that are protected by XSM checks. The internal hypervisor >> logic >> is represented a num

Re: [PATCH v4 4/4] x86/time: use fake read_tsc()

2022-04-04 Thread Jan Beulich
On 04.04.2022 15:22, Roger Pau Monné wrote: > On Thu, Mar 31, 2022 at 11:31:38AM +0200, Jan Beulich wrote: >> Go a step further than bed9ae54df44 ("x86/time: switch platform timer >> hooks to altcall") did and eliminate the "real" read_tsc() altogether: >> It's not used except in pointer comparison

[xen-4.15-testing test] 169152: regressions - FAIL

2022-04-04 Thread osstest service owner
flight 169152 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/169152/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-livepatch13 livepatch-runfail REGR. vs. 168502 test-amd64-amd

Re: [PATCH] of: of_property_read_string return -ENODATA when !length

2022-04-04 Thread Rob Herring
On Fri, Apr 01, 2022 at 03:43:42PM -0700, Stefano Stabellini wrote: > On Fri, 1 Apr 2022, Rob Herring wrote: > > On Fri, Apr 1, 2022 at 3:49 PM Stefano Stabellini > > wrote: > > > > > > On Fri, 1 Apr 2022, Rob Herring wrote: > > > > On Thu, Mar 31, 2022 at 7:46 PM Stefano Stabellini > > > > wrote

Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged

2022-04-04 Thread Jan Beulich
On 04.04.2022 17:12, Roger Pau Monné wrote: > On Mon, Apr 04, 2022 at 10:21:18AM -0400, Daniel P. Smith wrote: >> On 3/31/22 08:36, Roger Pau Monné wrote: >>> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote: There are now instances where internal hypervisor logic needs to make

Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged

2022-04-04 Thread Roger Pau Monné
On Mon, Apr 04, 2022 at 10:21:18AM -0400, Daniel P. Smith wrote: > On 3/31/22 08:36, Roger Pau Monné wrote: > > On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote: > >> There are now instances where internal hypervisor logic needs to make > >> resource > >> allocation calls that are p

Re: [PATCH v2 2/3] x86/mem_sharing: add fork_complete field to mem_sharing_domain

2022-04-04 Thread Tamas K Lengyel
On Tue, Mar 29, 2022 at 11:51 AM Jan Beulich wrote: > > On 29.03.2022 16:03, Tamas K Lengyel wrote: > > The fork's physmap should only be populated with select special pages during > > the setup of the fork. The rest of the fork's physmap should only be > > populated > > as needed after the fork

Re: [PATCH 2/2] arch: ensure idle domain is not left privileged

2022-04-04 Thread Daniel P. Smith
On 3/31/22 08:46, Roger Pau Monné wrote: > On Wed, Mar 30, 2022 at 07:05:49PM -0400, Daniel P. Smith wrote: >> It is now possible to promote the idle domain to privileged during setup. It >> is not desirable for the idle domain to still be privileged when moving into >> a >> running state. If the

Re: [PATCH v4 1/8] x86/boot: make "vga=current" work with graphics modes

2022-04-04 Thread Roger Pau Monné
On Thu, Mar 31, 2022 at 11:44:10AM +0200, Jan Beulich wrote: > GrUB2 can be told to leave the screen in the graphics mode it has been > using (or any other one), via "set gfxpayload=keep" (or suitable > variants thereof). In this case we can avoid doing another mode switch > ourselves. This in part

[ovmf test] 169156: regressions - FAIL

2022-04-04 Thread osstest service owner
flight 169156 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169156/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged

2022-04-04 Thread Daniel P. Smith
On 3/31/22 08:36, Roger Pau Monné wrote: > On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote: >> There are now instances where internal hypervisor logic needs to make >> resource >> allocation calls that are protected by XSM checks. The internal hypervisor >> logic >> is represented

Re: preparations for 4.14.5 ?

2022-04-04 Thread Marek Marczykowski-Górecki
On Mon, Apr 04, 2022 at 03:42:09PM +0200, Jan Beulich wrote: > On 01.04.2022 15:46, Marek Marczykowski-Górecki wrote: > > On Wed, Mar 30, 2022 at 12:16:00PM +0200, Jan Beulich wrote: > >> All, > >> > >> while 4.14's general support period ended in January, we're considering > >> to cut an out-of-ba

Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property section

2022-04-04 Thread Andrew Cooper
On 04/04/2022 13:45, Jan Beulich wrote: > On 04.04.2022 12:40, Roger Pau Monne wrote: >> Prevent the assembler from creating a .note.gnu.property section on >> the output objects, as it's not useful for firmware related binaries, >> and breaks the resulting rombios image. >> >> This requires modify

Re: preparations for 4.14.5 ?

2022-04-04 Thread Jan Beulich
On 01.04.2022 15:46, Marek Marczykowski-Górecki wrote: > On Wed, Mar 30, 2022 at 12:16:00PM +0200, Jan Beulich wrote: >> All, >> >> while 4.14's general support period ended in January, we're considering >> to cut an out-of-band release due to the relatively large number of >> security relevant bac

Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property section

2022-04-04 Thread Roger Pau Monné
On Mon, Apr 04, 2022 at 02:45:05PM +0200, Jan Beulich wrote: > (This, as an aside, also makes pretty clear that - unlike the title > of the series suggests - this has nothing to do with gcc 11.) I've started debugging this as reported as an issue associated with building with gcc 11, until I reali

Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state

2022-04-04 Thread Tamas K Lengyel
On Fri, Mar 25, 2022 at 9:34 AM Tamas K Lengyel wrote: > > During VM forking and resetting a failed vmentry has been observed due > to the guest non-register state going out-of-sync with the guest register > state. For example, a VM fork reset right after a STI instruction can trigger > the failed

Re: [PATCH v4 4/4] x86/time: use fake read_tsc()

2022-04-04 Thread Roger Pau Monné
On Thu, Mar 31, 2022 at 11:31:38AM +0200, Jan Beulich wrote: > Go a step further than bed9ae54df44 ("x86/time: switch platform timer > hooks to altcall") did and eliminate the "real" read_tsc() altogether: > It's not used except in pointer comparisons, and hence it looks overall > more safe to simp

Re: [PATCH v4 3/4] include: move STR() and IS_ALIGNED()

2022-04-04 Thread Roger Pau Monné
On Thu, Mar 31, 2022 at 11:31:02AM +0200, Jan Beulich wrote: > lib.h is imo a better fit for them than config.h. Looks like most of what's in config.h could move to lib.h. > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: PCI passthrough: possible bug in memory relocation

2022-04-04 Thread Jan Beulich
On 04.04.2022 01:24, Mateusz wrote: > Hello, > I'm working on resolving a bug in Qubes OS. The problem is that > when someone gives a VM too much RAM the GPU passthrough doesn't > work as intended. I think it's because in these cases RAM overlaps > with PCI addresses and memory relocation doesn't w

Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property section

2022-04-04 Thread Jan Beulich
On 04.04.2022 12:40, Roger Pau Monne wrote: > Prevent the assembler from creating a .note.gnu.property section on > the output objects, as it's not useful for firmware related binaries, > and breaks the resulting rombios image. > > This requires modifying the cc-option Makefile macro so it can tes

Re: [PATCH v4 1/4] x86/APIC: calibrate against platform timer when possible

2022-04-04 Thread Roger Pau Monné
On Mon, Apr 04, 2022 at 01:55:56PM +0200, Jan Beulich wrote: > On 04.04.2022 13:46, Roger Pau Monné wrote: > > On Thu, Mar 31, 2022 at 11:29:44AM +0200, Jan Beulich wrote: > >> +uint64_t __init calibrate_apic_timer(void) > >> +{ > >> +uint32_t start, end; > >> +uint64_t count = read_pt_and_

[xen-unstable test] 169151: trouble: broken/fail/pass

2022-04-04 Thread osstest service owner
flight 169151 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/169151/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 broken Tests which are fail

Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged

2022-04-04 Thread Jan Beulich
On 04.04.2022 10:08, Roger Pau Monné wrote: > On Fri, Apr 01, 2022 at 06:52:46PM +0100, Julien Grall wrote: >> Hi, >> >> On 31/03/2022 13:36, Roger Pau Monné wrote: >>> On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote: There are now instances where internal hypervisor logic need

Re: [PATCH v2 02/14] x86/P2M: introduce p2m_{add,remove}_page()

2022-04-04 Thread Jan Beulich
On 01.04.2022 14:02, George Dunlap wrote: >> On Feb 23, 2022, at 3:58 PM, Jan Beulich wrote: >> >> Rename guest_physmap_add_entry() to p2m_add_page(); make >> guest_physmap_remove_page() a trivial wrapper around p2m_remove_page(). >> This way callers can use suitable pairs of functions (previously

Re: [PATCH v4 1/4] x86/APIC: calibrate against platform timer when possible

2022-04-04 Thread Jan Beulich
On 04.04.2022 13:46, Roger Pau Monné wrote: > On Thu, Mar 31, 2022 at 11:29:44AM +0200, Jan Beulich wrote: >> +uint64_t __init calibrate_apic_timer(void) >> +{ >> +uint32_t start, end; >> +uint64_t count = read_pt_and_tmcct(&start), elapsed; >> +uint64_t target = CALIBRATE_VALUE(plt_src

Re: [PATCH v4 1/4] x86/APIC: calibrate against platform timer when possible

2022-04-04 Thread Roger Pau Monné
On Thu, Mar 31, 2022 at 11:29:44AM +0200, Jan Beulich wrote: > Use the original calibration against PIT only when the platform timer > is PIT. This implicitly excludes the "xen_guest" case from using the PIT > logic (init_pit() fails there, and as of 5e73b2594c54 ["x86/time: minor > adjustments to

Re: [PATCH v1 3/5] xen/arm: unpopulate memory when domain on static allocation

2022-04-04 Thread Jan Beulich
On 31.03.2022 12:30, Penny Zheng wrote: > Hi Jan > >> -Original Message- >> From: Jan Beulich >> Sent: Thursday, March 31, 2022 3:06 PM >> To: Penny Zheng >> Cc: Wei Chen ; Henry Wang ; >> Andrew Cooper ; George Dunlap >> ; Julien Grall ; Stefano Stabellini >> ; Wei Liu ; xen- >> de...@

Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property section

2022-04-04 Thread Anthony PERARD
On Mon, Apr 04, 2022 at 12:12:54PM +0100, Anthony PERARD wrote: > On Mon, Apr 04, 2022 at 12:40:44PM +0200, Roger Pau Monne wrote: > > Prevent the assembler from creating a .note.gnu.property section on > > the output objects, as it's not useful for firmware related binaries, > > and breaks the res

[libvirt test] 169154: regressions - FAIL

2022-04-04 Thread osstest service owner
flight 169154 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/169154/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

Re: [PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property section

2022-04-04 Thread Anthony PERARD
On Mon, Apr 04, 2022 at 12:40:44PM +0200, Roger Pau Monne wrote: > Prevent the assembler from creating a .note.gnu.property section on > the output objects, as it's not useful for firmware related binaries, > and breaks the resulting rombios image. > > This requires modifying the cc-option Makefil

Re: [PATCH v2] Grab the EFI System Resource Table and check it

2022-04-04 Thread Luca Fancellu
> On 2 Apr 2022, at 00:14, Demi Marie Obenour > wrote: > > The EFI System Resource Table (ESRT) is necessary for fwupd to identify > firmware updates to install. According to the UEFI specification §23.4, > the table shall be stored in memory of type EfiBootServicesData. > Therefore, Xen must

Re: [PATCH v2 1/2] tools/firmware: fix setting of fcf-protection=none

2022-04-04 Thread Anthony PERARD
On Mon, Apr 04, 2022 at 12:40:43PM +0200, Roger Pau Monne wrote: > Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the > Makefile doesn't get it propagated to the subdirectories, so instead > set the flag in firmware/Rules.mk, like it's done for other compiler > flags. > > Fixes

[PATCH v2 2/2] tools/firmware: do not add a .note.gnu.property section

2022-04-04 Thread Roger Pau Monne
Prevent the assembler from creating a .note.gnu.property section on the output objects, as it's not useful for firmware related binaries, and breaks the resulting rombios image. This requires modifying the cc-option Makefile macro so it can test assembler options (by replacing the usage of the -S

[PATCH v2 0/2] firmware: build fixes with gcc-11

2022-04-04 Thread Roger Pau Monne
Hello, The following fixes some firmware build issues with gcc-11. Note that dropping of .note.gnu.property section could likely be done in the linker script in the hvmloader case, but rombios has no linker script and such note is causing a non-working image. Other options could be using objcopy t

[PATCH v2 1/2] tools/firmware: fix setting of fcf-protection=none

2022-04-04 Thread Roger Pau Monne
Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the Makefile doesn't get it propagated to the subdirectories, so instead set the flag in firmware/Rules.mk, like it's done for other compiler flags. Fixes: 3667f7f8f7 ('x86: Introduce support for CET-IBT') Signed-off-by: Roger Pau

Re: [PATCH] platform/x86/dell: add buffer allocation/free functions for SMI calls

2022-04-04 Thread Hans de Goede
Hi, On 3/18/22 23:28, David Laight wrote: > From: Juergen Gross >> Sent: 18 March 2022 16:56 >> >> On 18.03.22 16:22, David Laight wrote: >>> From: Juergen Gross Sent: 18 March 2022 15:10 The dcdbas driver is used to call SMI handlers for both, dcdbas and dell-smbios-smm. Both

osstest: boxes pending comission

2022-04-04 Thread Roger Pau Monné
Hello, We have the following boxes pending commission: italias * Commission flight at: http://logs.test-lab.xenproject.org/osstest/logs/169015/ * Issues: All fine except for the leak-check errors: LEAKED [process 14559 run-parts] process: root 14559 14558 0 19:29 ? 00:00

Re: [PATCH 1/2] xsm: add ability to elevate a domain to privileged

2022-04-04 Thread Roger Pau Monné
On Fri, Apr 01, 2022 at 06:52:46PM +0100, Julien Grall wrote: > Hi, > > On 31/03/2022 13:36, Roger Pau Monné wrote: > > On Wed, Mar 30, 2022 at 07:05:48PM -0400, Daniel P. Smith wrote: > > > There are now instances where internal hypervisor logic needs to make > > > resource > > > allocation call

Re: [PATCH 12/15] swiotlb: provide swiotlb_init variants that remap the buffer

2022-04-04 Thread Dongli Zhang
On 4/3/22 10:05 PM, Christoph Hellwig wrote: > To shared more code between swiotlb and xen-swiotlb, offer a > swiotlb_init_remap interface and add a remap callback to > swiotlb_init_late that will allow Xen to remap the buffer the > buffer without duplicating much of the logic. > > Signed-off-b