[linux-linus test] 171374: regressions - FAIL

2022-06-27 Thread osstest service owner
flight 171374 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171374/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 8 xen-bootfail REGR. vs. 171277

[PATCH AUTOSEL 5.18 38/53] drm/xen: Add missing VM_DONTEXPAND flag in mmap callback

2022-06-27 Thread Sasha Levin
From: Oleksandr Tyshchenko [ Upstream commit ca6969013d13282b42cb5edcc13db731a08e0ad8 ] With Xen PV Display driver in use the "expected" VM_DONTEXPAND flag is not set (neither explicitly nor implicitly), so the driver hits the code path in drm_gem_mmap_obj() which triggers the WARNING.

[qemu-mainline test] 171372: tolerable FAIL - PUSHED

2022-06-27 Thread osstest service owner
flight 171372 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171372/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 22 guest-start.2fail in 171367 pass in 171372 test-amd64-i386-libvirt-raw

[xen-4.15-testing test] 171369: regressions - trouble: broken/fail/pass

2022-06-27 Thread osstest service owner
flight 171369 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/171369/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-amd64-xl broken test-amd64-coresched-amd64-xl 5

Re: [PATCH 6/7] xsm/flask: Use unsigned int instead of plain unsigned

2022-06-27 Thread Daniel P. Smith
On 6/27/22 09:15, Michal Orzel wrote: > This is just for the style and consistency reasons as the former is > being used more often than the latter. > > Signed-off-by: Michal Orzel > --- > xen/xsm/flask/ss/avtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH 4.9] xen/gntdev: Avoid blocking in unmap_grant_pages()

2022-06-27 Thread Demi Marie Obenour
commit dbe97cff7dd9f0f75c524afdd55ad46be3d15295 upstream unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was

[PATCH 4.14] xen/gntdev: Avoid blocking in unmap_grant_pages()

2022-06-27 Thread Demi Marie Obenour
commit dbe97cff7dd9f0f75c524afdd55ad46be3d15295 upstream unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was

[PATCH 5.4] xen/gntdev: Avoid blocking in unmap_grant_pages()

2022-06-27 Thread Demi Marie Obenour
commit dbe97cff7dd9f0f75c524afdd55ad46be3d15295 upstream unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was

[PATCH 4.19] xen/gntdev: Avoid blocking in unmap_grant_pages()

2022-06-27 Thread Demi Marie Obenour
commit dbe97cff7dd9f0f75c524afdd55ad46be3d15295 upstream unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was

[PATCH 5.10] xen/gntdev: Avoid blocking in unmap_grant_pages()

2022-06-27 Thread Demi Marie Obenour
commit dbe97cff7dd9f0f75c524afdd55ad46be3d15295 upstream unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was

[linux-linus test] 171368: regressions - FAIL

2022-06-27 Thread osstest service owner
flight 171368 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171368/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 8 xen-bootfail REGR. vs. 171277

Re: [PATCH] xen/manage: Use orderly_reboot() to reboot

2022-06-27 Thread Juergen Gross
On 27.06.22 17:29, Ross Lagerwall wrote: From: Juergen Gross Sent: Monday, June 27, 2022 3:49 PM To: Ross Lagerwall; xen-devel@lists.xenproject.org Cc: Stefano Stabellini; Oleksandr Tyshchenko; Dongli Zhang; Boris Ostrovsky Subject: Re: [PATCH] xen/manage: Use orderly_reboot() to reboot

Re: [PATCH v2 1/2] public/io: xs_wire: Document that EINVAL should always be first in xsd_errors

2022-06-27 Thread Juergen Gross
On 27.06.22 17:03, Julien Grall wrote: Hi Juergen, On 27/06/2022 15:50, Juergen Gross wrote: On 27.06.22 16:48, Julien Grall wrote: Hi, On 27/06/2022 15:31, Juergen Gross wrote: On 27.06.22 14:36, Julien Grall wrote: From: Julien Grall Some tools (e.g. xenstored) always expect EINVAL to

Re: [PATCH v2 1/2] public/io: xs_wire: Document that EINVAL should always be first in xsd_errors

2022-06-27 Thread Julien Grall
Hi Juergen, On 27/06/2022 15:50, Juergen Gross wrote: On 27.06.22 16:48, Julien Grall wrote: Hi, On 27/06/2022 15:31, Juergen Gross wrote: On 27.06.22 14:36, Julien Grall wrote: From: Julien Grall Some tools (e.g. xenstored) always expect EINVAL to be first in xsd_errors. Document it

Re: [PATCH v2 2/2] public/io: xs_wire: Allow Xenstore to report EPERM

2022-06-27 Thread Juergen Gross
On 27.06.22 14:36, Julien Grall wrote: From: Julien Grall C Xenstored is using EPERM when the client is not allowed to change the owner (see GET_PERMS). However, the xenstore protocol doesn't describe EPERM so EINVAL will be sent to the client. When writing test, it would be useful to

[qemu-mainline test] 171367: regressions - FAIL

2022-06-27 Thread osstest service owner
flight 171367 qemu-mainline real [real] flight 171370 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171367/ http://logs.test-lab.xenproject.org/osstest/logs/171370/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not

Re: [PATCH v2 1/2] public/io: xs_wire: Document that EINVAL should always be first in xsd_errors

2022-06-27 Thread Juergen Gross
On 27.06.22 16:48, Julien Grall wrote: Hi, On 27/06/2022 15:31, Juergen Gross wrote: On 27.06.22 14:36, Julien Grall wrote: From: Julien Grall Some tools (e.g. xenstored) always expect EINVAL to be first in xsd_errors. Document it so, one doesn't add a new entry before hand by mistake.

Re: [PATCH] xen/manage: Use orderly_reboot() to reboot

2022-06-27 Thread Juergen Gross
On 27.06.22 16:28, Ross Lagerwall wrote: Currently when the toolstack issues a reboot, it gets translated into a call to ctrl_alt_del(). But tying reboot to ctrl-alt-del means rebooting may fail if e.g. the user has masked the ctrl-alt-del.target under systemd. A previous attempt to fix this

Re: [PATCH v2 1/2] public/io: xs_wire: Document that EINVAL should always be first in xsd_errors

2022-06-27 Thread Julien Grall
Hi, On 27/06/2022 15:31, Juergen Gross wrote: On 27.06.22 14:36, Julien Grall wrote: From: Julien Grall Some tools (e.g. xenstored) always expect EINVAL to be first in xsd_errors. Document it so, one doesn't add a new entry before hand by mistake. Signed-off-by: Julien Grall I

Re: [PATCH v2 1/2] public/io: xs_wire: Document that EINVAL should always be first in xsd_errors

2022-06-27 Thread Juergen Gross
On 27.06.22 14:36, Julien Grall wrote: From: Julien Grall Some tools (e.g. xenstored) always expect EINVAL to be first in xsd_errors. Document it so, one doesn't add a new entry before hand by mistake. Signed-off-by: Julien Grall I have tried to add a BUILD_BUG_ON() but GCC

[PATCH] xen/manage: Use orderly_reboot() to reboot

2022-06-27 Thread Ross Lagerwall
Currently when the toolstack issues a reboot, it gets translated into a call to ctrl_alt_del(). But tying reboot to ctrl-alt-del means rebooting may fail if e.g. the user has masked the ctrl-alt-del.target under systemd. A previous attempt to fix this set the flag to force rebooting when

Re: [PATCH 3/7] xen/common: Use unsigned int instead of plain unsigned

2022-06-27 Thread Juergen Gross
On 27.06.22 15:15, Michal Orzel wrote: This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key

Re: [PATCH 3/7] xen/arm: head: Add missing isb after writing to SCTLR_EL2/HSCTLR

2022-06-27 Thread Bertrand Marquis
Hi Julien, > On 24 Jun 2022, at 10:11, Julien Grall wrote: > > From: Julien Grall > > Write to SCTLR_EL2/HSCTLR may not be visible until the next context > synchronization. When initializing the CPU, we want the update to take > effect right now. So add an isb afterwards. > > Spec

Re: [PATCH 2/7] xen/arm32: head.S: Introduce a macro to load the physical address of a symbol

2022-06-27 Thread Bertrand Marquis
Hi Julien, > On 27 Jun 2022, at 11:09, Julien Grall wrote: > > Hi Michal, > > On 27/06/2022 10:59, Michal Orzel wrote: >> On 27.06.2022 11:52, Julien Grall wrote: >>> >>> >>> On 27/06/2022 07:31, Michal Orzel wrote: Hi Julien, >>> >>> Hi Michal, >>> On 24.06.2022 11:11, Julien

Re: [PATCH 7/7] drivers/acpi: Drop the unneeded casts to unsigned

2022-06-27 Thread Jan Beulich
On 27.06.2022 15:15, Michal Orzel wrote: > ... and make use of PRIu format specifiers when applicable. > > Signed-off-by: Michal Orzel Reviewed-by: Jan Beulich

Re: [PATCH 6/7] xsm/flask: Use unsigned int instead of plain unsigned

2022-06-27 Thread Jan Beulich
On 27.06.2022 15:15, Michal Orzel wrote: > This is just for the style and consistency reasons as the former is > being used more often than the latter. > > Signed-off-by: Michal Orzel Acked-by: Jan Beulich

Re: [PATCH 1/7] xen/arm: Use unsigned int instead of plain unsigned

2022-06-27 Thread Julien Grall
Hi, On 27/06/2022 14:15, Michal Orzel wrote: This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel Acked-by: Julien Grall Cheers, -- Julien Grall

Re: [PATCH 5/7] include/public: Use uint32_t instead of unsigned (int)

2022-06-27 Thread Jan Beulich
On 27.06.2022 15:15, Michal Orzel wrote: > Public interfaces shall make use of types that indicate size and > signedness. Take the opportunity to also modify places where explicit > unsigned int is used. > > Signed-off-by: Michal Orzel Reviewed-by: Jan Beulich

Re: [PATCH 4/7] include/xen: Use unsigned int instead of plain unsigned

2022-06-27 Thread Jan Beulich
On 27.06.2022 15:15, Michal Orzel wrote: > This is just for the style and consistency reasons as the former is > being used more often than the latter. > > Signed-off-by: Michal Orzel Acked-by: Jan Beulich

Re: [PATCH 3/7] xen/common: Use unsigned int instead of plain unsigned

2022-06-27 Thread Jan Beulich
On 27.06.2022 15:15, Michal Orzel wrote: > This is just for the style and consistency reasons as the former is > being used more often than the latter. > > Signed-off-by: Michal Orzel Acked-by: Jan Beulich

Re: [PATCH 2/7] xen/domain: Use unsigned int instead of plain unsigned

2022-06-27 Thread Jan Beulich
On 27.06.2022 15:15, Michal Orzel wrote: > This is just for the style and consistency reasons as the former is > being used more often than the latter. > > Signed-off-by: Michal Orzel Acked-by: Jan Beulich

[PATCH 7/7] drivers/acpi: Drop the unneeded casts to unsigned

2022-06-27 Thread Michal Orzel
... and make use of PRIu format specifiers when applicable. Signed-off-by: Michal Orzel --- xen/drivers/acpi/tables/tbfadt.c | 6 +++--- xen/drivers/acpi/tables/tbutils.c | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/xen/drivers/acpi/tables/tbfadt.c

[PATCH 6/7] xsm/flask: Use unsigned int instead of plain unsigned

2022-06-27 Thread Michal Orzel
This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel --- xen/xsm/flask/ss/avtab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/xsm/flask/ss/avtab.c b/xen/xsm/flask/ss/avtab.c index

[PATCH 5/7] include/public: Use uint32_t instead of unsigned (int)

2022-06-27 Thread Michal Orzel
Public interfaces shall make use of types that indicate size and signedness. Take the opportunity to also modify places where explicit unsigned int is used. Signed-off-by: Michal Orzel --- xen/include/public/physdev.h | 4 ++-- xen/include/public/sysctl.h | 10 +- 2 files changed, 7

[PATCH 4/7] include/xen: Use unsigned int instead of plain unsigned

2022-06-27 Thread Michal Orzel
This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel --- xen/include/xen/perfc.h | 2 +- xen/include/xen/sched.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/perfc.h

[PATCH 3/7] xen/common: Use unsigned int instead of plain unsigned

2022-06-27 Thread Michal Orzel
This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel --- xen/common/grant_table.c | 6 +++--- xen/common/gunzip.c| 8 xen/common/sched/cpupool.c | 4 ++-- xen/common/trace.c | 2 +- 4

[PATCH 2/7] xen/domain: Use unsigned int instead of plain unsigned

2022-06-27 Thread Michal Orzel
This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel --- xen/common/domain.c | 2 +- xen/include/xen/domain.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/domain.c

[PATCH 1/7] xen/arm: Use unsigned int instead of plain unsigned

2022-06-27 Thread Michal Orzel
This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel --- xen/arch/arm/domain_build.c | 2 +- xen/arch/arm/guestcopy.c| 13 +++-- xen/arch/arm/include/asm/arm32/bitops.h | 8

[PATCH 0/7] xen/arm: use unsigned int instead of plain unsigned

2022-06-27 Thread Michal Orzel
This is done purely for cosmetic/style reasons (as we tend to use unsigned int more often than just unsigned) and not to waste changes made as part of [1] series that contained invalid justification (this is not fixing MISRA 8.1 rule). Most of these patches have already been reviewed/acked but

Re: [PATCH v7 7/9] xen/arm: unpopulate memory when domain is static

2022-06-27 Thread Jan Beulich
On 27.06.2022 12:03, Penny Zheng wrote: >> From: Jan Beulich >> Sent: Wednesday, June 22, 2022 5:24 PM >> >> Furthermore careful with the local variable name used here. Consider what >> would happen with an invocation of >> >> put_static_pages(d, page, i); >> >> To common approach is to

Re: [PATCH v6 1/9] xen: move do_vcpu_op() to arch specific code

2022-06-27 Thread Roger Pau Monné
On Thu, Mar 24, 2022 at 03:01:31PM +0100, Juergen Gross wrote: > The entry point used for the vcpu_op hypercall on Arm is different > from the one on x86 today, as some of the common sub-ops are not > supported on Arm. The Arm specific handler filters out the not > supported sub-ops and then calls

[PATCH v2 1/2] public/io: xs_wire: Document that EINVAL should always be first in xsd_errors

2022-06-27 Thread Julien Grall
From: Julien Grall Some tools (e.g. xenstored) always expect EINVAL to be first in xsd_errors. Document it so, one doesn't add a new entry before hand by mistake. Signed-off-by: Julien Grall I have tried to add a BUILD_BUG_ON() but GCC complained that the value was not a constant. I

[PATCH v2 2/2] public/io: xs_wire: Allow Xenstore to report EPERM

2022-06-27 Thread Julien Grall
From: Julien Grall C Xenstored is using EPERM when the client is not allowed to change the owner (see GET_PERMS). However, the xenstore protocol doesn't describe EPERM so EINVAL will be sent to the client. When writing test, it would be useful to differentiate between EINVAL (e.g. parsing

[PATCH v2 0/2] public/io: xs_wire: Allow Xenstore to report EPERM

2022-06-27 Thread Julien Grall
From: Julien Grall Hi all, This small patch series allows xenstore to report EPERM (see patch #2). Patch #1 was introduced to avoid someone else making the mistake to introduce a new error before EINVAL. Cheers, Julien Grall (2): public/io: xs_wire: Document that EINVAL should always be

Re: [PATCH v6 1/9] xen: move do_vcpu_op() to arch specific code

2022-06-27 Thread Juergen Gross
On 27.06.22 13:35, Roger Pau Monné wrote: On Mon, Jun 27, 2022 at 01:08:11PM +0200, Juergen Gross wrote: On 27.06.22 13:02, Roger Pau Monné wrote: On Mon, Jun 27, 2022 at 12:40:41PM +0200, Juergen Gross wrote: On 27.06.22 12:28, Roger Pau Monné wrote: On Thu, Mar 24, 2022 at 03:01:31PM

Re: [PATCH v6 1/9] xen: move do_vcpu_op() to arch specific code

2022-06-27 Thread Roger Pau Monné
On Mon, Jun 27, 2022 at 01:08:11PM +0200, Juergen Gross wrote: > On 27.06.22 13:02, Roger Pau Monné wrote: > > On Mon, Jun 27, 2022 at 12:40:41PM +0200, Juergen Gross wrote: > > > On 27.06.22 12:28, Roger Pau Monné wrote: > > > > On Thu, Mar 24, 2022 at 03:01:31PM +0100, Juergen Gross wrote: > > >

Re: [PATCH v6 1/9] xen: move do_vcpu_op() to arch specific code

2022-06-27 Thread Juergen Gross
On 27.06.22 13:02, Roger Pau Monné wrote: On Mon, Jun 27, 2022 at 12:40:41PM +0200, Juergen Gross wrote: On 27.06.22 12:28, Roger Pau Monné wrote: On Thu, Mar 24, 2022 at 03:01:31PM +0100, Juergen Gross wrote: The entry point used for the vcpu_op hypercall on Arm is different from the one on

Re: [PATCH v6 1/9] xen: move do_vcpu_op() to arch specific code

2022-06-27 Thread Roger Pau Monné
On Mon, Jun 27, 2022 at 12:40:41PM +0200, Juergen Gross wrote: > On 27.06.22 12:28, Roger Pau Monné wrote: > > On Thu, Mar 24, 2022 at 03:01:31PM +0100, Juergen Gross wrote: > > > The entry point used for the vcpu_op hypercall on Arm is different > > > from the one on x86 today, as some of the

Re: [PATCH v7 9/9] xen: retrieve reserved pages on populate_physmap

2022-06-27 Thread Julien Grall
Hi Penny, On 27/06/2022 11:11, Penny Zheng wrote: -Original Message- From: Julien Grall Sent: Saturday, June 25, 2022 3:51 AM To: Penny Zheng ; xen-devel@lists.xenproject.org Cc: Wei Chen ; Andrew Cooper ; George Dunlap ; Jan Beulich ; Stefano Stabellini ; Wei Liu Subject: Re: [PATCH

Re: [PATCH v6 1/9] xen: move do_vcpu_op() to arch specific code

2022-06-27 Thread Juergen Gross
On 27.06.22 12:28, Roger Pau Monné wrote: On Thu, Mar 24, 2022 at 03:01:31PM +0100, Juergen Gross wrote: The entry point used for the vcpu_op hypercall on Arm is different from the one on x86 today, as some of the common sub-ops are not supported on Arm. The Arm specific handler filters out the

Re: [PATCH] xen/arm: avoid extra caclulations when setting vtimer in context switch

2022-06-27 Thread Julien Grall
Hi Jiami Title: s/caclulations/calculations/ However, I think the title should mention the overflow rather than the extra calculations. The former is more important the latter. On 27/06/2022 03:58, Jiamei Xie wrote: virt_vtimer_save is calculating the new time for the vtimer in:

Re: [PATCH v6 1/9] xen: move do_vcpu_op() to arch specific code

2022-06-27 Thread Roger Pau Monné
On Thu, Mar 24, 2022 at 03:01:31PM +0100, Juergen Gross wrote: > The entry point used for the vcpu_op hypercall on Arm is different > from the one on x86 today, as some of the common sub-ops are not > supported on Arm. The Arm specific handler filters out the not > supported sub-ops and then calls

[linux-linus test] 171364: regressions - FAIL

2022-06-27 Thread osstest service owner
flight 171364 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171364/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 8 xen-bootfail REGR. vs. 171277

RE: [PATCH v7 9/9] xen: retrieve reserved pages on populate_physmap

2022-06-27 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Saturday, June 25, 2022 3:51 AM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Andrew Cooper > ; George Dunlap ; > Jan Beulich ; Stefano Stabellini ; > Wei Liu > Subject: Re: [PATCH v7 9/9] xen: retrieve

Re: [PATCH v7 7/9] xen/arm: unpopulate memory when domain is static

2022-06-27 Thread Julien Grall
On 27/06/2022 11:03, Penny Zheng wrote: Hi jan -Original Message- put_static_pages, that is, adding pages to the reserved list, is only for freeing static pages on runtime. In static page initialization stage, I also use free_statimem_pages, and in which stage, I think the domain

Re: [PATCH] public/io: xs_wire: Allow Xenstore to report EPERM

2022-06-27 Thread Julien Grall
Hi Jan, On 27/06/2022 07:57, Jan Beulich wrote: On 24.06.2022 18:51, Julien Grall wrote: --- a/xen/include/public/io/xs_wire.h +++ b/xen/include/public/io/xs_wire.h @@ -76,6 +76,7 @@ static struct xsd_errors xsd_errors[] __attribute__((unused)) #endif = { +XSD_ERROR(EPERM),

Re: [PATCH 2/7] xen/arm32: head.S: Introduce a macro to load the physical address of a symbol

2022-06-27 Thread Julien Grall
Hi Michal, On 27/06/2022 10:59, Michal Orzel wrote: On 27.06.2022 11:52, Julien Grall wrote: On 27/06/2022 07:31, Michal Orzel wrote: Hi Julien, Hi Michal, On 24.06.2022 11:11, Julien Grall wrote: From: Julien Grall A lot of places in the ARM32 assembly requires to load the

Re: [PATCH] public/io: xs_wire: Allow Xenstore to report EPERM

2022-06-27 Thread Juergen Gross
On 27.06.22 12:00, Julien Grall wrote: Hi Jan, On 27/06/2022 07:57, Jan Beulich wrote: On 24.06.2022 18:51, Julien Grall wrote: --- a/xen/include/public/io/xs_wire.h +++ b/xen/include/public/io/xs_wire.h @@ -76,6 +76,7 @@ static struct xsd_errors xsd_errors[]   __attribute__((unused))  

RE: [PATCH v7 7/9] xen/arm: unpopulate memory when domain is static

2022-06-27 Thread Penny Zheng
Hi jan > -Original Message- > From: Jan Beulich > Sent: Wednesday, June 22, 2022 5:24 PM > To: Penny Zheng > Cc: Wei Chen ; Andrew Cooper > ; George Dunlap ; > Julien Grall ; Stefano Stabellini ; > Wei Liu ; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v7 7/9] xen/arm:

[PATCH] x86/ept: fix shattering of special pages

2022-06-27 Thread Roger Pau Monne
The current logic in epte_get_entry_emt() will split any page marked as special with order greater than zero, without checking whether the super page is all special. Fix this by only splitting the page only if it's not all marked as special, in order to prevent unneeded super page shuttering.

Re: [PATCH 2/7] xen/arm32: head.S: Introduce a macro to load the physical address of a symbol

2022-06-27 Thread Michal Orzel
On 27.06.2022 11:52, Julien Grall wrote: > > > On 27/06/2022 07:31, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 24.06.2022 11:11, Julien Grall wrote: >>> From: Julien Grall >>> >>> A lot of places in the ARM32 assembly requires to load the physical address >>> of a symbol.

Re: [PATCH 2/7] xen/arm32: head.S: Introduce a macro to load the physical address of a symbol

2022-06-27 Thread Julien Grall
On 27/06/2022 07:31, Michal Orzel wrote: Hi Julien, Hi Michal, On 24.06.2022 11:11, Julien Grall wrote: From: Julien Grall A lot of places in the ARM32 assembly requires to load the physical address of a symbol. Rather than open-coding the translation, introduce a new macro that will

Re: [PATCH 1/7] xen/arm: Remove most of the *_VIRT_END defines

2022-06-27 Thread Julien Grall
On 27/06/2022 07:23, Michal Orzel wrote: Hi Julien, Hi, Thanks for the review. On 24.06.2022 11:11, Julien Grall wrote: From: Julien Grall --- xen/arch/arm/include/asm/config.h | 18 -- xen/arch/arm/livepatch.c | 2 +- xen/arch/arm/mm.c |

Re: [Viryaos-discuss] [PATCH 2/2] uboot-script-gen: do not enable direct mapping by default

2022-06-27 Thread Ayan Kumar Halder
On 26/06/2022 19:45, Xenia Ragiadakou wrote: To be inline with XEN, do not enable direct mapping automatically for all statically allocated domains. Signed-off-by: Xenia Ragiadakou Reviewed-by: Ayan Kumar Halder --- README.md| 4 ++-- scripts/uboot-script-gen | 8

Re: [Viryaos-discuss] [PATCH 1/2] uboot-script-gen: prevent user mistakes due to DOM0_KERNEL becoming optional

2022-06-27 Thread Ayan Kumar Halder
On 26/06/2022 19:45, Xenia Ragiadakou wrote: Before enabling true dom0less configuration, the script was failing instantly if DOM0_KERNEL parameter was not specified. This behaviour has changed and this needs to be communicated to the user. Mention in README.md that for dom0less

[libvirt test] 171366: regressions - FAIL

2022-06-27 Thread osstest service owner
flight 171366 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171366/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [linux-linus test] 171361: regressions - FAIL

2022-06-27 Thread Julien Grall
Hi, On 27/06/2022 08:38, Jan Beulich wrote: On 27.06.2022 03:38, osstest service owner wrote: flight 171361 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171361/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run:

Re: [PATCH 1/2] hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route()

2022-06-27 Thread Durrant, Paul
On 26/06/2022 10:46, Bernhard Beschow wrote: The only user of xen_set_pci_link_route() is xen_piix_pci_write_config_client() which implements PIIX-specific logic in the xen namespace. This makes xen-hvm depend on PIIX which could be avoided if xen_piix_pci_write_config_client() was implemented

Re: [PATCH 2/2] hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and remove it

2022-06-27 Thread Durrant, Paul
On 26/06/2022 10:46, Bernhard Beschow wrote: xen_piix_pci_write_config_client() is implemented in the xen sub tree and uses PIIX constants internally, thus creating a direct dependency on PIIX. Now that xen_set_pci_link_route() is stubbable, the logic of xen_piix_pci_write_config_client() can be

Re: [PATCH 2/5] xen/common: vm_event: Fix MISRA C 2012 Rule 8.7 violation

2022-06-27 Thread Jan Beulich
On 27.06.2022 09:54, xenia wrote: > On 6/27/22 10:11, Jan Beulich wrote: >> On 26.06.2022 23:11, Xenia Ragiadakou wrote: >>> The function vm_event_wake() is referenced only in vm_event.c. >>> Change the linkage of the function from external to internal by adding >>> the storage-class specifier

[xen-unstable test] 171363: tolerable FAIL

2022-06-27 Thread osstest service owner
flight 171363 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171363/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 18 guest-localmigrate fail in 171357 pass in 171363 test-armhf-armhf-xl-rtds 18

Re: [PATCH 2/5] xen/common: vm_event: Fix MISRA C 2012 Rule 8.7 violation

2022-06-27 Thread xenia
Hi Jan, On 6/27/22 10:11, Jan Beulich wrote: On 26.06.2022 23:11, Xenia Ragiadakou wrote: The function vm_event_wake() is referenced only in vm_event.c. Change the linkage of the function from external to internal by adding the storage-class specifier static to the function definition. This

Re: [PATCH 7/7] xen/arm: mm: Reduce the area that xen_second covers

2022-06-27 Thread Michal Orzel
Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall > > At the moment, xen_second is used to cover the first 2GB of the > virtual address space. With the recent rework of the page-tables, > only the first 1GB region (where Xen resides) is effectively used. > > In addition

Re: [linux-linus test] 171361: regressions - FAIL

2022-06-27 Thread Jan Beulich
On 27.06.2022 03:38, osstest service owner wrote: > flight 171361 linux-linus real [real] > http://logs.test-lab.xenproject.org/osstest/logs/171361/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >

Re: [XEN PATCH v3 00/25] Toolstack build system improvement, toward non-recursive makefiles

2022-06-27 Thread Christian Lindig
On 24 Jun 2022, at 17:03, Anthony PERARD mailto:anthony.per...@citrix.com>> wrote: Changes in v3: - rebased - several new patches, starting with 13/25 "tools/libs/util: cleanup Makefile" - introducing macros to deal with linking with in-tree xen libraries - Add -Werror to CFLAGS for all builds

Re: [PATCH 5/7] xen/arm32: mm: Consolidate the domheap mappings initialization

2022-06-27 Thread Michal Orzel
Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall > > At the moment, the domheap mappings initialization is done separately for > the boot CPU and secondary CPUs. The main difference is for the former > the pages are part of Xen binary whilst for the latter they are >

Re: [PATCH 4/5] xen/sched: credit: Fix MISRA C 2012 Rule 8.7 violation

2022-06-27 Thread Jan Beulich
On 26.06.2022 23:11, Xenia Ragiadakou wrote: > The per-cpu variable last_tickle_cpu is referenced only in credit.c. > Change its linkage from external to internal by adding the storage-class > specifier static to its definitions. > > This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4

Re: [PATCH 3/5] xen/drivers: iommu: Fix MISRA C 2012 Rule 8.7 violation

2022-06-27 Thread Jan Beulich
On 26.06.2022 23:11, Xenia Ragiadakou wrote: > The variable iommu_crash_disable is referenced only in one translation unit. > Change its linkage from external to internal by adding the storage-class > specifier static to its definition. > > This patch aims to resolve indirectly a MISRA C 2012

Re: [PATCH 2/5] xen/common: vm_event: Fix MISRA C 2012 Rule 8.7 violation

2022-06-27 Thread Jan Beulich
On 26.06.2022 23:11, Xenia Ragiadakou wrote: > The function vm_event_wake() is referenced only in vm_event.c. > Change the linkage of the function from external to internal by adding > the storage-class specifier static to the function definition. > > This patch aims to resolve indirectly a MISRA

Re: [PATCH 1/5] xen/common: page_alloc: Fix MISRA C 2012 Rule 8.7 violation

2022-06-27 Thread Jan Beulich
On 26.06.2022 23:11, Xenia Ragiadakou wrote: > The variables page_offlined_list and page_broken_list are referenced only > in page_alloc.c. > Change their linkage from external to internal by adding the storage-class > specifier static to their definitions. > > This patch aims to resolve

Re: [PATCH] public/io: xs_wire: Allow Xenstore to report EPERM

2022-06-27 Thread Jan Beulich
On 24.06.2022 18:51, Julien Grall wrote: > --- a/xen/include/public/io/xs_wire.h > +++ b/xen/include/public/io/xs_wire.h > @@ -76,6 +76,7 @@ static struct xsd_errors xsd_errors[] > __attribute__((unused)) > #endif > = { > +XSD_ERROR(EPERM), > XSD_ERROR(EINVAL), >

Re: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings()

2022-06-27 Thread Michal Orzel
Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall > > Both destroy_xen_mappings() and modify_xen_mappings() will take in > parameter a range [start, end[. Both end should be page aligned. > > Add extra ASSERT() to ensure start and end are page aligned. Take the >

Re: [PATCH 3/7] xen/arm: head: Add missing isb after writing to SCTLR_EL2/HSCTLR

2022-06-27 Thread Michal Orzel
Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall > > Write to SCTLR_EL2/HSCTLR may not be visible until the next context > synchronization. When initializing the CPU, we want the update to take > effect right now. So add an isb afterwards. > > Spec references: > -

Re: [PATCH 2/2] x86/P2M: allow 2M superpage use for shadowed guests

2022-06-27 Thread Jan Beulich
On 24.06.2022 21:27, George Dunlap wrote: > > >> On 9 Dec 2021, at 11:27, Jan Beulich wrote: >> >> For guests in shadow mode the P2M table gets used only by software. The >> only place where it matters whether superpages in the P2M can be dealt >> with is sh_unshadow_for_p2m_change(). > > It’s

Re: [PATCH 2/7] xen/arm32: head.S: Introduce a macro to load the physical address of a symbol

2022-06-27 Thread Michal Orzel
Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall > > A lot of places in the ARM32 assembly requires to load the physical address > of a symbol. Rather than open-coding the translation, introduce a new macro > that will load the phyiscal address of a symbol. > > Lastly,

Re: [PATCH 1/2] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change()

2022-06-27 Thread Jan Beulich
On 24.06.2022 21:16, George Dunlap wrote: > > >> On 9 Dec 2021, at 11:26, Jan Beulich wrote: >> >> In preparation for reactivating the presently dead 2M page path of the >> function, >> - also deal with the case of replacing an L1 page table all in one go, >> - pull common checks out of the

Re: [PATCH 1/7] xen/arm: Remove most of the *_VIRT_END defines

2022-06-27 Thread Michal Orzel
Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall > > At the moment, *_VIRT_END may either point to the address after the end > or the last address of the region. > > The lack of consistency make quite difficult to reason with them. > > Furthermore, there is a risk of