Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-05-03 Thread Jan Beulich
On 03.05.2023 17:33, Jan Beulich wrote: > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -683,11 +683,13 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe > unsigned int pirq = op->u.irq_permission.pirq, irq; > int allow = op->u.irq_permission.allow_access; > > +#ifdef CON

unsubscribe

2023-05-03 Thread Terry Yang
Henry Wang 于2023年5月4日 周四12:23写道: > Hi Vikram, > > > -Original Message- > > Subject: [XEN][PATCH v6 08/19] xen/device-tree: Add > > device_tree_find_node_by_path() to find nodes in device tree > > > > Add device_tree_find_node_by_path() to find a matching node with path for > > a > > dt_dev

[linux-linus test] 180516: regressions - FAIL

2023-05-03 Thread osstest service owner
flight 180516 linux-linus real [real] flight 180523 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180516/ http://logs.test-lab.xenproject.org/osstest/logs/180523/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

RE: [XEN][PATCH v6 14/19] common/device_tree: Add rwlock for dt_host

2023-05-03 Thread Henry Wang
Hi Vikram, > -Original Message- > Subject: [XEN][PATCH v6 14/19] common/device_tree: Add rwlock for dt_host > > Dynamic programming ops will modify the dt_host and there might be other > function which are browsing the dt_host at the same time. To avoid the race > conditions, adding rw

RE: [XEN][PATCH v6 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

2023-05-03 Thread Henry Wang
Hi Vikram, > -Original Message- > Subject: [XEN][PATCH v6 08/19] xen/device-tree: Add > device_tree_find_node_by_path() to find nodes in device tree > > Add device_tree_find_node_by_path() to find a matching node with path for > a > dt_device_node. > > Reason behind this function: >

RE: [XEN][PATCH v6 07/19] libfdt: overlay: change overlay_get_target()

2023-05-03 Thread Henry Wang
Hi Vikram, > -Original Message- > Subject: [XEN][PATCH v6 07/19] libfdt: overlay: change overlay_get_target() > > Rename overlay_get_target() to fdt_overlay_target_offset() and remove static > function type. > > This is done to get the target path for the overlay nodes which is very usef

RE: [XEN][PATCH v6 05/19] xen/arm: Add CONFIG_OVERLAY_DTB

2023-05-03 Thread Henry Wang
Hi Vikram, > -Original Message- > Subject: [XEN][PATCH v6 05/19] xen/arm: Add CONFIG_OVERLAY_DTB > > Introduce a config option where the user can enable support for > adding/removing > device tree nodes using a device tree binary overlay. May I please also suggest adding a CHANGELOG entr

RE: [XEN][PATCH v6 04/19] common/device_tree.c: unflatten_device_tree() propagate errors

2023-05-03 Thread Henry Wang
Hi Vikram, > -Original Message- > Subject: [XEN][PATCH v6 04/19] common/device_tree.c: > unflatten_device_tree() propagate errors > > This will be useful in dynamic node programming when new dt nodes are > unflatten Typo: s/unflatten/unflattened/? > during runtime. Invalid device tree n

RE: [XEN][PATCH v6 03/19] common/device_tree: change __unflatten_device_tree() type

2023-05-03 Thread Henry Wang
Hi Vikram, > -Original Message- > Subject: [XEN][PATCH v6 03/19] common/device_tree: change > __unflatten_device_tree() type > > Following changes are done to __unflatten_device_tree(): > 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). > 2. Remove __init and st

RE: [XEN][PATCH v6 02/19] common/device_tree: handle memory allocation failure in __unflatten_device_tree()

2023-05-03 Thread Henry Wang
Hi Vikram, > -Original Message- > Subject: [XEN][PATCH v6 02/19] common/device_tree: handle memory > allocation failure in __unflatten_device_tree() > > Change __unflatten_device_tree() return type to integer so it can propagate > memory allocation failure. Add panic() in dt_unflatten_hos

Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f

2023-05-03 Thread Stefano Stabellini
seems like an unreasonable amount of debugging, we've tracked > >>> down exactly what is going wrong here. > >>> > >>> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 > >>> > >>> Of note is the smoke.serial

[qemu-mainline test] 180514: tolerable FAIL - PUSHED

2023-05-03 Thread osstest service owner
flight 180514 qemu-mainline real [real] flight 180521 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180514/ http://logs.test-lab.xenproject.org/osstest/logs/180521/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f

2023-05-03 Thread andrew . cooper3
wn exactly what is going wrong here. >>> >>> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 >>> >>> Of note is the smoke.serial log around: >>> >>> io: IN 0x90fec250 d0 20230503 14:20:42 INTRODUCE (1 233473 1 ) >&

Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f

2023-05-03 Thread Stefano Stabellini
ab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 > > > > Of note is the smoke.serial log around: > > > > io: IN 0x90fec250 d0 20230503 14:20:42 INTRODUCE (1 233473 1 ) > > obj: CREATE connection 0x90fff1f0 > > *** d1 CONN RESET req_cons

[xen-unstable-smoke test] 180520: tolerable all pass - PUSHED

2023-05-03 Thread osstest service owner
flight 180520 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180520/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH] xen/arm: pci: fix -Wtype-limits warning in pci-host-common.c

2023-05-03 Thread Stewart Hildebrand
When building with EXTRA_CFLAGS_XEN_CORE="-Wtype-limits", we observe the following warning: arch/arm/pci/pci-host-common.c: In function ‘pci_host_common_probe’: arch/arm/pci/pci-host-common.c:238:26: warning: comparison is always false due to limited range of data type [-Wtype-limits] 238 |

Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems

2023-05-03 Thread Stefano Stabellini
On Wed, 3 May 2023, Julien Grall wrote: > Hi Stefano, > > On 03/05/2023 18:54, Stefano Stabellini wrote: > > On Wed, 3 May 2023, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 03/05/2023 00:55, Stefano Stabellini wrote: > > > > > +{ > > > > > +printk("CPU%d: No release addr\n",

Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR

2023-05-03 Thread Borislav Petkov
On Wed, May 03, 2023 at 11:14:25AM -0700, Sohil Mehta wrote: > A Nit -> Documentation/process/maintainer-tip.rst suggests: > "The condensed patch description in the subject line should start with a > uppercase letter and ..." Yeah, good point. But my patch massaging script does that automatically

[PATCH] x86/ucode: Refresh raw CPU policy after microcode load

2023-05-03 Thread Andrew Cooper
Loading microcode can cause new features to appear. This has happened routinely since Spectre/Meltdown, and even the presence of new status bits can mean the administrator has no further work to perform. Refresh the raw CPU policy after late microcode load, so xen-cpuid can reflect the updated st

Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR

2023-05-03 Thread Sohil Mehta
> Juergen Gross (16): > x86/mtrr: remove physical address size calculation > x86/mtrr: replace some constants with defines > x86/mtrr: support setting MTRR state for software defined MTRRs > x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest > x86/xen: set MTRR state when ru

Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems

2023-05-03 Thread Julien Grall
Hi Stefano, On 03/05/2023 18:54, Stefano Stabellini wrote: On Wed, 3 May 2023, Julien Grall wrote: Hi Stefano, On 03/05/2023 00:55, Stefano Stabellini wrote: +{ +printk("CPU%d: No release addr\n", cpu); +return -ENODEV; +} + +release = ioremap_nocache(cpu_release_a

Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems

2023-05-03 Thread Stefano Stabellini
On Wed, 3 May 2023, Julien Grall wrote: > Hi Stefano, > > On 03/05/2023 00:55, Stefano Stabellini wrote: > > > +{ > > > +printk("CPU%d: No release addr\n", cpu); > > > +return -ENODEV; > > > +} > > > + > > > +release = ioremap_nocache(cpu_release_addr[cpu], 4); > > > +

[xen-unstable-smoke test] 180518: tolerable all pass - PUSHED

2023-05-03 Thread osstest service owner
flight 180518 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180518/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[libvirt test] 180513: tolerable all pass - PUSHED

2023-05-03 Thread osstest service owner
flight 180513 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180513/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 180479 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems

2023-05-03 Thread Julien Grall
Hi Ayan, On 03/05/2023 17:49, Ayan Kumar Halder wrote: On 03/05/2023 08:40, Julien Grall wrote: Hi, Hi Julien, Title: Did you mean "Enable spin table"? Yes, that would be more concrete. On 02/05/2023 11:58, Ayan Kumar Halder wrote: On some of the Arm32 based systems (eg Cortex-R52), smpb

Re: [PATCH v5 3/3] tools/xen-ucode: print information about currently loaded ucode

2023-05-03 Thread Andrew Cooper
On 17/04/2023 2:53 pm, Sergey Dyasli wrote: > Add an option to xen-ucode tool to print the currently loaded ucode > revision and also print it during usage info. Print CPU signature and > platform flags as well. The raw data comes from XENPF_get_cpu_version > and XENPF_get_ucode_revision platform

Re: [PATCH v3 4/8] x86/mem-sharing: copy GADDR based shared guest areas

2023-05-03 Thread Tamas K Lengyel
> @@ -1974,7 +2046,10 @@ int mem_sharing_fork_reset(struct domain > > state: > if ( reset_state ) > +{ > rc = copy_settings(d, pd); > +/* TBD: What to do here with -ERESTART? */ Ideally we could avoid hitting code-paths that are restartable during fork reset since it ge

Re: [PATCH v3 3/3] domctl: Modify XEN_DOMCTL_getdomaininfo to fail if domid is not found

2023-05-03 Thread Anthony PERARD
On Tue, May 02, 2023 at 12:13:38PM +0100, Alejandro Vallejo wrote: > It previously mimicked the getdomaininfo sysctl semantics by returning > the first domid higher than the requested domid that does exist. This > unintuitive behaviour causes quite a few mistakes and makes the call > needlessly slo

Re: [PATCH v3 2/3] tools: Use new xc function for some xc_domain_getinfo() calls

2023-05-03 Thread Anthony PERARD
On Tue, May 02, 2023 at 12:13:37PM +0100, Alejandro Vallejo wrote: > diff --git a/tools/libs/light/libxl_x86_acpi.c > b/tools/libs/light/libxl_x86_acpi.c > index 22eb160659..796b009d0c 100644 > --- a/tools/libs/light/libxl_x86_acpi.c > +++ b/tools/libs/light/libxl_x86_acpi.c > @@ -87,14 +87,14 @@

Re: [RFC PATCH] xen/arm: arm32: Enable smpboot on Arm32 based systems

2023-05-03 Thread Ayan Kumar Halder
On 03/05/2023 08:40, Julien Grall wrote: Hi, Hi Julien, Title: Did you mean "Enable spin table"? Yes, that would be more concrete. On 02/05/2023 11:58, Ayan Kumar Halder wrote: On some of the Arm32 based systems (eg Cortex-R52), smpboot is supported. Same here. Yes In these systems

Re: [PATCH v3 1/3] tools: Modify single-domid callers of xc_domain_getinfolist()

2023-05-03 Thread Anthony PERARD
On Tue, May 02, 2023 at 12:13:36PM +0100, Alejandro Vallejo wrote: > diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c > index 7f0986c185..5709b3e62f 100644 > --- a/tools/libs/light/libxl_domain.c > +++ b/tools/libs/light/libxl_domain.c > @@ -349,16 +349,12 @@ int libxl

[PATCH v6 4/4] xen/riscv: remove dummy_bss variable

2023-05-03 Thread Oleksii Kurochko
After introduction of initial pagetables there is no any sense in dummy_bss variable as bss section will not be empty anymore. Signed-off-by: Oleksii Kurochko --- Changes in V6: - Nothing changed. Only rebase --- Changes in V5: - Nothing changed. Only rebase --- Changes in V4: - Nothing change

[PATCH v6 2/4] xen/riscv: introduce setup_initial_pages

2023-05-03 Thread Oleksii Kurochko
The idea was taken from xvisor but the following changes were done: * Use only a minimal part of the code enough to enable MMU * rename {_}setup_initial_pagetables functions * add an argument for setup_initial_mapping to have an opportunity to make set PTE flags. * update setup_initial_pagetables

[PATCH v6 0/4] enable MMU for RISC-V

2023-05-03 Thread Oleksii Kurochko
The patch series introduces the following things: 1. Functionality to build the page tables for Xen that map link-time to physical-time location. 2. Check that Xen is less then page size. 3. Check that load addresses don't overlap with linker addresses. 4. Prepare things for proper switch to vir

[PATCH v6 1/4] xen/riscv: add VM space layout

2023-05-03 Thread Oleksii Kurochko
Also it was added explanation about ignoring of top VA bits Signed-off-by: Oleksii Kurochko --- Changes in V6: - update comment above the RISCV-64 layout table - add Slot column to the table with RISCV-64 Layout - update RV-64 layout table. --- Changes in V5: * the patch was introduced in the

[PATCH v6 3/4] xen/riscv: setup initial pagetables

2023-05-03 Thread Oleksii Kurochko
The patch does two thing: 1. Setup initial pagetables. 2. Enable MMU which end up with code in cont_after_mmu_is_enabled() Signed-off-by: Oleksii Kurochko --- Changes in V6: - Nothing changed. Only rebase --- Changes in V5: - Nothing changed. Only rebase --- Changes in V4: - Nothing changed

[PATCH v3 8/8] common: convert vCPU info area registration

2023-05-03 Thread Jan Beulich
Switch to using map_guest_area(). Noteworthy differences from map_vcpu_info(): - remote vCPU-s are paused rather than checked for being down (which in principle can change right after the check), - the domain lock is taken for a much smaller region, - the error code for an attempt to re-register

[PATCH v3 6/8] domain: introduce GADDR based runstate area registration alternative

2023-05-03 Thread Jan Beulich
The registration by virtual/linear address has downsides: At least on x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit PV domains the area is inaccessible (and hence cannot be updated by Xen) when in guest-user mode. Introduce a new vCPU operation allowing to register the ru

[PATCH v3 7/8] x86: introduce GADDR based secondary time area registration alternative

2023-05-03 Thread Jan Beulich
The registration by virtual/linear address has downsides: The access is expensive for HVM/PVH domains. Furthermore for 64-bit PV domains the area is inaccessible (and hence cannot be updated by Xen) when in guest-user mode. Introduce a new vCPU operation allowing to register the secondary time are

[PATCH v3 5/8] domain: map/unmap GADDR based shared guest areas

2023-05-03 Thread Jan Beulich
The registration by virtual/linear address has downsides: At least on x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit PV domains the areas are inaccessible (and hence cannot be updated by Xen) when in guest-user mode, and for HVM guests they may be inaccessible when Meltdown

[PATCH v3 4/8] x86/mem-sharing: copy GADDR based shared guest areas

2023-05-03 Thread Jan Beulich
In preparation of the introduction of new vCPU operations allowing to register the respective areas (one of the two is x86-specific) by guest-physical address, add the necessary fork handling (with the backing function yet to be filled in). Signed-off-by: Jan Beulich --- v3: Extend comment. ---

[PATCH v3 3/8] x86: update GADDR based secondary time area

2023-05-03 Thread Jan Beulich
Before adding a new vCPU operation to register the secondary time area by guest-physical address, add code to actually keep such areas up-to- date. Note that pages aren't marked dirty when written to (matching the handling of space mapped by map_vcpu_info()), on the basis that the registrations ar

[PATCH v3 1/8] domain: GADDR based shared guest area registration alternative - teardown

2023-05-03 Thread Jan Beulich
In preparation of the introduction of new vCPU operations allowing to register the respective areas (one of the two is x86-specific) by guest-physical address, add the necessary domain cleanup hooks. Signed-off-by: Jan Beulich Reviewed-by: Julien Grall --- RFC: Zapping the areas in pv_shim_shutd

[PATCH v3 2/8] domain: update GADDR based runstate guest area

2023-05-03 Thread Jan Beulich
Before adding a new vCPU operation to register the runstate area by guest-physical address, add code to actually keep such areas up-to-date. Note that updating of the area will be done exclusively following the model enabled by VMASST_TYPE_runstate_update_flag for virtual-address based registered

[PATCH v3 0/8] runstate/time area registration by (guest) physical address

2023-05-03 Thread Jan Beulich
Since it was indicated that introducing specific new vCPU ops may be beneficial independent of the introduction of a fully physical- address-based ABI flavor, here we go. There continue to be a number of open questions throughout the series, resolving of which was one of the main goals of the earli

Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f

2023-05-03 Thread andrew . cooper3
>>> tracked >>> down exactly what is going wrong here. >>> >>> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 >>> >>> Of note is the smoke.serial log around: >>> >>> io: IN 0x90fec250 d0 20230503 14:20:42

[PATCH v2 2/2] cmdline: document and enforce "extra_guest_irqs" upper bounds

2023-05-03 Thread Jan Beulich
PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no more than 32k pIRQ-s can be used by a domain on x86. Document this upper bound. To also enforce the limit, (ab)use both arch_hwdom_irqs() (changing its parameter type) and setup_system_domains(). This is primarily to avoid expos

[PATCH v2 1/2] restrict concept of pIRQ to x86

2023-05-03 Thread Jan Beulich
... by way of a new arch-selectable Kconfig control. Note that some smaller pieces of code are left without #ifdef, to keep things better readable. Hence items like ECS_PIRQ, nr_static_irqs, or domain_pirq_to_irq() remain uniformly. Signed-off-by: Jan Beulich --- I'm not really certain about XEN

[PATCH v2 0/2] new CONFIG_HAS_PIRQ and extra_guest_irqs adjustment

2023-05-03 Thread Jan Beulich
The 1st patch (new in v2) has the effect of the 2nd one no longer affecting Arm. 1: restrict concept of pIRQ to x86 2: cmdline: document and enforce "extra_guest_irqs" upper bounds Jan

Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f

2023-05-03 Thread Juergen Gross
note is the smoke.serial log around: io: IN 0x90fec250 d0 20230503 14:20:42 INTRODUCE (1 233473 1 ) obj: CREATE connection 0x90fff1f0 *** d1 CONN RESET req_cons , req_prod 003a rsp_cons , rsp_prod io: OUT 0x9105cef0 d0 20230503 14:20:42 WATCH_

Re: dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f

2023-05-03 Thread Julien Grall
o: IN 0x90fec250 d0 20230503 14:20:42 INTRODUCE (1 233473 1 ) obj: CREATE connection 0x90fff1f0 *** d1 CONN RESET req_cons , req_prod 003a rsp_cons , rsp_prod io: OUT 0x9105cef0 d0 20230503 14:20:42 WATCH_EVENT (@introduceDomain domlist ) XS_INTRODUCE

[PATCH] xen/pvcalls-back: fix double frees with pvcalls_new_active_socket()

2023-05-03 Thread Dan Carpenter
In the pvcalls_new_active_socket() function, most error paths call pvcalls_back_release_active(fedata->dev, fedata, map) which calls sock_release() on "sock". The bug is that the caller also frees sock. Fix this by making every error path in pvcalls_new_active_socket() release the sock, and don't

[xen-unstable test] 180511: tolerable FAIL

2023-05-03 Thread osstest service owner
flight 180511 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180511/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-livepatch 7 xen-install fail in 180506 pass in 180511 test-amd64-i386-xl-vhd 21

[PATCH v1] tools: convert bitfields to unsigned type

2023-05-03 Thread Olaf Hering
clang complains about the signed type: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] The potential ABI change in libxenvchan is covered by the Xen version based SONAME. The xenalyze change follows the existing

Re: [PATCH v2 05/13] tools/xenstore: make some write limit functions static

2023-05-03 Thread Juergen Gross
On 03.05.23 16:51, Andrew Cooper wrote: On 30/03/2023 9:50 am, Juergen Gross wrote: +static void wrl_xfer_credit(wrl_creditt *debit, wrl_creditt debit_floor, + wrl_creditt *credit, wrl_creditt credit_ceil) + /* +* Transfers zero or more credit from "debit

Re: [PATCH v2 05/13] tools/xenstore: make some write limit functions static

2023-05-03 Thread Andrew Cooper
On 30/03/2023 9:50 am, Juergen Gross wrote: > +static void wrl_xfer_credit(wrl_creditt *debit, wrl_creditt debit_floor, > + wrl_creditt *credit, wrl_creditt credit_ceil) > + /* > + * Transfers zero or more credit from "debit" to "credit". > + * Transfers as mu

Re: [PATCH v2 08/13] tools/xenstore: remove unused events list

2023-05-03 Thread Juergen Gross
On 03.05.23 15:08, Julien Grall wrote: Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: struct watch contains an used struct list_head events. Remove it. Typo: s/used/unused/? Yes. Signed-off-by: Juergen Gross Acked-by: Julien Grall Thanks, Juergen OpenPGP_0xB0DE9DD628B

Re: [PATCH v2 04/13] tools/xenstore: let hashtable_insert() return 0 on success

2023-05-03 Thread Juergen Gross
On 03.05.23 15:03, Julien Grall wrote: Hi, On 30/03/2023 09:50, Juergen Gross wrote: Today hashtable_insert() returns 0 in case of an error. Change that to let it return an errno value in the error case and 0 in case of success. I usually find such change risky because it makes the backport m

Re: [PATCH v2 02/13] tools/xenstore: do some cleanup of hashtable.c

2023-05-03 Thread Juergen Gross
On 03.05.23 14:55, Julien Grall wrote: Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: Do the following cleanups: - hashtable_count() isn't used at all, so remove it - replace prime_table_length and max_load_factor with macros - make hash() static - add a loadlimit() helper function - rem

Re: [PATCH v2 03/13] tools/xenstore: modify interface of create_hashtable()

2023-05-03 Thread Juergen Gross
On 03.05.23 14:59, Julien Grall wrote: Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: The minsize parameter of create_hashtable() doesn't have any real use case for Xenstore, so drop it. For better talloc_report_full() diagnostic output add a name parameter to create_hashtable(). Signe

Re: [PATCH v4 13/13] tools/xenstore: switch quota management to be table based

2023-05-03 Thread Juergen Gross
On 03.05.23 12:53, Julien Grall wrote: Hi Juergen, On 05/04/2023 08:03, Juergen Gross wrote: Instead of having individual quota variables switch to a table based approach like the generic accounting. Include all the related data in the same table and add accessor functions. This enables to use

Re: [PATCH v4 12/13] tools/xenstore: use generic accounting for remaining quotas

2023-05-03 Thread Juergen Gross
On 03.05.23 12:18, Julien Grall wrote: On 05/04/2023 08:03, Juergen Gross wrote: The maxrequests, node size, number of node permissions, and path length quota are a little bit special, as they are either active in transactions only (maxrequests), or they are just per item instead of count valu

[xen-unstable-smoke test] 180517: tolerable all pass - PUSHED

2023-05-03 Thread osstest service owner
flight 180517 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180517/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

dom0less vs xenstored setup race Was: xen | Failed pipeline for staging | 6a47ba2f

2023-05-03 Thread andrew . cooper3
Hello, After what seems like an unreasonable amount of debugging, we've tracked down exactly what is going wrong here. https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4219721944 Of note is the smoke.serial log around: io: IN 0x90fec250 d0 20230503 14:20:42 INTRODUCE (1 233

Re: [XEN v6 03/12] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t

2023-05-03 Thread Ayan Kumar Halder
On 03/05/2023 12:25, Julien Grall wrote: Hi Ayan, Hi Julien, On 28/04/2023 18:55, Ayan Kumar Halder wrote: dt_device_get_address() can accept uint64_t only for address and size. However, the address/size denotes physical addresses. Thus, they should be represented by 'paddr_t'. Consequently

Re: [PATCH v4 07/20] block/export: stop using is_external in vhost-user-blk server

2023-05-03 Thread Kevin Wolf
Am 03.05.2023 um 15:11 hat Stefan Hajnoczi geschrieben: > On Wed, May 03, 2023 at 10:08:46AM +0200, Kevin Wolf wrote: > > Am 02.05.2023 um 22:06 hat Stefan Hajnoczi geschrieben: > > > On Tue, May 02, 2023 at 06:04:24PM +0200, Kevin Wolf wrote: > > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi gesc

[PATCH] x86/pci/xen: populate MSI sysfs entries

2023-05-03 Thread Maximilian Heyne
Commit bf5e758f02fc ("genirq/msi: Simplify sysfs handling") reworked the creation of sysfs entries for MSI IRQs. The creation used to be in msi_domain_alloc_irqs_descs_locked after calling ops->domain_alloc_irqs. Then it moved into __msi_domain_alloc_irqs which is an implementation of domain_alloc_

Re: [PATCH v4 03/20] virtio-scsi: avoid race between unplug and transport event

2023-05-03 Thread Stefan Hajnoczi
On Wed, May 03, 2023 at 10:00:57AM +0200, Kevin Wolf wrote: > Am 02.05.2023 um 20:56 hat Stefan Hajnoczi geschrieben: > > On Tue, May 02, 2023 at 05:19:46PM +0200, Kevin Wolf wrote: > > > Am 25.04.2023 um 19:26 hat Stefan Hajnoczi geschrieben: > > > > Only report a transport reset event to the gues

Re: [PATCH v4 07/20] block/export: stop using is_external in vhost-user-blk server

2023-05-03 Thread Stefan Hajnoczi
On Wed, May 03, 2023 at 10:08:46AM +0200, Kevin Wolf wrote: > Am 02.05.2023 um 22:06 hat Stefan Hajnoczi geschrieben: > > On Tue, May 02, 2023 at 06:04:24PM +0200, Kevin Wolf wrote: > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > > > vhost-user activity must be suspended during bd

Re: [PATCH v2 08/13] tools/xenstore: remove unused events list

2023-05-03 Thread Julien Grall
Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: struct watch contains an used struct list_head events. Remove it. Typo: s/used/unused/? Signed-off-by: Juergen Gross Acked-by: Julien Grall Cheers, --- tools/xenstore/xenstored_watch.c | 5 - 1 file changed, 5 deletions(-)

Re: [PATCH v2 07/13] tools/xenstore: remove stale TODO file

2023-05-03 Thread Julien Grall
Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: The TODO file is not really helpful any longer. It contains only entries which no longer apply or it is unknown what they are meant for ("Dynamic/supply nodes", "Remove assumption that rename doesn't fail"). Signed-off-by: Juergen Gross A

Re: [PATCH v4 04/20] virtio-scsi: stop using aio_disable_external() during unplug

2023-05-03 Thread Stefan Hajnoczi
On Wed, May 03, 2023 at 01:40:49PM +0200, Kevin Wolf wrote: > Am 02.05.2023 um 22:02 hat Stefan Hajnoczi geschrieben: > > On Tue, May 02, 2023 at 03:19:52PM +0200, Kevin Wolf wrote: > > > Am 01.05.2023 um 17:09 hat Stefan Hajnoczi geschrieben: > > > > On Fri, Apr 28, 2023 at 04:22:55PM +0200, Kevin

Re: [PATCH v2 04/13] tools/xenstore: let hashtable_insert() return 0 on success

2023-05-03 Thread Julien Grall
Hi, On 30/03/2023 09:50, Juergen Gross wrote: Today hashtable_insert() returns 0 in case of an error. Change that to let it return an errno value in the error case and 0 in case of success. I usually find such change risky because it makes the backport more complex if we introduce a new call

Re: xen | Failed pipeline for staging | 0956aa22

2023-05-03 Thread Andrew Cooper
On 03/05/2023 1:59 pm, Jan Beulich wrote: > On 03.05.2023 14:37, GitLab wrote: >> >> Pipeline #855820014 has failed! >> >> Project: xen ( https://gitlab.com/xen-project/xen ) >> Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) >> >> Commit: 0956aa22 ( >> https://gitlab.com/

Re: [PATCH v2 03/13] tools/xenstore: modify interface of create_hashtable()

2023-05-03 Thread Julien Grall
Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: The minsize parameter of create_hashtable() doesn't have any real use case for Xenstore, so drop it. For better talloc_report_full() diagnostic output add a name parameter to create_hashtable(). Signed-off-by: Juergen Gross --- tools/xen

Re: xen | Failed pipeline for staging | 0956aa22

2023-05-03 Thread Jan Beulich
On 03.05.2023 14:37, GitLab wrote: > > > Pipeline #855820014 has failed! > > Project: xen ( https://gitlab.com/xen-project/xen ) > Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) > > Commit: 0956aa22 ( > https://gitlab.com/xen-project/xen/-/commit/0956aa2219745a198bb6a

Re: [PATCH v2 02/13] tools/xenstore: do some cleanup of hashtable.c

2023-05-03 Thread Julien Grall
Hi Juergen, On 30/03/2023 09:50, Juergen Gross wrote: Do the following cleanups: - hashtable_count() isn't used at all, so remove it - replace prime_table_length and max_load_factor with macros - make hash() static - add a loadlimit() helper function - remove the /***/ lines between functions -

Re: [PATCH v2 01/13] tools/xenstore: verify command line parameters better

2023-05-03 Thread Julien Grall
Hi Juergen, On 30/03/2023 09:49, Juergen Gross wrote: Add some more verification of command line parameters. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/tools/xenstore/xenstored_cor

Re: [XEN v6 11/12] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-05-03 Thread Julien Grall
On 03/05/2023 13:20, Julien Grall wrote: Hi, On 28/04/2023 18:55, Ayan Kumar Halder wrote: Restructure the code so that one can use pa_range_info[] table for both ARM_32 as well as ARM_64. Also, removed the hardcoding for P2M_ROOT_ORDER and P2M_ROOT_LEVEL as p2m_root_order can be obtained f

Re: [PATCH V3 2/2] libxl: fix matching of generic virtio device

2023-05-03 Thread Jan Beulich
On 03.05.2023 14:04, Julien Grall wrote: > On 03/05/2023 12:42, Jan Beulich wrote: >> On 06.04.2023 10:58, Viresh Kumar wrote: >>> The strings won't be an exact match, as we are only looking to match the >>> prefix here, i.e. "virtio,device". This is already done properly in >>> libxl_virtio.c file

Re: [XEN v6 11/12] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-05-03 Thread Julien Grall
Hi, On 28/04/2023 18:55, Ayan Kumar Halder wrote: Restructure the code so that one can use pa_range_info[] table for both ARM_32 as well as ARM_64. Also, removed the hardcoding for P2M_ROOT_ORDER and P2M_ROOT_LEVEL as p2m_root_order can be obtained from the pa_range_info[].root_order and p2m_ro

Re: [XEN v6 10/12] xen/arm: domain_build: Check if the address fits the range of physical address

2023-05-03 Thread Julien Grall
Hi, On 28/04/2023 18:55, Ayan Kumar Halder wrote: handle_pci_range() and map_range_to_domain() take addr and len as uint64_t parameters. Then frame numbers are obtained from addr and len by right shifting with PAGE_SHIFT. The frame numbers are expressed using unsigned long. Now if 64-bit >> PAG

Re: [XEN v6 08/12] xen: dt: Replace u64 with uint64_t as the callback function parameters for dt_for_each_range()

2023-05-03 Thread Julien Grall
Hi, On 28/04/2023 18:55, Ayan Kumar Halder wrote: In the callback functions invoked by dt_for_each_range() ie handle_pci_range(), map_range_to_domain(), 'u64' should be replaced with 'uint64_t' as the data type for the parameters. Please explain why this needs to be replaced. I.e. Xen coding s

Re: [PATCH V3 2/2] libxl: fix matching of generic virtio device

2023-05-03 Thread Julien Grall
Hi Jan, On 03/05/2023 12:42, Jan Beulich wrote: On 06.04.2023 10:58, Viresh Kumar wrote: The strings won't be an exact match, as we are only looking to match the prefix here, i.e. "virtio,device". This is already done properly in libxl_virtio.c file, lets do the same here too. Fixes: 43ba5202e

Re: [XEN v6 05/12] xen/arm: Introduce choice to enable 64/32 bit physical addressing

2023-05-03 Thread Julien Grall
Hi Ayan, On 28/04/2023 18:55, Ayan Kumar Halder wrote: diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..192582b61d 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -19,13 +19,41 @@ config ARM select HAS_PMAP select IOMMU_FORCE_PT_SHARE

Re: [PATCH V3 2/2] libxl: fix matching of generic virtio device

2023-05-03 Thread Jan Beulich
On 06.04.2023 10:58, Viresh Kumar wrote: > The strings won't be an exact match, as we are only looking to match the > prefix here, i.e. "virtio,device". This is already done properly in > libxl_virtio.c file, lets do the same here too. > > Fixes: 43ba5202e2ee ("libxl: add support for generic virti

Re: [PATCH v4 04/20] virtio-scsi: stop using aio_disable_external() during unplug

2023-05-03 Thread Kevin Wolf
Am 02.05.2023 um 22:02 hat Stefan Hajnoczi geschrieben: > On Tue, May 02, 2023 at 03:19:52PM +0200, Kevin Wolf wrote: > > Am 01.05.2023 um 17:09 hat Stefan Hajnoczi geschrieben: > > > On Fri, Apr 28, 2023 at 04:22:55PM +0200, Kevin Wolf wrote: > > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi gesc

Re: [XEN v6 03/12] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t

2023-05-03 Thread Julien Grall
Hi Ayan, On 28/04/2023 18:55, Ayan Kumar Halder wrote: dt_device_get_address() can accept uint64_t only for address and size. However, the address/size denotes physical addresses. Thus, they should be represented by 'paddr_t'. Consequently, we introduce a wrapper for dt_device_get_address() ie d

Re: [XEN v6 02/12] xen/arm: Typecast the DT values into paddr_t

2023-05-03 Thread Julien Grall
Hi, On 28/04/2023 18:55, Ayan Kumar Halder wrote: The DT functions (dt_read_number(), device_tree_get_reg(), fdt_get_mem_rsv()) currently accept or return 64-bit values. In future when we support 32-bit physical address, these DT functions are expected to accept/return 32-bit or 64-bit values (

Re: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds

2023-05-03 Thread Julien Grall
Hi Jan, On 03/05/2023 11:43, Jan Beulich wrote: On 04.04.2023 12:40, Jan Beulich wrote: On 04.04.2023 12:34, Andrew Cooper wrote: On 04/04/2023 10:20 am, Jan Beulich wrote: --- a/xen/arch/arm/include/asm/irq.h +++ b/xen/arch/arm/include/asm/irq.h @@ -52,7 +52,7 @@ struct arch_irq_desc {

Re: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds

2023-05-03 Thread Julien Grall
Hi Jan, On 04/04/2023 10:20, Jan Beulich wrote: PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no more than 32k pIRQ-s can be used by a domain on x86. Document this upper bound. To also enforce the limit, (ab)use both arch_hwdom_irqs() (changing its parameter type) and setup

Re: [PATCH v3] xen/vcpu: ignore VCPU_SSHOTTMR_future

2023-05-03 Thread Roger Pau Monné
On Wed, May 03, 2023 at 12:38:59PM +0200, Jan Beulich wrote: > On 19.04.2023 16:31, Roger Pau Monne wrote: > > The usage of VCPU_SSHOTTMR_future in Linux prior to 4.7 is bogus. > > When the hypervisor returns -ETIME (timeout in the past) Linux keeps > > retrying to setup the timer with a higher tim

Re: [PATCH v4 13/13] tools/xenstore: switch quota management to be table based

2023-05-03 Thread Julien Grall
Hi Juergen, On 05/04/2023 08:03, Juergen Gross wrote: Instead of having individual quota variables switch to a table based approach like the generic accounting. Include all the related data in the same table and add accessor functions. This enables to use the command line --quota parameter for

Re: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds

2023-05-03 Thread Jan Beulich
On 04.04.2023 12:40, Jan Beulich wrote: > On 04.04.2023 12:34, Andrew Cooper wrote: >> On 04/04/2023 10:20 am, Jan Beulich wrote: >>> --- a/xen/arch/arm/include/asm/irq.h >>> +++ b/xen/arch/arm/include/asm/irq.h >>> @@ -52,7 +52,7 @@ struct arch_irq_desc { >>> >>> extern const unsigned int nr_ir

Re: [PATCH v3] xen/vcpu: ignore VCPU_SSHOTTMR_future

2023-05-03 Thread Jan Beulich
On 19.04.2023 16:31, Roger Pau Monne wrote: > The usage of VCPU_SSHOTTMR_future in Linux prior to 4.7 is bogus. > When the hypervisor returns -ETIME (timeout in the past) Linux keeps > retrying to setup the timer with a higher timeout instead of > self-injecting a timer interrupt. > > On boxes wit

Ping: [PATCH v2 0/2] build: out-of-tree building adjustments

2023-05-03 Thread Jan Beulich
On 29.03.2023 12:20, Jan Beulich wrote: > The 1st patch is new, addressing comments on the previously standalone > (and unchanged) 2nd patch in a way different from what was discussed. > > 1: don't export building_out_of_srctree > 2: omit "source" symlink when building hypervisor in-tree Ping? T

Ping: [PATCH RFC] build: respect top-level .config also for out-of-tree hypervisor builds

2023-05-03 Thread Jan Beulich
On 15.03.2023 15:58, Jan Beulich wrote: > With in-tree builds Config.mk includes a .config file (if present) from > the top-level directory. Similar functionality is wanted with out-of- > tree builds. Yet the concept of "top-level directory" becomes fuzzy in > that case, because there is not really

Re: [PATCH RFC] SUPPORT.md: Make all security support explicit

2023-05-03 Thread George Dunlap
On Tue, May 2, 2023 at 12:19 PM Jan Beulich wrote: > On 28.04.2023 10:12, George Dunlap wrote: > > --- a/SUPPORT.md > > +++ b/SUPPORT.md > > @@ -17,6 +17,36 @@ for the definitions of the support status levels etc. > > Release Notes > > : https://wiki.xenproject.org/wiki/Xen_Project_X.YY_Release

Re: [PATCH v4 12/13] tools/xenstore: use generic accounting for remaining quotas

2023-05-03 Thread Julien Grall
On 05/04/2023 08:03, Juergen Gross wrote: The maxrequests, node size, number of node permissions, and path length quota are a little bit special, as they are either active in transactions only (maxrequests), or they are just per item instead of count values. Nevertheless being able to know the

Re: [PATCH v4 11/13] tools/xenstore: remember global and per domain max accounting values

2023-05-03 Thread Julien Grall
Hi Juergen, On 05/04/2023 08:03, Juergen Gross wrote: Add saving the maximum values of the different accounting data seen per domain and (for unprivileged domains) globally, and print those values via the xenstore-control quota command. Add a sub-command for resetting the global maximum values s

  1   2   >