On 10.08.23 16:59, Jan Beulich wrote:
Interestingly only Clang warns about the now bogus less-than-zero
comparison. Convert it to something that's more explicitly doing what
the comment says.
Fixes: 4086857cc159 ("x86: implement cpuid() in terms of cpuid_count()")
Signed-off-by: Jan Beulich
R
flight 182268 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182268/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
flight 182258 linux-5.4 real [real]
flight 182267 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/182258/
http://logs.test-lab.xenproject.org/osstest/logs/182267/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
t
On Thu, 10 Aug 2023, Luca Fancellu wrote:
> > On 10 Aug 2023, at 12:25, Michal Orzel wrote:
> >
> > Configuration for dom0less domUs is stored under /chosen/ nodes
> > present in the host device tree provided to Xen. All the properties and
> > sub nodes there are meant only for Xen. However, at t
On Thu, 10 Aug 2023, Luca Fancellu wrote:
> > On 10 Aug 2023, at 12:25, Michal Orzel wrote:
> >
> > When booting a dom0less domU without initial ramdisk, it was observed
> > that Xen still creates empty linux,initrd-{start,end} properties under
> > /chosen node. This is because in make_chosen_nod
On Thu, 10 Aug 2023, Luca Fancellu wrote:
> > On 10 Aug 2023, at 09:08, Jan Beulich wrote:
> >
> > On 09.08.2023 18:18, Luca Fancellu wrote:
> >>> On 9 Aug 2023, at 16:48, Jan Beulich wrote:
> >>> On 28.07.2023 10:11, Luca Fancellu wrote:
> --- /dev/null
> +++ b/xen/.clang-format
> >>>
flight 182247 linux-linus real [real]
flight 182265 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/182247/
http://logs.test-lab.xenproject.org/osstest/logs/182265/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run
On Wed, Aug 9, 2023 at 6:34 AM Julien Grall wrote:
>
> From: Julien Grall
>
> The function do_pci_remove() has two local variables 'domid' and
> 'domainid' containing the same value.
>
> Looking at the history, until 2cf3b50dcd8b ("libxl_pci: Use
> libxl__ao_device with pci_remove") the two varia
On Wed, Aug 9, 2023 at 6:34 AM Julien Grall wrote:
>
> From: Julien Grall
>
> Currently, libxl will grant IOMEM, I/O port and IRQ permissions when
> a PCI is attached (see pci_add_dm_done()) for all domain types. However,
> the permissions are only revoked for non-HVM domain (see do_pci_remove())
Xen vPCI only supports virtualizing the MSI and MSI-X capabilities, so all other
PCI capabilities should be hidden from a domU for now. We parse the physical PCI
capabilities linked list and add vPCI register handlers for the next elements,
inserting our own next value, thus presenting a modified l
Introduce a vPCI read helper function that returns a fixed value. This may be
used for RAZ registers, or registers whose value doesn't change. This helper
will be used in a subsequent patch.
Signed-off-by: Stewart Hildebrand
---
RFC: I'm not a fan of the (uintptr_t) cast, but without it I wasn't
This will be used in a subsequent patch.
Signed-off-by: Stewart Hildebrand
---
xen/drivers/vpci/vpci.c | 6 ++
xen/include/xen/vpci.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index d73fa7630237..acadba1fd6c5 100644
--- a/xen/dr
This small series enables vPCI to filter which PCI capabilites we expose to a
domU. This series adds vPCI register handlers within
xen/drivers/vpci/header.c:init_bars(), along with some supporting functions.
Note there are minor rebase conflicts with the in-progress vPCI series [1].
These conflict
On Thu, 10 Aug 2023, Julien Grall wrote:
> Hi,
>
> On 10/08/2023 10:29, Nicola Vetrini wrote:
> > The function in question has no callers and its removal has already
> > been proposed (and acked) as part of this larger series [1].
>
> This is useful information after for the reviewer to know it w
flight 182244 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182244/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182192
test-armhf-armhf-libvirt-qcow2 15 saveres
flight 182261 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182261/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
flight 182242 qemu-mainline real [real]
flight 182262 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/182242/
http://logs.test-lab.xenproject.org/osstest/logs/182262/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-ar
On 10.08.2023 17:40, Nicola Vetrini wrote:
> Address some occurrences of shadowing between the global
> variable 'e820' in 'xen/arch/x86/e820.c' and the function
> parameter name of 'e820_add_range'.
>
> Since the function is only ever called with the global variable
> as the actual parameter, so
Address some occurrences of shadowing between the global
variable 'e820' in 'xen/arch/x86/e820.c' and the function
parameter name of 'e820_add_range'.
Since the function is only ever called with the global variable
as the actual parameter, so there is no need to have it as a parameter
because both
On 09/08/2023 14:45, Jan Beulich wrote:
On 09.08.2023 09:55, Nicola Vetrini wrote:
The local variables 'irq_desc' shadow the homonymous global variable,
declared in 'xen/arch/x86/include/asm/irq.h', therefore they are
renamed
'irqd' for consistency.
Perhaps with "for consistency" dropped (or
There's nothing else that should need doing in order for guests to be
able to use these insns.
Signed-off-by: Jan Beulich
--- a/tools/misc/xen-cpuid.c
+++ b/tools/misc/xen-cpuid.c
@@ -220,6 +220,8 @@ static const char *const str_7d1[32] =
{
[ 4] = "avx-vnni-int8", [ 5] = "avx-ne-conv
Interestingly only Clang warns about the now bogus less-than-zero
comparison. Convert it to something that's more explicitly doing what
the comment says.
Fixes: 4086857cc159 ("x86: implement cpuid() in terms of cpuid_count()")
Signed-off-by: Jan Beulich
--- a/xen/arch/x86/cpu/intel_cacheinfo.c
+
> On 10 Aug 2023, at 12:25, Michal Orzel wrote:
>
> Configuration for dom0less domUs is stored under /chosen/ nodes
> present in the host device tree provided to Xen. All the properties and
> sub nodes there are meant only for Xen. However, at the moment we still
> copy them (except for module
> On 10 Aug 2023, at 12:25, Michal Orzel wrote:
>
> When booting a dom0less domU without initial ramdisk, it was observed
> that Xen still creates empty linux,initrd-{start,end} properties under
> /chosen node. This is because in make_chosen_node(), generation of initrd
> placeholders (later o
On 10.08.2023 12:43, Luca Fancellu wrote:
>> On 10 Aug 2023, at 10:07, Jan Beulich wrote:
>> On 09.08.2023 21:51, Stefano Stabellini wrote:
>>> Would the x86 maintainers be OK with it too? Of course further changes
>>> will be needed to make it useable on x86, but looking at the series from
>>> Ch
Michal Orzel (2):
xen/arm: Fix initrd placeholders generation in make_chosen_node()
xen/arm: Skip inclusion of domU nodes into hwdom dt /chosen node
xen/arch/arm/domain_build.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
2.25.1
Configuration for dom0less domUs is stored under /chosen/ nodes
present in the host device tree provided to Xen. All the properties and
sub nodes there are meant only for Xen. However, at the moment we still
copy them (except for modules that we skip) into hardware domain /chosen
node. Fix it by ad
When booting a dom0less domU without initial ramdisk, it was observed
that Xen still creates empty linux,initrd-{start,end} properties under
/chosen node. This is because in make_chosen_node(), generation of initrd
placeholders (later on filled with the real values) is protected with
a check for pr
flight 182241 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182241/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-i386-examine-uefi 6 xen-install fail like 182227
test-armhf-armhf-libvirt 16 save
Hi,
On 10/08/2023 10:29, Nicola Vetrini wrote:
The function in question has no callers and its removal has already
been proposed (and acked) as part of this larger series [1].
This is useful information after for the reviewer to know it was already
acked, but it is not really past commit. So
> On 10 Aug 2023, at 10:07, Jan Beulich wrote:
>
> On 09.08.2023 21:51, Stefano Stabellini wrote:
>> Would the x86 maintainers be OK with it too? Of course further changes
>> will be needed to make it useable on x86, but looking at the series from
>> Christopher, the two sets of internal inter
On 10/08/2023 11:29, Nicola Vetrini wrote:
The function in question has no callers and its removal has already
been proposed (and acked) as part of this larger series [1].
There have been further bugfixes to that function [2], but they do not
add
any caller, hence it can be removed.
[1]
https
The function in question has no callers and its removal has already
been proposed (and acked) as part of this larger series [1].
There have been further bugfixes to that function [2], but they do not add
any caller, hence it can be removed.
[1]
https://lore.kernel.org/xen-devel/1395766541-23979-2
On 09.08.2023 22:29, Andrew Cooper wrote:
> This popped up with insufficient time to organise a response before the
> pile of fixes yesterday.
>
> https://www.amd.com/en/resources/product-security/bulletin/amd-sb-7007.html
>
> Per my current understanding:
>
> * There is a single integer divider
On 09.08.2023 21:51, Stefano Stabellini wrote:
> Would the x86 maintainers be OK with it too? Of course further changes
> will be needed to make it useable on x86, but looking at the series from
> Christopher, the two sets of internal interfaces (dom0less/ARM and
> hyperlaunch/x86) are very much al
On 10.08.2023 10:39, Nicola Vetrini wrote:
> The functions and variables touched by this commit can be static,
> as they are only used within the same unit. This in turn addresses
> the absence of declarations that violates Rule 8.4.
>
> Signed-off-by: Nicola Vetrini
> Fixes: 741367e77d6c ("mce:
On 10.08.2023 10:39, Nicola Vetrini wrote:
> A declaration for 'get_sec' is added in 'xen/include/xen/time.h' to
> be available for every call site (in particular 'cper.h').
> This also resolves a violation of MISRA C:2012 Rule 8.4.
>
> Signed-off-by: Nicola Vetrini
> Fixes: c8cb30cfc87a ("mce: P
On 10.08.2023 10:39, Nicola Vetrini wrote:
> The function 'ioreq_server_max_frames' can be defined static,
> as its only uses are within the same file. This in turn avoids
> violating Rule 8.4 because no declaration is present.
Here and presumably in subsequent patches (I only looked at patch 2
fo
On 09.08.2023 22:54, Shawn Anastasio wrote:
> On 8/1/23 8:18 AM, Jan Beulich wrote:
>> On 29.07.2023 00:21, Shawn Anastasio wrote:
>>> --- /dev/null
>>> +++ b/xen/arch/ppc/include/asm/page.h
>>> @@ -0,0 +1,178 @@
>>> +#ifndef _ASM_PPC_PAGE_H
>>> +#define _ASM_PPC_PAGE_H
>>> +
>>> +#include
>>> +
>
Add a declaration for the variable 'init_ttbr' to resolve
the violation of Rule 8.4 present the relative source file 'mm.c'.
No functional changes.
Signed-off-by: Nicola Vetrini
Fixes: 4557c2292854 ("xen: arm: rewrite start of day page table and cpu bring
up")
Reviewed-by: Luca Fancellu
Review
The variable 'saved_cmdline' can be defined static,
as its only uses are within the same file. This in turn avoids
violating Rule 8.4 because no declaration is present.
Signed-off-by: Nicola Vetrini
Fixes: e6ee01ad24b6 ("xen/version: Drop compat/kernel.c")
Reviewed-by: Luca Fancellu
Reviewed-by:
The functions and variables touched by this commit can be static,
as they are only used within the same unit. This in turn addresses
the absence of declarations that violates Rule 8.4.
Signed-off-by: Nicola Vetrini
Fixes: 741367e77d6c ("mce: Clean-up mcheck_init handler")
Fixes: 45f57813f646 ("x8
'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow
the declaration of 'arch_get_xen_caps' to be visible when
defining the function.
The header 'xen/delay.h' is included in 'xen/arch/arm/time.c'
to allow the declaration of 'udelay' to be visible.
Signed-off-by: Nicola Vetrini
Fixes:
Include an additional header to make the declarations for
functions 'watchdog_*' visible prior to their definition in
the file, thereby resolving the violations of Rule 8.4.
No functional change.
Signed-off-by: Nicola Vetrini
Fixes: c8177e691f0f ("watchdog: Move watchdog from being x86 specific
The files touched by this series contain function or variable definitions with
no prior declaration visible, because it's inside an header that is not included
or it's not present anywhere. This is a risk in itself, but also violates
MISRA C:2012 Rule 8.4, which states the following:
"A compatible
The function 'ioreq_server_max_frames' can be defined static,
as its only uses are within the same file. This in turn avoids
violating Rule 8.4 because no declaration is present.
No functional change.
Signed-off-by: Nicola Vetrini
Fixes: 9244528955de ("xen/memory: Fix acquire_resource size seman
A declaration for 'get_sec' is added in 'xen/include/xen/time.h' to
be available for every call site (in particular 'cper.h').
This also resolves a violation of MISRA C:2012 Rule 8.4.
Signed-off-by: Nicola Vetrini
Fixes: c8cb30cfc87a ("mce: Provide ERST interface")
---
Changes in v2:
- Revised co
> On 10 Aug 2023, at 09:08, Jan Beulich wrote:
>
> On 09.08.2023 18:18, Luca Fancellu wrote:
>>> On 9 Aug 2023, at 16:48, Jan Beulich wrote:
>>> On 28.07.2023 10:11, Luca Fancellu wrote:
--- /dev/null
+++ b/xen/.clang-format
@@ -0,0 +1,693 @@
+# SPDX-License-Identifier: GPL
On 09.08.2023 22:15, Stefano Stabellini wrote:
> On Wed, 9 Aug 2023, Jan Beulich wrote:
>> On 09.08.2023 16:17, Nicola Vetrini wrote:
>>> On 09/08/2023 14:52, Jan Beulich wrote:
On 09.08.2023 13:02, Nicola Vetrini wrote:
> The additional header file makes the declaration for the function
>
On 10.08.2023 10:07, Henry Wang wrote:
>> On Aug 1, 2023, at 15:43, Jan Beulich wrote:
>> On 01.08.2023 05:44, Henry Wang wrote:
>>> From: Penny Zheng
>>>
>>> SMMU subsystem is only supported in MMU system, so we make it dependent
>>> on CONFIG_HAS_MMU.
>>>
>>> Signed-off-by: Penny Zheng
>>> Sig
On 09.08.2023 18:18, Luca Fancellu wrote:
>> On 9 Aug 2023, at 16:48, Jan Beulich wrote:
>> On 28.07.2023 10:11, Luca Fancellu wrote:
>>> --- /dev/null
>>> +++ b/xen/.clang-format
>>> @@ -0,0 +1,693 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only
>>> +#
>>> +# clang-format configuration file. Inte
Hi Jan,
> On Aug 1, 2023, at 15:43, Jan Beulich wrote:
>
> On 01.08.2023 05:44, Henry Wang wrote:
>> From: Penny Zheng
>>
>> SMMU subsystem is only supported in MMU system, so we make it dependent
>> on CONFIG_HAS_MMU.
>>
>> Signed-off-by: Penny Zheng
>> Signed-off-by: Wei Chen
>> Signed-of
Hi Julien,
> On Aug 9, 2023, at 20:28, Julien Grall wrote:
>
> Hi Henry,
>
> Title: NIT: It is more a fold rather than move.
You are correct, using “fold” here is more appropriate.
>
> On 01/08/2023 04:44, Henry Wang wrote:
>> For the
>> future MPU support work, the early UART mapping could
On 09.08.2023 20:41, Shawn Anastasio wrote:
> On 8/8/23 4:12 AM, Jan Beulich wrote:
>> On 03.08.2023 01:03, Shawn Anastasio wrote:
>>> @@ -15,4 +16,10 @@
>>>
>>> #define BUG_FN_REG r0
>>>
>>> +#define BUG() do { \
>>> +die(); \
>>> +} while (0)
>>
>> This looks like it's temporary. I think
Hi Julien,
> On Aug 9, 2023, at 20:19, Julien Grall wrote:
>
> Hi Henry,
>
> On 01/08/2023 04:44, Henry Wang wrote:
>> From: Wei Chen
>> Xen defines some global configuration macros for Arm in config.h.
>> However there are some address layout related definitions that are
>> defined for MMU sy
Hi Stefano,
On 10/08/2023 03:18, Stefano Stabellini wrote:
>
>
> From: Stefano Stabellini
>
> Signed-off-by: Stefano Stabellini
Reviewed-by: Michal Orzel
~Michal
Hi Stefano,
On 10/08/2023 03:18, Stefano Stabellini wrote:
>
>
> From: Stefano Stabellini
>
> Alpine 3.12 is EOL. Also update the containerize script.
>
> Signed-off-by: Stefano Stabellini
You could mention the python upgrade in alpine test artifacts.
Reviewed-by: Michal Orzel
~Michal
On 09/08/2023 11:15, Jan Beulich wrote:
On 09.08.2023 10:58, Simone Ballarin wrote:
Il giorno mer 26 lug 2023 alle ore 13:04 Simone Ballarin <
simone.balla...@bugseng.com> ha scritto:
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
headline
states:
"A 'u' or 'U' suffix shal
Making virt_to_pfn() a static inline taking a strongly typed
(const void *) makes the contract of a passing a pointer of that
type to the function explicit and exposes any misuse of the
macro virt_to_pfn() acting polymorphic and accepting many types
such as (void *), (unitptr_t) or (unsigned long)
Hi Julien,
> On Aug 9, 2023, at 20:12, Julien Grall wrote:
>
> Hi Henry,
>
> On 01/08/2023 04:44, Henry Wang wrote:
>> From: Wei Chen
>> We want to reuse head.S for MPU systems, but there are some
>> code are implemented for MMU systems only. We will move such
>> code to another MMU specific f
60 matches
Mail list logo
