Hi Julien, > On Aug 9, 2023, at 20:19, Julien Grall <jul...@xen.org> wrote: > > Hi Henry, > > On 01/08/2023 04:44, Henry Wang wrote: >> From: Wei Chen <wei.c...@arm.com> >> Xen defines some global configuration macros for Arm in config.h. >> However there are some address layout related definitions that are >> defined for MMU systems only, and these definitions could not be >> used by MPU systems. Adding ifdefs with CONFIG_HAS_MPU to gate these > > You haven't yet introduced HAS_MPU. So I would suggest to write: 'Adding > ifdefs to differentiate the MPU from MMU layout will result in a ...'. > >> definitions will result in a messy and hard-to-read/maintain code. >> So move MMU related definitions to a new file, i.e. mmu/layout.h to >> avoid spreading "#ifdef" everywhere. > > AFAICT, you are moving all memory layout definition in a separate file. So I > would say it explicitely rather than using "MMU related definitions". > >> Signed-off-by: Wei Chen <wei.c...@arm.com> >> Signed-off-by: Penny Zheng <penny.zh...@arm.com> >> Signed-off-by: Henry Wang <henry.w...@arm.com> > > With the comments addressed: > > Reviewed-by: Julien Grall <jgr...@amazon.com>
Thanks, I’ve taken this tag with above two comments fixed. Kind regards, Henry > > Cheers, > > -- > Julien Grall
