Re: [PATCH v2 1/8] xen/common: Add missing #includes treewide

2023-08-23 Thread Jan Beulich
On 23.08.2023 22:07, Shawn Anastasio wrote: > A few files treewide depend on defininitions in headers that they > don't include. This works when arch headers end up including the > required headers by chance, but broke on ppc64 with only minimal/stub > arch headers. > > Signed-off-by: Shawn

[linux-linus test] 182452: regressions - trouble: fail/pass/starved

2023-08-23 Thread osstest service owner
flight 182452 linux-linus real [real] flight 182496 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182452/ http://logs.test-lab.xenproject.org/osstest/logs/182496/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[xen-unstable-smoke test] 182497: tolerable all pass - PUSHED

2023-08-23 Thread osstest service owner
flight 182497 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182497/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

RE: [PATCH] x86/vmx: Revert "x86/VMX: sanitize rIP before re-entering guest"

2023-08-23 Thread Tian, Kevin
> From: Andrew Cooper > Sent: Thursday, April 6, 2023 5:53 AM > > At the time of XSA-170, the x86 instruction emulator was genuinely broken. > It > would load arbitrary values into %rip and putting a check here probably was > the best stopgap security fix. It should have been reverted following

[PATCH v5 05/45] xenbus/backend: dynamically allocate the xen-backend shrinker

2023-08-23 Thread Qi Zheng
Use new APIs to dynamically allocate the xen-backend shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song CC: Juergen Gross CC: Stefano Stabellini CC: Oleksandr Tyshchenko CC: xen-devel@lists.xenproject.org --- drivers/xen/xenbus/xenbus_probe_backend.c | 18 +++--- 1 file

[libvirt test] 182426: tolerable all pass - PUSHED

2023-08-23 Thread osstest service owner
flight 182426 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182426/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182416 test-armhf-armhf-libvirt-qcow2 15

[xen-4.17-testing test] 182427: tolerable trouble: fail/pass/starved - PUSHED

2023-08-23 Thread osstest service owner
flight 182427 xen-4.17-testing real [real] flight 182494 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182427/ http://logs.test-lab.xenproject.org/osstest/logs/182494/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

[xen-unstable-smoke test] 182490: tolerable all pass - PUSHED

2023-08-23 Thread osstest service owner
flight 182490 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182490/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[PATCH] docs/misra: add rules 10.1 10.2 10.3 10.4

2023-08-23 Thread Stefano Stabellini
From: Stefano Stabellini 10.1 with several caveats, described in the notes. 10.3 and 10.4 as "aspirational" guidelines, as clarified in the notes. Signed-off-by: Stefano Stabellini --- docs/misra/rules.rst | 52 1 file changed, 52 insertions(+)

[PATCH v2] docs/misra: add rule 2.1 exceptions

2023-08-23 Thread Stefano Stabellini
From: Stefano Stabellini During the discussions that led to the acceptance of Rule 2.1, we decided on a few exceptions that were not properly recorded in rules.rst. Add them now. Signed-off-by: Stefano Stabellini Acked-by: Jan Beulich --- Note that safe.json and the codebase are not yet

Re: [PATCH] docs/misra: add rule 2.1 exceptions

2023-08-23 Thread Stefano Stabellini
On Wed, 23 Aug 2023, Jan Beulich wrote: > On 23.08.2023 02:24, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > During the discussions that led to the acceptable of Rule 2.1, we > > Nit (as before): "acceptance"? > > > decided on a few exceptions that were not properly recorded

Re: [PATCH] docs/misra: add rule 2.1 exceptions

2023-08-23 Thread Stefano Stabellini
On Wed, 23 Aug 2023, Julien Grall wrote: > Hi Stefano, > > On 23/08/2023 01:24, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > During the discussions that led to the acceptable of Rule 2.1, we > > decided on a few exceptions that were not properly recorded in > > rules.rst. Add

Re: [XEN][PATCH v9 00/19] dynamic node programming using overlay dtbo

2023-08-23 Thread Julien Grall
On 19/08/2023 01:28, Vikram Garhwal wrote: Hi, Hi Vikram, This patch series is for introducing dynamic programming i.e. add/remove the devices during run time. Using "xl dt_overlay" a device can be added/removed with dtbo. Do you have any pointer where one can find more details about the

Re: [XEN][PATCH v9 14/19] common/device_tree: Add rwlock for dt_host

2023-08-23 Thread Julien Grall
Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race Typo: I think you want to write 'functions' conditions, adding rwlock for browsing

Re: [XEN][PATCH v9 13/19] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h

2023-08-23 Thread Julien Grall
Hi, On 19/08/2023 01:28, Vikram Garhwal wrote: Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, we will need to add a rwlock to protect access to the dt_host. However, adding rwlock

Re: [PATCH v5 11/13] xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h}

2023-08-23 Thread Julien Grall
On 23/08/2023 04:47, Penny Zheng wrote: Hi Julien Hi Penny, On 2023/8/23 02:01, Julien Grall wrote: Hi Henry, On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng Current P2M implementation is designed for MMU system only. We move the MMU-specific codes into mmu/p2m.c, and only

Re: [PATCH v5 11/13] xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h}

2023-08-23 Thread Julien Grall
Hi, On 23/08/2023 19:08, Julien Grall wrote: With the code movement, global variable max_vmid is used in multiple files instead of a single file (and will be used in MPU P2M implementation), declare it in the header and remove the "static" of this variable. Add #ifdef CONFIG_HAS_MMU to

Re: [XEN PATCH] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-23 Thread Stefano Stabellini
On Wed, 23 Aug 2023, Julien Grall wrote: > Hi Nicola, > > On 23/08/2023 17:09, Nicola Vetrini wrote: > > On 23/08/2023 16:59, Julien Grall wrote: > > > Hi, > > > > > > On 23/08/2023 15:27, Nicola Vetrini wrote: > > > > Directive 4.3 prescribes the following: > > > > "Assembly language shall be

[PATCH v2 7/8] xen/ppc: Add stub function and symbol definitions

2023-08-23 Thread Shawn Anastasio
Add stub function and symbol definitions required by common code. If the file that the definition is supposed to be located in doesn't already exist yet, temporarily place its definition in the new stubs.c Signed-off-by: Shawn Anastasio --- v2: - Use BUG_ON("unimplemented") instead of BUG()

[PATCH v2 4/8] xen/ppc: Implement bitops.h

2023-08-23 Thread Shawn Anastasio
Implement bitops.h, based on Linux's implementation as of commit 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc. Though it is based off of Linux's implementation, this code diverges significantly in a number of ways: - Bitmap entries changed to 32-bit words to match X86 and Arm on Xen -

[PATCH v2 5/8] xen/ppc: Define minimal stub headers required for full build

2023-08-23 Thread Shawn Anastasio
Additionally, change inclusion of asm/ headers to corresponding xen/ ones throughout arch/ppc now that they work. Signed-off-by: Shawn Anastasio --- v2: - Use BUG_ON("unimplemented") instead of BUG() for unimplemented functions to make searching easier. - (altp2m.h) Drop Intel license in

[PATCH v2 8/8] xen/ppc: Enable full Xen build

2023-08-23 Thread Shawn Anastasio
Bring ppc's Makefile and arch.mk in line with arm and x86 to disable the build overrides and enable the full Xen build. Signed-off-by: Shawn Anastasio Reviewed-by: Jan Beulich --- xen/arch/ppc/Makefile | 16 +++- xen/arch/ppc/arch.mk | 3 --- 2 files changed, 15 insertions(+), 4

[PATCH v2 2/8] xen/ppc: Add public/arch-ppc.h

2023-08-23 Thread Shawn Anastasio
Signed-off-by: Shawn Anastasio --- v2: - Drop full license text in favor of SPDX header - Fix include guard naming (s/PPC64/PPC/g) - Use __aligned__ instead of aligned keyword - Fix macro naming conventions (use trailing underscore) - Drop unused MEMORY_PADDING, TRAP_INSTR definitions

[PATCH v2 0/8] ppc: Enable full Xen build

2023-08-23 Thread Shawn Anastasio
Hello all, This patch series performs all of the additions necessary to drop the build overrides for PPC and enable the full Xen build. Except in cases where compatibile implementations already exist (e.g. atomic.h and bitops.h), the newly added definitions are simple, unimplemented stubs that

[PATCH v2 6/8] xen/ppc: Define bug frames table in linker script

2023-08-23 Thread Shawn Anastasio
Define the bug frames table in ppc's linker script as is done by other architectures. Signed-off-by: Shawn Anastasio Acked-by: Jan Beulich --- v2: Add extra space to fix alignment of newly added lines xen/arch/ppc/xen.lds.S | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v2 3/8] xen/ppc: Implement atomic.h

2023-08-23 Thread Shawn Anastasio
Implement atomic.h for PPC, based off of the original Xen 3.2 implementation. Signed-off-by: Shawn Anastasio --- v2: - Fix style of asm block constraints to include required spaces - Fix macro local variable naming (use trailing underscore instead of leading) - Drop unnecessary parens

[PATCH v2 1/8] xen/common: Add missing #includes treewide

2023-08-23 Thread Shawn Anastasio
A few files treewide depend on defininitions in headers that they don't include. This works when arch headers end up including the required headers by chance, but broke on ppc64 with only minimal/stub arch headers. Signed-off-by: Shawn Anastasio --- v2: - (xen/domain.h) Drop include in favor

[xen-unstable-smoke test] 182488: tolerable all pass - PUSHED

2023-08-23 Thread osstest service owner
flight 182488 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182488/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH 8/9] xen/ppc: Add stub function and symbol definitions

2023-08-23 Thread Shawn Anastasio
On 8/8/23 5:27 AM, Jan Beulich wrote: > On 03.08.2023 01:03, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/mm-radix.c >> +++ b/xen/arch/ppc/mm-radix.c >> @@ -266,3 +266,47 @@ void __init setup_initial_pagetables(void) >> /* Turn on the MMU */ >> enable_mmu(); >> } >> + >> + > > Nit: No

Re: [PATCH v5 11/13] xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h}

2023-08-23 Thread Julien Grall
On 23/08/2023 02:41, Henry Wang wrote: Hi Julien, Hi Henry, On Aug 23, 2023, at 02:01, Julien Grall wrote: Hi Henry, On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng Current P2M implementation is designed for MMU system only. We move the MMU-specific codes into mmu/p2m.c, and

Re: [XEN PATCH] CI: Always move the bisect build log back

2023-08-23 Thread Andrew Cooper
On 23/08/2023 4:23 pm, Anthony PERARD wrote: > On failure of "build"-each-commit script, the next command that move > the log back into the build directory isn't executed. Fix that by > using "after_script" which is always executed even if the main > "script" fails. (We would still miss the log

Re: [PATCH v5 12/13] xen/arm: mmu: relocate copy_from_paddr() to setup.c

2023-08-23 Thread Julien Grall
Hi Stefano, On 23/08/2023 01:10, Stefano Stabellini wrote: On Tue, 22 Aug 2023, Julien Grall wrote: I also don't like the idea of having again a massive mm.c files. So maybe we need a split like: * File 1: Boot CPU0 MM bringup (mmu/setup.c) * File 2: Secondary CPUs MM bringup

Re: [PATCH v4 3/3] xen/ppc: Implement initial Radix MMU support

2023-08-23 Thread Shawn Anastasio
On 8/23/23 9:04 AM, Jan Beulich wrote: > On 23.08.2023 01:03, Shawn Anastasio wrote: >> Add code to construct early identity-mapped page tables as well as the >> required process and partition tables to enable the MMU. >> >> Signed-off-by: Shawn Anastasio > > Acked-by: Jan Beulich > with two

Re: [XEN PATCH] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-23 Thread Julien Grall
Hi Nicola, On 23/08/2023 17:09, Nicola Vetrini wrote: On 23/08/2023 16:59, Julien Grall wrote: Hi, On 23/08/2023 15:27, Nicola Vetrini wrote: Directive 4.3 prescribes the following: "Assembly language shall be encapsulated and isolated", on the grounds of improved readability and ease of

[xen-unstable-smoke test] 182461: regressions - FAIL

2023-08-23 Thread osstest service owner
flight 182461 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182461/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 6 xen-buildfail REGR. vs. 182436 Tests which

Re: [XEN PATCH] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-23 Thread Nicola Vetrini
On 23/08/2023 16:59, Julien Grall wrote: Hi, On 23/08/2023 15:27, Nicola Vetrini wrote: Directive 4.3 prescribes the following: "Assembly language shall be encapsulated and isolated", on the grounds of improved readability and ease of maintenance. The Directive is violated in this case by asm

[xen-unstable test] 182425: regressions - FAIL

2023-08-23 Thread osstest service owner
flight 182425 xen-unstable real [real] flight 182471 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182425/ http://logs.test-lab.xenproject.org/osstest/logs/182471/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[XEN PATCH] CI: Always move the bisect build log back

2023-08-23 Thread Anthony PERARD
On failure of "build"-each-commit script, the next command that move the log back into the build directory isn't executed. Fix that by using "after_script" which is always executed even if the main "script" fails. (We would still miss the log when the jobs times out.) Signed-off-by: Anthony

Re: [XEN PATCH] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-23 Thread Nicola Vetrini
On 23/08/2023 16:59, Julien Grall wrote: Hi, On 23/08/2023 15:27, Nicola Vetrini wrote: Directive 4.3 prescribes the following: "Assembly language shall be encapsulated and isolated", on the grounds of improved readability and ease of maintenance. The Directive is violated in this case by asm

Re: [XEN PATCH] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-23 Thread Julien Grall
Hi, On 23/08/2023 15:27, Nicola Vetrini wrote: Directive 4.3 prescribes the following: "Assembly language shall be encapsulated and isolated", on the grounds of improved readability and ease of maintenance. The Directive is violated in this case by asm code in between C code. A macro is the

[XEN PATCH] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-23 Thread Nicola Vetrini
Directive 4.3 prescribes the following: "Assembly language shall be encapsulated and isolated", on the grounds of improved readability and ease of maintenance. The Directive is violated in this case by asm code in between C code. A macro is the chosen encapsulation mechanism. No functional

Re: [XEN PATCH v2 2/3] vpci/msix: make 'get_slot' static

2023-08-23 Thread Roger Pau Monné
On Thu, Aug 17, 2023 at 02:39:27PM +0200, Nicola Vetrini wrote: > The function can become static since it's used only within this file. > This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence > of a declaration before the function definition. > > Fixes: b177892d2d0e

Re: [PATCH] x86/vmx: Revert "x86/VMX: sanitize rIP before re-entering guest"

2023-08-23 Thread Andrew Cooper
On 23/08/2023 2:31 pm, Roger Pau Monné wrote: > On Wed, Aug 23, 2023 at 12:56:48PM +0100, Andrew Cooper wrote: >> On 23/08/2023 12:15 pm, Roger Pau Monné wrote: >>> On Wed, Apr 05, 2023 at 10:52:45PM +0100, Andrew Cooper wrote: At the time of XSA-170, the x86 instruction emulator was

Re: [XEN PATCH v2 2/3] vpci/msix: make 'get_slot' static

2023-08-23 Thread Nicola Vetrini
On 17/08/2023 14:39, Nicola Vetrini wrote: The function can become static since it's used only within this file. This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence of a declaration before the function definition. Fixes: b177892d2d0e ("vpci/msix: handle accesses

Re: [PATCH] libxc: remove / adjust xc_get_cpufreq_para()'s BUILD_BUG_ON()s

2023-08-23 Thread Juergen Gross
On 23.08.23 16:07, Jan Beulich wrote: On 23.08.2023 15:57, Jason Andryuk wrote: On Wed, Aug 23, 2023 at 9:47 AM Jan Beulich wrote: @@ -316,6 +277,22 @@ int xc_get_cpufreq_para(xc_interface *xc BUILD_BUG_ON(sizeof(((struct xc_get_cpufreq_para *)0)->u) !=

Re: [PATCH] libxc: remove / adjust xc_get_cpufreq_para()'s BUILD_BUG_ON()s

2023-08-23 Thread Jan Beulich
On 23.08.2023 15:57, Jason Andryuk wrote: > On Wed, Aug 23, 2023 at 9:47 AM Jan Beulich wrote: >> @@ -316,6 +277,22 @@ int xc_get_cpufreq_para(xc_interface *xc >> BUILD_BUG_ON(sizeof(((struct xc_get_cpufreq_para *)0)->u) != >> sizeof(((struct xen_get_cpufreq_para

Re: [PATCH v4 3/3] xen/ppc: Implement initial Radix MMU support

2023-08-23 Thread Jan Beulich
On 23.08.2023 01:03, Shawn Anastasio wrote: > Add code to construct early identity-mapped page tables as well as the > required process and partition tables to enable the MMU. > > Signed-off-by: Shawn Anastasio Acked-by: Jan Beulich with two nits, which I'll be happy to take care of while

Re: [PATCH] libxc: remove / adjust xc_get_cpufreq_para()'s BUILD_BUG_ON()s

2023-08-23 Thread Jason Andryuk
On Wed, Aug 23, 2023 at 9:47 AM Jan Beulich wrote: > > The full structures cannot match in layout, as soon as a 32-bit tool > stack build comes into play. But it also doesn't need to; the part of > the layouts that needs to match is merely the union that we memcpy() > from the sysctl structure to

Re: [PATCH] libxl/CPUID: drop two more feature flag table entries

2023-08-23 Thread Jan Beulich
On 23.08.2023 15:45, Anthony PERARD wrote: > On Wed, Aug 23, 2023 at 09:21:26AM +0200, Jan Beulich wrote: >> Two entries were left in place by d638fe233cb3 ("libxl: use the cpuid >> feature names from cpufeatureset.h"), despite matching the generated >> names. >> >> Signed-off-by: Jan Beulich >

Re: [PATCH] libxc: remove / adjust xc_get_cpufreq_para()'s BUILD_BUG_ON()s

2023-08-23 Thread Juergen Gross
On 23.08.23 15:47, Jan Beulich wrote: The full structures cannot match in layout, as soon as a 32-bit tool stack build comes into play. But it also doesn't need to; the part of the layouts that needs to match is merely the union that we memcpy() from the sysctl structure to the xc one. Keep (in

[PATCH] libxc: remove / adjust xc_get_cpufreq_para()'s BUILD_BUG_ON()s

2023-08-23 Thread Jan Beulich
The full structures cannot match in layout, as soon as a 32-bit tool stack build comes into play. But it also doesn't need to; the part of the layouts that needs to match is merely the union that we memcpy() from the sysctl structure to the xc one. Keep (in adjusted form) only the relevant ones.

Re: [PATCH] stubdom: remove openssl related clean actions

2023-08-23 Thread Anthony PERARD
On Wed, Aug 23, 2023 at 10:32:19AM +0200, Juergen Gross wrote: > When introducing polarssl into stubdom building the clean targets of > stubdom/Makefile gained actions for removing openssl directories and > files additional to polarssl ones. > > As those openssl files are never downloaded or

Re: [PATCH] libxl/CPUID: drop two more feature flag table entries

2023-08-23 Thread Anthony PERARD
On Wed, Aug 23, 2023 at 09:21:26AM +0200, Jan Beulich wrote: > Two entries were left in place by d638fe233cb3 ("libxl: use the cpuid > feature names from cpufeatureset.h"), despite matching the generated > names. > > Signed-off-by: Jan Beulich Acked-by: Anthony PERARD > --- > Permitting

Re: [PATCH] x86/vmx: Revert "x86/VMX: sanitize rIP before re-entering guest"

2023-08-23 Thread Roger Pau Monné
On Wed, Aug 23, 2023 at 12:56:48PM +0100, Andrew Cooper wrote: > On 23/08/2023 12:15 pm, Roger Pau Monné wrote: > > On Wed, Apr 05, 2023 at 10:52:45PM +0100, Andrew Cooper wrote: > >> At the time of XSA-170, the x86 instruction emulator was genuinely broken. > >> It > >> would load arbitrary

Re: [PATCH v8 04/15] xen/sysctl: Nest cpufreq scaling options

2023-08-23 Thread Jan Beulich
On 07.08.2023 20:51, Jason Andryuk wrote: > --- a/tools/libs/ctrl/xc_pm.c > +++ b/tools/libs/ctrl/xc_pm.c > @@ -245,6 +245,45 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, > sys_para->freq_num = user_para->freq_num; > sys_para->gov_num = user_para->gov_num; > > +/*

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

2023-08-23 Thread Jan Beulich
On 23.08.2023 11:21, Andrew Cooper wrote: > On 07/08/2023 3:18 pm, Jan Beulich wrote: >> On 07.08.2023 16:04, Andrew Cooper wrote: >>> On 07/08/2023 2:17 pm, Jan Beulich wrote: On 07.08.2023 14:55, Simon Gaiser wrote: > Jan Beulich: >> On 07.08.2023 11:38, Simon Gaiser wrote: >>>

[xen-unstable-smoke test] 182455: regressions - FAIL

2023-08-23 Thread osstest service owner
flight 182455 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182455/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 6 xen-buildfail REGR. vs. 182436 Tests which

Re: [PATCH] x86/vmx: Revert "x86/VMX: sanitize rIP before re-entering guest"

2023-08-23 Thread Andrew Cooper
On 23/08/2023 12:15 pm, Roger Pau Monné wrote: > On Wed, Apr 05, 2023 at 10:52:45PM +0100, Andrew Cooper wrote: >> At the time of XSA-170, the x86 instruction emulator was genuinely broken. >> It >> would load arbitrary values into %rip and putting a check here probably was >> the best stopgap

Re: [xen-4.17-testing test] 182423: regressions - FAIL

2023-08-23 Thread Anthony PERARD
On Wed, Aug 23, 2023 at 8:05 AM Jan Beulich wrote: > > On 23.08.2023 06:32, osstest service owner wrote: > > flight 182423 xen-4.17-testing real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/182423/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocking, > >

Re: [PATCH] x86/vmx: Revert "x86/VMX: sanitize rIP before re-entering guest"

2023-08-23 Thread Roger Pau Monné
On Wed, Apr 05, 2023 at 10:52:45PM +0100, Andrew Cooper wrote: > At the time of XSA-170, the x86 instruction emulator was genuinely broken. It > would load arbitrary values into %rip and putting a check here probably was > the best stopgap security fix. It should have been reverted following c/s

[PATCH v3 0/29] block: Make blkdev_get_by_*() return handle

2023-08-23 Thread Jan Kara
Hello, this is a v3 of the patch series which implements the idea of blkdev_get_by_*() calls returning bdev_handle which is then passed to blkdev_put() [1]. This makes the get and put calls for bdevs more obviously matching and allows us to propagate context from get to put without having to

[PATCH 07/29] xen/blkback: Convert to bdev_open_by_dev()

2023-08-23 Thread Jan Kara
Convert xen/blkback to use bdev_open_by_dev() and pass the handle around. CC: xen-devel@lists.xenproject.org Acked-by: Christoph Hellwig Signed-off-by: Jan Kara --- drivers/block/xen-blkback/blkback.c | 4 +-- drivers/block/xen-blkback/common.h | 4 +-- drivers/block/xen-blkback/xenbus.c |

[xen-unstable-smoke test] 182436: tolerable all pass - PUSHED

2023-08-23 Thread osstest service owner
flight 182436 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182436/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[linux-linus test] 182424: tolerable FAIL - PUSHED

2023-08-23 Thread osstest service owner
flight 182424 linux-linus real [real] flight 182442 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182424/ http://logs.test-lab.xenproject.org/osstest/logs/182442/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

2023-08-23 Thread Andrew Cooper
On 07/08/2023 3:45 pm, Simon Gaiser wrote: > Andrew Cooper: >> On 07/08/2023 10:38 am, Simon Gaiser wrote: >>> It seems some firmwares put dummy entries in the ACPI MADT table for non >>> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >>> 0xff. Linux already has code to

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

2023-08-23 Thread Andrew Cooper
On 07/08/2023 3:18 pm, Jan Beulich wrote: > On 07.08.2023 16:04, Andrew Cooper wrote: >> On 07/08/2023 2:17 pm, Jan Beulich wrote: >>> On 07.08.2023 14:55, Simon Gaiser wrote: Jan Beulich: > On 07.08.2023 11:38, Simon Gaiser wrote: >> It seems some firmwares put dummy entries in the

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

2023-08-23 Thread Roger Pau Monné
On Mon, Aug 07, 2023 at 03:17:18PM +0200, Jan Beulich wrote: > On 07.08.2023 14:55, Simon Gaiser wrote: > > Jan Beulich: > >> On 07.08.2023 11:38, Simon Gaiser wrote: > >>> It seems some firmwares put dummy entries in the ACPI MADT table for non > >>> existing processors. On my NUC11TNHi5 those

Re: [PATCH] docs/misra: add rule 2.1 exceptions

2023-08-23 Thread Julien Grall
Hi Stefano, On 23/08/2023 01:24, Stefano Stabellini wrote: From: Stefano Stabellini During the discussions that led to the acceptable of Rule 2.1, we decided on a few exceptions that were not properly recorded in rules.rst. Add them now. Signed-off-by: Stefano Stabellini ---

Re: [RFC XEN PATCH 6/6] tools/libs/light: pci: translate irq to gsi

2023-08-23 Thread Roger Pau Monné
On Mon, Jul 31, 2023 at 04:40:35PM +, Chen, Jiqian wrote: > Hi, > > On 2023/3/18 04:55, Stefano Stabellini wrote: > > On Fri, 17 Mar 2023, Roger Pau Monné wrote: > >> On Fri, Mar 17, 2023 at 11:15:37AM -0700, Stefano Stabellini wrote: > >>> On Fri, 17 Mar 2023, Roger Pau Monné wrote: >

[PATCH] build: simplify clean handling of extras directory

2023-08-23 Thread Juergen Gross
The extras directory is used only as a download target for Mini-OS sources. Instead of special handling extras/mini-os* in .gitignore and the clean targets, just use extras for that purpose. So add "extras" to .gitignore and remove it when doing a "make distclean". Signed-off-by: Juergen Gross

[PATCH] stubdom: remove openssl related clean actions

2023-08-23 Thread Juergen Gross
When introducing polarssl into stubdom building the clean targets of stubdom/Makefile gained actions for removing openssl directories and files additional to polarssl ones. As those openssl files are never downloaded or created during build, the related actions can be dropped. Fixes:

Re: [XEN PATCH 00/13] xen: address violations of MISRA C:2012 Rule 7.3

2023-08-23 Thread Jan Beulich
On 03.08.2023 12:22, Simone Ballarin wrote: > This series aims to address some violations ofMISRA C:2012 Rule 7.3: > "The lowercase character 'l' shall not be used in a literal suffix". > > This patch replaces "l" suffixes with "L", to comply with the rule. > If the "u" suffix is used near "L",

Re: [XEN PATCH v2] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3

2023-08-23 Thread Jan Beulich
On 23.08.2023 09:28, Andrew Cooper wrote: > On 23/08/2023 8:04 am, Federico Serafini wrote: >> Make function declarations and definitions consistent to address >> violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or >> function shall use the same names and type qualifiers"). >>

Re: [XEN PATCH v2] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3

2023-08-23 Thread Andrew Cooper
On 23/08/2023 8:04 am, Federico Serafini wrote: > Make function declarations and definitions consistent to address > violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or > function shall use the same names and type qualifiers"). > > No functional change. > > Signed-off-by:

[PATCH] libxl/CPUID: drop two more feature flag table entries

2023-08-23 Thread Jan Beulich
Two entries were left in place by d638fe233cb3 ("libxl: use the cpuid feature names from cpufeatureset.h"), despite matching the generated names. Signed-off-by: Jan Beulich --- Permitting "psn", "ia64, "cntxid", and "perfctr_*" when the hypervisor doesn't even know of the bits (perhaps wrongly

Re: [XEN PATCH v2] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3

2023-08-23 Thread Jan Beulich
On 23.08.2023 09:04, Federico Serafini wrote: > Make function declarations and definitions consistent to address > violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or > function shall use the same names and type qualifiers"). > > No functional change. > > Signed-off-by:

Re: [xen-4.17-testing test] 182423: regressions - FAIL

2023-08-23 Thread Jan Beulich
On 23.08.2023 06:32, osstest service owner wrote: > flight 182423 xen-4.17-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/182423/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-amd64-xsm

[XEN PATCH v2] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3

2023-08-23 Thread Federico Serafini
Make function declarations and definitions consistent to address violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional change. Signed-off-by: Federico Serafini --- Changes in v2: - change

Re: [PATCH] docs/misra: add rule 2.1 exceptions

2023-08-23 Thread Jan Beulich
On 23.08.2023 02:24, Stefano Stabellini wrote: > From: Stefano Stabellini > > During the discussions that led to the acceptable of Rule 2.1, we Nit (as before): "acceptance"? > decided on a few exceptions that were not properly recorded in > rules.rst. Add them now. > > Signed-off-by: Stefano

Re: [PATCH v4 2/3] xen/ppc: Relocate kernel to physical address 0 on boot

2023-08-23 Thread Jan Beulich
On 23.08.2023 01:03, Shawn Anastasio wrote: > Introduce a small assembly loop in `start` to copy the kernel to > physical address 0 before continuing. This ensures that the physical > address lines up with XEN_VIRT_START (0xc000) and allows us > to identity map the kernel when the MMU

Re: [PATCH v4 1/3] xen/ppc: Bump minimum target ISA to 3.0 (POWER9)

2023-08-23 Thread Jan Beulich
On 23.08.2023 01:03, Shawn Anastasio wrote: > In preparation for implementing ISA3+ Radix MMU support, drop ISA 2.07B > from the supported ISA list to avoid having a non-working > configuration in tree. It can be re-added at a later point when Hash > MMU support is added. > > Signed-off-by: Shawn

Re: [PATCH] docs/misra: add exceptions to rules

2023-08-23 Thread Jan Beulich
On 23.08.2023 02:23, Stefano Stabellini wrote: > On Tue, 22 Aug 2023, Jan Beulich wrote: >> On 22.08.2023 03:40, Stefano Stabellini wrote: >>> If we only mention BUG, we are basically saying that as a general rule >>> only BUG is an exception. Then we have a longer more detailed list for >>>

Re: [PATCH] docs/misra: add exceptions to rules

2023-08-23 Thread Jan Beulich
On 23.08.2023 02:19, Stefano Stabellini wrote: > On Tue, 22 Aug 2023, Jan Beulich wrote: >> (re-adding xen-devel@) >> >> On 22.08.2023 17:09, Nicola Vetrini wrote: >>> >> + - Switch with a controlling value incompatible with labeled >> + statements > > What does

Re: [PATCH v3 2/4] xen/pci: convert pci_find_*cap* to pci_sbdf_t

2023-08-23 Thread Jan Beulich
On 23.08.2023 05:03, Stewart Hildebrand wrote: > On 8/22/23 08:53, Jan Beulich wrote: >> On 22.08.2023 03:29, Stewart Hildebrand wrote: >>> --- a/xen/include/xen/pci.h >>> +++ b/xen/include/xen/pci.h >>> @@ -193,11 +193,10 @@ int pci_mmcfg_read(unsigned int seg, unsigned int bus, >>>

Re: [PATCH] xen/xenbus: Avoid a lockdep warning when adding a watch

2023-08-23 Thread Juergen Gross
On 07.06.23 14:36, Petr Pavlu wrote: The following lockdep warning appears during boot on a Xen dom0 system: [ 96.388794] == [ 96.388797] WARNING: possible circular locking dependency detected [ 96.388799] 6.4.0-rc5-default+ #8 Tainted:

Re: [PATCH V5] xen: privcmd: Add support for irqfd

2023-08-23 Thread Juergen Gross
On 22.08.23 11:45, Viresh Kumar wrote: Xen provides support for injecting interrupts to the guests via the HYPERVISOR_dm_op() hypercall. The same is used by the Virtio based device backend implementations, in an inefficient manner currently. Generally, the Virtio backends are implemented to