Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-09-29 Thread Luca Fancellu
Hi Stefano, > On 29 Sep 2023, at 01:33, Stefano Stabellini wrote: > > On Wed, 27 Sep 2023, Luca Fancellu wrote: >> Currently the dom0less feature code is mostly inside domain_build.c >> and setup.c, it is a feature that may not be useful to everyone so >> put the code in a different compilation

Re: Misra rule 10.3 violations report script

2023-09-29 Thread Luca Fancellu
> Hi Luca, Hi Ayan, >> >> In the last MISRA meeting Stefano told me about the Rule 10.3 and that we >> have a lot of violations, >> but GCC has a way to list them as written in rules.rst. >> >> So the issue was just that we have a lot of violations, most of them coming >> from headers and th

Re: [PATCH] bitmap: fix n__ signess

2023-09-29 Thread Julien Grall
Hi Stefano, On 29/09/2023 00:19, Stefano Stabellini wrote: All callers of the bitmap_switch macro (which are all within bitmap.h) pass an int as first parameter. Do not assign it to an unsigned int potentially introducing errors. Signed-off-by: Stefano Stabellini --- We could also have gone t

Re: [PATCH] cpumask: fix integer type in cpumask_first

2023-09-29 Thread Julien Grall
Hi Stefano, On 29/09/2023 00:32, Stefano Stabellini wrote: nr_cpu_ids is unsigned int, but find_first_bit returns unsigned long (at least on arm). find_* are meant to be used by common code. So I think the first step is to correct the return type so it is consistent across all architectures.

Re: Misra rule 10.3 violations report script

2023-09-29 Thread Luca Fancellu
> On 29 Sep 2023, at 00:20, Stefano Stabellini wrote: > > On Thu, 28 Sep 2023, Luca Fancellu wrote: >> Hi all, >> >> In the last MISRA meeting Stefano told me about the Rule 10.3 and that we >> have a lot of violations, >> but GCC has a way to list them as written in rules.rst. >> >> So the

Re: [PATCH] xen/arm: Validate generic timer frequency

2023-09-29 Thread Julien Grall
Hi Michal, On 28/09/2023 13:34, Michal Orzel wrote: Generic timer dt node property "clock-frequency" (refer Linux dt binding Documentation/devicetree/bindings/timer/arm,arch_timer.yaml) is used to override the incorrect value set by firmware in CNTFRQ_EL0. If the value of this property is 0 (i.e

Re: [XEN PATCH v7 3/4] x86/include: address violations of MISRA C:2012 Rule 7.2

2023-09-29 Thread Simone Ballarin
On 29/09/23 00:58, Stefano Stabellini wrote: On Thu, 28 Sep 2023, Simone Ballarin wrote: The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". Add the 'U' suff

Re: [XEN PATCH v2 00/10] address violations of MISRA C:2012 Directive 4.10

2023-09-29 Thread Simone Ballarin
On 29/09/23 00:24, Stefano Stabellini wrote: On Thu, 28 Sep 2023, Jan Beulich wrote: On 28.09.2023 15:17, Simone Ballarin wrote: On 28/09/23 14:51, Jan Beulich wrote: On 28.09.2023 14:46, Simone Ballarin wrote: On 13/09/23 10:02, Jan Beulich wrote: On 12.09.2023 11:36, Simone Ballarin wrote:

[PATCH 2/2] Update Xen version to 4.18-rc

2023-09-29 Thread Julien Grall
From: Julien Grall Signed-off-by: Julien Grall --- README | 16 SUPPORT.md | 2 +- xen/Makefile | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/README b/README index a491c8dce55b..f45e1ef1cdca 100644 --- a/README +++ b/README @@ -1,11 +1,11 @@

[PATCH 0/2] Prepare the tree for Xen 4.18 RC1

2023-09-29 Thread Julien Grall
From: Julien Grall Hi all, This small series is to prepare the tree for Xen 4.18 RC1. Cheers, Julien Grall (2): Config.mk pin QEMU_UPSTREAM_REVISION (prep for Xen 4.18 RC1) Update Xen version to 4.18-rc Config.mk| 2 +- README | 16 SUPPORT.md | 2 +- xen/M

[PATCH 1/2] Config.mk pin QEMU_UPSTREAM_REVISION (prep for Xen 4.18 RC1)

2023-09-29 Thread Julien Grall
From: Julien Grall Signed-off-by: Julien Grall --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index 29c29f8d7fb9..000cf06d418f 100644 --- a/Config.mk +++ b/Config.mk @@ -223,7 +223,7 @@ OVMF_UPSTREAM_URL ?= https://xenbits.xen.org/git-ht

Re: [PATCH 2/2] Update Xen version to 4.18-rc

2023-09-29 Thread Juergen Gross
On 29.09.23 09:58, Julien Grall wrote: From: Julien Grall Signed-off-by: Julien Grall --- README | 16 SUPPORT.md | 2 +- xen/Makefile | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/README b/README index a491c8dce55b..f45e1ef1cdca 10064

Re: [PATCH 1/2] Config.mk pin QEMU_UPSTREAM_REVISION (prep for Xen 4.18 RC1)

2023-09-29 Thread Henry Wang
Hi Julien, > On Sep 29, 2023, at 15:58, Julien Grall wrote: > > From: Julien Grall > > Signed-off-by: Julien Grall Thanks for doing the changes, Release-acked-by: Henry Wang Kind regards, Henry > --- > Config.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Con

Re: [PATCH 2/2] Update Xen version to 4.18-rc

2023-09-29 Thread Henry Wang
Hi Julien, > On Sep 29, 2023, at 15:58, Julien Grall wrote: > > From: Julien Grall > > Signed-off-by: Julien Grall Release-acked-by: Henry Wang Kind regards, Henry > --- > README | 16 > SUPPORT.md | 2 +- > xen/Makefile | 2 +- > 3 files changed, 10 insertions(+),

Re: [PATCH 2/2] Update Xen version to 4.18-rc

2023-09-29 Thread Julien Grall
Hi Juergen, On 29/09/2023 09:04, Juergen Gross wrote: On 29.09.23 09:58, Julien Grall wrote: From: Julien Grall Signed-off-by: Julien Grall ---   README   | 16   SUPPORT.md   |  2 +-   xen/Makefile |  2 +-   3 files changed, 10 insertions(+), 10 deletions(-) diff --git

Re: [PATCH 2/2] Update Xen version to 4.18-rc

2023-09-29 Thread Henry Wang
> On Sep 29, 2023, at 16:04, Juergen Gross wrote: > > On 29.09.23 09:58, Julien Grall wrote: >> From: Julien Grall >> Signed-off-by: Julien Grall >> --- >> README | 16 >> SUPPORT.md | 2 +- >> xen/Makefile | 2 +- >> 3 files changed, 10 insertions(+), 10 deletions

Re: [PATCH v2] xen/arm: Skip memory nodes if not enabled

2023-09-29 Thread Michal Orzel
Hi Leo, On 28/09/2023 16:31, Leo Yan wrote: > > > Currently, the Xen hypervisor doesn't handle the status, the issue can > be described from two perspectives: the memory nodes and the reserved > memory nodes. > > - If a memory node has a status "disabled" it implies that it should > not be us

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-29 Thread Michal Orzel
Hi Leo, On 28/09/2023 16:37, Leo Yan wrote: > > > Hi Michal, Julien, > > On Wed, Sep 27, 2023 at 02:49:23PM +0200, Michal Orzel wrote: > > [...] > >> Either way is fine. The advantage of placing the check in boot_fdt_info() is >> that we can have a single check instead of duplicated and we do

Re: [PATCH] tools/xenstore: Avoid leaking memory in check_store

2023-09-29 Thread Andrew Cooper
On 29/09/2023 6:56 am, Juergen Gross wrote: > On 29.09.23 06:57, David Kahurani wrote: > > I'd like the following paragraph added to the commit message: > >   check_store() will leak the memory from reading the "@introduceDomain" >   and "@releaseDomain" nodes. > >> While this code should not be tr

Re: [PATCH] bitmap: fix n__ signess

2023-09-29 Thread Luca Fancellu
> On 29 Sep 2023, at 08:24, Julien Grall wrote: > > Hi Stefano, > > On 29/09/2023 00:19, Stefano Stabellini wrote: >> All callers of the bitmap_switch macro (which are all within bitmap.h) >> pass an int as first parameter. Do not assign it to an unsigned int >> potentially introducing errors

Xen 4.18 rc1

2023-09-29 Thread Henry Wang
Hi all, Xen 4.18 rc1 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.18.0-rc1 For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/4.18.0-rc1/xen-4.18.0-rc1.tar.gz And the signature is at: https://downloads.xenproject.org/

Re: Temporary commit moratorium for 4.18 RC1

2023-09-29 Thread Henry Wang
Hi all, > On Sep 27, 2023, at 08:10, Henry Wang wrote: > > Hi committers, > We will be tagging the 4.18 RC1 on Fri Sep 29, 2023. In order to have enough > time > for OSSTest to do the sync between staging and master, if there is any patch > to be > committed, please commit them by the morning

Re: [PATCH] tools/xenstore: Avoid leaking memory in check_store

2023-09-29 Thread Henry Wang
Hi all, > On Sep 29, 2023, at 16:23, Andrew Cooper wrote: > > On 29/09/2023 6:56 am, Juergen Gross wrote: >> On 29.09.23 06:57, David Kahurani wrote: >> >> I'd like the following paragraph added to the commit message: >> >> check_store() will leak the memory from reading the "@introduceDomai

Definition of mfn_t in x86's hvm/grant_table.h

2023-09-29 Thread Nicola Vetrini
Hi, while fixing a violation of R8.4 related to a missing include in x86/hvm/grant_table.c I included , since that file contains just the declarations needed by the .c file. However, since the declaration uses the type mfn_t, which is defined in an header not included from hvm/grant_table.h I'

Re: [PATCH v3] docs/misra: add rule 2.1 exceptions

2023-09-29 Thread Henry Wang
Hi Stefano, > On Sep 28, 2023, at 08:40, Stefano Stabellini wrote: > > On Wed, 27 Sep 2023, Bertrand Marquis wrote: >>> On 27 Sep 2023, at 09:53, Nicola Vetrini wrote: >>> >> diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c >> index 695d2fa1f1..2a8527cacc 100644 >> --- a/xen/

Re: [PATCH v2] docs/misra: add rule 2.1 exceptions

2023-09-29 Thread Henry Wang
Hi Stefano, > On Sep 28, 2023, at 17:10, Bertrand Marquis wrote: > > Hi Stefano, > >> On 24 Aug 2023, at 00:39, Stefano Stabellini wrote: >> >> From: Stefano Stabellini >> >> During the discussions that led to the acceptance of Rule 2.1, we >> decided on a few exceptions that were not prope

[XEN PATCH 0/4] Address violations of MISRA C:2012 Rule 8.3

2023-09-29 Thread Federico Serafini
This series contains small and uncontroversial patches to address some violations of Rule 8.3. No functonal changes are introduced. Federico Serafini (4): video/vesa: drop bool_t x86/uaccess: address violations of MISRA C:2012 Rule 8.3 x86/xstate: address a violation of MISRA C:2012 Rule 8.3

[XEN PATCH 1/4] video/vesa: drop bool_t

2023-09-29 Thread Federico Serafini
Drop bool_t to make function declaration and definition consistent and address a violation of MISRA C:2012 Rule 8.3. No functional change. Signed-off-by: Federico Serafini --- xen/drivers/video/vesa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/video/vesa.c b/

[XEN PATCH 3/4] x86/xstate: address a violation of MISRA C:2012 Rule 8.3

2023-09-29 Thread Federico Serafini
Make function declaration and definition consistent. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/xstate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index f442610fc5..cf94761d05 100644 ---

[XEN PATCH 4/4] x86/psr: address a violation of MISRA C:2012 Rule 8.3

2023-09-29 Thread Federico Serafini
Make function declaration and definition consistent. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/psr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/include/asm/psr.h b/xen/arch/x86/include/asm/psr.h index c2257da7fc..8ec

[XEN PATCH 2/4] x86/uaccess: address violations of MISRA C:2012 Rule 8.3

2023-09-29 Thread Federico Serafini
Make function declarations and definitions consistent. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/uaccess.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/include/asm/uaccess.h b/xen/arch/x86/include/asm/uaccess.h

Re: [PATCH] cpumask: fix integer type in cpumask_first

2023-09-29 Thread Luca Fancellu
> On 29 Sep 2023, at 08:31, Julien Grall wrote: > > Hi Stefano, > > On 29/09/2023 00:32, Stefano Stabellini wrote: >> nr_cpu_ids is unsigned int, but find_first_bit returns unsigned long (at >> least on arm). > > find_* are meant to be used by common code. So I think the first step is to > c

Re: [PATCH 1/3] xen/ppc: Fix stack initialization in head.S

2023-09-29 Thread Andrew Cooper
On 29/09/2023 12:19 am, Shawn Anastasio wrote: > The code to set up the stack in head.S erroneously loads the bottom of > the stack (the symbol cpu0_boot_stack) into r1 instead of the top of the > stack (cpu0_boot_stack + STACK_SIZE). > > Fixes: 3a4e6f67bc68 ("xen/ppc: Set up a basic C environment"

Re: [PATCH 1/3] xen/ppc: Fix stack initialization in head.S

2023-09-29 Thread Henry Wang
Hi Andrew, Shawn, > On Sep 29, 2023, at 17:15, Andrew Cooper wrote: > > On 29/09/2023 12:19 am, Shawn Anastasio wrote: >> The code to set up the stack in head.S erroneously loads the bottom of >> the stack (the symbol cpu0_boot_stack) into r1 instead of the top of the >> stack (cpu0_boot_stack +

Re: [PATCH 2/3] xen/ppc: Add .text.exceptions section for exception vectors

2023-09-29 Thread Andrew Cooper
On 29/09/2023 12:19 am, Shawn Anastasio wrote: > On Power, the exception vectors must lie at a fixed address, depending > on the state of the Alternate Interrupt Location (AIL) field of the > Logical Partition Control Register (LPCR). Create a .text.exceptions > section in the linker script at an a

[linux-linus test] 183206: tolerable FAIL - PUSHED

2023-09-29 Thread osstest service owner
flight 183206 linux-linus real [real] flight 183212 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183206/ http://logs.test-lab.xenproject.org/osstest/logs/183212/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

Re: [PATCH 3/3] xen/ppc: Implement a basic exception handler

2023-09-29 Thread Andrew Cooper
On 29/09/2023 12:19 am, Shawn Anastasio wrote: > Implement a basic exception handler that dumps the CPU state to the > console, as well as the code required to set the correct exception > vector table's base address in setup.c. > > Signed-off-by: Shawn Anastasio > --- > xen/arch/ppc/include/asm/p

Re: [XEN PATCH 1/4] video/vesa: drop bool_t

2023-09-29 Thread Federico Serafini
On 29/09/23 10:56, Federico Serafini wrote: Drop bool_t to make function declaration and definition consistent and address a violation of MISRA C:2012 Rule 8.3. No functional change. Signed-off-by: Federico Serafini --- xen/drivers/video/vesa.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[xen-unstable-smoke test] 183213: tolerable all pass - PUSHED

2023-09-29 Thread osstest service owner
flight 183213 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183213/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 11/15] sgi-xp: Remove the now superfluous sentinel element from ctl_table array

2023-09-29 Thread Joel Granados
On Thu, Sep 28, 2023 at 12:51:15PM -0500, Steve Wahl wrote: > On Thu, Sep 28, 2023 at 03:21:36PM +0200, Joel Granados via B4 Relay wrote: > > From: Joel Granados > > > > This commit comes at the tail end of a greater effort to remove the > > empty elements at the end of the ctl_table arrays (sent

Re: [PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel element from ctl_table array

2023-09-29 Thread Joel Granados
On Thu, Sep 28, 2023 at 03:26:16PM +, Wei Liu wrote: > Please change the prefix to "Drivers: hv:" in the subject line in the > two patches. > > On Thu, Sep 28, 2023 at 03:21:39PM +0200, Joel Granados via B4 Relay wrote: > > From: Joel Granados > > > > This commit comes at the tail end of a g

Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-09-29 Thread Joel Granados
On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote: > > From: Joel Granados > > > > This commit comes at the tail end of a greater effort to remove the > > empty elements at the end of the ctl_table arra

[XEN PATCH] x86/msi: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-09-29 Thread Federico Serafini
Add missing parameter names and make function declarations and definitions consistent. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/msi.h | 22 +++--- xen/arch/x86/msi.c | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-)

[xen-unstable test] 183208: tolerable FAIL

2023-09-29 Thread osstest service owner
flight 183208 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183208/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl7 xen-install fail in 183202 pass in 183208 test-arm64-arm64-xl-credit2 8

Re: [PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel element from ctl_table array

2023-09-29 Thread Joel Granados
On Thu, Sep 28, 2023 at 03:26:16PM +, Wei Liu wrote: > Please change the prefix to "Drivers: hv:" in the subject line in the > two patches. I'll change the commit message for the 14/15 patch from "hyper-v/azure" to "Drivers: hv:". But I only see one patch that needs this. Which is the other one

Re: [PATCH v4 5/9] x86/mem-sharing: copy GADDR based shared guest areas

2023-09-29 Thread Roger Pau Monné
On Fri, Sep 29, 2023 at 08:31:58AM -0400, Tamas K Lengyel wrote: > On Thu, Sep 28, 2023 at 10:08 AM Roger Pau Monné wrote: > > > > On Thu, Sep 28, 2023 at 08:57:04AM -0400, Tamas K Lengyel wrote: > > > On Thu, Sep 28, 2023 at 7:08 AM Roger Pau Monné > > > wrote: > > > > > > > > On Thu, Sep 28, 2

Re: [PATCH v4 2/7] xen/arm: Move is_protected flag to struct device

2023-09-29 Thread Stewart Hildebrand
On 6/29/23 18:22, Julien Grall wrote: > Hi Stewart, > > On 07/06/2023 04:02, Stewart Hildebrand wrote: >> From: Oleksandr Tyshchenko >> >> This flag will be re-used for PCI devices by the subsequent >> patches. > > I was expecting that we would only do PCI passthrough on boards where > all the P

[xen-unstable-smoke test] 183214: tolerable all pass - PUSHED

2023-09-29 Thread osstest service owner
flight 183214 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183214/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [XEN PATCH v2 0/3] docs/misra: add documentation skeleton to address MISRA C:2012 Dir 4.1

2023-09-29 Thread Nicola Vetrini
On 27/09/2023 11:52, Nicola Vetrini wrote: The headline of Directive 4.1 states: "Run-time failures shall be minimized". Thus, it requires the project to supply documentation that pertains the measures and techinques used to prevent run-time failures from happening. For ease of reading, the do

Re: [PATCH] bitmap: fix n__ signess

2023-09-29 Thread Elliott Mitchell
On Fri, Sep 29, 2023 at 08:24:37AM +0100, Julien Grall wrote: > Hi Stefano, > > On 29/09/2023 00:19, Stefano Stabellini wrote: > > All callers of the bitmap_switch macro (which are all within bitmap.h) > > pass an int as first parameter. Do not assign it to an unsigned int > > potentially introduc

Re: [PATCH v4 3/7] iommu/arm: Add iommu_dt_xlate()

2023-09-29 Thread Stewart Hildebrand
On 6/29/23 18:29, Julien Grall wrote: > Hi Stewart, > > On 07/06/2023 04:02, Stewart Hildebrand wrote: >> From: Oleksandr Tyshchenko >> >> Move code for processing DT IOMMU specifier to a separate helper. >> This helper will be re-used for adding PCI devices by the subsequent >> patches as we wil

[XEN PATCH] automation/eclair: update accepted and clean guidelines

2023-09-29 Thread Simone Ballarin
This patch updates accepted and clean guidelines selectors. Align accepted selector with docs/misra/rules.txt. Add rule 7.3 in the clean selector for ARM. Avoid regular expressions in all service selectors: usign them requires escaping dots, which make selectors hard to read. Signed-off-by: Simon

Sketch of an idea for handling the "mixed workload" problem

2023-09-29 Thread George Dunlap
The basic credit2 algorithm goes something like this: 1. All vcpus start with the same number of credits; about 10ms worth if everyone has the same weight 2. vcpus burn credits as they consume cpu, based on the relative weights: higher weights burn slower, lower weights burn faster 3. At any giv

Re: [XEN PATCH v2 0/3] docs/misra: add documentation skeleton to address MISRA C:2012 Dir 4.1

2023-09-29 Thread Luca Fancellu
> > CC-ing Luca as well: > I'm testing the next version of this series, and I'm seeing a failure on > cppcheck > containers on this pipeline [1]. I'm not sure about what is causing that > conversion script > to fail. Any pointer in debugging this would be greatly appreciated. > > [1] https://gi

Re: [PATCH 2/3] xen/ppc: Add .text.exceptions section for exception vectors

2023-09-29 Thread Shawn Anastasio
On 9/29/23 4:28 AM, Andrew Cooper wrote: > On 29/09/2023 12:19 am, Shawn Anastasio wrote: >> On Power, the exception vectors must lie at a fixed address, depending >> on the state of the Alternate Interrupt Location (AIL) field of the >> Logical Partition Control Register (LPCR). Create a .text.exc

Re: [PATCH 2/3] xen/ppc: Add .text.exceptions section for exception vectors

2023-09-29 Thread Andrew Cooper
On 29/09/2023 7:15 pm, Shawn Anastasio wrote: > On 9/29/23 4:28 AM, Andrew Cooper wrote: >> As I said for patch 1, we're now at 4.18-rc1. Does this need to be >> included now, or wait for 4.19? There's something to be said for having >> a basic exception handler, but it is technically a new feat

Re: [XEN PATCH v7 3/4] x86/include: address violations of MISRA C:2012 Rule 7.2

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Simone Ballarin wrote: > On 29/09/23 00:58, Stefano Stabellini wrote: > > On Thu, 28 Sep 2023, Simone Ballarin wrote: > > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > > > headline states: > > > "A 'u' or 'U' suffix shall be applied to all integer const

Re: Misra rule 10.3 violations report script

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Luca Fancellu wrote: > > On 29 Sep 2023, at 00:20, Stefano Stabellini wrote: > > > > On Thu, 28 Sep 2023, Luca Fancellu wrote: > >> Hi all, > >> > >> In the last MISRA meeting Stefano told me about the Rule 10.3 and that we > >> have a lot of violations, > >> but GCC has a

Re: [PATCH v2 3/5] arm/dom0less: put dom0less feature code in a separate module

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Luca Fancellu wrote: > > On 29 Sep 2023, at 01:33, Stefano Stabellini wrote: > > > > On Wed, 27 Sep 2023, Luca Fancellu wrote: > >> Currently the dom0less feature code is mostly inside domain_build.c > >> and setup.c, it is a feature that may not be useful to everyone so > >>

RE: Xen on AWS EC2 Graviton 2 metal instances (c6g.metal)

2023-09-29 Thread Driscoll, Dan
All, Just an FYI - using the debug guidance from Julien on Graviton 2, we have successfully been able to boot Xen and 3 Linux VMs on a Graviton 2 c6g.metal instance. The problem turned out to be that the ACPI table containing the arch timer interrupt vectors had an issue - the

RE: Xen on AWS EC2 Graviton 2 metal instances (c6g.metal)

2023-09-29 Thread Stefano Stabellini
Hi Dan, I am very glad you managed to solve the issue! It is always difficult to know what is the right thing to do when the firmware provides wrong or noncompliant information. One on hand a panic can help debug a potentially broken firmware configuration. On the other hand the panic can cause p

Re: [XEN PATCH v2 00/10] address violations of MISRA C:2012 Directive 4.10

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Simone Ballarin wrote: > On 29/09/23 00:24, Stefano Stabellini wrote: > > On Thu, 28 Sep 2023, Jan Beulich wrote: > > > On 28.09.2023 15:17, Simone Ballarin wrote: > > > > On 28/09/23 14:51, Jan Beulich wrote: > > > > > On 28.09.2023 14:46, Simone Ballarin wrote: > > > > > > On

Re: [XEN PATCH] automation/eclair: update accepted and clean guidelines

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Simone Ballarin wrote: > This patch updates accepted and clean guidelines selectors. > > Align accepted selector with docs/misra/rules.txt. > Add rule 7.3 in the clean selector for ARM. > Avoid regular expressions in all service selectors: usign them > requires escaping dots,

Re: [XEN PATCH] x86/msi: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Federico Serafini wrote: > Add missing parameter names and make function declarations and > definitions consistent. > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 2/4] x86/uaccess: address violations of MISRA C:2012 Rule 8.3

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Federico Serafini wrote: > Make function declarations and definitions consistent. > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 3/4] x86/xstate: address a violation of MISRA C:2012 Rule 8.3

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Federico Serafini wrote: > Make function declaration and definition consistent. > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 4/4] x86/psr: address a violation of MISRA C:2012 Rule 8.3

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Federico Serafini wrote: > Make function declaration and definition consistent. > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini

Re: [PATCH v4 4/7] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

2023-09-29 Thread Stewart Hildebrand
On 7/4/23 05:35, Julien Grall wrote: > Hi, > > On 07/06/2023 04:02, Stewart Hildebrand wrote: >> From: Oleksandr Tyshchenko >> >> The main purpose of this patch is to add a way to register PCI device >> (which is behind the IOMMU) using the generic PCI-IOMMU DT bindings [1] >> before assigning th

Re: [PATCH] bitmap: fix n__ signess

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Julien Grall wrote: > On 29/09/2023 00:19, Stefano Stabellini wrote: > > All callers of the bitmap_switch macro (which are all within bitmap.h) > > pass an int as first parameter. Do not assign it to an unsigned int > > potentially introducing errors. > > > > Signed-off-by: St

Re: [PATCH] cpumask: fix integer type in cpumask_first

2023-09-29 Thread Stefano Stabellini
On Fri, 29 Sep 2023, Luca Fancellu wrote: > > On 29 Sep 2023, at 08:31, Julien Grall wrote: > > > > Hi Stefano, > > > > On 29/09/2023 00:32, Stefano Stabellini wrote: > >> nr_cpu_ids is unsigned int, but find_first_bit returns unsigned long (at > >> least on arm). > > > > find_* are meant to be

[libvirt test] 183210: tolerable all pass - PUSHED

2023-09-29 Thread osstest service owner
flight 183210 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/183210/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183201 test-armhf-armhf-libvirt-qcow2 15 saveres

[linux-5.4 test] 183211: regressions - trouble: fail/pass/starved

2023-09-29 Thread osstest service owner
flight 183211 linux-5.4 real [real] flight 183219 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183211/ http://logs.test-lab.xenproject.org/osstest/logs/183219/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

[xen-unstable-smoke test] 183218: tolerable all pass - PUSHED

2023-09-29 Thread osstest service owner
flight 183218 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183218/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] bitmap: fix n__ signess

2023-09-29 Thread Elliott Mitchell
On Fri, Sep 29, 2023 at 02:13:59PM -0700, Stefano Stabellini wrote: > On Fri, 29 Sep 2023, Julien Grall wrote: > > On 29/09/2023 00:19, Stefano Stabellini wrote: > > > All callers of the bitmap_switch macro (which are all within bitmap.h) > > > pass an int as first parameter. Do not assign it to an

[xen-unstable test] 183216: tolerable FAIL - PUSHED

2023-09-29 Thread osstest service owner
flight 183216 xen-unstable real [real] flight 183221 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183216/ http://logs.test-lab.xenproject.org/osstest/logs/183221/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6