Re: [PATCH] ui/input: Constify QemuInputHandler structure

2023-10-17 Thread Mark Cave-Ayland
utHandler vdagent_mouse_handler = { .name = "vdagent mouse", .mask = INPUT_EVENT_MASK_BTN | INPUT_EVENT_MASK_ABS, .event = vdagent_pointer_event, Looks mostly harmless to me: Reviewed-by: Mark Cave-Ayland ATB, Mark.

Re: [PATCH v13 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-09-20 Thread Mark Cave-Ayland
On 20/09/2023 12:42, Akihiko Odaki wrote: On 2023/08/29 9:36, Gurchetan Singh wrote: This adds initial support for gfxstream and cross-domain.  Both features rely on virtio-gpu blob resources and context types, which are also implemented in this patch. gfxstream has a long and illustrious hist

Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs

2023-07-01 Thread Mark Cave-Ayland
On 01/07/2023 10:53, Bernhard Beschow wrote: Am 30. Juni 2023 08:48:02 UTC schrieb Paolo Bonzini : Il mer 28 giu 2023, 13:28 Bernhard Beschow ha scritto: Am 27. Juni 2023 12:07:40 UTC schrieb Olaf Hering : Tue, 27 Jun 2023 10:12:50 + Bernhard Beschow : The BAR is a 32 bit register w

Re: [PATCH v4 0/2] pci: slot_reserved_mask improvements

2023-03-23 Thread Mark Cave-Ayland
/xen_pt.c | 8 include/hw/pci/pci.h | 3 +++ include/hw/pci/pci_bus.h | 3 ++- 5 files changed, 40 insertions(+), 14 deletions(-) The v4 series looks good to me: I've also confirmed that sun4u still works as before, so from my perspective: Reviewed-by: Mark Cave-A

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Mark Cave-Ayland
On 14/03/2023 14:21, Chuck Zmudzinski wrote: On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: On 14/03/2023 13:26, Chuck Zmudzinski wrote: On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: On 14/03/2023 06:33, Michael S. Tsirkin

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Mark Cave-Ayland
On 14/03/2023 13:26, Chuck Zmudzinski wrote: On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: On 14/03/2023 06:33, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: Commit

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-14 Thread Mark Cave-Ayland
On 14/03/2023 06:33, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") uses slot_reserved_mask to reserve slot 2 for the Intel IGD for the xenfv machine when the guest is configur

Re: [PATCH 0/9] Deprecate sysbus_get_default() and get_system_memory() et. al

2022-09-20 Thread Mark Cave-Ayland
On 20/09/2022 10:55, Peter Maydell wrote: On Tue, 20 Sept 2022 at 00:18, Bernhard Beschow wrote: In address-spaces.h it can be read that get_system_memory() and get_system_io() are temporary interfaces which "should only be used temporarily until a proper bus interface is available". This sta

Re: sysbus failed assert for xen_sysdev

2020-06-22 Thread Mark Cave-Ayland
On 22/06/2020 21:33, Jason Andryuk wrote: > Hi, > > Running qemu devel for a Xen VM is failing an assert after the recent > "qdev: Rework how we plug into the parent bus" sysbus changes. > > qemu-system-i386: hw/core/qdev.c:102: qdev_set_parent_bus: Assertion > `dc->bus_type && object_dynamic_ca