Re: [PATCH] xen/riscv: init bss section

2023-02-27 Thread Oleksii
On Fri, 2023-02-24 at 16:55 +, Andrew Cooper wrote: > On 24/02/2023 2:48 pm, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > >  xen/arch/riscv/setup.c | 14 ++ > >  1 file changed, 14 insertions(+) > > > > diff --git a/xen/arch/riscv/setup.c

Re: [PATCH] xen/riscv: init bss section

2023-02-24 Thread Andrew Cooper
On 24/02/2023 2:48 pm, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/setup.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > index 154bf3a0bc..593bb471a4 100644 > ---

Re: [PATCH] xen/riscv: init bss section

2023-02-24 Thread Oleksii
On Fri, 2023-02-24 at 15:56 +0100, Jan Beulich wrote: > On 24.02.2023 15:48, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/setup.c > > +++ b/xen/arch/riscv/setup.c > > @@ -24,6 +24,18 @@ static void test_macros_from_bug_h(void) > > early_printk("WARN is most likely working\n"); > >  } > >  

Re: [PATCH] xen/riscv: init bss section

2023-02-24 Thread Jan Beulich
On 24.02.2023 15:56, Jan Beulich wrote: > On 24.02.2023 15:48, Oleksii Kurochko wrote: >> +char *bss = &__bss_start; >> + >> +while ( bss < &__bss_end ) { >> +*bss = 0; >> +bss++; >> +} >> +} > > If you're sure you can defer this until being in C code, why not use >

Re: [PATCH] xen/riscv: init bss section

2023-02-24 Thread Jan Beulich
On 24.02.2023 15:48, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -24,6 +24,18 @@ static void test_macros_from_bug_h(void) > early_printk("WARN is most likely working\n"); > } > > +static void __init init_bss(void) > +{ > +extern char

[PATCH] xen/riscv: init bss section

2023-02-24 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/setup.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 154bf3a0bc..593bb471a4 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -24,6 +24,18 @@ static