Re: [PATCH 1/2] livepatch: do not ignore sections with 0 size

2022-04-07 Thread Ross Lagerwall
> From: Roger Pau Monne > Sent: Thursday, March 17, 2022 11:08 AM > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Konrad Rzeszutek Wilk > ; Ross Lagerwall > Subject: [PATCH 1/2] livepatch: do not ignore sections with 0 size > > A side effect o

Re: [PATCH 1/2] livepatch: do not ignore sections with 0 size

2022-03-25 Thread Roger Pau Monné
Ping? There was some discussion on whether we need to handle such empty sections, but I think we settled that it's necessary. Thanks, Roger. On Thu, Mar 17, 2022 at 12:08:53PM +0100, Roger Pau Monne wrote: > A side effect of ignoring such sections is that symbols belonging to > them won't be

Re: [PATCH 1/2] livepatch: do not ignore sections with 0 size

2022-03-17 Thread Andrew Cooper
On 17/03/2022 14:16, Roger Pau Monné wrote: > On Thu, Mar 17, 2022 at 02:00:19PM +, Andrew Cooper wrote: >> On 17/03/2022 11:08, Roger Pau Monne wrote: >>> A side effect of ignoring such sections is that symbols belonging to >>> them won't be resolved, and that could make relocations belonging

Re: [PATCH 1/2] livepatch: do not ignore sections with 0 size

2022-03-17 Thread Roger Pau Monné
On Thu, Mar 17, 2022 at 02:00:19PM +, Andrew Cooper wrote: > On 17/03/2022 11:08, Roger Pau Monne wrote: > > A side effect of ignoring such sections is that symbols belonging to > > them won't be resolved, and that could make relocations belonging to > > other sections that reference those

Re: [PATCH 1/2] livepatch: do not ignore sections with 0 size

2022-03-17 Thread Jan Beulich
On 17.03.2022 15:00, Andrew Cooper wrote: > On 17/03/2022 11:08, Roger Pau Monne wrote: >> A side effect of ignoring such sections is that symbols belonging to >> them won't be resolved, and that could make relocations belonging to >> other sections that reference those symbols fail. >> >> For

Re: [PATCH 1/2] livepatch: do not ignore sections with 0 size

2022-03-17 Thread Andrew Cooper
On 17/03/2022 11:08, Roger Pau Monne wrote: > A side effect of ignoring such sections is that symbols belonging to > them won't be resolved, and that could make relocations belonging to > other sections that reference those symbols fail. > > For example it's likely to have an empty

[PATCH 1/2] livepatch: do not ignore sections with 0 size

2022-03-17 Thread Roger Pau Monne
A side effect of ignoring such sections is that symbols belonging to them won't be resolved, and that could make relocations belonging to other sections that reference those symbols fail. For example it's likely to have an empty .altinstr_replacement with symbols pointing to it, and marking the