Re: [PATCH v1] tools: drop bogus and obsolete ptyfuncs.m4

2023-05-12 Thread Olaf Hering
Tue, 9 May 2023 17:47:33 +0100 Anthony PERARD : > That change isn't enough. And I'm not convinced that it needs to be > removed. You are right, the provided functions must be removed as well. My build scripts do not run autoreconf, perhaps it is about time to change that. > First,

Re: [PATCH v1] tools: drop bogus and obsolete ptyfuncs.m4

2023-05-09 Thread Anthony PERARD
On Tue, May 02, 2023 at 08:48:00PM +, Olaf Hering wrote: > According to openpty(3) it is required to include to get the > prototypes for openpty() and login_tty(). But this is not what the > function AX_CHECK_PTYFUNCS actually does. It makes no attempt to include > the required header. > >

[PATCH v1] tools: drop bogus and obsolete ptyfuncs.m4

2023-05-02 Thread Olaf Hering
According to openpty(3) it is required to include to get the prototypes for openpty() and login_tty(). But this is not what the function AX_CHECK_PTYFUNCS actually does. It makes no attempt to include the required header. The two source files which call openpty() and login_tty() already contain