Re: [PATCH v2] Fix install.sh for systemd

2023-05-12 Thread Olaf Hering
Fri, 12 May 2023 12:22:08 +0100 Andrew Cooper : > Does this allow for making any of these files no longer > preprocessed by ./configure ?  (i.e. cease being .in files) The path to hotplugpath.sh is variable, so each consumer needs to be a .in file. Olaf pgpSPFRUGSANB.pgp Description:

Re: [PATCH v2] Fix install.sh for systemd

2023-05-12 Thread Andrew Cooper
On 12/05/2023 12:18 pm, Olaf Hering wrote: > Tue, 9 May 2023 13:47:11 +0100 Andrew Cooper : > >> Why is this 700, and the others just using regular perms? >> Also, doesn't it want quoting like the other examples too? > It is not clear why there is a single mkdir -m 0700 in the tree. > Most likely

Re: [PATCH v2] Fix install.sh for systemd

2023-05-12 Thread Olaf Hering
Tue, 9 May 2023 13:47:11 +0100 Andrew Cooper : > Why is this 700, and the others just using regular perms? > Also, doesn't it want quoting like the other examples too? It is not clear why there is a single mkdir -m 0700 in the tree. Most likely it will not give any extra security. The scripts

Re: [PATCH v2] Fix install.sh for systemd

2023-05-10 Thread Jason Andryuk
On Mon, May 8, 2023 at 1:14 PM Olaf Hering wrote: > > On a fedora system, if you run `sudo sh install.sh` you break your > system. The installation clobbers /var/run, a symlink to /run. A > subsequent boot fails when /var/run and /run are different since > accesses through /var/run can't find

Re: [PATCH v2] Fix install.sh for systemd

2023-05-09 Thread Olaf Hering
Tue, 9 May 2023 13:47:11 +0100 Andrew Cooper : > > +++ b/tools/hotplug/Linux/init.d/xendriverdomain.in > > @@ -49,6 +49,7 @@ fi > > > > do_start () { > > echo Starting xl devd... > > + mkdir -m700 -p @XEN_RUN_DIR@ > > Why is this 700, and the others just using regular perms? I think

Re: [PATCH v2] Fix install.sh for systemd

2023-05-09 Thread Andrew Cooper
On 08/05/2023 6:14 pm, Olaf Hering wrote: > On a fedora system, if you run `sudo sh install.sh` you break your > system. The installation clobbers /var/run, a symlink to /run. A > subsequent boot fails when /var/run and /run are different since > accesses through /var/run can't find items that

[PATCH v2] Fix install.sh for systemd

2023-05-08 Thread Olaf Hering
On a fedora system, if you run `sudo sh install.sh` you break your system. The installation clobbers /var/run, a symlink to /run. A subsequent boot fails when /var/run and /run are different since accesses through /var/run can't find items that now only exist in /run and vice-versa. Skip