Re: [Xen-devel] [PATCH] x86/HVM: correct an inverted check in hvm_load()

2018-08-16 Thread Andrew Cooper
On 02/08/18 07:02, Jan Beulich wrote: On 01.08.18 at 18:08, wrote: >> On 01/08/18 16:36, Jan Beulich wrote: >>> Clearly we want to put a vCPU to sleep if it is _not_ already down. >>> >>> Signed-off-by: Jan Beulich >>> --- >>> TBD: Since the flaw apparently never mattered, I imply that the

Re: [Xen-devel] [PATCH] x86/HVM: correct an inverted check in hvm_load()

2018-08-02 Thread Jan Beulich
>>> On 01.08.18 at 18:08, wrote: > On 01/08/18 16:36, Jan Beulich wrote: >> Clearly we want to put a vCPU to sleep if it is _not_ already down. >> >> Signed-off-by: Jan Beulich >> --- >> TBD: Since the flaw apparently never mattered, I imply that the function >> is never called with any

Re: [Xen-devel] [PATCH] x86/HVM: correct an inverted check in hvm_load()

2018-08-01 Thread Andrew Cooper
On 01/08/18 16:36, Jan Beulich wrote: > Clearly we want to put a vCPU to sleep if it is _not_ already down. > > Signed-off-by: Jan Beulich > --- > TBD: Since the flaw apparently never mattered, I imply that the function > is never called with any vCPU up. Hence an alternative might be to >

[Xen-devel] [PATCH] x86/HVM: correct an inverted check in hvm_load()

2018-08-01 Thread Jan Beulich
Clearly we want to put a vCPU to sleep if it is _not_ already down. Signed-off-by: Jan Beulich --- TBD: Since the flaw apparently never mattered, I imply that the function is never called with any vCPU up. Hence an alternative might be to simply return an error if a vCPU doesn't have