Re: [Xen-devel] [PATCH] xen: Use 'unsigned int' instead of 'unsigned'

2020-03-03 Thread Boris Ostrovsky
On 3/3/20 3:30 AM, Jan Beulich wrote: > On 02.03.2020 23:18, Yan Yankovskyi wrote: >> On Mon, Mar 2, 2020 at 10:11 Jan Beulich wrote: >>> ... evtchn_port_t here and elsewhere. >> There are some interfaces with signed int as a type for port, e.g. in >> include/xen/events.h. >> Should I create addi

Re: [Xen-devel] [PATCH] xen: Use 'unsigned int' instead of 'unsigned'

2020-03-03 Thread Jan Beulich
On 02.03.2020 23:18, Yan Yankovskyi wrote: > On Mon, Mar 2, 2020 at 10:11 Jan Beulich wrote: >> ... evtchn_port_t here and elsewhere. > > There are some interfaces with signed int as a type for port, e.g. in > include/xen/events.h. > Should I create additional patch to resolve inconsistency with e

Re: [Xen-devel] [PATCH] xen: Use 'unsigned int' instead of 'unsigned'

2020-03-02 Thread Yan Yankovskyi
On Mon, Mar 2, 2020 at 10:11 Jan Beulich wrote: > ... evtchn_port_t here and elsewhere. There are some interfaces with signed int as a type for port, e.g. in include/xen/events.h. Should I create additional patch to resolve inconsistency with evtchn interface? Or you suggest combining these change

Re: [Xen-devel] [PATCH] xen: Use 'unsigned int' instead of 'unsigned'

2020-03-02 Thread Yan Yankovskyi
On Mon, Mar 2, 2020 at 10:11 AM Jan Beulich wrote: > ... evtchn_port_t here and elsewhere. There are some interfaces with signed int as a type for port, e.g. in include/xen/events.h. Should I create additional patch to resolve inconsistency with evtchn interface? Or you suggest combining these ch

Re: [Xen-devel] [PATCH] xen: Use 'unsigned int' instead of 'unsigned'

2020-03-02 Thread Jan Beulich
On 29.02.2020 23:30, Yan Yankovskyi wrote: > Resolve the following warning, reported by checkpatch.pl: > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > No functional change. IMO a change like this would ideally go a little further and try to use the actually designated types when ad

[Xen-devel] [PATCH] xen: Use 'unsigned int' instead of 'unsigned'

2020-02-29 Thread Yan Yankovskyi
Resolve the following warning, reported by checkpatch.pl: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' No functional change. Signed-off-by: Yan Yankovskyi --- drivers/xen/events/events_2l.c | 18 ++--- drivers/xen/events/events_base.c | 92