Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-13 Thread Wei Liu
On Tue, Mar 13, 2018 at 02:23:15PM +, Roger Pau Monné wrote: > On Mon, Mar 05, 2018 at 11:36:58AM +, Ian Jackson wrote: > > Roger Pau Monne writes ("[PATCH] xl: remove apic option for PVH guests"): > > > XSA-256 forces the local APIC to always be enabled for PVH guests, so > > > ignore any

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-13 Thread Roger Pau Monné
On Mon, Mar 05, 2018 at 11:36:58AM +, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH] xl: remove apic option for PVH guests"): > > XSA-256 forces the local APIC to always be enabled for PVH guests, so > > ignore any apic option for PVH guests. Update the documentation > > accordingly. > .

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-13 Thread Wei Liu
On Tue, Mar 13, 2018 at 10:31:20AM +, Roger Pau Monné wrote: > On Mon, Mar 05, 2018 at 08:43:48AM -0600, Doug Goldstein wrote: > > On 3/2/18 5:29 AM, Jan Beulich wrote: > > On 02.03.18 at 12:09, wrote: > > >> On Thu, Mar 01, 2018 at 05:01:55PM +, Roger Pau Monné wrote: > > >>> On Thu,

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-13 Thread Roger Pau Monné
On Mon, Mar 05, 2018 at 08:43:48AM -0600, Doug Goldstein wrote: > On 3/2/18 5:29 AM, Jan Beulich wrote: > On 02.03.18 at 12:09, wrote: > >> On Thu, Mar 01, 2018 at 05:01:55PM +, Roger Pau Monné wrote: > >>> On Thu, Mar 01, 2018 at 04:01:23PM +, Wei Liu wrote: > On Thu, Mar 01, 20

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-05 Thread Doug Goldstein
On 3/2/18 5:29 AM, Jan Beulich wrote: On 02.03.18 at 12:09, wrote: >> On Thu, Mar 01, 2018 at 05:01:55PM +, Roger Pau Monné wrote: >>> On Thu, Mar 01, 2018 at 04:01:23PM +, Wei Liu wrote: On Thu, Mar 01, 2018 at 03:57:18PM +, Andrew Cooper wrote: > On 01/03/18 12:22, Wei

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-05 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH] xl: remove apic option for PVH guests"): > XSA-256 forces the local APIC to always be enabled for PVH guests, so > ignore any apic option for PVH guests. Update the documentation > accordingly. ... > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index f68

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-02 Thread Andrew Cooper
On 02/03/18 11:09, Wei Liu wrote: > On Thu, Mar 01, 2018 at 05:01:55PM +, Roger Pau Monné wrote: >> On Thu, Mar 01, 2018 at 04:01:23PM +, Wei Liu wrote: >>> On Thu, Mar 01, 2018 at 03:57:18PM +, Andrew Cooper wrote: On 01/03/18 12:22, Wei Liu wrote: > On Wed, Feb 28, 2018 at 10

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-02 Thread Jan Beulich
>>> On 02.03.18 at 12:09, wrote: > On Thu, Mar 01, 2018 at 05:01:55PM +, Roger Pau Monné wrote: >> On Thu, Mar 01, 2018 at 04:01:23PM +, Wei Liu wrote: >> > On Thu, Mar 01, 2018 at 03:57:18PM +, Andrew Cooper wrote: >> > > On 01/03/18 12:22, Wei Liu wrote: >> > > > On Wed, Feb 28, 2018

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-02 Thread Wei Liu
On Thu, Mar 01, 2018 at 05:01:55PM +, Roger Pau Monné wrote: > On Thu, Mar 01, 2018 at 04:01:23PM +, Wei Liu wrote: > > On Thu, Mar 01, 2018 at 03:57:18PM +, Andrew Cooper wrote: > > > On 01/03/18 12:22, Wei Liu wrote: > > > > On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wr

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-01 Thread Roger Pau Monné
On Thu, Mar 01, 2018 at 04:01:23PM +, Wei Liu wrote: > On Thu, Mar 01, 2018 at 03:57:18PM +, Andrew Cooper wrote: > > On 01/03/18 12:22, Wei Liu wrote: > > > On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > > >> XSA-256 forces the local APIC to always be enabled for PVH gu

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-01 Thread Wei Liu
On Thu, Mar 01, 2018 at 03:57:18PM +, Andrew Cooper wrote: > On 01/03/18 12:22, Wei Liu wrote: > > On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > >> XSA-256 forces the local APIC to always be enabled for PVH guests, so > >> ignore any apic option for PVH guests. Update the d

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-01 Thread Andrew Cooper
On 01/03/18 12:22, Wei Liu wrote: > On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: >> XSA-256 forces the local APIC to always be enabled for PVH guests, so >> ignore any apic option for PVH guests. Update the documentation >> accordingly. > I think how I will approach this is to d

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-01 Thread Wei Liu
On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > XSA-256 forces the local APIC to always be enabled for PVH guests, so > ignore any apic option for PVH guests. Update the documentation > accordingly. I think how I will approach this is to dictate that PVH always has LAPIC in our

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-02-28 Thread Roger Pau Monné
On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > XSA-256 forces the local APIC to always be enabled for PVH guests, so > ignore any apic option for PVH guests. Update the documentation > accordingly. > > Signed-off-by: Roger Pau Monné > --- > Cc: Ian Jackson > Cc: Wei Liu I'v

[Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-02-28 Thread Roger Pau Monne
XSA-256 forces the local APIC to always be enabled for PVH guests, so ignore any apic option for PVH guests. Update the documentation accordingly. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- docs/man/xl.cfg.pod.5.in | 6 -- tools/libxl/libxl_x86.c | 6 +- tools/