Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Wei Liu
On Fri, Sep 28, 2018 at 05:19:50PM +0100, Wei Liu wrote: > On Fri, Sep 28, 2018 at 10:05:21AM -0600, Jan Beulich wrote: > > >>> On 28.09.18 at 17:53, wrote: > > > At the moment the ordering of the options matter, which means if "xen" > > > is not the first option we can lose output. > > > > > > I

Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Wei Liu
On Fri, Sep 28, 2018 at 10:05:21AM -0600, Jan Beulich wrote: > >>> On 28.09.18 at 17:53, wrote: > > At the moment the ordering of the options matter, which means if "xen" > > is not the first option we can lose output. > > > > I think one easy way of improving is to parse opt_console twice. The >

Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Jan Beulich
>>> On 28.09.18 at 17:53, wrote: > At the moment the ordering of the options matter, which means if "xen" > is not the first option we can lose output. > > I think one easy way of improving is to parse opt_console twice. The > first time solely looks for "xen" and the second time parses the rest

Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Wei Liu
On Fri, Sep 28, 2018 at 04:23:24PM +0100, Wei Liu wrote: > On Fri, Sep 28, 2018 at 09:19:56AM -0600, Jan Beulich wrote: > > >>> On 28.09.18 at 17:12, wrote: > > > On Fri, Sep 28, 2018 at 09:08:34AM -0600, Jan Beulich wrote: > > >> >>> On 28.09.18 at 10:24, wrote: > > >> > --- a/xen/drivers/char/c

Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Wei Liu
On Fri, Sep 28, 2018 at 09:19:56AM -0600, Jan Beulich wrote: > >>> On 28.09.18 at 17:12, wrote: > > On Fri, Sep 28, 2018 at 09:08:34AM -0600, Jan Beulich wrote: > >> >>> On 28.09.18 at 10:24, wrote: > >> > --- a/xen/drivers/char/console.c > >> > +++ b/xen/drivers/char/console.c > >> > @@ -91,7 +9

Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Jan Beulich
>>> On 28.09.18 at 17:12, wrote: > On Fri, Sep 28, 2018 at 09:08:34AM -0600, Jan Beulich wrote: >> >>> On 28.09.18 at 10:24, wrote: >> > --- a/xen/drivers/char/console.c >> > +++ b/xen/drivers/char/console.c >> > @@ -91,7 +91,8 @@ static uint32_t conringc, conringp; >> > static int __read_mostly

Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Wei Liu
On Fri, Sep 28, 2018 at 04:13:51PM +0100, Andrew Cooper wrote: > On 28/09/18 16:12, Wei Liu wrote: > > On Fri, Sep 28, 2018 at 09:08:34AM -0600, Jan Beulich wrote: > > On 28.09.18 at 10:24, wrote: > >>> --- a/xen/drivers/char/console.c > >>> +++ b/xen/drivers/char/console.c > >>> @@ -91,7 +91,

Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Andrew Cooper
On 28/09/18 16:12, Wei Liu wrote: > On Fri, Sep 28, 2018 at 09:08:34AM -0600, Jan Beulich wrote: > On 28.09.18 at 10:24, wrote: >>> --- a/xen/drivers/char/console.c >>> +++ b/xen/drivers/char/console.c >>> @@ -91,7 +91,8 @@ static uint32_t conringc, conringp; >>> static int __read_mostly serc

Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Wei Liu
On Fri, Sep 28, 2018 at 09:08:34AM -0600, Jan Beulich wrote: > >>> On 28.09.18 at 10:24, wrote: > > --- a/xen/drivers/char/console.c > > +++ b/xen/drivers/char/console.c > > @@ -91,7 +91,8 @@ static uint32_t conringc, conringp; > > static int __read_mostly sercon_handle = -1; > > > > #ifdef CO

Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Jan Beulich
>>> On 28.09.18 at 10:24, wrote: > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -91,7 +91,8 @@ static uint32_t conringc, conringp; > static int __read_mostly sercon_handle = -1; > > #ifdef CONFIG_X86 > -static bool __read_mostly opt_console_xen; /* console=xen */ >

[Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

2018-09-28 Thread Wei Liu
This helps capture issues before console is initialised. The impact is minimal because it only affects Xen running in as a guest. Signed-off-by: Wei Liu --- xen/drivers/char/console.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/drivers/char/console.c b/xen/drive