Re: [Xen-devel] [PATCH 5/6] mm: add 'is_special_page' macro...

2020-02-29 Thread Durrant, Paul
> -Original Message- > From: Tamas K Lengyel > Sent: 28 February 2020 19:32 > To: Durrant, Paul > Cc: Xen-devel ; Jan Beulich > ; Andrew Cooper ; Wei Liu > ; Roger Pau Monné ; George Dunlap > ; Ian Jackson ; > Julien Grall ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; Tim > Deegan > S

Re: [Xen-devel] [PATCH 5/6] mm: add 'is_special_page' macro...

2020-02-28 Thread Tamas K Lengyel
> diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c > index 3835bc928f..c14a724c6d 100644 > --- a/xen/arch/x86/mm/mem_sharing.c > +++ b/xen/arch/x86/mm/mem_sharing.c > @@ -842,7 +842,7 @@ static int nominate_page(struct domain *d, gfn_t gfn, > > /* Skip xen heap pages

[Xen-devel] [PATCH 5/6] mm: add 'is_special_page' macro...

2020-02-28 Thread Paul Durrant
... to cover xenheap and PGC_extra pages. PGC_extra pages are intended to hold data structures that are associated with a domain and my be mapped by that domain. They should not be treated as 'normal' guest pages (i.e. RAM or page tables). Hence, in many cases where code currently tests is_xen_hea