Re: [Xen-devel] [PATCH v2 06/45] xen/arm: gic: Split the field state in gic_lr in 2 fields active and pending

2018-03-19 Thread Andre Przywara
Hi, On 16/03/18 22:52, Stefano Stabellini wrote: > On Fri, 16 Mar 2018, Julien Grall wrote: >> On 16/03/2018 21:34, Stefano Stabellini wrote: >>> On Thu, 15 Mar 2018, Andre Przywara wrote: From: Julien Grall diff --git a/xen/include/asm-arm/gic.h

Re: [Xen-devel] [PATCH v2 06/45] xen/arm: gic: Split the field state in gic_lr in 2 fields active and pending

2018-03-16 Thread Stefano Stabellini
On Fri, 16 Mar 2018, Julien Grall wrote: > On 16/03/2018 21:34, Stefano Stabellini wrote: > > On Thu, 15 Mar 2018, Andre Przywara wrote: > > > From: Julien Grall > > > diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h > > > index daec51499c..c32861d4fa

Re: [Xen-devel] [PATCH v2 06/45] xen/arm: gic: Split the field state in gic_lr in 2 fields active and pending

2018-03-16 Thread Julien Grall
On 16/03/2018 21:34, Stefano Stabellini wrote: On Thu, 15 Mar 2018, Andre Przywara wrote: From: Julien Grall diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h index daec51499c..c32861d4fa 100644 --- a/xen/include/asm-arm/gic.h +++

Re: [Xen-devel] [PATCH v2 06/45] xen/arm: gic: Split the field state in gic_lr in 2 fields active and pending

2018-03-16 Thread Stefano Stabellini
On Thu, 15 Mar 2018, Andre Przywara wrote: > From: Julien Grall > > Mostly making the code nicer to read. > > Signed-off-by: Julien Grall > Reviewed-by: Andre Przywara > Signed-off-by: Andre Przywara

[Xen-devel] [PATCH v2 06/45] xen/arm: gic: Split the field state in gic_lr in 2 fields active and pending

2018-03-15 Thread Andre Przywara
From: Julien Grall Mostly making the code nicer to read. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara Signed-off-by: Andre Przywara --- Changes: - Use 1ULL - Remove pointless == *_STATE_*