[Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-06 Thread Christopher Clark
Initialises basic data structures and performs teardown of argo state for domain shutdown. Inclusion of the Argo implementation is dependent on CONFIG_ARGO. Introduces a new Xen command line parameter 'argo': bool to enable/disable the argo hypercall. Defaults to disabled. New headers: public/

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-08 Thread Ross Philipson
On 01/07/2019 02:42 AM, Christopher Clark wrote: > Initialises basic data structures and performs teardown of argo state > for domain shutdown. > > Inclusion of the Argo implementation is dependent on CONFIG_ARGO. > > Introduces a new Xen command line parameter 'argo': bool to enable/disable > th

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-08 Thread Christopher Clark
On Tue, Jan 8, 2019 at 2:09 PM Ross Philipson wrote: > > On 01/07/2019 02:42 AM, Christopher Clark wrote: > > Initialises basic data structures and performs teardown of argo state > > for domain shutdown. > > > > Inclusion of the Argo implementation is dependent on CONFIG_ARGO. > > > > Introduces

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-08 Thread Jason Andryuk
On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark wrote: > > Initialises basic data structures and performs teardown of argo state > for domain shutdown. > > Inclusion of the Argo implementation is dependent on CONFIG_ARGO. > > Introduces a new Xen command line parameter 'argo': bool to enable/disa

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-08 Thread Christopher Clark
On Tue, Jan 8, 2019 at 2:54 PM Jason Andryuk wrote: > > On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark > wrote: > > > > Initialises basic data structures and performs teardown of argo state > > for domain shutdown. > > > > Inclusion of the Argo implementation is dependent on CONFIG_ARGO. > > >

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-09 Thread Jan Beulich
>>> On 08.01.19 at 23:54, wrote: First of all - please trim your replies. > On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark > wrote: >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen-command-line.pandoc >> @@ -182,6 +182,17 @@ Permit Xen to use "Always Running APIC Timer" supp

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-09 Thread Jason Andryuk
On Wed, Jan 9, 2019 at 1:48 AM Christopher Clark wrote: > > On Tue, Jan 8, 2019 at 2:54 PM Jason Andryuk wrote: > > > > On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark > > wrote: > > > + > > > +/* A space-available notification that is awaiting sufficient space */ > > > +struct pending_ent > >

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-09 Thread Jason Andryuk
On Wed, Jan 9, 2019 at 4:35 AM Jan Beulich wrote: > > >>> On 08.01.19 at 23:54, wrote: > > First of all - please trim your replies. Sorry. Will do. > > On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark > > wrote: > >> --- a/docs/misc/xen-command-line.pandoc > >> +++ b/docs/misc/xen-command-li

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-09 Thread Jan Beulich
>>> On 09.01.19 at 15:26, wrote: > On Wed, Jan 9, 2019 at 4:35 AM Jan Beulich wrote: >> >>> On 08.01.19 at 23:54, wrote: >> > On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark >> > wrote: >> >> + */ >> >> +struct argo_ring_info *ring_info; >> >> +/* domain to be notified when space

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-09 Thread Christopher Clark
On Wed, Jan 9, 2019 at 6:16 AM Jason Andryuk wrote: > On Wed, Jan 9, 2019 at 1:48 AM Christopher Clark > wrote: > > On Tue, Jan 8, 2019 at 2:54 PM Jason Andryuk wrote: > > > On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark > > > wrote: > > > > > + > > > > +/* A space-available notification th

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-10 Thread Roger Pau Monné
aOn Mon, Jan 7, 2019 at 8:44 AM Christopher Clark wrote: > > Initialises basic data structures and performs teardown of argo state > for domain shutdown. > > Inclusion of the Argo implementation is dependent on CONFIG_ARGO. > > Introduces a new Xen command line parameter 'argo': bool to enable/di

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-10 Thread Jan Beulich
>>> On 10.01.19 at 11:19, wrote: > aOn Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > wrote: >> >> +/* Xen command line option to enable argo */ >> +static bool __read_mostly opt_argo_enabled; >> +boolean_param("argo", opt_argo_enabled); > > I would drop the opt_* prefix, new options added re

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-10 Thread Roger Pau Monné
On Thu, Jan 10, 2019 at 12:52 PM Jan Beulich wrote: > > >>> On 10.01.19 at 11:19, wrote: > > aOn Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > > wrote: > >> > >> +/* Xen command line option to enable argo */ > >> +static bool __read_mostly opt_argo_enabled; > >> +boolean_param("argo", opt_ar

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-10 Thread Jan Beulich
>>> On 10.01.19 at 13:26, wrote: > On Thu, Jan 10, 2019 at 12:52 PM Jan Beulich wrote: >> >> >>> On 10.01.19 at 11:19, wrote: >> > aOn Mon, Jan 7, 2019 at 8:44 AM Christopher Clark >> > wrote: >> >> >> >> +/* Xen command line option to enable argo */ >> >> +static bool __read_mostly opt_argo_

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-10 Thread Eric Chanudet
On 06/01/19 at 11:42pm, Christopher Clark wrote: +partner_rings_remove(struct domain *src_d) +ring_info = ring_find_info(dst_d, &send_info->id); ring_find_info is defined later (PATCH 07/15), should it be moved to this patch since it is now used here? -- Eric Chanudet __

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-10 Thread Christopher Clark
On Wed, Jan 9, 2019 at 6:38 AM Jan Beulich wrote: > > >>> On 09.01.19 at 15:26, wrote: > > On Wed, Jan 9, 2019 at 4:35 AM Jan Beulich wrote: > >> >>> On 08.01.19 at 23:54, wrote: > >> > On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark > >> > wrote: > >> >> + */ > >> >> +struct argo_ri

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-10 Thread Christopher Clark
On Thu, Jan 10, 2019 at 2:19 AM Roger Pau Monné wrote: > > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > wrote: > > > > Initialises basic data structures and performs teardown of argo state > > for domain shutdown. > > diff --git a/xen/common/argo.c b/xen/common/argo.c > > index 6f782f7..8

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-10 Thread Christopher Clark
On Thu, Jan 10, 2019 at 8:16 AM Eric Chanudet wrote: > > On 06/01/19 at 11:42pm, Christopher Clark wrote: > >+partner_rings_remove(struct domain *src_d) > > >+ring_info = ring_find_info(dst_d, &send_info->id); > ring_find_info is defined later (PATCH 07/15), should it be moved to

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-11 Thread Roger Pau Monné
On Fri, Jan 11, 2019 at 7:04 AM Christopher Clark wrote: > > On Thu, Jan 10, 2019 at 2:19 AM Roger Pau Monné wrote: > > > > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > > wrote: > > > +/* > > > + * Locking is organized as follows: > > > + * > > > + * Terminology: R() means taking a read l

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-11 Thread Jan Beulich
>>> On 07.01.19 at 08:42, wrote: > --- a/xen/common/argo.c > +++ b/xen/common/argo.c > @@ -17,7 +17,177 @@ > */ > > #include > +#include > +#include > +#include > +#include > +#include > #include > +#include > +#include > + > +DEFINE_XEN_GUEST_HANDLE(xen_argo_addr_t); > +DEFINE_XEN_

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Christopher Clark
On Fri, Jan 11, 2019 at 1:27 AM Roger Pau Monné wrote: > On Fri, Jan 11, 2019 at 7:04 AM Christopher Clark > wrote: > > > > On Thu, Jan 10, 2019 at 2:19 AM Roger Pau Monné wrote: > > > > > > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > > > wrote: > > > > +/* > > > > + * Locking is organi

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Christopher Clark
On Fri, Jan 11, 2019 at 3:54 AM Jan Beulich wrote: > > >>> On 07.01.19 at 08:42, wrote: > > --- a/xen/common/argo.c > > +++ b/xen/common/argo.c > > @@ -17,7 +17,177 @@ > > */ > > > > #include > > +#include > > +#include > > +#include > > +#include > > +#include > > #include > > +#inclu

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Roger Pau Monné
On Mon, Jan 14, 2019 at 9:32 AM Christopher Clark wrote: > > On Fri, Jan 11, 2019 at 1:27 AM Roger Pau Monné wrote: > > On Fri, Jan 11, 2019 at 7:04 AM Christopher Clark > > wrote: > > > > > > On Thu, Jan 10, 2019 at 2:19 AM Roger Pau Monné > > > wrote: > > > > > > > > On Mon, Jan 7, 2019 at

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Rich Persaud
> On Jan 14, 2019, at 06:32, Roger Pau Monné wrote: > > On Mon, Jan 14, 2019 at 9:32 AM Christopher Clark > wrote: >> >> I've written a document about the locking to add to the tree with the >> series, and a copy is at github here: >> >> https://github.com/dozylynx/xen/blob/0cb95385eba696ecf4

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Wei Liu
Hi all The locking scheme seems to be remaining sticking point. The rest are mostly cosmetic issues (FAOD, they still need to be addressed). Frankly I don't think there is enough time to address all the technical details, but let me sum up each side's position and see if we can reach an amicable

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Andrew Cooper
On 07/01/2019 07:42, Christopher Clark wrote: > Initialises basic data structures and performs teardown of argo state > for domain shutdown. > > Inclusion of the Argo implementation is dependent on CONFIG_ARGO. > > Introduces a new Xen command line parameter 'argo': bool to enable/disable > the arg

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 15:58, wrote: > On 07/01/2019 07:42, Christopher Clark wrote: >> --- a/xen/common/argo.c >> +++ b/xen/common/argo.c >> long >> do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > > I know I'm commenting on the wrong patch, but please use unsigned long > cmd, so

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Lars Kurth
Adding Juergen, to make sure he is aware of the discussion, as this is an excellent summary of the status of this series. > On 14 Jan 2019, at 14:46, Wei Liu wrote: > > Hi all > > The locking scheme seems to be remaining sticking point. The rest are > mostly cosmetic issues (FAOD, they still

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Christopher Clark
On Mon, Jan 14, 2019 at 6:47 AM Wei Liu wrote: > > Hi all > > The locking scheme seems to be remaining sticking point. The rest are > mostly cosmetic issues (FAOD, they still need to be addressed). Frankly > I don't think there is enough time to address all the technical details, > but let me sum

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Roger Pau Monné
On Mon, Jan 14, 2019 at 3:48 PM Wei Liu wrote: > > Hi all > > The locking scheme seems to be remaining sticking point. The rest are > mostly cosmetic issues (FAOD, they still need to be addressed). Frankly > I don't think there is enough time to address all the technical details, > but let me sum

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Christopher Clark
On Mon, Jan 14, 2019 at 6:58 AM Andrew Cooper wrote: > > On 07/01/2019 07:42, Christopher Clark wrote: > > Initialises basic data structures and performs teardown of argo state > > for domain shutdown. > > > > Inclusion of the Argo implementation is dependent on CONFIG_ARGO. > > > > Introduces a n

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Christopher Clark
On Mon, Jan 14, 2019 at 7:12 AM Jan Beulich wrote: > > >>> On 14.01.19 at 15:58, wrote: > > On 07/01/2019 07:42, Christopher Clark wrote: > >> --- a/xen/common/argo.c > >> +++ b/xen/common/argo.c > >> long > >> do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > > > > I know I'm c

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 08:21, wrote: > On Mon, Jan 14, 2019 at 6:58 AM Andrew Cooper > wrote: >> On 07/01/2019 07:42, Christopher Clark wrote: >> > --- a/docs/misc/xen-command-line.pandoc >> > +++ b/docs/misc/xen-command-line.pandoc >> > @@ -182,6 +182,17 @@ Permit Xen to use "Always Running APIC Ti

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-15 Thread Andrew Cooper
On 15/01/2019 09:01, Jan Beulich wrote: On 15.01.19 at 08:21, wrote: >> On Mon, Jan 14, 2019 at 6:58 AM Andrew Cooper >> wrote: >>> On 07/01/2019 07:42, Christopher Clark wrote: --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -182,6 +182,17

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-15 Thread Jan Beulich
>>> On 15.01.19 at 10:06, wrote: > On 15/01/2019 09:01, Jan Beulich wrote: > On 15.01.19 at 08:21, wrote: >>> On Mon, Jan 14, 2019 at 6:58 AM Andrew Cooper > wrote: On 07/01/2019 07:42, Christopher Clark wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-com

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-02-04 Thread Christopher Clark
On Mon, Jan 14, 2019 at 6:47 AM Wei Liu wrote: > > Hi all > > The locking scheme seems to be remaining sticking point. The rest are > mostly cosmetic issues (FAOD, they still need to be addressed). Frankly > I don't think there is enough time to address all the technical details, > but let me sum

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-02-05 Thread Wei Liu
On Mon, Feb 04, 2019 at 12:56:13PM -0800, Christopher Clark wrote: > > Wei, > > do you have any feedback on the latest argo MAINTAINERS patch? It looks fine to me. Wei. > > Christopher ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https