Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-23 Thread Julien Grall
Hi Andrew, On 21/11/2023 20:15, Andrew Cooper wrote: -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but this logic looks incorrect. It was inherited from the x86 side, where the logic was redundant and has now been removed. In the ARM case it inserts the image name into

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-23 Thread Andrew Cooper
On 23/11/2023 9:46 am, Luca Fancellu wrote: > >> On 22 Nov 2023, at 18:03, Andrew Cooper wrote: >> >> On 22/11/2023 3:49 pm, Luca Fancellu wrote: On 21 Nov 2023, at 20:41, Andrew Cooper wrote: On 21/11/2023 8:33 pm, Luca Fancellu wrote: > + CC henry > >> On 21 Nov 2023,

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-23 Thread Luca Fancellu
> On 22 Nov 2023, at 18:03, Andrew Cooper wrote: > > On 22/11/2023 3:49 pm, Luca Fancellu wrote: >> >>> On 21 Nov 2023, at 20:41, Andrew Cooper wrote: >>> >>> On 21/11/2023 8:33 pm, Luca Fancellu wrote: + CC henry > On 21 Nov 2023, at 20:15, Andrew Cooper wrote: > >

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-22 Thread Henry Wang
Hi, > On Nov 23, 2023, at 12:20, Henry Wang wrote: > > Hi, > >> On Nov 23, 2023, at 02:03, Andrew Cooper wrote: >> >> On 22/11/2023 3:49 pm, Luca Fancellu wrote: >>> On 21 Nov 2023, at 20:41, Andrew Cooper wrote: On 21/11/2023 8:33 pm, Luca Fancellu wrote: > + CC henry >

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-22 Thread Henry Wang
Hi, > On Nov 23, 2023, at 02:03, Andrew Cooper wrote: > > On 22/11/2023 3:49 pm, Luca Fancellu wrote: >> >>> On 21 Nov 2023, at 20:41, Andrew Cooper wrote: >>> >>> On 21/11/2023 8:33 pm, Luca Fancellu wrote: + CC henry > On 21 Nov 2023, at 20:15, Andrew Cooper wrote: > >>

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-22 Thread Stefano Stabellini
On Wed, 22 Nov 2023, Andrew Cooper wrote: > On 22/11/2023 3:49 pm, Luca Fancellu wrote: > > > >> On 21 Nov 2023, at 20:41, Andrew Cooper wrote: > >> > >> On 21/11/2023 8:33 pm, Luca Fancellu wrote: > >>> + CC henry > >>> > On 21 Nov 2023, at 20:15, Andrew Cooper > wrote: > >

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-22 Thread Andrew Cooper
On 22/11/2023 3:49 pm, Luca Fancellu wrote: > >> On 21 Nov 2023, at 20:41, Andrew Cooper wrote: >> >> On 21/11/2023 8:33 pm, Luca Fancellu wrote: >>> + CC henry >>> On 21 Nov 2023, at 20:15, Andrew Cooper wrote: -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer,

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-22 Thread Luca Fancellu
> On 21 Nov 2023, at 20:41, Andrew Cooper wrote: > > On 21/11/2023 8:33 pm, Luca Fancellu wrote: >> + CC henry >> >>> On 21 Nov 2023, at 20:15, Andrew Cooper wrote: >>> >>> -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but >>> this >>> logic looks incorrect. It was

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-22 Thread Andrew Cooper
On 22/11/2023 1:31 am, Henry Wang wrote: > Hi Both, > >> On Nov 22, 2023, at 04:41, Andrew Cooper wrote: >> >> On 21/11/2023 8:33 pm, Luca Fancellu wrote: >>> + CC henry >>> On 21 Nov 2023, at 20:15, Andrew Cooper wrote: -Wwrite-strings is unhappy with assigning "xen" to a mutable

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-21 Thread Henry Wang
Hi Both, > On Nov 22, 2023, at 04:41, Andrew Cooper wrote: > > On 21/11/2023 8:33 pm, Luca Fancellu wrote: >> + CC henry >> >>> On 21 Nov 2023, at 20:15, Andrew Cooper wrote: >>> >>> -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but >>> this >>> logic looks incorrect.

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-21 Thread Andrew Cooper
On 21/11/2023 8:33 pm, Luca Fancellu wrote: > + CC henry > >> On 21 Nov 2023, at 20:15, Andrew Cooper wrote: >> >> -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but >> this >> logic looks incorrect. It was inherited from the x86 side, where the logic >> was redundant and

Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()

2023-11-21 Thread Luca Fancellu
+ CC henry > On 21 Nov 2023, at 20:15, Andrew Cooper wrote: > > -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but this > logic looks incorrect. It was inherited from the x86 side, where the logic > was redundant and has now been removed. > > In the ARM case it inserts t