[PATCH] xen/arm: Add workaround for Cortex-A53 erratum #843419

2020-12-10 Thread Luca Fancellu
. The workaround is to enable the linker flag --fix-cortex-a53-843419 if present, to check and fix the affected sequence. Otherwise print a warning that Xen may be susceptible to this errata Signed-off-by: Luca Fancellu --- docs/misc/arm/silicon-errata.txt | 1 + xen/arch/arm/Kconfig | 19

Re: [PATCH v6 0/9] Use Doxygen and sphinx for html documentation

2021-06-07 Thread Luca Fancellu
Hello Xen community, Can someone have a look on these patches? Some of them are acked but some others needs review. Many thanks! Cheers, Luca > On 10 May 2021, at 09:40, Luca Fancellu wrote: > > This serie introduce doxygen in the sphinx html docs generation. > One benefit is

Re: [PATCH 03/10] tools/xenstore: Don't assume conn->in points to the LU request

2021-06-21 Thread Luca Fancellu
> On 16 Jun 2021, at 15:43, Julien Grall wrote: > > From: Julien Grall > > call_delayed() is currently assuming that conn->in is NULL when > handling delayed request. However, the connection is not paused. > Therefore new request can be processed and conn->in may be non-NULL > if we have

Re: [PATCH 04/10] tools/xenstored: Limit the number of requests a connection can delay

2021-06-21 Thread Luca Fancellu
gt; bypass the quota check. This would be useful when the function > is called from the restore code. > > Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu > --- > tools/xenstore/xenstored_control.c | 2 +- > tools/xenstore/xenstored_core.c| 11 ++- > tools/x

Re: [PATCH 05/10] tools/xenstored: xenstored_core.h should include fcntl.h

2021-06-21 Thread Luca Fancellu
cd831ee438 ("tools/xenstore: handle CLOEXEC flag for local files and > pipes") > Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu > --- > tools/xenstore/xenstored_core.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/xenstore/xenstored_cor

Re: [PATCH 06/10] tools/xenstored: Introduce a wrapper for conn->funcs->can_{read, write}

2021-06-21 Thread Luca Fancellu
functions can now be static. Note that the implementations need > to be moved earlier in the file xenstored_domain.c to avoid > declaring the prototype. > > Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu > --- > tools/xenstore/xenstored_core.c | 18 ++ > too

Re: [PATCH 07/10] tools/xenstored: delay_request: don't assume conn->in == in

2021-06-21 Thread Luca Fancellu
r to specify any request. > > To prevent any future surprise, check if the request delayed is the > current one. > > Fixes: c5ca1404b4 ("tools/xenstore: add support for delaying execution of a > xenstore request") > Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu &g

Re: [PATCH 08/10] tools/xenstored: Extend restore code to handle multiple input buffer

2021-06-21 Thread Luca Fancellu
want to bypass the quota check for delayed requests as > the new Xenstore may have a lower limit. > > Lastly, there is no need to change the specification as there was > no restriction on the number of in-flight requests preserved. > > Signed-off-by: Julien Grall Reviewed-by:

Re: [PATCH 09/10] tools/xenstored: Dump delayed requests

2021-06-21 Thread Luca Fancellu
-Update. > > Delayed requests are just complete "in" buffer. So the code is > refactored to allow sharing the code to dump "in" buffer. > > Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu > --- > tools/xenstore/xenstored_core.c | 42 ++

Re: [PATCH 10/10] tools/xenstored: Delay new transaction while Live-Update is pending

2021-06-21 Thread Luca Fancellu
With this stop gap in place, domains with long running transactions will > still break when using -F, but other domains which starts a transaction > in the middle of Live-Update will continue to work. > > Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu > --- > tools/xen

Re: [PATCH] tools/xenstored: Don't crash xenstored when Live-Update is cancelled

2021-06-21 Thread Luca Fancellu
ixes: af216a99fb ("tools/xenstore: add the basic framework for doing the > live update") > Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu > > > > This is currently based on top of: > > https://lore.kernel.org/xen-devel/20210616144324.31652

Re: [PATCH 02/10] tools/xenstored: Introduce lu_get_connection() and use it

2021-06-21 Thread Luca Fancellu
> Signed-off-by: Julien Grall Reviewed-by: Luca Fancellu > --- > tools/xenstore/xenstored_control.c | 13 - > tools/xenstore/xenstored_control.h | 2 ++ > tools/xenstore/xenstored_core.c| 7 +++ > tools/xenstore/xenstored_core.h| 1 - >

Re: [PATCH v5 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-12 Thread Luca Fancellu
> On 11 May 2021, at 22:58, Stefano Stabellini wrote: > > On Thu, 6 May 2021, Jan Beulich wrote: >> An alternative to correcting the (as it seems) v2 related issues, it >> may be worth considering to extract only v1 documentation in this >> initial phase. > > FWIW I agree with Jan that

Re: [PATCH v2 1/2] xen/char: console: Use const whenever we point to literal strings

2021-05-18 Thread Luca Fancellu
OGLVL_VAL_SZ, "%s/%s", lvl2opt[lower], lvl2opt[upper]); > } > > @@ -262,7 +263,7 @@ static int parse_guest_loglvl(const char *s) > return ret; > } > > -static char *loglvl_str(int lvl) > +static const char *loglvl_str(int lvl) > { > switch ( lvl ) > { > -- > 2.17.1 > Hi Julien, Seems good to me and very sensible. Reviewed-by: Luca Fancellu Cheers, Luca

Re: [PATCH] tools/xenstored: Remove unused parameter in check_domains()

2021-05-18 Thread Luca Fancellu
nstore/xenstored_domain.h > index dc9759171317..cc5147d7e747 100644 > --- a/tools/xenstore/xenstored_domain.h > +++ b/tools/xenstore/xenstored_domain.h > @@ -21,7 +21,7 @@ > > void handle_event(void); > > -void check_domains(bool restore); > +void check_domains(void); > > /* domid, mfn, eventchn, path */ > int do_introduce(struct connection *conn, struct buffered_data *in); > -- > 2.17.1 > > Reviewed-by: Luca Fancellu Cheers, Luca

[PATCH v6 9/9] docs/doxygen: doxygen documentation for grant_table.h

2021-05-10 Thread Luca Fancellu
for grant table for Arm64 Signed-off-by: Luca Fancellu --- v6 changes: - Fix misaligned comment - Moved comments to make them display in the docs - Included more documentation in the docs (see output here: https://luca.fancellu.gitlab.io/xen-docs/hypercall-interfaces/common/grant_tables.html) v5

[PATCH v6 7/9] docs: Change Makefile and sphinx configuration for doxygen

2021-05-10 Thread Luca Fancellu
for doxygen. Signed-off-by: Luca Fancellu --- .gitignore| 6 ++ docs/Makefile | 42 +++--- docs/conf.py | 48 +--- 3 files changed, 90 insertions(+), 6 deletions(-) diff --git a/.gitignore b/.gitignore

[PATCH v6 1/9] docs: add doxygen configuration file

2021-05-10 Thread Luca Fancellu
Add xen.doxyfile.in as template for the doxygen configuration file, it will be used to generate the doxygen documentation. Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini --- docs/xen.doxyfile.in | 2316 ++ 1 file changed, 2316 insertions

[PATCH v6 3/9] docs: add doxygen templates

2021-05-10 Thread Luca Fancellu
Add doxygen templates for the doxygen documentation. Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini --- docs/xen-doxygen/customdoxygen.css | 36 +++ docs/xen-doxygen/footer.html | 21 +++ docs/xen-doxygen/header.html | 56

[PATCH v6 0/9] Use Doxygen and sphinx for html documentation

2021-05-10 Thread Luca Fancellu
ot;aarch64-linux-gnu-" make -C docs XEN_TARGET_ARCH="arm64" sphinx-html now in docs/sphinx/html/ we have the generated docs starting from the index.html page. Luca Fancellu (9): docs: add doxygen configuration file docs: add Xen png logo for the doxygen documentation doc

[PATCH v6 2/9] docs: add Xen png logo for the doxygen documentation

2021-05-10 Thread Luca Fancellu
Add the xen-doxygen folder for the doxygen template and add the Xen png logo in it. Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini --- docs/xen-doxygen/xen_project_logo_165x67.png | Bin 0 -> 18223 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 docs/

[PATCH v6 5/9] docs: add checks to configure for sphinx and doxygen

2021-05-10 Thread Luca Fancellu
Add checks in the configure files to see if the system is capable of generate the sphinx html docs using doxygen and sphinx-breathe tools. Signed-off-by: Luca Fancellu --- config/Docs.mk.in | 2 + docs/configure| 258 ++ docs/configure.ac | 15

[PATCH v6 6/9] docs: add doxygen preprocessor and related files

2021-05-10 Thread Luca Fancellu
to be parsed by doxygen. The path sould be relative to the xen folder: E.g. xen/include/public/grant_table.h Signed-off-by: Luca Fancellu --- docs/xen-doxygen/doxy-preprocessor.py | 110 ++ docs/xen-doxygen/doxy_input.list | 0 docs/xen-doxygen/doxygen_include.h.in

[PATCH v6 8/9] docs: hypercalls sphinx skeleton for generated html

2021-05-10 Thread Luca Fancellu
Create a skeleton for the documentation about hypercalls Signed-off-by: Luca Fancellu --- v6 changes: - Now every platform has the same sections in .rst files --- .gitignore | 1 + docs/Makefile | 4 docs/hypercall-interfaces/arm32.rst

[PATCH v6 4/9] m4/python: add function to docs_tool.m4 and new m4 module

2021-05-10 Thread Luca Fancellu
Add ax_python_module.m4 to have a way to check if a python module is installed in the system. Add a function to docs_tool.m4 to throw an error if the required docs tool is missing. Signed-off-by: Luca Fancellu --- m4/ax_python_module.m4 | 56 ++ m4

Re: [PATCH] tools/xenstored: Prevent a buffer overflow in dump_state_node_perms()

2021-05-07 Thread Luca Fancellu
st void *state); > diff --git a/tools/xenstore/xenstored_domain.c > b/tools/xenstore/xenstored_domain.c > index 3d4d0649a243..580ed454a3f5 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -1254,7 +1254,7 @@ static const char *dump_state_special_node(FILE *fp, > const char *name, > if (fwrite(, sizeof(sn), 1, fp) != 1) > return "Dump special node error"; > > - ret = dump_state_node_perms(fp, , perms->p, perms->num); > + ret = dump_state_node_perms(fp, perms->p, perms->num); > if (ret) > return ret; > > -- > 2.17.1 > > Tested on FVP and another arm board, basic testing (run Xen, dom0, run one/two guests) - Everything fine. Reviewed-by: Luca Fancellu Cheers, Luca

Re: [PATCH v5 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-06 Thread Luca Fancellu
> On 4 May 2021, at 23:27, Stefano Stabellini wrote: > > On Tue, 4 May 2021, Luca Fancellu wrote: >> Modification to include/public/grant_table.h: >> >> 1) Add doxygen tags to: >> - Create Grant tables section >> - include variables in the genera

Re: [PATCH v5 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-06 Thread Luca Fancellu
> On 6 May 2021, at 10:58, Jan Beulich wrote: > > On 06.05.2021 10:48, Luca Fancellu wrote: >>> On 4 May 2021, at 23:27, Stefano Stabellini wrote: >>> On Tue, 4 May 2021, Luca Fancellu wrote: >>>> @@ -51,13 +55,10 @@ >>>> * know the real

Re: [PATCH v6 7/9] docs: Change Makefile and sphinx configuration for doxygen

2021-07-05 Thread Luca Fancellu
> On 2 Jul 2021, at 23:23, Stefano Stabellini wrote: > > On Fri, 2 Jul 2021, Luca Fancellu wrote: >>> On 1 Jul 2021, at 18:43, Stefano Stabellini wrote: >>> >>> On Thu, 1 Jul 2021, Luca Fancellu wrote: >>>>> On 24 Jun 2021, at 00:33, Stefan

Re: [PATCH] tools/xenstored: Stash the correct request in lu_status->in

2021-07-05 Thread Luca Fancellu
> On 1 Jul 2021, at 15:03, Julien Grall wrote: > > From: Julien Grall > > When Live-Updating with some load, Xenstored may hit the assert > req->in == lu_status->in in do_lu_start(). > > This is happening because the request is stashed when Live-Update > begins. This happens in a different

Re: [PATCH 03/10] tools/xenstore: Don't assume conn->in points to the LU request

2021-06-24 Thread Luca Fancellu
> On 24 Jun 2021, at 08:34, Juergen Gross wrote: > > On 24.06.21 09:32, Juergen Gross wrote: >> On 16.06.21 16:43, Julien Grall wrote: >>> From: Julien Grall >>> >>> call_delayed() is currently assuming that conn->in is NULL when >>> handling delayed request. However, the connection is not

Re: [PATCH v6 7/9] docs: Change Makefile and sphinx configuration for doxygen

2021-07-02 Thread Luca Fancellu
Hi Stefano, > On 1 Jul 2021, at 18:43, Stefano Stabellini wrote: > > On Thu, 1 Jul 2021, Luca Fancellu wrote: >>> On 24 Jun 2021, at 00:33, Stefano Stabellini wrote: >>> >>> On Mon, 10 May 2021, Luca Fancellu wrote: >>>> Modify docs/Makefi

Re: [PATCH v6 9/9] docs/doxygen: doxygen documentation for grant_table.h

2021-07-02 Thread Luca Fancellu
> On 1 Jul 2021, at 18:44, Stefano Stabellini wrote: > > On Thu, 1 Jul 2021, Luca Fancellu wrote: >> Hi Stefano, >> >>> On 24 Jun 2021, at 00:34, Stefano Stabellini wrote: >>> >>> On Mon, 10 May 2021, Luca Fancellu wrote: >>>> Mod

Re: [PATCH v6 6/9] docs: add doxygen preprocessor and related files

2021-07-01 Thread Luca Fancellu
> On 23 Jun 2021, at 23:03, Stefano Stabellini wrote: > > On Mon, 10 May 2021, Luca Fancellu wrote: >> Add preprocessor called by doxygen before parsing headers, >> it will include in every header a doxygen_include.h file >> that provides missing defines and i

Re: [PATCH v6 7/9] docs: Change Makefile and sphinx configuration for doxygen

2021-07-01 Thread Luca Fancellu
> On 24 Jun 2021, at 00:33, Stefano Stabellini wrote: > > On Mon, 10 May 2021, Luca Fancellu wrote: >> Modify docs/Makefile to call doxygen and generate sphinx >> html documentation given the doxygen XML output. >> >> Modify docs/conf.py sphinx configura

Re: [PATCH v6 8/9] docs: hypercalls sphinx skeleton for generated html

2021-07-01 Thread Luca Fancellu
> On 24 Jun 2021, at 00:34, Stefano Stabellini wrote: > > On Mon, 10 May 2021, Luca Fancellu wrote: >> Create a skeleton for the documentation about hypercalls >> >> Signed-off-by: Luca Fancellu >> --- >> v6 changes: >> - Now every

Re: [PATCH v6 9/9] docs/doxygen: doxygen documentation for grant_table.h

2021-07-01 Thread Luca Fancellu
Hi Stefano, > On 24 Jun 2021, at 00:34, Stefano Stabellini wrote: > > On Mon, 10 May 2021, Luca Fancellu wrote: >> Modification to include/public/grant_table.h: >> >> 1) Add doxygen tags to: >> - Create Grant tables section >> - include variables i

Re: [PATCH v7 9/9] docs/doxygen: doxygen documentation for grant_table.h

2021-07-05 Thread Luca Fancellu
Hi Jan, > On 5 Jul 2021, at 14:03, Jan Beulich wrote: > > On 05.07.2021 12:51, Luca Fancellu wrote: >> Modification to include/public/grant_table.h: >> >> 1) Add doxygen tags to: >> - Create Grant tables section >> - include variables in the genera

[PATCH v7 3/9] docs: add doxygen templates

2021-07-05 Thread Luca Fancellu
Add doxygen templates for the doxygen documentation. Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini --- docs/xen-doxygen/customdoxygen.css | 36 +++ docs/xen-doxygen/footer.html | 21 +++ docs/xen-doxygen/header.html | 56

[PATCH v7 1/9] docs: add doxygen configuration file

2021-07-05 Thread Luca Fancellu
Add xen.doxyfile.in as template for the doxygen configuration file, it will be used to generate the doxygen documentation. Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini --- docs/xen.doxyfile.in | 2316 ++ 1 file changed, 2316 insertions

[PATCH v7 9/9] docs/doxygen: doxygen documentation for grant_table.h

2021-07-05 Thread Luca Fancellu
for grant table Signed-off-by: Luca Fancellu --- v7 changes: - commit message changed - Add comment about grant table queries and uses to the documentation v6 changes: - Fix misaligned comment - Moved comments to make them display in the docs - Included more documentation in the docs v5 changes

[PATCH v7 6/9] docs: add doxygen preprocessor and related files

2021-07-05 Thread Luca Fancellu
-by: Luca Fancellu --- v7 changes: - add comment to address one limitation of the preprocessor and change commit message. --- docs/xen-doxygen/doxy-preprocessor.py | 116 ++ docs/xen-doxygen/doxy_input.list | 0 docs/xen-doxygen/doxygen_include.h.in | 32 +++ 3 files

[PATCH v7 2/9] docs: add Xen png logo for the doxygen documentation

2021-07-05 Thread Luca Fancellu
Add the xen-doxygen folder for the doxygen template and add the Xen png logo in it. Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini --- docs/xen-doxygen/xen_project_logo_165x67.png | Bin 0 -> 18223 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 docs/

[PATCH v7 4/9] m4/python: add function to docs_tool.m4 and new m4 module

2021-07-05 Thread Luca Fancellu
Add ax_python_module.m4 to have a way to check if a python module is installed in the system. Add a function to docs_tool.m4 to throw an error if the required docs tool is missing. Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini --- m4/ax_python_module.m4 | 56

[PATCH v7 8/9] docs: hypercalls sphinx skeleton for generated html

2021-07-05 Thread Luca Fancellu
Create a skeleton for the documentation about hypercalls. At this stage the documentation can be created only for one architecture at a time. Signed-off-by: Luca Fancellu --- v7 changes: - modify the commit message v6 changes: - Now every platform has the same sections in .rst files

[PATCH v7 5/9] docs: add checks to configure for sphinx and doxygen

2021-07-05 Thread Luca Fancellu
Add checks in the configure files to see if the system is capable of generating the sphinx html docs using doxygen and sphinx-breathe tools. Signed-off-by: Luca Fancellu Acked-by: Stefano Stabellini --- config/Docs.mk.in | 2 + docs/configure| 258

[PATCH v7 7/9] docs: Change Makefile and sphinx configuration for doxygen

2021-07-05 Thread Luca Fancellu
for doxygen. Signed-off-by: Luca Fancellu --- v7 changes: - in conf.py, get DOXYGEN_OUTPUT as environmental variable and add new types into cpp_id_attributes --- .gitignore| 6 ++ docs/Makefile | 43 --- docs/conf.py | 43

[PATCH v7 0/9] Use Doxygen and sphinx for html documentation

2021-07-05 Thread Luca Fancellu
ontains a dot, this is a known limitation of gitlab pages so there is nothing to worry about. Luca Fancellu (9): docs: add doxygen configuration file docs: add Xen png logo for the doxygen documentation docs: add doxygen templates m4/python: add function to docs_tool.m4 and new m4 module docs: add

Re: [PATCH v7 9/9] docs/doxygen: doxygen documentation for grant_table.h

2021-07-06 Thread Luca Fancellu
> On 5 Jul 2021, at 14:27, Jan Beulich wrote: > > On 05.07.2021 15:23, Luca Fancellu wrote: >> Hi Jan, >> >>> On 5 Jul 2021, at 14:03, Jan Beulich wrote: >>> >>> On 05.07.2021 12:51, Luca Fancellu wrote: >>>> Modification to

Re: [PATCH v7 9/9] docs/doxygen: doxygen documentation for grant_table.h

2021-07-06 Thread Luca Fancellu
> On 5 Jul 2021, at 15:20, Julien Grall wrote: > > Hi Luca, > > On 05/07/2021 11:51, Luca Fancellu wrote: >> Modification to include/public/grant_table.h: >> 1) Add doxygen tags to: >> - Create Grant tables section >> - include variables in

Re: Deploy XEN Project

2021-05-19 Thread Luca Fancellu
> On 19 May 2021, at 06:59, Technologyrss Mail > wrote: > > Hi, > > I am new user for DEV XEN project on my Centos server. Please guide me how to > install & deploy XEN project on centos 7? > Hi, I think you might write to xen-users@, here the mailing lists for Xen

Re: [PATCH] x86/shadow: fix DO_UNSHADOW()

2021-05-19 Thread Luca Fancellu
eading indentation. Besides adding the missing braces, > also adjust the two oddly formatted if()-s in the macro. > > Fixes: 90629587e16e ("x86/shadow: replace stale literal numbers in > hash_{vcpu,domain}_foreach()") > Signed-off-by: Jan Beulich Reviewed-by: Luca F

[PATCH v3 2/3] docs: hypercalls sphinx skeleton for generated html

2021-04-26 Thread Luca Fancellu
Create a skeleton for the documentation about hypercalls Signed-off-by: Luca Fancellu --- .gitignore | 1 + docs/Makefile | 4 docs/hypercall-interfaces/arm32.rst| 4 docs/hypercall-interfaces/arm64.rst| 32

[PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-26 Thread Luca Fancellu
Modification to include/public/grant_table.h: 1) Add doxygen tags to: - Create Grant tables section - include variables in the generated documentation 2) Add .rst file for grant table for Arm64 Signed-off-by: Luca Fancellu --- v3 changes: - removed tags to skip anonymous union/struct - moved

[PATCH v3 0/3] Use Doxygen and sphinx for html documentation

2021-04-26 Thread Luca Fancellu
ot;aarch64-linux-gnu-" make -C docs XEN_TARGET_ARCH="arm64" sphinx-html now in docs/sphinx/html/ we have the generated docs starting from the index.html page. Luca Fancellu (3): docs: add doxygen support for html documentation docs: hypercalls sphinx skeleton for generated html doc

Re: [PATCH v2 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-26 Thread Luca Fancellu
> On 22 Apr 2021, at 09:06, Jan Beulich wrote: > > On 22.04.2021 09:39, Luca Fancellu wrote: >>> On 20 Apr 2021, at 11:27, Jan Beulich wrote: >>> On 20.04.2021 11:42, Luca Fancellu wrote: >>>>> On 20 Apr 2021, at 10:14, Jan Beulich wrote: >

Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-29 Thread Luca Fancellu
> On 29 Apr 2021, at 14:11, Jan Beulich wrote: > > On 29.04.2021 11:50, Luca Fancellu wrote: >>> On 29 Apr 2021, at 10:04, Jan Beulich wrote: >>> On 28.04.2021 16:59, Luca Fancellu wrote: >>>>> On 27 Apr 2021, at 14:57, Jan Beulich wrote: >

Re: [PATCH] public/gnttab: relax v2 recommendation

2021-04-30 Thread Luca Fancellu
ucture is maintained largely for > + * backwards compatibility. New guests are recommended to support using > + * version 2 to overcome version 1 limitations, but to be able to fall back > + * to version 1. > */ > #if __XEN_INTERFACE_VERSION__ < 0x0003020a > #define grant_entry_v1 grant_entry > Reviewed-by: Luca Fancellu Cheers, Luca

Re: [PATCH v2 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-22 Thread Luca Fancellu
> On 20 Apr 2021, at 11:27, Jan Beulich wrote: > > On 20.04.2021 11:42, Luca Fancellu wrote: >>> On 20 Apr 2021, at 10:14, Jan Beulich wrote: >>> On 20.04.2021 10:46, Luca Fancellu wrote: >>>>> On 19 Apr 2021, at 12:05, Jan Beulich wrote: >

Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-29 Thread Luca Fancellu
> On 29 Apr 2021, at 10:04, Jan Beulich wrote: > > On 28.04.2021 16:59, Luca Fancellu wrote: >>> On 27 Apr 2021, at 14:57, Jan Beulich wrote: >>> On 26.04.2021 17:37, Luca Fancellu wrote: >>>> @@ -66,6 +67,7 @@ >>>> * compiler barrie

Re: [PATCH v5 2/3] docs: hypercalls sphinx skeleton for generated html

2021-05-05 Thread Luca Fancellu
> On 4 May 2021, at 23:30, Stefano Stabellini wrote: > > On Tue, 4 May 2021, Luca Fancellu wrote: >> Create a skeleton for the documentation about hypercalls > > Why is there a difference between the arm32, arm64 and x86_64 skeletons? > Shouldn't just we have one? Or

[PATCH v4 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-04 Thread Luca Fancellu
for grant table for Arm64 Signed-off-by: Luca Fancellu --- v4 changes: - Used @keepindent/@endkeepindent doxygen commands to keep text with spaces indentation. - drop changes to grant_entry_v1 comment, it will be changed and included in the docs in a future patch - Move docs .rst to "c

[PATCH v4 0/3] Use Doxygen and sphinx for html documentation

2021-05-04 Thread Luca Fancellu
ot;aarch64-linux-gnu-" make -C docs XEN_TARGET_ARCH="arm64" sphinx-html now in docs/sphinx/html/ we have the generated docs starting from the index.html page. Luca Fancellu (3): docs: add doxygen support for html documentation docs: hypercalls sphinx skeleton for generated html doc

[PATCH v4 2/3] docs: hypercalls sphinx skeleton for generated html

2021-05-04 Thread Luca Fancellu
Create a skeleton for the documentation about hypercalls Signed-off-by: Luca Fancellu --- .gitignore | 1 + docs/Makefile | 4 docs/hypercall-interfaces/arm32.rst| 4 docs/hypercall-interfaces/arm64.rst| 32

[PATCH v5 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-04 Thread Luca Fancellu
for grant table for Arm64 Signed-off-by: Luca Fancellu --- v5 changes: - Move GNTCOPY_* define next to the flags field v4 changes: - Used @keepindent/@endkeepindent doxygen commands to keep text with spaces indentation. - drop changes to grant_entry_v1 comment, it will be changed and included

[PATCH v5 0/3] Use Doxygen and sphinx for html documentation

2021-05-04 Thread Luca Fancellu
ot;aarch64-linux-gnu-" make -C docs XEN_TARGET_ARCH="arm64" sphinx-html now in docs/sphinx/html/ we have the generated docs starting from the index.html page. Luca Fancellu (3): docs: add doxygen support for html documentation docs: hypercalls sphinx skeleton for generated html doc

[PATCH v5 2/3] docs: hypercalls sphinx skeleton for generated html

2021-05-04 Thread Luca Fancellu
Create a skeleton for the documentation about hypercalls Signed-off-by: Luca Fancellu --- .gitignore | 1 + docs/Makefile | 4 docs/hypercall-interfaces/arm32.rst| 4 docs/hypercall-interfaces/arm64.rst| 32

Re: [PATCH v4 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-04 Thread Luca Fancellu
> On 4 May 2021, at 12:48, Jan Beulich wrote: > > On 04.05.2021 11:46, Luca Fancellu wrote: >> @@ -451,11 +466,6 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_transfer_t); >> * bytes to be copied. >> */ >> >> -#define _GNTCOPY_source_gref (0) &

Re: [PATCH v4 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-05-04 Thread Luca Fancellu
> On 4 May 2021, at 14:28, Jan Beulich wrote: > > On 04.05.2021 15:09, Luca Fancellu wrote: >>> On 4 May 2021, at 12:48, Jan Beulich wrote: >>> On 04.05.2021 11:46, Luca Fancellu wrote: >>>> @@ -451,11 +466,6 @@ DEFINE_XEN_GUEST_HANDLE(gnttab

Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-28 Thread Luca Fancellu
> On 27 Apr 2021, at 14:57, Jan Beulich wrote: > > On 26.04.2021 17:37, Luca Fancellu wrote: >> --- a/docs/hypercall-interfaces/arm64.rst >> +++ b/docs/hypercall-interfaces/arm64.rst >> @@ -8,6 +8,7 @@ Starting points >> .. toctree:: >>:ma

Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10

2021-03-24 Thread Luca Fancellu
> On 23 Mar 2021, at 19:26, Julien Grall wrote: > > > > On 23/03/2021 17:06, Luca Fancellu wrote: >> Hi all, > > Hi, > > Please avoid top posting when answering to a comment. This makes more > difficult to follow. > >> I have an update, c

Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10

2021-03-23 Thread Luca Fancellu
kernel) and we are trying to figure out what. > On 23 Mar 2021, at 12:36, Jason Andryuk wrote: > > On Mon, Mar 22, 2021 at 3:09 PM Luca Fancellu wrote: >> >> Hi Juergen, >> >> Yes you are right it was my mistake, as you said to remove the BU

[PATCH 0/3] Use Doxygen and sphinx for html documentation

2021-04-06 Thread Luca Fancellu
ot;aarch64-linux-gnu-" make -C docs XEN_TARGET_ARCH="arm64" sphinx-html now in docs/sphinx/html/ we have the generated docs starting from the index.html page. Luca Fancellu (3): docs: add doxygen support for html documentation docs: hypercalls sphinx skeleton for generated html doc

[PATCH 2/3] docs: hypercalls sphinx skeleton for generated html

2021-04-06 Thread Luca Fancellu
Create a skeleton for the documentation about hypercalls Signed-off-by: Luca Fancellu --- .gitignore | 1 + docs/Makefile | 4 docs/hypercall-interfaces/arm32.rst| 4 docs/hypercall-interfaces/arm64.rst| 32

[PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-06 Thread Luca Fancellu
-off-by: Luca Fancellu --- docs/hypercall-interfaces/arm64.rst | 1 + .../arm64/grant_tables.rst| 8 ++ docs/xen-doxygen/doxy_input.list | 1 + xen/include/public/grant_table.h | 79 --- 4 files changed, 59 insertions

[PATCH] xen/evtchn: Change irq_info lock to raw_spinlock_t

2021-04-06 Thread Luca Fancellu
("xen/events: don't unmask an event channel when an eoi is pending") Signed-off-by: Luca Fancellu --- drivers/xen/events/events_base.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_ba

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Luca Fancellu
> On 7 Apr 2021, at 09:10, Jan Beulich wrote: > > On 06.04.2021 23:46, Stefano Stabellini wrote: >> On Tue, 6 Apr 2021, Jan Beulich wrote: >>> On 06.04.2021 12:36, Luca Fancellu wrote: >>>> Modification to include/public/grant_table.h: >>>>

Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10

2021-03-23 Thread Luca Fancellu
. So seems that the BUG_ON(…) is needed and the unmask function should run with interrupt disabled, anyone knows why this change worked? > On 23 Mar 2021, at 15:39, Luca Fancellu wrote: > > Hi Jason, > > Thanks for your hints, unfortunately seems not an init problem because in t

Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10

2021-03-22 Thread Luca Fancellu
into the serie we can’t spot anything and that serie was also tested by others from the community. Do you have any idea on that? Thank you for your time. > On 19 Mar 2021, at 11:54, Jürgen Groß wrote: > > On 19.03.21 12:50, Luca Fancellu wrote: >> Hi Juergen, >> Could you conf

Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10

2021-03-18 Thread Luca Fancellu
Hi Juergen, If you are willing to do the patch I think it will be faster to being accepted, what about the BUG_ON(…) in evtchn_2l_unmask from events_2l.c file? Cheers, Luca > On 18 Mar 2021, at 07:54, Jürgen Groß wrote: > > On 17.03.21 15:32, Luca Fancellu wrote: >> Hi all

Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less

2021-03-18 Thread Luca Fancellu
Hi Julien, I will create a new serie with all the improvements we have discussed. Thank you for your time. Cheers, Luca > On 18 Mar 2021, at 11:13, Julien Grall wrote: > > > > On 17/03/2021 17:04, Luca Fancellu wrote: >> Hi, > > Hi Luca, > >> I’ve

xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10

2021-03-17 Thread Luca Fancellu
Hi all, we've been encountering an issue when using the kernel 5.10 with preempt_rt support for Dom0, the problem is that during the boot of Dom0, it hits a BUG_ON(!irqs_disabled()) from the function evtchn_fifo_unmask defined in events_fifo.c. This is the call stack: [ 17.817018]

Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less

2021-03-17 Thread Luca Fancellu
ing if the domain is NULL in is_hardware_domain(…). So, if the community agree, I can push a v2 patch with all the discussed things (moving dom0 creation code) Cheers, Luca > On 12 Mar 2021, at 11:31, Julien Grall wrote: > > Hi Luca, > > On 12/03/2021 09:38, L

Re: xen/evtchn: Dom0 boot hangs using preempt_rt kernel 5.10

2021-03-19 Thread Luca Fancellu
the BUG_ON(…)? Thank you for your time. Cheers, Luca > On 18 Mar 2021, at 08:47, Luca Fancellu wrote: > > Hi Juergen, > > If you are willing to do the patch I think it will be faster to being > accepted, what about the BUG_ON(…) in evtchn_2l_unmask from events_2l.c

Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less

2021-03-12 Thread Luca Fancellu
Hi all, > On 8 Mar 2021, at 14:12, Julien Grall wrote: > > Hi Luca, > > On 08/03/2021 11:56, Luca Fancellu wrote: >> This patch prevents the dom0 to be loaded skipping its >> building and going forward to build domUs when the dom0 >> kernel is not found

[PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less

2021-03-08 Thread Luca Fancellu
This patch prevents the dom0 to be loaded skipping its building and going forward to build domUs when the dom0 kernel is not found and at least one domU is present. Signed-off-by: Luca Fancellu --- xen/arch/arm/setup.c | 83 +++- 1 file changed, 59

[PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less

2021-03-08 Thread Luca Fancellu
This patch prevents the dom0 to be loaded skipping its building and going forward to build domUs when the dom0 kernel is not found and at least one domU is present. Signed-off-by: Luca Fancellu Change-Id: Ieb9630b80cc7be7688d7d5fff3f839958f142ac0 --- xen/arch/arm/setup.c | 83

[PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less

2021-03-08 Thread Luca Fancellu
This patch prevents the dom0 to be loaded skipping its building and going forward to build domUs when the dom0 kernel is not found and at least one domU is present. Signed-off-by: Luca Fancellu Change-Id: Ieb9630b80cc7be7688d7d5fff3f839958f142ac0 --- xen/arch/arm/setup.c | 83

Re: [PATCH] xen/arm: Prevent Dom0 to be loaded when using dom0less

2021-03-08 Thread Luca Fancellu
> On 8 Mar 2021, at 11:59, Julien Grall wrote: > > Hi Luca, > > On 08/03/2021 11:56, Luca Fancellu wrote: >> This patch prevents the dom0 to be loaded skipping its >> building and going forward to build domUs when the dom0 >> kernel is not found and at lea

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Luca Fancellu
> On 7 Apr 2021, at 14:13, Julien Grall wrote: > > Hi, > > On 06/04/2021 11:36, Luca Fancellu wrote: >> Modification to include/public/grant_table.h: >> 1) Change anonymous structure to be named structure, >>because doxygen can't deal with them. &g

Re: [PATCH 0/3] Use Doxygen and sphinx for html documentation

2021-04-07 Thread Luca Fancellu
> On 7 Apr 2021, at 14:07, Julien Grall wrote: > > > > On 06/04/2021 11:36, Luca Fancellu wrote: >> This serie introduce doxygen in the sphinx html docs generation. >> One benefit is to keep most of the documentation in the source >> files of xen so that it'

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-07 Thread Luca Fancellu
> On 7 Apr 2021, at 14:56, Julien Grall wrote: > > Hi Luca, > > On 07/04/2021 14:19, Luca Fancellu wrote: >>> On 7 Apr 2021, at 14:13, Julien Grall wrote: >>> >>> Hi, >>> >>> On 06/04/2021 11:36, Luca Fancellu wrote: >&

Re: [PATCH v2 1/4] xen/arm: Move dom0 creation in domain_build.c

2021-04-09 Thread Luca Fancellu
> On 9 Apr 2021, at 09:30, Julien Grall wrote: > > Hi Luca, > > On 08/04/2021 10:48, Luca Fancellu wrote: >> Move dom0 creation and start from setup.c to domain_build.c >> on a dedicate function. >> Signed-off-by: Luca Fancellu >> -

Re: [PATCH v2 4/4] xen/arm: Prevent Dom0 to be loaded when using dom0less

2021-04-09 Thread Luca Fancellu
> On 9 Apr 2021, at 10:12, Julien Grall wrote: > > Hi Luca, > > On 08/04/2021 10:48, Luca Fancellu wrote: >> This patch prevents the dom0 to be loaded skipping its >> building and going forward to build domUs when the dom0 >> kernel is not found and at lea

Re: [PATCH v3 1/4] xen/arm: Move dom0 creation in domain_build.c

2021-04-13 Thread Luca Fancellu
> On 13 Apr 2021, at 17:40, Julien Grall wrote: > > Hi Luca, > > On 12/04/2021 11:52, Luca Fancellu wrote: >> Move dom0 creation and start from setup.c to domain_build.c >> on a dedicate function. > > s/dedicate/dedicated/ > > I would also suggest

Re: [PATCH v3 3/4] xen/arm: Reserve domid 0 for Dom0

2021-04-13 Thread Luca Fancellu
send soon Cheers, Luca > > On 12/04/2021 11:52, Luca Fancellu wrote: >> This patch adds a comment in create_domUs() right before >> domain_create() to explain the importance of the pre-increment >> operator on the variable max_init_domid, to ensure that the >>

[PATCH v3 2/4] xen/arm: Handle cases when hardware_domain is NULL

2021-04-12 Thread Luca Fancellu
is equal to the hardware_domain, change this cases to use is_hardware_domain() function instead. Signed-off-by: Luca Fancellu --- v3 changes: - removed unneeded parenthesis for macro is_domain_direct_mapped - is_hardware_domain() checks for the passed domain and if it is NULL, it returns false

[PATCH v3 1/4] xen/arm: Move dom0 creation in domain_build.c

2021-04-12 Thread Luca Fancellu
Move dom0 creation and start from setup.c to domain_build.c on a dedicate function. Signed-off-by: Luca Fancellu --- v3 changes: - move create_dom0 function after construct_dom0 and make construct_dom0 static --- xen/arch/arm/domain_build.c | 38 - xen/arch

[PATCH v3 3/4] xen/arm: Reserve domid 0 for Dom0

2021-04-12 Thread Luca Fancellu
to the domain_create() function. Signed-off-by: Luca Fancellu --- Changes in v3: - removed check introduced in v2. --- xen/arch/arm/domain_build.c | 5 + 1 file changed, 5 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 359957dc1b..b1d7b9849f 100644

[PATCH v3 4/4] xen/arm: Prevent Dom0 to be loaded when using dom0less

2021-04-12 Thread Luca Fancellu
This patch prevents the dom0 to be loaded skipping its building and going forward to build domUs when the dom0 kernel is not found and at least one domU is present. Signed-off-by: Luca Fancellu --- v3 changes: - Rephrase documentation --- docs/features/dom0less.pandoc | 7 +++--- xen/arch/arm

  1   2   3   4   5   6   7   8   9   10   >