Re: [xmail] XMail 1.27-pre01

2009-10-22 Thread Oliver Stöneberg
I also recognised the fflush() I mentioned in an earlier mail is still in the source. No it's not. Sorry, you are right. I overlooked it. Thanks. ___ xmail mailing list xmail@xmailserver.org http://xmailserver.org/mailman/listinfo/xmail

Re: [xmail] XMail 1.27-pre01

2009-10-20 Thread Oliver Stöneberg
On Fri, 16 Oct 2009, Davide Libenzi wrote: Here are the links: http://www.xmailserver.org/xmail-1.27-pre01.tar.gz http://www.xmailserver.org/xmail-1.27-pre01.win32bin.zip ChangeLog is included inside the archives. Forgot to add that there is a new version of the OpenSSL DLLs

[xmail] VS2008 compilation problem

2009-10-16 Thread Oliver Stöneberg
Because of the IPv6 stuff I had to move on to VS2008 for XMail and I wasn't able to compile it: D:\xmail-1.26\win32ssl\include\openssl/ossl_typ.h(178) : error C2143: syntax error : missing ')' before 'constant' D:\xmail-1.26\win32ssl\include\openssl/ossl_typ.h(178) : error C2143: syntax error

[xmail] warnings with -Wshadow

2009-10-15 Thread Oliver Stöneberg
Sorry for this rather verbose report, but I thought I add them all. I was mainly concerned about the global handle thing. In CRTLSvr.cpp the functions CTRLGetConfigCopy(), CTRLLogEnabled() and CTRLThreadCountAdd() have a parameter named hShbCTRL. Unfortunately there also exists a global

[xmail] Typos in error messages

2009-10-15 Thread Oliver Stöneberg
ERR_LOADMODULE and ERR_LOADMODULESYMBOL say moading instead of loading in their messages. ___ xmail mailing list xmail@xmailserver.org http://xmailserver.org/mailman/listinfo/xmail

[xmail] another batch of source comments

2009-10-14 Thread Oliver Stöneberg
Thanks for the reply on my first mail. Here's a few more notes. SMAILUtils.cpp The function USmlExtractToAddress() is not used at all. SMTPSvr.cpp In the function SMTPFilterMessage() a fflush() is performed before the fclose(). I think this is unncessary as fclose() implies a fflush()

Re: [xmail] another batch of source comments

2009-10-14 Thread Oliver Stöneberg
On Wed, 14 Oct 2009, Oliver Stöneberg wrote: Thanks for the reply on my first mail. Here's a few more notes. SMAILUtils.cpp The function USmlExtractToAddress() is not used at all. Right, by it stays. Like the others just FYI. SMTPSvr.cpp In the function SMTPFilterMessage

[xmail] Minor notes on the source

2009-10-08 Thread Oliver Stöneberg
Hey, here are just a few things I recognised after looking at various parts of the source: CTRLSvr.cpp In the function CTRLHandleSession() the local variable iTimeout is unused. It's a copy of pCTRLCfg-iTimeout that is not necessary as the rest of the function is accessing it directly.

Re: [xmail] relay email for an individual email address

2009-10-08 Thread Oliver Stöneberg
On Thu, 8 Oct 2009, Oliver Stöneberg wrote: - Second, taking a look at mailproc.tab file that can be associated with a local mailbox to do some specific process. It permit such redirections :) In your case, create a real u...@mydomain.com mailbox on your xmail server

[xmail] XMail not seeding evenly

2009-08-07 Thread Oliver Stöneberg
There are a few cases in that XMail is distributing data randomly to various destinations (e.g. relay domains or internal spool folders - the code with rand() % count). It's not distributing the data evenly in theses cases, so you end up with e.g. one server getting or traffic or one spool

[xmail] SysEventLogV() always logs an error on Unix

2009-08-05 Thread Oliver Stöneberg
The function SysEventLogV() does ignore the iLogLevel parameter and always logs an error in the unix implementation. The win32 implementation properly uses the parameter to log different kinds of messages. ___ xmail mailing list xmail@xmailserver.org

[xmail] Problem exposed by -Wextra

2009-07-16 Thread Oliver Stöneberg
Compiling XMail with -Wextra produces this warning: SysDepUnix.cpp: In function int SysSendFileMMap(SYS_SOCKET, const char*, SYS_OFF_T, SYS_OFF_T, int): SysDepUnix.cpp:539: warning: comparison of unsigned expression 0 is always false The affected line is: if ((iCurrSend = SysSendData(SockFD,

Re: [xmail] XMail 1.26-pre06

2009-06-24 Thread Oliver Stöneberg
On Wed, 24 Jun 2009, Oliver Stöneberg wrote: I was refering to the SMTPResetSession() calls in SMTPHandleCmd_DATA() in SMTPSvr.cpp. In 1.26-pre06 you removed the single occurance at the end of the function and added three seperate ones in the different cases. The empty message ID

Re: [xmail] XMail 1.26-pre06

2009-05-19 Thread Oliver Stöneberg
The reset of the session before the 250 OK causes XMail to return an empty message ID: Trying 192.168.56.98... Connected to 192.168.56.98. Escape character is '^]'. 220 XMail ESMTP server ready helo test.test 250 example.com mail from: 250 OK rcpt to:t...@example.com 250 OK data 354 Start mail

[xmail] No more errors in XMAIL log?

2009-05-18 Thread Oliver Stöneberg
I am curious why the logging of SMAIL errors has been removed from the smail log. Version 1.22 was writing errors like this, which were quite helpful: example.com 1238664198223.65541.5.lancelot.ganz.alt E4B57800- 810A-491D-BA31-2ECB72557CFApostmas...@example.com

[xmail] MSVC6 compilation fails

2009-05-18 Thread Oliver Stöneberg
It's not possible to compile with MSVC6 (yes, unfortunately some people still have to use it...), because the function _CrtSetReportHook2() doesn't exist. Maybe the calls should be put in a #if _MSC_VER 1200 (not sure when it was introduced) block so you don't have to modify the code to

[xmail] compilation with older OpenSSL fails

2009-05-18 Thread Oliver Stöneberg
We have to use an older OpenSSL version to compile XMail with and that version doesn't contain the function CRYPTO_cleanup_all_ex_data() yet. I put #if OPENSSL_VERSION_NUMBER 0x0090602fL around it, but I am not sure, if that is the proper version to check for.

Re: [xmail] No more errors in XMAIL log?

2009-05-18 Thread Oliver Stöneberg
Argh! I am very sorry. This code was never in xmail 1.22 - it was an unmarked modification to the code, so it didn't get ported over to the new version... Still it would be a nice feature :-) I am curious why the logging of SMAIL errors has been removed from the smail log. Version 1.22 was

Re: [xmail] compilation with older OpenSSL fails

2009-05-18 Thread Oliver Stöneberg
On Mon, 18 May 2009, Oliver Stöneberg wrote: We have to use an older OpenSSL version to compile XMail with and that version doesn't contain the function CRYPTO_cleanup_all_ex_data() yet. I put #if OPENSSL_VERSION_NUMBER 0x0090602fL around it, but I am not sure, if that is the proper

Re: [xmail] Segmentation Fault on SLES10

2009-05-15 Thread Oliver Stöneberg
On Tue, 5 May 2009, Oliver Stöneberg wrote: I was gonna say impossible because of the 'state check at the beginning of the RCPT handling command, but then I remembered SMTPFilterMessage(). Needs better handling if we fail to re-open the file. Will fix ASAP. I also saw

Re: [xmail] Segmentation Fault on SLES10

2009-05-15 Thread Oliver Stöneberg
I'll make a new pre-release this weekend. There are a few other things in there... nice. ___ xmail mailing list xmail@xmailserver.org http://xmailserver.org/mailman/listinfo/xmail

Re: [xmail] XMail does not shut down on SIGINT

2009-05-08 Thread Oliver Stöneberg
On Thu, 7 May 2009, Oliver Stöneberg wrote: When you send a SIGINT (STRG+C) to XMail it might not shutdown properly as some threads are still active. You need to send it again at least once to get XMail to actually shutdown. It was an installation, that was still getting mails

[xmail] XMail does not shut down on SIGINT

2009-05-07 Thread Oliver Stöneberg
When you send a SIGINT (STRG+C) to XMail it might not shutdown properly as some threads are still active. You need to send it again at least once to get XMail to actually shutdown. It was an installation, that was still getting mails and the threads were SMTP ones. It appears to me the

Re: [xmail] Segmentation Fault on SLES10

2009-05-05 Thread Oliver Stöneberg
I was gonna say impossible because of the 'state check at the beginning of the RCPT handling command, but then I remembered SMTPFilterMessage(). Needs better handling if we fail to re-open the file. Will fix ASAP. I also saw that function, but didn't look into it too deeply before. Now I

Re: [xmail] Segmentation Fault on SLES10

2009-05-04 Thread Oliver Stöneberg
I also just realised, that iRcptCount and iErrorsCount are both already have a count of 1. So it might be an issue when there is an error while receiving various RCPT commands. I have no logfiles at the moment, but with the next crash I should also have those. I am getting segmentation faults

[xmail] Segmentation Fault on SLES10

2009-05-04 Thread Oliver Stöneberg
I am getting segmentation faults on a SLES10 system with 1.25 built from the official sources. Here's the backtrace and some information: Program terminated with signal 11, Segmentation fault. #0 0xb7b702b5 in vfprintf () from /lib/libc.so.6 (gdb) bt #0 0xb7b702b5 in vfprintf () from

[xmail] specfile out-of-date and download issue

2009-04-30 Thread Oliver Stöneberg
The specfile in the 1.25 distribution still has the version 1.23 and the Copyright: field needs to be changed to License: (at least on SLES10). Also the source is being downloaded as xmail-1.25.tar.tar when I use IE7 or IE8, although the URL shows tar.gz and it is indeed a tar.gz.

[xmail] Return-Path missing in delivery error notifications

2008-11-27 Thread Oliver Stöneberg
Quoting RFC 2821 section 6.1: If there is a delivery failure after acceptance of a message, the receiver-SMTP MUST formulate and mail a notification message. This notification MUST be sent using a null () reverse path in the envelope. The recipient of this notification MUST be the

[xmail] typo in Errors.cpp

2008-11-27 Thread Oliver Stöneberg
I wanted to mention this in my last mail, but forgot. The error string for ERR_CFG_VAR_NOT_FOUND has a small typo. It should say variable instead. ___ xmail mailing list xmail@xmailserver.org http://xmailserver.org/mailman/listinfo/xmail

[xmail] Re: XMail crashes when the logs reach 2 GB in size

2008-10-22 Thread Oliver Stöneberg
On Tue, 21 Oct 2008, Oliver St=F6neberg wrote: When any of the XMail log files reaches 2 GB in size, it still crash on the next try to write to it. This is caused by the default fopen() not supporting files 2 GB (at least on the old Red Hat 8.0 platform we are using). It can be fixed

[xmail] XMail crashes when the logs reach 2 GB in size

2008-10-21 Thread Oliver Stöneberg
When any of the XMail log files reaches 2 GB in size, it still crash on the next try to write to it. This is caused by the default fopen() not supporting files 2 GB (at least on the old Red Hat 8.0 platform we are using). It can be fixed by compiling it with -D_FILE_OFFSET_BITS=64. - To

[xmail] Re: multiple smtprelay servers for custdomains and 5xx er rors

2008-09-16 Thread Oliver Stöneberg
On Sat, 26 Apr 2008, Davide Libenzi wrote: On Thu, 24 Apr 2008, Oliver St=F6neberg wrote: On Tue, 22 Apr 2008, CLEMENT Francis wrote: Seems there was some post about this. The BIG figure is when the final domain have multiple mx servers= .. Suppose the final domain

[xmail] Problem with empty DefaultSMTPGateways

2008-09-16 Thread Oliver Stöneberg
There is a problem, if you got a server.tab with an empty DefaultSMTPGateways entry. The code in USmtpGetMailExchangers() in SMTPUtils.cpp will return a valid, but empty array of gateways, so it won't even try to send the mail anywhere and will drop the message silently. This might be the

[xmail] Re: Problem with empty DefaultSMTPGateways

2008-09-16 Thread Oliver Stöneberg
There is also a similar problem with SmartDNSHost in USmtpGetDomainMX(). But in the case of an empty value you get at least the ERR_BAD_SMARTDNSHOST_SYNTAX error. BTW I am getting delivery errors for the address [EMAIL PROTECTED] soft.com.ph when I send a mail to the mailing list. There is a

[xmail] XMail accepts invalid mail addresses

2008-06-18 Thread Oliver Stöneberg
OK, I give it another try. This time I leave out the misinterpretation of the RFC and go straight for the issue: XMail accepts mail from and to invalid addresses. The invalid addresses are starting with a colon (':') or a comma (','). The latter cannot be send from a normal client as they

[xmail] Invalid mail addresses?

2008-04-30 Thread Oliver Stöneberg
Today I recognised, that some mails with invalid mail addresses were received by XMail. It were always mails, that started with a colon (e.g.:rekc|[EMAIL PROTECTED]). I checked the RFC again and it appears, the colon is not a valid atom, but there is the obs-local-part (as described in section

[xmail] Re: Invalid mail addresses?

2008-04-30 Thread Oliver Stöneberg
-Message d'origine- De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] la part de Oliver St=F6neberg Envoy=E9 : mercredi 30 avril 2008 17:01 =C0 : xmail@xmailserver.org Objet : [xmail] Invalid mail addresses? Today I recognised, that some mails with invalid mail addresses were=20

[xmail] Re: multiple smtprelay servers for custdomains and 5xx er rors

2008-04-24 Thread Oliver Stöneberg
On Tue, 22 Apr 2008, CLEMENT Francis wrote: Seems there was some post about this. The BIG figure is when the final domain have multiple mx servers. Suppose the final domain have two mx and one is misconfigured and return a 5xx. So if xmail tries first the 'bad' server, what to do

[xmail] non-RFC compliant Received headers

2008-04-22 Thread Oliver Stöneberg
XMail 1.24 writes Received headers, that are looking like this: Received: from [9.145.228.148] ([192.168.56.85]:3022) by example.com ([192.168.56.102]:25) with [XMail 1.24 ESMTP Server] id 825E7D24-FB9C-46E1-8D27-D3988F776D8F for [EMAIL PROTECTED] from [EMAIL PROTECTED];

[xmail] multiple smtprelay servers for custdomains and 5xx errors

2008-04-22 Thread Oliver Stöneberg
Recently a issue with 5xx errors and multiple servers in the smtprelay option for a custdomain arose with XMail 1.24. When the first entry returns a 5xx error, XMail still tries to send it to the other servers. In case of a 4xx error or a connection issue, that would make sense. But not for a

[xmail] Re: bug fix for xmail crash (core dump) when build in Win32 debug mode

2007-11-20 Thread Oliver Stöneberg
On Tue, 20 Nov 2007, Gerrit E.G. Hobbelt wrote: Davide Libenzi wrote: I think this (and many of the patches you sent) it is just *your* problems with a broken compiler. The Standard define non-local non-initialized object to be pre-initialized with zero. Please do not post

[xmail] Re: 1.25-pre20

2007-10-31 Thread Oliver Stöneberg
I forgot about making the new pre-release: http://www.xmailserver.org/xmail-1.25-pre20.tar.gz http://www.xmailserver.org/xmail-1.25-pre20.win32bin.zip This has the new PSYNC timeout option, and I also updated OpenSSL binaries to the new version. - Davide You included the

[xmail] Re: 1.25-pre20

2007-10-31 Thread Oliver Stöneberg
I forgot about making the new pre-release: http://www.xmailserver.org/xmail-1.25-pre20.tar.gz http://www.xmailserver.org/xmail-1.25-pre20.win32bin.zip This has the new PSYNC timeout option, and I also updated OpenSSL binaries to the new version. - Davide You included

[xmail] missing RFC822 atom

2007-10-09 Thread Oliver Stöneberg
The character ` (hex 0x96) is missing in your list of the valid RFC 822 atoms. If you look at section 3.3, you will see, that it is not part of the exclusions. So long Oliver - To unsubscribe from this list: send the line unsubscribe xmail in the body of a message to [EMAIL PROTECTED] For

[xmail] Re: missing RFC822 atom

2007-10-09 Thread Oliver Stöneberg
On Tue, 9 Oct 2007, Oliver St=F6neberg wrote: The character ` (hex 0x96) is missing in your list of the valid RFC 822 atoms. If you look at section 3.3, you will see, that it is not part of the exclusions. If you notice though, text, atom, qtext, dtext and quoted-pair= , all talks

[xmail] Re: 1.25-pre18

2007-09-26 Thread Oliver Stöneberg
On Mon, 24 Sep 2007, Oliver St=F6neberg wrote: Sorry, I was busy with other stuff and completely forgot about this. The changes didn't fix the problem for me. You also won't get a proper error for a failed shutdown function as stated in the SSL documentation. This was a bitch to

[xmail] Re: 1.25-pre18

2007-09-26 Thread Oliver Stöneberg
On Wed, 26 Sep 2007, Davide Libenzi wrote: On Wed, 26 Sep 2007, Oliver St=F6neberg wrote: On Mon, 24 Sep 2007, Oliver St=3DF6neberg wrote: Sorry, I was busy with other stuff and completely forgot about t= his. The changes didn't fix the problem for me. You also won't get

[xmail] Re: 1.25-pre18

2007-09-24 Thread Oliver Stöneberg
Sorry, I was busy with other stuff and completely forgot about this. The changes didn't fix the problem for me. You also won't get a proper error for a failed shutdown function as stated in the SSL documentation. This tries to fix the MS AUTH LOGIN, a problem with SSL connection reset (for

[xmail] Re: XMail closes TLS connection with a RST

2007-09-04 Thread Oliver Stöneberg
On Mon, 3 Sep 2007, Oliver St=F6neberg wrote: This appears to work. I know get 1 as result of the second call. I still need to check, if a RST is still occuring. Also, this code only works on Linux. You have to use the define SD_SEND on windows. s/Linux/Unix/ ;) Of course, I already

[xmail] Re: XMail closes TLS connection with a RST

2007-09-03 Thread Oliver Stöneberg
On Fri, 31 Aug 2007, Davide Libenzi wrote: On Fri, 31 Aug 2007, Oliver St=F6neberg wrote: On Fri, 10 Aug 2007, Oliver St=3DF6neberg wrote: Hi, we recently started using the TLS features of the XMail and duri= ng a tcpdump session, someone discovered an issue. After

[xmail] Re: XMail closes TLS connection with a RST

2007-08-31 Thread Oliver Stöneberg
On Fri, 10 Aug 2007, Oliver St=F6neberg wrote: Hi, we recently started using the TLS features of the XMail and during a tcpdump session, someone discovered an issue. After the communication is done and the communication should be closed the sending XMail will send a RST, instead

[xmail] XMail closes TLS connection with a RST

2007-08-10 Thread Oliver Stöneberg
Hi, we recently started using the TLS features of the XMail and during a tcpdump session, someone discovered an issue. After the communication is done and the communication should be closed the sending XMail will send a RST, instead of closing the connection properly. The mail is being send