[Xmame] xf86_dga2.c and deprecated DGA function

2002-01-25 Thread Fernand Albarracin
Hi xmame people, Here is a small patch that replace a call to a DGA1 function with the matching DGA2 version. diff -ru xmame-0.57.1/src/unix/video-drivers/xf86_dga2.c xmame-0.57.1-f/src/unix/video-drivers/xf86_dga2.c --- xmame-0.57.1/src/unix/video-drivers/xf86_dga2.c Wed Jan 2 03:45:56 20

Re: [Xmame] xf86_dga2.c and deprecated DGA function

2002-01-26 Thread Shyouzou Sugitani
Fernand Albarr wrote: > Here is a small patch that replace a call to a DGA1 function with the > matching DGA2 version. Thanks. > - we are in an initialization routine, I suppose we don't care when the > location adjustement will be done, am I missing something here ? But there is no other ro

Re: [Xmame] xf86_dga2.c and deprecated DGA function

2002-01-26 Thread Shyouzou Sugitani
> My idea: > - In xf86_dga2_create_display() replace XDGASetViewport(); with >"xf86_dga_fix_viewport = 1;". > - In xf86_dga2_update_display() check xf86ctx.modes->viewportFlags and use >"XDGAFlipImmediate" or "XDGAFlipRetrace" with XDGAGetViewportStatus(). Attached patch is an implemen

Re: [Xmame] xf86_dga2.c and deprecated DGA function

2002-01-26 Thread Shyouzou Sugitani
> Attached patch is an implementation of my idea, but not tested. Attached is a correct(tested) patch. Shyouzou Sugitani <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> --- src/unix/video-drivers/xf86_dga2.c.dist Sun Jan 27 01:08:30 2002 +++ src/unix/video-drivers/xf86_dga2

Re: [Xmame] xf86_dga2.c and deprecated DGA function

2002-01-26 Thread Fernand Albarracin
On Sat 26 Jan 2002 at 17:49:36 +0900, Shyouzou Sugitani wrote: > > - we are in an initialization routine, I suppose we don't care when the > > location adjustement will be done, am I missing something here ? Hmmm, what I didn't know at that point is that the code didn't perform any location ad

Re: [Xmame] xf86_dga2.c and deprecated DGA function

2002-01-26 Thread Shyouzou Sugitani
> > > - we are in an initialization routine, I suppose we don't care when the > > > location adjustement will be done, am I missing something here ? > > Hmmm, what I didn't know at that point is that the code didn't perform > any location adjustement in the normal case ... Is the default view

Re: [Xmame] xf86_dga2.c and deprecated DGA function

2002-01-26 Thread Fernand Albarracin
On Sun 27 Jan 2002 at 11:37:33 +0900, Shyouzou Sugitani wrote: > Is the default view port always set to (0,0)? I think it is safe to > call XDGASetViewport(,,0,0,) in xf86_dga2_create_display(). Well, the documentation doesn't say anything on this. You suspect that the viewport may be in an und

Re: [Xmame] xf86_dga2.c and deprecated DGA function

2002-01-26 Thread Shyouzou Sugitani
Fernand, how do you think about this patch? Shyouzou Sugitani <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> --- src/unix/video-drivers/xf86_dga2.c.dist Sat Jan 26 19:18:01 2002 +++ src/unix/video-drivers/xf86_dga2.c Sun Jan 27 11:56:35 2002 @@ -315,8 +315,6 @@

Re: [Xmame] xf86_dga2.c and deprecated DGA function

2002-01-27 Thread Fernand Albarracin
On Sun 27 Jan 2002 at 12:44:35 +0900, Shyouzou Sugitani wrote: > Fernand, how do you think about this patch? > - xf86_dga_fix_viewport = 0; > - xf86_dga_first_click = 1; There is a flaw here, not a big problem though. Look at xinput.c : /* Some buggy combination of XFree and

Re: [Xmame] xf86_dga2.c and deprecated DGA function

2002-01-27 Thread Shyouzou Sugitani
OK. Attached is the final patch. Fernand, thank you very much. Shyouzou Sugitani <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> --- src/unix/video-drivers/xf86_dga2.c.dist Sat Jan 26 19:18:01 2002 +++ src/unix/video-drivers/xf86_dga2.c Mon Jan 28 06:35:23 2002 @@ -315,8 +3

Re: [Xmame] xf86_dga2.c and deprecated DGA function

2002-01-29 Thread Lawrence Gold
On Mon, Jan 28, 2002 at 06:52:24AM +0900, Shyouzou Sugitani wrote: > > OK. Attached is the final patch. > Fernand, thank you very much. I'll apply this to 0.57.2, which I hope to release in the next week or so. Thanks! ___ Xmame mailing list [EMAIL