left one
> + * of our surfaces might not have been shown. In that case we'll
> + * have a cursor surface frame callback pending which we need to
> + * clear so that we can continue submitting new cursor frames. */
> +if (xwl_seat->cursor_frame_cb) {
> +
From: Bryce Harrington <br...@bryceharrington.org>
When doing practice runs of the script, we aren't going to be uploading
anything, so don't treat it as a fatal error if the tarball is already
uploaded, as this may hide potential subsequent issues that the user
should know about.
Sign
From: Bryce Harrington <br...@bryceharrington.org>
Signed-off-by: Bryce Harrington <br...@bryceharrington.org>
---
release.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/release.sh b/release.sh
index ef384de..0a1c607 100755
--- a/release.sh
+++ b/release.
On Thu, Sep 17, 2015 at 03:15:29PM -0400, Olivier Fourdan wrote:
>
> Hi Bryce,
>
> - Original Message -
> > That'd be great, thanks Olivier!
> >
> > I'm not sure if the wayland patchwork is representative of Xwayland
> > patches, as we tend to prune PW to show only items bound for
On Thu, Sep 17, 2015 at 10:27:13AM -0400, Olivier Fourdan wrote:
> Hi Bryce,
>
> cc'ing xorg-devel as well, see below, I would like to help with xwayland.
>
> - Original Message -
> > I've assembled a blog post with a run-down of our current status on
> > Wayland - bugs needing
On Wed, Jul 15, 2015 at 01:09:03PM +0100, Emil Velikov wrote:
Hello gents,
On 15 July 2015 at 09:51, Marek Chalupa mchqwe...@gmail.com wrote:
Reviewed-by: Marek Chalupa mchqwe...@gmail.com
(http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.html)
On 05/16/2015 07:38
coordination logic, and can (and
should) be fixed within those limiations. Not in xserver itself.
This leaves some of the diagnostic improvements from the recent patch
series, in case others run into a similar situation.
Signed-off-by: Bryce Harrington br...@canonical.com
---
hw/xfree86/os-support/linux
On Wed, Apr 10, 2013 at 11:05:40PM -0700, Bryce Harrington wrote:
Revert 70739e817b2d64bc020ea491f23a3574bdb6155e and mostly revert
c31eac647a9ecf0fb20dc98266cadf0ba923ba14.
Further investigation shows the encountered race condition is between
lightdm and plymouth-splash, as implemented
On Tue, Apr 09, 2013 at 07:15:58PM -0700, Keith Packard wrote:
Bryce Harrington br...@canonical.com writes:
So, feel free to revert the patches if the thinking is it's just adding
clutter, but you may still want the first patch in the series as it adds
a missing close(). We also found
On Mon, Apr 08, 2013 at 09:16:02AM -0700, Keith Packard wrote:
Bryce Harrington br...@canonical.com writes:
We have not root-caused the bug yet, but are able to reproduce it
synthetically. Currently we suspect the actual breakage is underneath X
(plymouth/lightdm/kernel
/ubuntu/+source/libdrm/+bug/982889
Bryce Harrington (6):
xfree86: (Cleanup) Close fd if drm interface 1.4 could not be set.
xfree86: Track error code and add label for error handling.
xfree86: Provide more details on failure
xfree86: Keep trying to set interface on drm for 2 seconds
Signed-off-by: Bryce Harrington br...@canonical.com
Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk
---
hw/xfree86/os-support/linux/lnx_platform.c |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/xfree86/os-support/linux/lnx_platform.c
b/hw/xfree86/os-support/linux/lnx_platform.c
Signed-off-by: Bryce Harrington br...@canonical.com
Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk
---
hw/xfree86/os-support/linux/lnx_platform.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/xfree86/os-support/linux/lnx_platform.c
b/hw/xfree86/os
Signed-off-by: Bryce Harrington br...@canonical.com
Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk
---
hw/xfree86/os-support/linux/lnx_platform.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/xfree86/os-support/linux/lnx_platform.c
b/hw/xfree86/os-support/linux
And if we've had to delay booting due to not being able to set the
interface, fess up.
Signed-off-by: Bryce Harrington br...@canonical.com
Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk
---
hw/xfree86/os-support/linux/lnx_platform.c | 20 +++-
1 file changed, 15 insertions
Signed-off-by: Bryce Harrington br...@canonical.com
Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk
---
hw/xfree86/os-support/linux/lnx_platform.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/xfree86/os-support/linux/lnx_platform.c
b/hw/xfree86/os-support
and verified they apply to current git.
Bryce Harrington (3):
xfree86: Use fbdev/vesa driver on Oaktrail, Medfield, CDV rather than
-intel
xfree86: Man page shouldn't say Device is mandatory anymore
Xext: xauth generate with large timeout crashes Xorg #27134
Xext/security.c|6
and verified they apply to current git.
Bryce Harrington (3):
xfree86: Use fbdev/vesa driver on Oaktrail, Medfield, CDV rather than
-intel
xfree86: Man page shouldn't say Device is mandatory anymore
Xext: xauth generate with large timeout crashes Xorg #27134
Xext/security.c|6
man xorg.conf states that the 'Device' identifier is required in the
'Screen' section, yet current xserver defaults properly and boots up
fine without it.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=20742
Signed-off-by: Bryce Harrington br...@canonical.com
---
hw/xfree86/man
, and the
patch was not picked up. We have carried the patch in Ubuntu since Jun
2010 as it was confirmed to fix the reported issue.
ref: http://lists.x.org/archives/xorg-devel/2010-April/006992.html
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=27134
Signed-off-by: Bryce Harrington br
extensive code refactoring, but given it's been a few months
maybe that's more than the patch author is prepared to do for now.
Bryce
On Fri, Feb 08, 2013 at 03:56:00PM -0800, Bryce Harrington wrote:
Here are a few patches we've been carrying in Ubuntu for a while,
that should be considered
/+bug/1076627
Tested-by: Bryce Harrington br...@canonical.com
---
dix/devices.c |2 --
dix/getevents.c| 19 ++-
dix/touch.c|1 -
include/inputstr.h |3 +--
4 files changed, 7 insertions(+), 18 deletions(-)
diff --git a/dix/devices.c b/dix
Reviewed-by: Bryce Harrington br...@canonical.com
On Fri, Apr 20, 2012 at 11:08:15AM -0700, Chase Douglas wrote:
Signed-off-by: Chase Douglas chase.doug...@canonical.com
---
dix/touch.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/dix/touch.c b/dix/touch.c
On Wed, Apr 11, 2012 at 11:22:10AM -0700, Chase Douglas wrote:
This will be used for accepting and rejecting touches in the future.
Signed-off-by: Chase Douglas chase.doug...@canonical.com
---
dix/events.c| 11 +---
dix/touch.c | 68
On Tue, Apr 17, 2012 at 04:33:23PM -0700, Chase Douglas wrote:
Pointer passive grabs may be changed by the grabbing client. This allows
for a selecting client to change an implicit grab to an active grab,
which is the mechanism used for pop-up windows like application menus.
We need to do
://cgit.freedesktop.org/~cndougla/xserver/log/?h=input-fixes
Aside from my couple comments earlier, which are perhaps unlikely corner
cases, for the 17 patches 4c1dfd21...00cf1c40:
Reviewed-by: Bryce Harrington br...@canonical.com
___
xorg-devel@lists.x.org
corruption can occur, I suggest this be applied to the 1.12
stable series as well. However, I don't know for sure that corruption is
occurring, so it's not a clear cut candidate.
For the series:
Reviewed-by: Bryce Harrington br...@canonical.com
___
xorg
On Fri, Apr 06, 2012 at 12:00:50PM -0700, Chase Douglas wrote:
On 04/06/2012 11:25 AM, Chase Douglas wrote:
Because corruption can occur, I suggest this be applied to the 1.12
stable series as well. However, I don't know for sure that corruption is
occurring, so it's not a clear cut
On Fri, Apr 06, 2012 at 12:00:50PM -0700, Chase Douglas wrote:
On 04/06/2012 11:25 AM, Chase Douglas wrote:
This is all preliminary, based on a few minutes of testing. I'll follow
up after more people have tested it out.
After bypassing the test error, I've built xserver debs, installed, and
On Fri, Apr 06, 2012 at 01:20:22PM -0700, Bryce Harrington wrote:
On Fri, Apr 06, 2012 at 12:00:50PM -0700, Chase Douglas wrote:
On 04/06/2012 11:25 AM, Chase Douglas wrote:
This is all preliminary, based on a few minutes of testing. I'll follow
up after more people have tested it out.
I
On Mon, Mar 19, 2012 at 06:58:59PM -0700, Chase Douglas wrote:
I think that's a bit overkill. If we are going to reformat the 1.11 and
earlier branches, then we might as well leave it at that and let the
downstreams worry about it. Or, actually have someone maintain a
pre-formatted branch.
This follows the same API style as rotation.
Signed-off-by: Bryce Harrington br...@canonical.com
---
examples/xrandr.c| 36 ++
include/X11/extensions/XrandrUtils.h |9 +++
man/XrandrUtils.man | 18 +
src/XrandrUtils.c
Signed-off-by: Bryce Harrington br...@canonical.com
---
examples/before_and_after.sh | 23 +++
examples/xrandr.c|5 -
2 files changed, 27 insertions(+), 1 deletions(-)
create mode 100755 examples/before_and_after.sh
diff --git a/examples
This is perhaps the simplest way to refactor out the code, but I'm not
happy with it. It adds three api calls when it seems like 2 ought to be
sufficient. Also, one routine returns 0 on error, the other -1, and
that's no good.
Signed-off-by: Bryce Harrington br...@canonical.com
---
Makefile.am
Refactors three more chunks of xrandr into libXrandrUtils, and
associated tests.
Since there were no further comments to the last set of patches, they've
been posted to git.freedesktop.org.
Bryce Harrington (4):
Refactor rotations into library
Refactor reflection support into library.
Add
Signed-off-by: Bryce Harrington br...@canonical.com
---
examples/xrandr.c| 202 --
include/X11/extensions/XrandrUtils.h | 38 +++
man/XrandrUtils.man | 15 +++
src/Makefile.am |3 +-
src/names.c
On Sat, Feb 11, 2012 at 04:32:10PM +, Daniel Stone wrote:
What Bryce was saying is when you go from one touch on the touchpad to
two, but before the button is pressed, the cursor freezes. As soon as
the button is pressed, the cursor unfreezes so you can click and drag
with two fingers.
it.
As the code is displaying a unique error message prior to termination,
it should be discoverable enough where in the code the failure occurs,
so an exit(1) should be sufficient for termination.
Signed-off-by: Bryce Harrington br...@canonical.com
---
lib/drmtest.c |4 ++--
1 files changed, 2
COPYING is taken from xrandr since this package will largely be
repackaging code from that tool. README is adapted from libXrandr.
Keith Packard is the owner of the xrandr code and thus is primary
author of this codebase.
Signed-off-by: Bryce Harrington br...@canonical.com
---
AUTHORS |1
Adopt header style and struct naming scheme from libXrandr's Xrandr.h.
In particular, rename enums from foobar_t to XRUFoobar.
Signed-off-by: Bryce Harrington br...@canonical.com
---
include/X11/extensions/XrandrUtils.h | 47 ++
man/XrandrUtils.man
Signed-off-by: Bryce Harrington br...@canonical.com
---
examples/.gitignore |1 +
examples/xrandr.c | 33 +
2 files changed, 10 insertions(+), 24 deletions(-)
create mode 100644 examples/.gitignore
diff --git a/examples/.gitignore b/examples/.gitignore
This is copied directly from libXrandr with some tweaking based on
xrandr configs.
Signed-off-by: Bryce Harrington br...@canonical.com
---
.gitignore | 78 ++
Makefile.am | 37
autogen.sh
On Fri, Jan 06, 2012 at 04:36:28PM -0800, Bryce Harrington wrote:
This tree is also available in my personal git repository on fdo.
ssh://people.freedesktop.org/~bryce/libXrandrUtils
Bryce Harrington (7):
Initial doc files.
Initial packaging and directory structure.
Import
On Thu, Dec 22, 2011 at 07:36:06PM -0500, Gaetan Nadon wrote:
On 11-12-22 10:11 AM, Gaetan Nadon wrote:
diff --git a/examples/Makefile.am b/examples/Makefile.am
new file mode 100644
index 000..86e9943
--- /dev/null
+++ b/examples/Makefile.am
@@ -0,0 +1,13 @@
+bin_PROGRAMS = xrandr
+
On Thu, Dec 22, 2011 at 07:47:38PM -0500, Gaetan Nadon wrote:
On 11-12-21 09:47 PM, Bryce Harrington wrote:
+static void geometry_rectangle(void)
+{
+XRURectangle r;
The 'make check' target fails which causes 'make distcheck' to fail.
geometry.c: In function ‘geometry_rectangle
On Wed, Dec 21, 2011 at 07:58:09PM -0800, Jamey Sharp wrote:
On Wed, Dec 21, 2011 at 06:47:07PM -0800, Bryce Harrington wrote:
Begin refactoring the xrandr command line tool's internals into a
utility library. This is to provide a higher level abstraction for
configuring multiple monitors
This is copied directly from libXrandr with some tweaking based on
xrandr configs.
Signed-off-by: Bryce Harrington br...@canonical.com
---
.gitignore | 78 ++
Makefile.am | 37
autogen.sh
This follows the style of the X server test suite, using autoconf's
built-in support for make check using asserts.
The first test trivially checks the geometry structures.
Signed-off-by: Bryce Harrington br...@canonical.com
---
configure.ac |1 +
test/.gitignore |2 +
test
.
Bryce Harrington (6):
Initial packaging and directory structure.
Import xrandr.c and its test as implementation examples.
Copy a few basic structs and enums from xrandr.c into header.
Add unit test suite and a basic test of the geometry structs.
Refactor geometry structs in xrandr.c
Adopt header style and struct naming scheme from libXrandr's Xrandr.h.
In particular, rename enums from foobar_t to XRUFoobar.
Signed-off-by: Bryce Harrington br...@canonical.com
---
include/X11/extensions/XrandrUtils.h | 47 ++
man/XrandrUtils.man
Signed-off-by: Bryce Harrington br...@canonical.com
---
examples/.gitignore |1 +
examples/xrandr.c | 33 +
2 files changed, 10 insertions(+), 24 deletions(-)
create mode 100644 examples/.gitignore
diff --git a/examples/.gitignore b/examples/.gitignore
There are no internal users.
box_t (now XRUBox) serves essentially the same purpose.
Signed-off-by: Bryce Harrington br...@canonical.com
---
examples/xrandr.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/examples/xrandr.c b/examples/xrandr.c
index 6d921fb..a69eea3
On Tue, Nov 29, 2011 at 11:49:01PM -0800, Jeremy Huddleston wrote:
Does anything trigger usage() now? Can you send a followup (or squash in)
support for 'xinput --help' for further consistency?
Yes, both -h and --help are already supported. Also, it prints usage on
any unrecognized command.
Reviewed-by: Bryce Harrington br...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On Tue, Nov 29, 2011 at 11:57:30PM -0800, Jeremy Huddleston wrote:
For the first hunk,
Reviewed-by: Jeremy Huddleston jerem...@apple.com
For the second hunk, we don't use glib for the tests any more. I'd just
delete the sentence about g_test_bug. See:
commit
The X server doesn't use glib for the tests any more.
Signed-off-by: Bryce Harrington br...@canonical.com
---
test/README | 17 +++--
1 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/test/README b/test/README
index 5759a72..618130c 100644
--- a/test/README
+++ b/test
Remove extraneous right parens in usage docs.
Signed-off-by: Bryce Harrington br...@canonical.com
---
xsetpointer.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/xsetpointer.c b/xsetpointer.c
index 8ffbaa5..566b9f4 100644
--- a/xsetpointer.c
+++ b/xsetpointer.c
xrandr lists all outputs by default when run with no args. So, make
xinput list all inputs by default when run the same way, so the tools
are consistent.
Signed-off-by: Bryce Harrington br...@canonical.com
---
src/xinput.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions
On Tue, Nov 29, 2011 at 05:11:16PM -0800, Chase Douglas wrote:
On 11/29/2011 04:57 PM, Bryce Harrington wrote:
xrandr lists all outputs by default when run with no args. So, make
xinput list all inputs by default when run the same way, so the tools
are consistent.
Signed-off-by: Bryce
xrandr lists all outputs by default when run with no args. So, make
xinput list all inputs by default when run the same way, so the tools
are consistent.
Signed-off-by: Bryce Harrington br...@canonical.com
Reviewed-by: Chase Douglas chase.doug...@canonical.com
---
src/xinput.c | 11
Signed-off-by: Bryce Harrington br...@canonical.com
---
test/README |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/test/README b/test/README
index 5759a72..59b1f47 100644
--- a/test/README
+++ b/test/README
@@ -15,8 +15,9 @@ of the X server. Unless the test suite
On Thu, Sep 15, 2011 at 01:30:02PM -0700, Chase Douglas wrote:
Note that I'm speaking here with my personal developer hat on. Bryce
Harrington and Chris Halse Rogers would be better to chime in on
Canonical support for Ubuntu, but I imagine that it really doesn't
matter too much to us because
When system is out of memory, calloc can fail returning a NULL pointer.
Check for this before dereferencing it, and bail out if it fails.
Ref.: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/720445
Signed-off-by: Bryce Harrington br...@canonical.com
---
Xi/xichangehierarchy.c |2
On Mon, Feb 07, 2011 at 11:15:24AM +0100, Soeren Sandmann wrote:
Bryce Harrington br...@canonical.com writes:
pixman_image_create_bits() can return NULL under a variety of
circumstances. If this happens, it will segfault when dereferenced in
pixman_image_set_accessors().
http
/ubuntu/+source/xorg-server/+bug/705078
Signed-off-by: Bryce Harrington br...@canonical.com
---
fb/fbpict.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fb/fbpict.c b/fb/fbpict.c
index 7636040..79b462b 100644
--- a/fb/fbpict.c
+++ b/fb/fbpict.c
@@ -163,7 +163,8
is pretty rare hardware but is simulated by FAUmachine.
Patch originally provided to Ubuntu by Stefan Potyra.
Recently integrated into Debian by KiBi.
Signed-off-by: Bryce Harrington br...@canonical.com
---
src/alp_driver.c | 15 ++-
1 files changed, 14 insertions(+), 1 deletions
On Mon, Dec 06, 2010 at 09:35:48AM -0800, Jesse Barnes wrote:
On Wed, 1 Dec 2010 18:54:22 -0800
Bryce Harrington br...@canonical.com wrote:
Jesse,
I have a question about change 2bda5b73 that you did to libpciaccess
last year, to stop pci_device_get_bridge_buses() from looking at bus
Bit 7 of the pci device header type is an indicator of multi-function
devices, so needs to be masked when examining the bridge type.
Thanks go to Chih-Pin Wu for finding the bug and its fix.
Signed-off-by: Bryce Harrington br...@canonical.com
---
src/common_bridge.c |4 ++--
1 files changed
Jesse,
I have a question about change 2bda5b73 that you did to libpciaccess
last year, to stop pci_device_get_bridge_buses() from looking at bus
data if the bridge data was not read.
A ubuntu bug reporter says that this check is preventing his device from
getting detected properly - see
On Thu, Dec 02, 2010 at 03:09:41AM +, Matt Turner wrote:
On Thu, Dec 2, 2010 at 2:42 AM, Bryce Harrington br...@canonical.com wrote:
Bit 7 of the pci device header type is an indicator of multi-function
devices, so needs to be masked when examining the bridge type.
Thanks go to Chih-Pin
On Wed, Oct 28, 2009 at 07:39:41PM +1100, Daniel Stone wrote:
On Wed, Oct 28, 2009 at 12:42:40AM -0700, Keith Packard wrote:
But, if doing 3 month releases of the whole server tree means that
we'll scare OSVs away from our project, then I wonder how they manage
the Linux kernel today. Is
On Mon, Oct 26, 2009 at 01:28:40PM -0700, Keith Packard wrote:
Deployment is -largely- distro driven. with our past track record regarding
QA I'm not sure how many distros are willing to deploy a new server update
during their stable cycle. At which point you end with server releases being
72 matches
Mail list logo
