Re: Xorg setting low resolution with double HDMI output despite forcing to full HD

2019-02-21 Thread Chris Wilson
Quoting Felix Miata (2019-02-21 12:05:36) > Francesco Nwokeka composed on 2019-02-21 10:45 (UTC+0100): > > > I have an Intel NUC with dual HDMI output. Recently I've been > > experiencing > > a problem with the output resolution of the screens. When booting the > > system i > > get screen

Re: X freezes for a second or every now and then when lid closed

2018-10-29 Thread Chris Wilson
Quoting Joel Fernandes (2018-10-27 09:14:07) > On Sat, Oct 27, 2018 at 12:38:56AM -0700, Joel Fernandes wrote: > > Hi! > > My Linux laptop running kernel v4.17 freezes intermittently when the laptop > > lid is closed but external monitors are connected to 2 HDMI ports. I > > provided > > details

Re: One (Intel) GPU multiseat without Xephyr/Xnest, with a Xorg server per output

2018-09-20 Thread Chris Wilson
Quoting Troll Berserker (2018-09-18 16:28:02) > Is it possible? man 4 intel, search for ZaphodHeads -Chris ___ xorg@lists.x.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: https://lists.x.org/mailman/listinfo/xorg Your

Re: [PATCH xserver 1/2] xf86-video-modesetting: Add ms_queue_vblank helper

2018-04-15 Thread Chris Wilson
Quoting Keith Packard (2017-09-29 07:20:46) > This provides an API wrapper around the kernel interface for queueing > a vblank event, simplifying all of the callers. > > Signed-off-by: Keith Packard > --- > diff --git a/hw/xfree86/drivers/modesetting/dri2.c >

[PATCH xserver 3/3] os/WaitFor: Use the simpler xorg_list_for_each_entry()

2018-04-15 Thread Chris Wilson
As we are not freeing elements while iterating the list of timers, we can forgo using the safe variant, and reduce the number of pointer dances required for the insertion sort. Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- os/WaitFor.c | 4 ++-- 1 file changed, 2 insertions

[PATCH xserver 2/3] os/WaitFor: Use xorg_list_append()

2018-04-15 Thread Chris Wilson
Currently, we use xorg_list_add(new, head->prev) which is functionaly equivalent to xorg_list_append(), but with more pointer chasing, so reduce the strain on the reader and compiler by using the simpler append(). Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- os/WaitFor.c

[PATCH xserver 1/3] os/WaitFor: Check timers on every iteration

2018-04-15 Thread Chris Wilson
, and so also serviced on every pass. The trade-off being that the kernel timer wheel is likely more efficiently integrated with epoll, but individual updates to each timer would then require syscalls.) Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- os/WaitFor.c | 3 +-- 1 file chan

Re: Gradients are broken with glamor when RepeatReflect is set

2018-01-23 Thread Chris Wilson
Quoting Clemens Eisserer (2018-01-23 17:03:04) > Hi, > > Great to see movement regading this issue. > > > It's broken with llvmpipe/softpipe as well. Does it render correctly > > with glamor on i965? If so, maybe it's a Gallium non-driver issue. > > Glamor on Intel Gen5 (Arrendale) procudes

Re: Gradients are broken with glamor when RepeatReflect is set

2018-01-23 Thread Chris Wilson
Quoting Chris Wilson (2018-01-23 15:26:50) > Quoting Jeffrey Smith (2018-01-23 15:15:10) > > On Mon, Jan 22, 2018 at 3:01 PM, Chris Wilson <ch...@chris-wilson.co.uk> > > wrote: > > > Quoting Adam Jackson (2018-01-22 20:09:52) > > >> On Sat, 2017-12

Re: Gradients are broken with glamor when RepeatReflect is set

2018-01-23 Thread Chris Wilson
Quoting Jeffrey Smith (2018-01-23 15:15:10) > On Mon, Jan 22, 2018 at 3:01 PM, Chris Wilson <ch...@chris-wilson.co.uk> > wrote: > > Quoting Adam Jackson (2018-01-22 20:09:52) > >> On Sat, 2017-12-23 at 19:26 +0100, Clemens Eisserer wrote: > >> > Hi

Re: Gradients are broken with glamor when RepeatReflect is set

2018-01-22 Thread Chris Wilson
Quoting Adam Jackson (2018-01-22 20:09:52) > On Sat, 2017-12-23 at 19:26 +0100, Clemens Eisserer wrote: > > Hi there, > > > > Glamor's gradient acceleration code is broken in case RepeatReflect is > > used, please see: https://bugs.freedesktop.org/show_bug.cgi?id=98508 > > I've filed the bug

Re: [xrandr v2] Select NearestNeighbour filtering for pixel exact scaling

2017-09-24 Thread Chris Wilson
Quoting Matt Turner (2017-09-01 22:17:58) > Was there a reason this did not land? It needs a touch more work: "I was wondering, did you (or anyone else) follow up on this patch? I recently used it with good success, and would be happy if it was upstream. Especially as I am planning on getting a

Re: [Intel-gfx] intel driver 4k MST

2017-03-27 Thread Chris Wilson
xorg driver that is just considered > obsolete and dead or anything? It is not likely a ddx bug... -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-

[PATCH xserver] Revert "prime: Sync shared pixmap from root window instead of screen pixmap"

2017-03-09 Thread Chris Wilson
This reverts commit b5b292896f647c85f03f53b20b2f03c0e94de428. This breaks the concept of the screen->pixmap_dirty_list as it no longer tracks the relationship between the PixmapDirtyUpdate src and slave_dst, for the supposed convenience of not tracking present flips. --- dix/pixmap.c | 16

[PATCH xserver] inputthread: Initialise inputThreadInfo->changed before use

2017-02-22 Thread Chris Wilson
==8734== Thread 2 InputThread: ==8734== Conditional jump or move depends on uninitialised value(s) ==8734==at 0x2FDB05: InputThreadDoWork (inputthread.c:333) ==8734==by 0x6924423: start_thread (pthread_create.c:333) ==8734==by 0x6C229BE: clone (clone.S:105) Signed-off-by: Chris Wilson

[PATCH xserver] os: Fix iteration over busfaults

2017-02-17 Thread Chris Wilson
nearby memory instead. Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- os/busfault.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/os/busfault.c b/os/busfault.c index d4afa6df3..a2d433a2e 100644 --- a/os/busfault.c +++ b/os/busfault.c @@ -98,15 +98,

[PATCH xserver 2/3] xfree86: Take input lock for xf86TransparentCursor

2017-02-02 Thread Chris Wilson
The new input lock is missing for the xf86TransparentCursor() entry point. Fixes: 6a5a4e60373c ("Remove SIGIO support for input [v5]") References: https://bugs.freedesktop.org/show_bug.cgi?id=99358 Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- hw/xfree86/ramdac/

[PATCH xserver 3/3] xfree86: Take input_lock() for xf86ScreenCheckHWCursor

2017-02-02 Thread Chris Wilson
Add the missing input_lock() around the call into the driver's UseHWCursor() callback. Fixes: 6a5a4e60373c ("Remove SIGIO support for input [v5]") References: https://bugs.freedesktop.org/show_bug.cgi?id=99358 Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- h

[PATCH xserver 1/3] xfree86: Take the input lock for xf86RecolorCursor

2017-02-02 Thread Chris Wilson
: 6a5a4e60373c ("Remove SIGIO support for input [v5]") References: https://bugs.freedesktop.org/show_bug.cgi?id=99358 Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- hw/xfree86/ramdac/xf86HWCurs.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-)

[PATCH xserver] xfree86: Choose the largest output as primary for xf86TargetFallback()

2016-10-21 Thread Chris Wilson
mode available. Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- hw/xfree86/modes/xf86Crtc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c index 966a168..048c3b2 100644 --- a/hw/xfree86/modes/xf86

Re: [PATCH v6 10/11] modesetting: Disable Reverse PRIME for i915

2016-06-12 Thread Chris Wilson
On Sun, Jun 12, 2016 at 06:23:25PM +0100, Emil Velikov wrote: > On 12 June 2016 at 17:09, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > > On Sun, Jun 12, 2016 at 02:35:43PM +0100, Emil Velikov wrote: > >> Hi all, > >> > >> On 11 June 2016 at 0

Re: [PATCH v6 10/11] modesetting: Disable Reverse PRIME for i915

2016-06-12 Thread Chris Wilson
t; > > IMHO the proposed patch does not sound like a reasonable long-term > solution. Ideally the driver will expose a flag, based on which Xorg > will enable/disable reverse prime. That said, as a short-term fix this > is fine, barring the issues mentioned below. The decision as

Re: [PATCH] uxa: fix missing includes for fstat

2016-04-26 Thread Chris Wilson
On Tue, Apr 26, 2016 at 02:42:52PM +0200, Stefan Dirsch wrote: > From: Dominique Leuenberger <dims...@opensuse.org> > > Without these headers, we can run into build errors like: sys/stat.h is already included. Curious. -Chris -- Chris Wilson, Intel Open Source Te

[PATCH xserver] present: Be consistent in using window vs vblank->window in present_execute()

2016-04-19 Thread Chris Wilson
ted instantaneously and so accessing the vblank structure after a successful call into the driver may cause a use-after-free. This is trivially avoided by using the locals we took earlier. Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- present/present.c | 30 +++--

[xrandr v2] Select NearestNeighbour filtering for pixel exact scaling

2016-04-04 Thread Chris Wilson
: https://bugs.freedesktop.org/show_bug.cgi?id=94816 Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- configure.ac | 2 +- xrandr.c | 275 +-- 2 files changed, 192 insertions(+), 85 deletions(-) diff --git a/configur

Re: [xrandr] Select NearestNeighbour filtering for pixel exact scaling

2016-04-04 Thread Chris Wilson
On Mon, Apr 04, 2016 at 05:11:11PM +0100, Chris Wilson wrote: > When using pixel-exact scaling from for example running a 3840x2160 monitor > at 1920x1080 half-resolution upscaling using a bilinear filter > introduces blur where none is expected. Missed --scale, this only changes --s

[xrandr] Select NearestNeighbour filtering for pixel exact scaling

2016-04-04 Thread Chris Wilson
When using pixel-exact scaling from for example running a 3840x2160 monitor at 1920x1080 half-resolution upscaling using a bilinear filter introduces blur where none is expected. References: https://bugs.freedesktop.org/show_bug.cgi?id=94816 Signed-off-by: Chris Wilson <ch...@chris-wilson.co

[PATCH xserver] Xext/vidmode: Reduce verbosity of GetModeLine debug messages

2016-03-13 Thread Chris Wilson
equest and others) was increased leading to lots of log spam. Downgrade the logging back to DebugF. References: https://bugs.freedesktop.org/show_bug.cgi?id=94515 Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Olivier Fourdan <ofour...@redhat.com> Cc: Adam Jackson <a...@redhat.com

Re: [PATCH xserver 1/3] present: Move msc_is_(equal_or_)after to the top of present.c

2016-02-25 Thread Chris Wilson
On Wed, Feb 24, 2016 at 04:52:57PM +0900, Michel Dänzer wrote: > From: Michel Dänzer <michel.daen...@amd.com> > > To make them usable from any other function in the file. No functional > change. > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Reviewed

Re: [PATCH xserver 2/3] present: Requeue if flip driver hook fails and target MSC not reached

2016-02-25 Thread Chris Wilson
alling back to a copy, or else it's executed too > early. > > Fixes glxgears running at unbounded framerate (not synchronized to the > refresh rate) in fullscreen if the driver flip hook fails. > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: C

Re: [PATCH xserver 3/3] present: Only requeue if target MSC is not reached after an unflip

2016-02-25 Thread Chris Wilson
pup menu appears on top of a > flipping fullscreen window. > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH xserver 3/3] present: Call present_restore_screen_pixmap from present_set_abort_flip

2016-02-19 Thread Chris Wilson
that's already the case in other present code. It is true that we cannot schedule a flip without screen->root (though present_check_flip would crash rather than reject the call). > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: Chris Wilson <ch...@chris-wilson.c

Re: [PATCH xserver 2/3] present: Factor code for restoring screen pixmap out of present_unflip

2016-02-19 Thread Chris Wilson
On Fri, Feb 19, 2016 at 11:39:11AM +0900, Michel Dänzer wrote: > From: Michel Dänzer <michel.daen...@amd.com> > > The following fix will use the refactored function. > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: Chris Wilson <ch...@chris-w

Re: [PATCH xserver 1/3] present: Only update screen pixmap from flip pixmap once per unflip

2016-02-19 Thread Chris Wilson
copy. > > When switching a flipping window out of fullscreen, a repeated unflip > copy could leave artifacts of the flip pixmap on the desktop. > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> And the ordering is better: we should do the restoration of the contents bef

Re: [PATCH xserver] dri2: Use the work queue to manage client sleeps

2016-02-12 Thread Chris Wilson
On Thu, Feb 11, 2016 at 05:41:16PM +, Chris Wilson wrote: > On Wed, Feb 10, 2016 at 11:51:18AM -0500, Adam Jackson wrote: > > @@ -983,7 +990,7 @@ DRI2WakeClient(ClientPtr client, DrawablePtr pDraw, int > > frame, > > { > > ScreenPtr pScreen = pDraw->pSc

[PATCH xserver 2/2] dri2: Allow many blocked clients per-drawable

2016-02-12 Thread Chris Wilson
callback and so we want to only use that external list as our means of controlling sleeps and wakeups. We thus have a list of sleeping clients at our disposal and can manage multiple events and sources. Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- hw/xfree86/dri2/dri2.c

[PATCH xserver 1/2] dix: Add ClientSignalAll()

2016-02-12 Thread Chris Wilson
This is a variant of ClientSignal() that signals all clients with an optional matching sleeping client, function and closure. Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- dix/dixutils.c | 22 ++ include/dix.h | 8 2 files changed, 30 inse

Re: [PATCH xserver] dri2: Use the work queue to manage client sleeps

2016-02-11 Thread Chris Wilson
On Wed, Feb 10, 2016 at 11:51:18AM -0500, Adam Jackson wrote: > @@ -983,7 +990,7 @@ DRI2WakeClient(ClientPtr client, DrawablePtr pDraw, int > frame, > { > ScreenPtr pScreen = pDraw->pScreen; > DRI2DrawablePtr pPriv; > - > +t Without this, Tested-by: C

[PATCH xserver 2/2] dix: Disable AttendClient() operation during client teardown

2016-02-10 Thread Chris Wilson
commit e43abdce964f5ed9689cf908af8c305b39a5dd36 Author: Chris Wilson <ch...@chris-wilson.co.uk> Date: Wed Feb 3 09:54:46 2016 + dri2: Unblock Clients on Drawable release added a call to AttendClient during drawable teardown, which also happens as a result of client teardown. H

[PATCH xserver 1/2] os: Move OsCommPtr dereference after ignoreCount check

2016-02-10 Thread Chris Wilson
Make AttendClient safe to call along the client teardown path (i.e. after CloseDownConnection which is called before the Client's resources are freed) by checking the ClientPtr before the OsCommPtr. References: https://bugs.freedesktop.org/show_bug.cgi?id=94074 Signed-off-by: Chris Wilson <

[PATCH xserver 3/4] dri2: Only create one unnamed reference per Drawable per Client

2016-02-03 Thread Chris Wilson
op.org/patch/19695/ Link: http://lists.x.org/archives/xorg-devel/2010-November/014783.html Link: http://lists.x.org/archives/xorg-devel/2010-November/014782.html Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- hw/xfr

[PATCH xserver 2/4] dri2: Split resource tracking for DRI2Drawable and references to them

2016-02-03 Thread Chris Wilson
to DRI2Drawables. Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- glx/glxdri2.c | 10 ++-- hw/xfree86/dri2/dri2.c| 136 ++ hw/xfree86/dri2/dri2.h| 11 ++-- hw/

[PATCH xserver 4/4] dri2: Unblock Clients on Drawable release

2016-02-03 Thread Chris Wilson
. Testcase: dri2-race/manager Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- hw/xfree86/dri2/dri2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index 2f05c64..80

[PATCH xserver 1/4] dri2: Only invalidate the immediate Window upon SetWindowPixmap

2016-02-03 Thread Chris Wilson
chives/xorg-devel/2015-February/045638.html Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- hw/xfree86/dri2/dri2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86

Re: xrandr only lists mode after a while of waiting

2015-12-14 Thread Chris Wilson
de-after-a-while-of-waiting Should be resolved by now. It was just bug that mistakenly marked the first current-only probe as valid on the initial modesetting. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg@lists.x.org: X

Re: xrandr only lists mode after a while of waiting

2015-12-14 Thread Chris Wilson
med the release notes of 4.2.6 and 4.2.7 (Arch has 4.2.5) and >could not find a hint on a fix related to KMS. If you add an xf86-video-intel bug on https://bugs.archlinux.org/ and mention commit 627ef68a8cd7a51627d5b6a98cb0a5bdb1d9b534 Author: Chris Wilson <ch...@chris-wilson.co.uk> Date:

Re: How to refresh the list of outputs detected by xrandr?

2015-11-19 Thread Chris Wilson
g stations, it remembers the layout of available monitors and when > I > dock it onto the other station and resume, it still shows me the old list of > outputs and modes. I need to undock it while running and dock it again to > make > it notify the change in outputs. > &g

Re: How to refresh the list of outputs detected by xrandr?

2015-11-19 Thread Chris Wilson
On Thu, Nov 19, 2015 at 02:39:21PM +0100, Łukasz Maśko wrote: > Dnia czwartek, 19 listopada 2015 13:27:37 Chris Wilson pisze: > [...] > > The kernel is supposed to send a hotplug notification on resume that > > should result in the list being updated. > > If I get yo

Re: [PATCH] present: Fix Async swap logic

2015-11-04 Thread Chris Wilson
sync_flip) +if (!(options & PresentOptionCopy) && pixmap != NULL) { +if (options & PresentOptionAsync && +(screen_priv->info && + screen_priv->info->capabilities & PresentCapabilityAsync) && + present_check_f

Re: [PATCH] present: Fix Async swap logic

2015-11-04 Thread Chris Wilson
On Wed, Nov 04, 2015 at 10:48:40AM +0100, Axel Davy wrote: > On 04/11/2015 10:40, Chris Wilson wrote: > >On Tue, Nov 03, 2015 at 09:14:51AM +0100, Axel Davy wrote: > >>+if (pixmap != NULL && > >>+!(options & PresentOption

Re: How to setup independent screens with the Intel driver?

2015-10-30 Thread Chris Wilson
> Section "Device" > Identifier "Intel1" > Driver "intel" > BusID "PCI:0:2:0" > Screen 1 > Option "AccelMethod" "sna" > Option "Monitor-VGA1" "VGA1" Option "ZaphodHeads" "VGA1" > Option "TearFree" "on" > EndSection -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg@lists.x.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: http://lists.x.org/mailman/listinfo/xorg Your subscription address: %(user_address)s

Re: How to setup independent screens with the Intel driver?

2015-10-30 Thread Chris Wilson
On Fri, Oct 30, 2015 at 08:00:46PM +0100, Boszormenyi Zoltan wrote: > 2015-10-30 19:15 keltezéssel, Chris Wilson írta: > > On Fri, Oct 30, 2015 at 06:17:50PM +0100, Boszormenyi Zoltan wrote: > >> In my case with this particular POS machine, the intended primary display, >

Re: How to setup independent screens with the Intel driver?

2015-10-30 Thread Chris Wilson
On Fri, Oct 30, 2015 at 05:56:35PM +0100, Boszormenyi Zoltan wrote: > 2015-10-30 17:46 keltezéssel, Boszormenyi Zoltan írta: > > 2015-10-30 17:36 keltezéssel, Chris Wilson írta: > >> On Fri, Oct 30, 2015 at 04:58:49PM +0100, Boszormenyi Zoltan wrote: > >>> Section &qu

Re: How to setup independent screens with the Intel driver?

2015-10-30 Thread Chris Wilson
On Fri, Oct 30, 2015 at 05:46:51PM +0100, Boszormenyi Zoltan wrote: > 2015-10-30 17:36 keltezéssel, Chris Wilson írta: > > On Fri, Oct 30, 2015 at 04:58:49PM +0100, Boszormenyi Zoltan wrote: > >> Section "Device" > >> Identifier "Intel0" >

Re: How to setup independent screens with the Intel driver?

2015-10-30 Thread Chris Wilson
On Fri, Oct 30, 2015 at 06:17:50PM +0100, Boszormenyi Zoltan wrote: > 2015-10-30 18:03 keltezéssel, Chris Wilson írta: > > On Fri, Oct 30, 2015 at 05:56:35PM +0100, Boszormenyi Zoltan wrote: > >> 2015-10-30 17:46 keltezéssel, Boszormenyi Zoltan írta: > >>> 2015-

[PATCH] os: Fix iteration over busfaults

2015-10-06 Thread Chris Wilson
nearby memory instead. Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- os/busfault.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/os/busfault.c b/os/busfault.c index d4afa6d..a2d433a 100644 --- a/os/busfault.c +++ b/os/busfault.c @@ -98,15 +98,

[xrandr] Pretty print modeFlags on unattached modes

2015-09-17 Thread Chris Wilson
For modes attached to an output we decode the modeFlags into their human readable strings. For unattached modes, we currently do not print the modeFlags at all - so continue the copy'n'paste for mode printing. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92025 Signed-off-by: Chris

[xrandr] Only use the current information when setting modes

2015-09-13 Thread Chris Wilson
of seconds), but it may perturb the setup that the user is trying to configure. Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> --- xrandr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xrandr.c b/xrandr.c index 181c76e..dcfdde0 100644 --- a/xr

Re: [xrandr] Only use the current information when setting modes

2015-09-13 Thread Chris Wilson
On Sun, Sep 13, 2015 at 12:14:57PM +0100, Chris Wilson wrote: > On Sun, Sep 13, 2015 at 01:08:11PM +0200, Mark Kettenis wrote: > > Seems you already can get the behaviour you want by specifying > > --current. Whereas there is no convenient way to force a probe, other > > t

Re: [xrandr] Only use the current information when setting modes

2015-09-13 Thread Chris Wilson
On Sun, Sep 13, 2015 at 01:08:11PM +0200, Mark Kettenis wrote: > > From: Chris Wilson <ch...@chris-wilson.co.uk> > > Date: Sun, 13 Sep 2015 11:40:37 +0100 > > > > Before we change the state (e.g. adding a mode or applying one to an > > output), we quer

Re: [xrandr] Only use the current information when setting modes

2015-09-13 Thread Chris Wilson
On Sun, Sep 13, 2015 at 08:01:46PM +0200, Mark Kettenis wrote: > > Date: Sun, 13 Sep 2015 12:14:57 +0100 > > From: Chris Wilson <ch...@chris-wilson.co.uk> > > > > On Sun, Sep 13, 2015 at 01:08:11PM +0200, Mark Kettenis wrote: > > > > From: Chris Wilson &l

Re: [PATCH] Xephyr: Paint with subimage for non-Glamor non-XSHM case

2015-06-22 Thread Chris Wilson
); +xcb_image_put(HostX.conn, scrpriv-win, HostX.gc, img, dx, dy, 0); +if (subimg != img) xcb_image_destroy(img); +xcb_image_destroy(subimg); Nevertheless, Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology

[xrandr 1/2] Mark disabling an output as a change in its CRTC

2015-06-18 Thread Chris Wilson
When an output is disabled via the cmdline, we can use that information to prevent assigning the current CRTC to the output and free it up for reuse by other outputs in the first pass of picking CRTC. Reported-and-tested-by: Nathan Schulte nmschu...@gmail.com Signed-off-by: Chris Wilson ch

[xrandr 2/2] Mark all CRTC as currently unused for second picking CRTC pass

2015-06-18 Thread Chris Wilson
request 3 new HDMI outputs on a system with only 3 CRTC, and wished to switch off an active internal panel, we would report cannot find CRTC even though that configuration could be established.) Reported-and-tested-by: Nathan Schulte nmschu...@gmail.com Signed-off-by: Chris Wilson ch...@chris

Re: [PATCH 6/6] prime: add rotation support for offloaded outputs

2015-06-15 Thread Chris Wilson
to apply HW transformation when possible. It also needs to know the transform for applying the HW cursor. I guess the problem you face is that you want the host GPU to accelerate the rotation for a slaved USB device? -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH 1/2] atom: Bump initial table size

2015-06-05 Thread Chris Wilson
On Fri, Jun 05, 2015 at 10:26:15AM -0400, Adam Jackson wrote: On Tue, 2015-06-02 at 20:54 +0100, Chris Wilson wrote: On Tue, Jun 02, 2015 at 02:08:38PM -0400, Adam Jackson wrote: We're always creating ~230 atoms at startup, might as well tune it so we don't hit the realloc path before

Re: [PATCH 2/2] atom: make FreeAtom static

2015-06-05 Thread Chris Wilson
On Tue, Jun 02, 2015 at 02:08:39PM -0400, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 1/2] atom: Bump initial table size

2015-06-02 Thread Chris Wilson
the number of Atoms created during initialisation. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

Re: [PATCH 1/8] dix: Unexport various implementation details

2015-06-02 Thread Chris Wilson
On Tue, Jun 02, 2015 at 02:14:59PM -0400, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com For this series, Acked-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel

Re: [PATCH 2/3] present: Query the Window's CRTC every time

2015-05-28 Thread Chris Wilson
On Thu, May 28, 2015 at 04:59:14PM +0900, Michel Dänzer wrote: On 27.05.2015 15:51, Chris Wilson wrote: On Tue, May 26, 2015 at 02:30:32PM -0700, Keith Packard wrote: Michel Dänzer mic...@daenzer.net writes: The old code also called present_get_crtc() unless pixmap == NULL, so

Re: [PATCH 2/3] present: Query the Window's CRTC every time

2015-05-28 Thread Chris Wilson
On Thu, May 28, 2015 at 05:56:15PM +0900, Michel Dänzer wrote: On 28.05.2015 17:38, Chris Wilson wrote: On Thu, May 28, 2015 at 04:59:14PM +0900, Michel Dänzer wrote: The patch below is an alternative fix for the problem I'm seeing, while preserving the window CRTC for MSC waits when

Re: [PATCH 2/3] present: Query the Window's CRTC every time

2015-05-28 Thread Chris Wilson
On Thu, May 28, 2015 at 06:27:34PM +0900, Michel Dänzer wrote: On 28.05.2015 18:07, Chris Wilson wrote: On Thu, May 28, 2015 at 05:56:15PM +0900, Michel Dänzer wrote: On 28.05.2015 17:38, Chris Wilson wrote: On Thu, May 28, 2015 at 04:59:14PM +0900, Michel Dänzer wrote: The patch below

Re: [PATCH 5/5] render: Eliminate temporary mask when drawing glyphs

2015-05-27 Thread Chris Wilson
succinctly. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] renderproto: Fix compositeglyph dst position. eliminate use of mask-format

2015-05-27 Thread Chris Wilson
of the glyph path when specifying a mask - plus the effect the mask has for allowing combining a mixture of glyph formats without unwanted fringing. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 2/3] present: Query the Window's CRTC every time

2015-05-27 Thread Chris Wilson
. It looks like this will only solve the problem of how to deal with new PresentNotifyMSC requests; any PresentPixmap or PresentNotifyMSC requests which are pending when the CRTC is disabled may end up getting wedged too? Queued events are flushed when the CRTC is disabled. -Chris -- Chris

[PATCH] glamor/glyphs: Fix rendering regressions

2015-05-18 Thread Chris Wilson
(for example to correctly render overlapping glyphs and to apply quantisation effects, e.g. mixing different filters) along with incorrectly computing the glyph source coordinates. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Keith Packard kei...@keithp.com --- glamor/glamor_composite_glyphs.c

Re: [PATCH] composite: Install SourceValidation hooks only when required

2015-05-18 Thread Chris Wilson
On Mon, May 18, 2015 at 03:26:29PM +0100, Chris Wilson wrote: Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Eek, used send-email from the wrong branch. This is fun but incomplete... -Chris -- Chris Wilson, Intel Open Source Technology Centre

[PATCH] composite: Install SourceValidation hooks only when required

2015-05-18 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- composite/compalloc.c | 3 +++ composite/compinit.c | 49 +++-- composite/compint.h| 4 composite/compwindow.c | 8 4 files changed, 46 insertions(+), 18 deletions(-) diff

Re: combining Render's Composite + SHM's PutImage

2015-04-09 Thread Chris Wilson
of how to mix SHM and Render, or http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/tools/virtual.c#n1819 The synopsis is that you want to insert your own SHMCompletionEvents which are then guarranteed to be sent after the rendering by X's very strict protocol ordering. -Chris -- Chris

Re: [PATCH] modesetting: add tile property support (v2.1)

2015-04-06 Thread Chris Wilson
tile property (Chris) Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

[PATCH 2/2] prime: Don't lose SourceValidate on PixmapSyncDirtyHelper no-ops

2015-04-05 Thread Chris Wilson
the SourceValidate callback back in place even for an early exit. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl...@redhat.com --- dix/pixmap.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dix/pixmap.c b/dix/pixmap.c index 00e298f

[PATCH 1/2] Xv: Only stop the adaptors when the Pixmap is finally destroyed

2015-04-05 Thread Chris Wilson
Pixmaps are reference counted and DestroyPixmap is called for the removal of every reference. However, we only want to stop the adaptors writing into the Pixmap just before the Pixmap is finally destroyed, similar to how Windows are handled. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc

Re: [PATCH 3/3] modesetting: add tile property support (v2)

2015-03-31 Thread Chris Wilson
-length, tile_info); xf86OutputSetTile(output, tile_info); -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH 3/3] modesetting: add tile property support (v2)

2015-03-31 Thread Chris Wilson
On Tue, Mar 31, 2015 at 10:07:53AM +0100, Chris Wilson wrote: On Tue, Mar 31, 2015 at 01:47:26PM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This adds tiling support to the server modesetting driver, it retrieves the tile info from the kernel and translates

Re: [PATCH] glx/dri2: Disable AIGLX if indirect GLX is disabled

2015-03-04 Thread Chris Wilson
On Thu, Mar 05, 2015 at 01:18:51PM +0900, Michel Dänzer wrote: On 04.03.2015 21:16, Chris Wilson wrote: There is no point in setting up the acceleration for indirect GLX if indirect GLX is itself disabled. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- glx/glxdri2.c | 3

[PATCH] glx/dri2: Disable AIGLX if indirect GLX is disabled

2015-03-04 Thread Chris Wilson
There is no point in setting up the acceleration for indirect GLX if indirect GLX is itself disabled. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- glx/glxdri2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index ec86a73..7cb0f28 100644

Re: [PATCH] damage: Only track extents where possible

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 02:58:45PM -0500, Adam Jackson wrote: On Wed, 2015-02-25 at 18:01 +, Chris Wilson wrote: For external Damage, we need only track sufficient information to satisfy the DamageReportLevel. That is if the Client only wishes to hear that the Damage is now non-empty

[PATCH] damage: Only track extents where possible

2015-02-25 Thread Chris Wilson
the full region intact for them. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Adam Jackson a...@redhat.com --- miext/damage/damage.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/miext/damage/damage.c b/miext/damage/damage.c index b99cfb0..450a517

Re: Limit DRI2Drawable reference leak

2015-02-22 Thread Chris Wilson
On Sun, Feb 22, 2015 at 02:09:36AM +0200, Ville Syrjälä wrote: On Sat, Feb 21, 2015 at 10:52:49PM +, Chris Wilson wrote: On Sun, Feb 22, 2015 at 12:13:38AM +0200, Ville Syrjälä wrote: On Sat, Feb 21, 2015 at 09:31:07PM +, Chris Wilson wrote: With the current protocol

[PATCH 3/3] dri2: Only create one unnamed reference per Drawable per Client

2015-02-22 Thread Chris Wilson
: http://lists.x.org/archives/xorg-devel/2010-November/014782.html Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Ville Syrjälä syrj...@sci.fi --- hw/xfree86/dri2/dri2.c| 57 +++ hw/xfree86/dri2/dri2ext.c | 4 ++-- 2 files changed, 55 insertions

[PATCH 1/3] dri2: Only invalidate the immediate Window upon SetWindowPixmap

2015-02-22 Thread Chris Wilson
All callers of SetWindowPixmap will themselves be traversing the Window heirachy updating the backing Pixmap of each child and so we can forgo doing the identical traversal inside the DRI2SetWindowPixmap handler. Reported-by: Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86

[PATCH 2/3] dri2: Split resource tracking for DRI2Drawable and references to them

2015-02-22 Thread Chris Wilson
to DRI2Drawables. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- glx/glxdri2.c | 10 ++-- hw/xfree86/dri2/dri2.c| 136 ++ hw/xfree86/dri2/dri2.h| 11 ++-- hw/xfree86/dri2/dri2ext.c | 6 +- 4 files changed, 66 insertions

Re: Limit DRI2Drawable reference leak

2015-02-22 Thread Chris Wilson
On Sun, Feb 22, 2015 at 09:02:41AM +, Chris Wilson wrote: Yes, that is what I think the mesa patch is about. I think the solution would have been that the DRI2Drawable take a refcnt on its parent and then DRI2DestroyDrawable could be made to work. However, if we did that today we would end

Re: Limit DRI2Drawable reference leak

2015-02-21 Thread Chris Wilson
On Sun, Feb 22, 2015 at 12:13:38AM +0200, Ville Syrjälä wrote: On Sat, Feb 21, 2015 at 09:31:07PM +, Chris Wilson wrote: With the current protocol and implementations, we have to often call DRI2CreateDrawable but can never call DRI2DestroyDrawable. This ends up with us leaking

Re: [PATCH] dri2: work around broken DRI2CreateDrawable callers

2015-02-21 Thread Chris Wilson
you find an alternative solution for mali? If not, I think I can generalise this into only allocating a single reference per DRI2 Client per Drawable. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development

[PATCH 3/3] dri2: Support named DRI2Drawable references

2015-02-21 Thread Chris Wilson
still causes an invalidate event to be sent, the overhead of sending those unnecessary events quickly mounts. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86/dri2/dri2ext.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/xfree86/dri2

[PATCH 1/3] dri2: Split resource tracking for DRI2Drawable and references to them

2015-02-21 Thread Chris Wilson
to DRI2Drawables. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- glx/glxdri2.c | 8 +-- hw/xfree86/dri2/dri2.c| 136 ++ hw/xfree86/dri2/dri2.h| 11 ++-- hw/xfree86/dri2/dri2ext.c | 6 +- 4 files changed, 65 insertions

[PATCH 2/3] dri2: Only create one unnamed reference per Drawable per Client

2015-02-21 Thread Chris Wilson
dispatcher and thus we don't need to check that the invalidate handler is the same. Cc: Daniel Drake dr...@endlessm.com Link: https://freedesktop.org/patch/19695/ Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86/dri2/dri2.c| 22 -- hw/xfree86/dri2/dri2ext.c | 2

Limit DRI2Drawable reference leak

2015-02-21 Thread Chris Wilson
With the current protocol and implementations, we have to often call DRI2CreateDrawable but can never call DRI2DestroyDrawable. This ends up with us leaking references to DRI2Drawables based on the assumption that the references have identical lifetimes to the Drawable going astray. This was

Re: DRI2InvalidateWalk high in perf top profile

2015-02-16 Thread Chris Wilson
); +DRI2InvalidateDrawable(pWin-drawable); } would suffice -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo

  1   2   3   4   5   >