RE: [PULL] Misc patches

2015-03-29 Thread Colin Harrison
Hi, Builds for me on MinGW-w64. I suspect the '#ifdef INXQUARTZ' ...'#endif', 5 lines, removal in exinit.h needs reverting for Jeremy? Sorry, I can't test for the Darwin build. Thanks, Colin Harrison -Original Message- From: Jeremy Huddleston Sequoia [mailto:jerem...@gmail.com

Re: [PATCH] Fix a crash with XDMCP error handler

2015-01-25 Thread Colin Harrison
Hi, I much prefer Jon Turney's more universal fix to this problem. http://lists.x.org/archives/xorg-devel/2014-November/044568.html and having tested Jon's fix it can have Reviewed-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison

Reference: xorg/app/xauth Update DISPLAY parsing to work with new launchd paths in Yosemite

2014-12-31 Thread Colin Harrison
Hi, In the latest commit to xauth there are two added instances of: buf[sizeof(path) - 1] = '\0'; shouldn't those be? path[sizeof(path) - 1] = '\0'; Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH] xdmcp: Simplify format specifier in XdmcpFatal() for vpnprintf()

2014-10-21 Thread Colin Harrison
Hi, There are instances of this format also in os/access.c (not that I ever get sight of them!) Probably best fixed in vpnprintf() but your xdmcp patch fixes the most seen instance (for me). Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH xinit 0/1] startx: Pass -nolisten tcp by default

2014-09-12 Thread Colin Harrison
Hi, 'this day and age' 'this time and age' Time is good: it allows evolution (or erosion) to slowly happen. But I for one vote that X11 network transparency remains default. Cheers, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH xinit 0/1] startx: Pass -nolisten tcp by default

2014-09-12 Thread Colin Harrison
for private companies and individuals, not producing databases and servers for huge anonymous data centres! Cheers, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: XI18N_OBJS and XLC_LOCALE.pre

2014-08-01 Thread Colin Harrison
Hi, In order for the new Czech keyboard locale directory to actually appear in a distribution I had to add cs_CZ.UTF-8 to the list of AC_SUBST(locales) in libX11/configure.ac Thanks, Colin ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 0/2] hw/xwin build fixes

2014-05-29 Thread Colin Harrison
Reviewed-by: Colin Harrison colin.harrison at virgin.net ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] hw/xwin: link dynamically and export symbols

2014-04-18 Thread Colin Harrison
Reviewed-by: Colin Harrison colin.harrison at virgin.net ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH libXfont] Make shared library work on Cygwin/MinGW

2014-04-18 Thread Colin Harrison
Reviewed-by: Colin Harrison colin.harrison at virgin.net And works for me cross-compiling with MinGW-w64 for Microsoft Windows (a magic patch solving an old/large problem!) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives

Re: [PATCH 00/37] Warning fixes (post 1.15 proposed changes)

2014-01-13 Thread Colin Harrison
** resolvedp, int* resolvedlenp, - pointer private); + void * private); typedef void (*SetPathFunc)(void); I've not had any problems elsewhere after applying these changes. Thanks, Colin Harrison

Re: [PATCH 00/37] Warning fixes (post 1.15 proposed changes)

2014-01-13 Thread Colin Harrison
struct { -GCFuncs *originalFuncs; -GCOps *originalOps; +const GCFuncs *originalFuncs; +const GCOps *originalOps; } RootlessGCRec; // RootlessScreenRec: per-screen private data Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 00/37] Warning fixes (post 1.15 proposed changes)

2014-01-13 Thread Colin Harrison
*originalOps; } RootlessGCRec; // RootlessScreenRec: per-screen private data Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 0/5] hw/xwin fixes and more (v2)

2013-12-08 Thread Colin Harrison
Hi, I'm happy with Jon making code changes in xwin to try and sort this glx-dispatch mess out (i.e. xwin is currently broken in xserver git master!) but am unable to spare much time mangling changes at the moment. Thanks Colin Harrison ___ xorg

Re: [PATCH 16/19] glx: Remove screen number from __GLXconfig

2013-10-07 Thread Colin Harrison
Hi, Jon's patch works for me. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: Syntax error in recent twm commit

2013-07-19 Thread Colin Harrison
Hi, B) No POSIX on Windows (mingw-w64), so quicker to list the stuff I have, than functions like mkstemp() that I haven't! Autotools not at fault this time. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http

Syntax error in recent twm commit

2013-07-18 Thread Colin Harrison
+const char *prefix) #else static char * unique_filename ( Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH:libXt 2/6] Avoid shadowing variables.

2013-07-10 Thread Colin Harrison
!) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL unreviewed] touch fixes for #56578

2013-05-24 Thread Colin Harrison
Hi, I got some log spam from the Abstract cursor refcounting change and so just commented it out... --- ./dix/save_cursor.c 2013-05-24 07:01:07.905179181 +0100 +++ ./dix/cursor.c 2013-05-24 07:21:53.055169797 +0100 @@ -134,12 +134,12 @@ CursorPtr RefCursor(CursorPtr cursor) { -

Re: [PATCH] dix/resource: bug out if we get 0 type resource added

2013-02-26 Thread Colin Harrison
@@ { int *counts = (int *) cdata; -counts[(type TypeMask) - 1]++; +if ((type TypeMask) != RT_NONE) counts[(type TypeMask) - 1]++; } to avoid xrestop crashing the server...which has got to be a good thing? Thanks, Colin Harrison ___ xorg-devel

Re: [PATCH app/xhost 0/4] xhost fixes for Windows MinGW

2013-02-15 Thread Colin Harrison
For the series: Reviewed-by: Colin Harrison colin.harrison at virgin.net ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

RE: [PATCH mkfontscale] Prefer original file over symlink (v2)

2013-01-11 Thread Colin Harrison
Hi, Yes that's more elegant than an if(0) bodge that I used quickly to get me compiling again! Reviewed-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison -Original Message- From: Jon TURNEY [mailto:jon.tur...@dronecode.org.uk] Sent: 11 January 2013 15:14

Re: [PATCH] dix: Make small bitfields that store enums unsigned

2012-12-21 Thread Colin Harrison
Hi, Reviewed-by: Colin Harrison colin.harrison at virgin.net And first reported in October... http://lists.x.org/archives/xorg-devel/2012-October/033868.html Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH] dix/resource: bug out if we get 0 type resource added

2012-12-04 Thread Colin Harrison
Hi, It gets called, for me (MinGW build for Windows), and messes up xrestop, but I haven't traced back through libXfont, to try and work out the logic or why. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH] dix/resource: bug out if we get 0 type resource added

2012-12-04 Thread Colin Harrison
Hi, I still use this empirical patch (AKA a bodge!) to fix the xrestop crash. http://lists.x.org/archives/xorg-devel/2012-July/032898.html Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH proto/x11proto] Adjust windows.h wrapping to work with MinGW-w64 headers as well

2012-10-30 Thread Colin Harrison
Hi, http://lists.x.org/archives/xorg-devel/2012-October/034096.html works for me (MinGW 32-bit) for both Xwinsock.h and Xwindows.h Reviewed-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH libXfont] Omit catalogue support on systems without symlinks

2012-10-29 Thread Colin Harrison
Hi, That's much better than my hatchet job patch. Reviewed-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH proto/x11proto] Adjust windows.h wrapping to work with MinGW-w64 headers as well

2012-10-29 Thread Colin Harrison
Hi, Jon's patch to Xwindow.h is as far as I get OK at the moment...your extras cause me problems in a 32-bit build of the xserver. I'll get back, when I have time, with the reason...quick look...something to do with the INT64's used in wgl wrappers. Thanks, Colin Harrison

Re: [PATCH 2/4] doc: Update documentation about Windows platforms support

2012-10-26 Thread Colin Harrison
Hi, At least NT 5.1 it is then. Reviewed-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo

Re: [PATCH 2/4] doc: Update documentation about Windows platforms support

2012-10-23 Thread Colin Harrison
. Luckily most old Windows stuff (let's say 5.1 now defines old!) will probably still run on Windows 8 (well not on 8 RT...but that's for big cloudy phones...used for putting your private data on someone else's machine...somewhere...for 'non-evil' search and use by people unknown :) Thanks, Colin Harrison

Re: [PATCH lib/libXaw] Include winsock header on WIN32 to provide fd_set etc.

2012-10-22 Thread Colin Harrison
Hi, Ryan's change to libXaw/src/TextAction.c is OK by me. Reviewed-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH lib/libXpm] Define NO_ZPIPE when building for MinGW

2012-10-22 Thread Colin Harrison
Hi, Jon's change to libXpm/configure.ac is OK by me. Reviewed-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH lib/libXfont] Provide a dummy readlink on WIN32

2012-10-22 Thread Colin Harrison
Hi, I have just used something like this to avoid the symlink problem... --- ./src/fontfile/save_catalogue.c 2011-09-17 07:30:41.710991917 +0100 +++ ./src/fontfile/catalogue.c 2011-11-03 21:12:30.800542536 + @@ -154,6 +154,7 @@ } CatalogueUnrefFPEs (fpe); +#ifndef __MINGW32__

Re: [PATCH lib/libXpm] Define NO_ZPIPE when building for MinGW

2012-10-22 Thread Colin Harrison
) I lazily just like it to compile :) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH proto/x11proto] Adjust windows.h wrapping to work with MinGW-w64 headers as well

2012-10-21 Thread Colin Harrison
Hi, Jon's changes to proto/x11proto Xwindows.h are OK by me. Reviewed-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH xproto] Do not use visibility attributes on MinGW

2012-10-15 Thread Colin Harrison
Hi, That patch is essential. Reviewed-by and Tested-by: Colin Harrison colin.harri...@virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH 0/7] Resume breaking ABI

2012-10-05 Thread Colin Harrison
died or needs to be killed */ int priority; Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 0/7] Resume breaking ABI

2012-10-05 Thread Colin Harrison
Hi, Probably needs to be 'unsigned int' instead. I still don't know if we can use the enum type here. My compiler is happy with 'unsigned int', which is the safest bet I reckon for all (I had to dig out my KR ANSI C on this...and read it once more!) Thanks, Colin Harrison

Re: [PATCH 0/7] Resume breaking ABI

2012-10-05 Thread Colin Harrison
noClientException; /* this client died or needs to be killed */ int priority; Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 0/7] Resume breaking ABI

2012-10-05 Thread Colin Harrison
Hi, Thinking about this after strong coffee: all those bit-fields would be better unsigned... --- ./include/save_dixstruct.h 2012-10-05 01:24:03.981982326 +0100 +++ ./include/dixstruct.h 2012-10-05 20:13:19.803253520 +0100 @@ -90,12 +90,12 @@ typedef struct _Client { Mask

Re: [PATCH 0/7] Resume breaking ABI

2012-10-04 Thread Colin Harrison
Hi, In xserver/include/dixstruct.h struct _Client: isn't clientState type ClientState not int? Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH v7 04/15] Add LogMessageVerbSigSafe() for logging messages while in signal context

2012-08-17 Thread Colin Harrison
Hi, Jon Turney: wrote: Is there a typo here and this should be an #ifndef WIN32 guard around a use of fsync(), like the other uses of fsync() in log.c? fysnc() can be replaced with _commit() in this instance for MinGW. Thanks, Colin Harrison

[PATCH] Xext/xres.c: Possible buffer underrun

2012-07-23 Thread Colin Harrison
11:16:44.191904782 +0100 +++ ./Xext/xres.c 2012-07-16 16:19:50.078292944 +0100 @@ -274,7 +274,7 @@ { int *counts = (int *) cdata; -counts[(type TypeMask) - 1]++; +counts[(type TypeMask)]++; } static int Thanks, Colin Harrison

Re: [PATCH 0/3] extmod changes fallout

2012-07-12 Thread Colin Harrison
Hi, All Jon's series works OK for me: Reviewed-by: Colin Harrison colin.harrison at virgin.net Tested-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: git pull api break - squashed

2012-06-05 Thread Colin Harrison
(XWIN_CLIPBOARD) || defined(XWIN_MULTIWINDOW) -winScreenPriv((ScreenPtr) pBlockData); +winScreenPriv(pScreen); #endif MSG msg; Etc. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: xserver: Branch 'master' - 14 commits

2012-05-15 Thread Colin Harrison
] Trivial to fix with... --- ./dix/save_enterleave.c 2012-03-26 18:46:59.432816397 +0100 +++ ./dix/enterleave.c 2012-05-14 20:51:43.343698453 +0100 @@ -35,6 +35,7 @@ #include scrnintstr.h #include exglobals.h #include enterleave.h +#include exevents.h /** * @file Thanks, Colin Harrison

Re: [PATCH] os: Add CryptoAPI as a choice of SHA1 implementation

2012-05-02 Thread Colin Harrison
Reviewed-by: Colin Harrison Tested-by: Colin Harrison This patch works well for me. However the line.. #define WIN32_LEAN_AND_MEAN in os/xsha1.c is superfluous as the code should be built with that defined elsewhere. Thanks, Colin Harrison ___ xorg

Re: [PULL updated] XQuartz pending formatting cleanup

2012-03-26 Thread Colin Harrison
Hi, Why did the line va_start(args, f); get removed from xserver/os/log.c? Isn't args uninitialized without it? Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: indent quirks

2012-03-25 Thread Colin Harrison
mere mortals. e.g. MakeHost(host, len) if (!host) return; Should be MakeHost(host, len) if (!host) return; Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH] render: don't bother with animated cursors on floating slaves (#39989)

2012-02-15 Thread Colin Harrison
Hi, On Wed, Feb 15, 2012 Peter Hutterer wrote: This is the corrected version after the initial fix in bbb6b8c834e0e1491ca14403b5d0840dd14380d3. Works for me. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Colin Harrison
Hi, This looks like it's missing x = dx; y = dy; With this in I get no mouse events (on the left monitor) when the main display is not leftmost with multiple monitors. The casting is probably messing up negative x's on Windows? As in the [PULL] I can't detect any position errors.

Re: [PATCH] render: don't bother with animated cursors on floating slaves (#39989)

2012-01-26 Thread Colin Harrison
Hi, On my Windows build this patch... diff --git a/render/animcur.c b/render/animcur.c index 4cf1fdf..0f174fd 100644 --- a/render/animcur.c +++ b/render/animcur.c @@ -208,6 +208,9 @@ AnimCurDisplayCursor (DeviceIntPtr pDev, AnimCurScreenPtras = GetAnimCurScreen(pScreen); Bool

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Colin Harrison
Hi, Looking into it further the code at the end of miPointerSetPosition() maybe the cause of this... /* In the event we actually change screen or we get confined, we just * drop the float component on the floor * FIXME: only drop remainder for ConstrainCursorHarder, not for screen

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Colin Harrison
Hi, Daniel wrote: Why are you actually calling miPointerSetPosition at all? Someone had to be daft enough to use it. As in if it isn't defined static then it must be useful And if it is then I want to access it anyway :) It's late...more coffee is required to wash away the dust! Thanks,

Re: [PATCH] Remove hw/xwin/xlaunch

2011-07-09 Thread Colin Harrison
Hi, I agree, the xlaunch directory should now be removed. Reviewed-by: Colin Harrison colin.harrisom at virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH 2/2] glx: Synchronize Xserver glx/rensize.c with mesa src/glx/compsize.c

2011-06-30 Thread Colin Harrison
GL_422_AVERAGE_EXT: case GL_422_REV_AVERAGE_EXT: case GL_DEPTH_STENCIL_NV: case GL_DEPTH_STENCIL_MESA: + case GL_YCBCR_422_APPLE: case GL_YCBCR_MESA: case GL_LUMINANCE_ALPHA: elementsPerGroup = 2; Thanks, Colin Harrison

Re: [PATCH] glx: Add _glapi_create_table_from_handle

2011-06-27 Thread Colin Harrison
Hi, I just leave glapi_gentable.c out of my xserver build. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: libXdmcp is not ready for Windows

2011-04-21 Thread Colin Harrison
Hi, Yes WSAStartup() is called by an application and is not needed in this library. I always link to Winsock ws2_32 and replace all 'int fd's with 'SOCKET fd' in all apps. Thanks, Colin ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 0/3] XWin: Find GL specs, rather than downloading them

2011-04-17 Thread Colin Harrison
Hi, A move in the right direction that is OK by me. Reviewed-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: Current tinderbox regression (xserver, randr)

2011-02-23 Thread Colin Harrison
haven't got suitable tests to say Rand 1.4 is OK. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] change output of colors to hex instead of decimal

2011-01-28 Thread Colin Harrison
Hi, Now xset has this, what about xdpyinfo? At xdpyinfo.c:512 Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] Typo in xserver Xvasprintf()

2010-12-09 Thread Colin Harrison
; vsnprintf(*ret, size + 1, format, va); -ret[size] = 0; +(*ret)[size] = 0; return size; #endif } Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH] Typo in xserver Xvasprintf()

2010-12-09 Thread Colin Harrison
Hi, Alan Coopersmith wrote: ...since the vsnprintf should be null terminating it... Best forced to be always null..it's anarchy, with this functions family, outside the world of *nix :) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] Fix Xwin build after af0f9f91

2010-12-08 Thread Colin Harrison
Hi, Jon's fix is good for me Reviewed-by: Colin Harrison colin.harrison at virgin.net Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

[PATCH] Comparison between pointer and integer in latest xserver/dix/dispatch.c

2010-10-13 Thread Colin Harrison
)) +if (WindowDrawable(pDraw-type)) { WindowPtr pWin = (WindowPtr)pDraw; rep-x = pWin-origin.x - wBorderWidth (pWin); Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH 2/2] xwin: Remove some undue paranoia about UNDRAWABLE_WINDOW

2010-10-11 Thread Colin Harrison
Hi, I don't even compile those three files in Xming xserver builds. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] Missing end comment in libXpm/src/parse.c

2010-10-07 Thread Colin Harrison
or otherwise to promote the sale, use or other dealings * in this Software without prior written authorization from GROUPE BULL. + */ /*** **\ * parse.c: Thanks, Colin Harrison

Obfuscated code in xserver/os/io.c ?

2010-09-21 Thread Colin Harrison
(); is what it does at present. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Cygwin/X: Fix glxWinCreateDrawable() for API change

2010-08-10 Thread Colin Harrison
Hi, I've had to use these changes myself since commit 9de0e31746d5f0d9d39d11c94ec3cbc04a9935fc (dri2: Take an XID for tracking the DRI2 drawable, 11 May 2010), so am very happy to add 'Tested-by' and 'Reviewed-by' to Jon's patch. Thanks, Colin Harrison

Re: [PATCH] rootless: fix uninitialized private key assert in non-rootless modes on cygwin

2010-08-04 Thread Colin Harrison
Hi, I've reviewed and tested this patch, but only using the XWin DDX. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 0/3] GLX changes to support XWin AIGLX

2010-07-20 Thread Colin Harrison
Hi, I'm happy to say Reviewed-by: for these changes. I'm already using most of them :) Other users mileage may differ with different make methods/environments, and I don't use dixmods. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] rootless: Adjust the frame size of the native root window in RootlessResizeWindow

2010-07-19 Thread Colin Harrison
Hi, Jeremy wrote: my guess is that you guys don't even enter this codepath. You're right, I can't currently get to that code. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH] rootless: change the last calls to compatibility wrapper fbCopyRegion()

2010-07-17 Thread Colin Harrison
fbDots wfbDots #define fbDots16 wfbDots16 #define fbDots24 wfbDots24 Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] rootless: change the last calls to compatibility wrapper fbCopyRegion()

2010-07-16 Thread Colin Harrison
((DrawablePtr) pWin, (DrawablePtr) pWin, 0, rgnDst, dx, dy, fbCopyWindowProc, 0, 0); /* prgnSrc has been translated to dst position */ Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: libXfont: Changes to 'master'

2010-07-11 Thread Colin Harrison
instead. Thanks Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: libXfont: Changes to 'master'

2010-07-11 Thread Colin Harrison
Hi, Looks like this libXfont problem is finally fixed in all tinderbox builds. Thanks Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] XWin: Fix for static libXfont use

2010-07-09 Thread Colin Harrison
themselves at least once */ weak long serverGeneration = 1; +#endif in ./src/util/miscutil.c Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo

[PATCH] XWin: Fix for static libXfont use

2010-06-28 Thread Colin Harrison
tinderbox. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] XWin: Fix for static libXfont use

2010-06-28 Thread Colin Harrison
else needs serverGeneration other than the xserver? Fixing the xserver build for Cygwin/X should be the top priority and my patch does that (but the Cygwin/X builders may disagree?) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH] XWin: Fix for static libXfont use

2010-06-28 Thread Colin Harrison
Hi, Tiago Vignattiw wrote all right, I do agree. So if WIN32 macro means Xming only then I'd give my review for your patch: No that covers all Microsoft Windows builds...but lets hear what the Cygwin/X people say. Their tinderbox build is busted (and Xming) without this. See also

Re: [PATCH] XWin: Fix for static libXfont use

2010-06-28 Thread Colin Harrison
Hi, Jon Turney wrote: That is not correct. WIN32 is not defined under cygwin and I can't just change it to check defined(__MINGW__) || defined(__CYGWIN__) Woops..I should also stay well clear of WIN32 and _WIN32, they aren't mine to mess with. (force of habit). MinGW defines (__MINGW32__)

[PATCH] dixSetPrivate regressions in DDX xwin

2010-06-07 Thread Colin Harrison
(g_iGCPrivateKeyRec) extern DevPrivateKeyRecg_iPixmapPrivateKeyRec; Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] A few Cygwin/X patches

2010-03-18 Thread Colin Harrison
Hi, These all look good to me. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [Patch] hw/xwin: remove glx subdirectory.

2010-03-05 Thread Colin Harrison
Hi, Any new hw/xwin/glx code (thanks John Turney) does not need to include the glcore.h file. So best go ahead and sync up the gl headers and glapi/indirect code anyway between Mesa, glproto and xserver/glx. AFAICS should not be a problem for the xwin ddx. Thanks, Colin harrison

[PULL] Assorted Cygwin/X related patches

2010-02-11 Thread Colin Harrison
All look good to me. Thanks, Colin Harrison ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

-fno-strict-aliasing in CWARNFLAGS?

2010-02-03 Thread Colin Harrison
! I'm trialling this at the moment (with only libX11 and libX11 built no-strict). Thanks, Colin Harrison ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

PATCH Lost parenthesis in a recent libXaw change

2009-10-20 Thread Colin Harrison
Hi, Don’t we still need the parenthesis in the recent libXaw change? http://lists.freedesktop.org/archives/xorg-commit/2009-October/023796.html --- ./src/save_AsciiSrc.c 2009-10-20 16:29:07.0 +0100 +++ ./src/AsciiSrc.c2009-10-20 16:34:55.0 +0100 @@ -1292,7 +1292,7 @@

[PATCH] Lost parenthesis in a recent libXaw change

2009-10-20 Thread Colin Harrison
-Original Message- From: Colin Harrison [mailto:colin.harri...@virgin.net] Sent: 20 October 2009 17:34 To: 'xorg-devel@lists.x.org' Subject: PATCH Lost parenthesis in a recent libXaw change Hi, Don’t we still need the parenthesis in the recent libXaw change? http

Testing requested for pixman 0.16.1

2009-09-15 Thread Colin Harrison
Hi, How about this one in pixman-trap.c _pixman_edge_multi_init() Shouldn't the type of nx be 'pixman_fixed_48_16_t' not 'int'? Thanks, Colin Harrison ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

gcc3 source code in xorg-server-1.6.1.901

2009-05-31 Thread Colin Harrison
Hi, You get the same problem including 'recent' GNU GCC headers and libraries in your code. Just mention this exception to avoid taint... http://www.gnu.org/licenses/gcc-exception.html Thanks Colin ___ xorg-devel mailing list xorg-devel@lists.x.org