1451.
[ This bug was found by the Parfait 0.3.6 bug checking tool.
For more information see http://labs.oracle.com/projects/parfait/ ]
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/Region.c | 13 +++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git
.
For more information see http://labs.oracle.com/projects/parfait/ ]
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/FSErrDis.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/FSErrDis.c b/src/FSErrDis.c
index f89e49f..5e9d9d2 100644
--- a/src
On 02/12/11 12:48 AM, Dirk Wallenstein wrote:
On Thu, Feb 10, 2011 at 11:01:58PM -0800, Alan Coopersmith wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=34151
Use rfName consistently, instead of sometimes reverting to svValue[RULES_NDX]
Signed-off-by: Alan Coopersmith alan.coopersm
for Linux users) to
see what files it was trying to open.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org
Easy enough to accept the syntax documented in the man page, so accept
the -I flag with or without a space between -I and the directory argument.
https://bugs.freedesktop.org/show_bug.cgi?id=34117
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Dirk Wallenstein hals...@t
https://bugs.freedesktop.org/show_bug.cgi?id=34151
Use rfName consistently, instead of sometimes reverting to svValue[RULES_NDX]
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Fixed typo/merge error in v2, added additional change to use rfName as well
in the informational
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Dirk Wallenstein hals...@t-online.de
---
Just rebased to apply correctly after fixing the typo in patch 2.
setxkbmap.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/setxkbmap.c b
If we go through the loop, next is overwritten on the very first line.
If we don't go through the loop, next is never referenced again.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
New in this round of review, clearing a simple lint warning.
setxkbmap.c |2 +-
1 files
of us.
The if is just in the configure.ac Makefile.am, not the C code.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives
On 02/13/11 01:32 AM, Dirk Wallenstein wrote:
For the series (the two missing one):
Reviewed-by: Dirk Wallenstein hals...@t-online.de
Just a nitpick: Tabs now in Patch 3.
Thanks, amended to fix the tabs before pushing.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/FSErrDis.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/FSErrDis.c b/src/FSErrDis.c
index 5e9d9d2..5c1188f 100644
--- a/src/FSErrDis.c
+++ b/src/FSErrDis.c
@@ -104,7 +104,7 @@ int FSGetErrorText
needed.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
.gitignore|1 +
Makefile.am |2 +-
configure.ac |1 +
test/FSGetErrorText.c | 101 +
test/Makefile.am | 30 ++
5
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http
Documentation is quite out of date but still fits better here than
in the client library.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
---
doc/xml/Makefile.am |2 +-
doc/xml/Xinput.xml | 1209
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
xkb/ddxLoad.c | 21 +++--
xkb/maprules.c |3 +--
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/xkb/ddxLoad.c b/xkb/ddxLoad.c
index 51b5777..9686ea8 100644
--- a/xkb/ddxLoad.c
+++ b/xkb
The two functions have identical semantics, including safely returning
NULL when NULL is passed in (which POSIX strdup does not guarantee).
Some callers could probably be adjusted to call libc strdup directly,
when we know the input is non-NULL.
Signed-off-by: Alan Coopersmith alan.coopersm
Check the variable we just tried to malloc, not the string we're copying
and already checked for NULL at the beginning of the function.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
xkb/XKBGAlloc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/xkb
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
xkb/XKBGAlloc.c | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/xkb/XKBGAlloc.c b/xkb/XKBGAlloc.c
index f49aead..65f92fd 100644
--- a/xkb/XKBGAlloc.c
+++ b/xkb/XKBGAlloc.c
@@ -647,9 +647,7
On 02/14/11 06:18 AM, Dan Nicholson wrote:
On Sun, Feb 13, 2011 at 11:43 PM, Matthieu Herrb matthieu.he...@laas.fr
wrote:
On Sun, Feb 13, 2011 at 04:44:35PM -0800, Alan Coopersmith wrote:
On 02/13/11 12:51 PM, Matthieu Herrb wrote:
$ is not allowed in explicit rules.
Solaris make has
On 02/14/11 08:52 AM, Gaetan Nadon wrote:
On Mon, 2011-02-14 at 07:29 -0800, Alan Coopersmith wrote:
On 02/14/11 06:18 AM, Dan Nicholson wrote:
On Sun, Feb 13, 2011 at 11:43 PM, Matthieu Herrb matthieu.he...@laas.fr
mailto:matthieu.he...@laas.fr wrote:
On Sun, Feb 13, 2011 at 04:44:35PM
On 02/14/11 04:48 PM, Peter Hutterer wrote:
On Thu, Feb 10, 2011 at 12:00:11AM -0800, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
setxkbmap.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/setxkbmap.c b/setxkbmap.c
Allows easier comparison between builds to detect changes.
Helps reduce deltas in packaging systems that compare old new versions.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
list.c| 34 ++
list.h|1 +
mkfontscale.c
Removes duplicate lines in encodings.dir (noticed when sorting encodings.dir)
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
large/cns11643-1.enc |1 -
large/cns11643-2.enc |1 -
large/cns11643-3.enc |1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git
(path);
}
}
if (!rules)
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http
On 02/15/11 12:48 PM, Van de Bugger wrote:
On Tue, 2011-02-15 at 10:48 +1000, Peter Hutterer wrote:
On Thu, Feb 10, 2011 at 12:00:11AM -0800, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
setxkbmap.c |7 +++
1 files changed, 3 insertions
about xrandr events would review.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg
an idiot.
/usr/share/xkb is not that long.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives
-scanPrefix = 0;
break;
case DEVICE_CLOSE:
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org
so
few times that it's not worth a lot of effort worrying about.
Certainly in more general purpose code, allocating dynamically sized
buffers makes sense, but setxkbmap is very limited in the paths it
needs to deal with.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
On 02/15/11 06:22 AM, Dan Nicholson wrote:
On Mon, Feb 14, 2011 at 08:43:08AM +0100, Matthieu Herrb wrote:
On Sun, Feb 13, 2011 at 04:44:35PM -0800, Alan Coopersmith wrote:
On 02/13/11 12:51 PM, Matthieu Herrb wrote:
$ is not allowed in explicit rules.
Solaris make has the same limitation
It only includes X11/Xos.h, no headers or functions from libX11.
Due to a typo in Makefile.am (also fixed) it wasn't actually linking
with libX11 even though it had x11 in its PKG_CHECK_MODULES list.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Makefile.am |2
type ‘long unsigned int’
An int is likely to be sufficient for this buffer's size…
Whoops, that's what I get for only testing 32-bit with gcc. Thanks.
Pushed to master.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
)
Why do you believe this is needed? I see nothing in xdm that calls
functions in libXext. The greeter library does, but that's already
covered in:
PKG_CHECK_MODULES(XDMGREET, xt x11 xext)
What error are you getting that this solves?
--
-Alan Coopersmith-alan.coopersm
, such as:
Explicitly depend on libICE since ICE functions are called directly
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http
doesn't need to solve.)
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http
On 02/19/11 11:30 AM, Fernando Lemos wrote:
On Sat, Feb 19, 2011 at 6:47 PM, Alan Coopersmith
alan.coopersm...@oracle.com wrote:
On 02/19/11 10:28 AM, Mark Kettenis wrote:
Date: Sat, 19 Feb 2011 18:03:04 +
From: Fernando Lemos fernando...@gmail.com
/usr/bin/ld: session.o: undefined
filter that
redirects the dl* apis back to libc and doesn't hurt beyond a wasted page of
memory.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org
auth.c: In function `DefineSelf':
auth.c:1045: warning: unused variable `n'
error.c: In function `Debug':
error.c:116: warning: unused variable `buf'
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
xdm/auth.c |1 -
xdm/error.c |2 --
2 files changed, 0 insertions(+), 3
Stop hardcoding it to '*'. Allows setting a resource with no value to
display to advance the cursor without drawing text.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
greeter/Login.c | 11 ---
greeter/Login.h |2 ++
greeter/LoginP.h |4 +++-
man/xdm.man
If you want to have it, for feedback that's visible to the user but
harder to shoulder-surf, enable echoPasswd and set the echoPasswdChar
to empty/space.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
greeter/Login.c |6 --
1 files changed, 0 insertions(+), 6 deletions
declaration
greet.c:146: warning: shadowed declaration is here
greet.c: At top level:
greet.c:431: warning: declaration of 'dpy' shadows a global declaration
greet.c:146: warning: shadowed declaration is here
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
greeter/greet.c |2 --
1
declaration is here
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
greeter/Login.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/greeter/Login.c b/greeter/Login.c
index 5bc8c05..1a02846 100644
--- a/greeter/Login.c
+++ b/greeter/Login.c
@@ -1898,7
, SBUS:fb%d, sBus-fbNum);
+XNFasprintf(GDev-busID, SBUS:fb%d, sBus-fbNum);
}
}
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
Apologized-for-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle
On 02/20/11 03:24 AM, Mark Kettenis wrote:
From: Alan Coopersmith alan.coopersm...@oracle.com
Date: Sat, 19 Feb 2011 22:36:38 -0800
Stop hardcoding it to '*'. Allows setting a resource with no value to
display to advance the cursor without drawing text.
What's the motivation
: warning: declaration of 'valueMask' shadows a parameter
Login.c:1871: warning: shadowed declaration is here
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Modified as suggested by Mark Kettenis
greeter/Login.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git
Stop hardcoding it to '*'. Allows setting a resource with no value to
to advance the cursor without drawing text (as was previously the default).
Resolves https://bugs.freedesktop.org/show_bug.cgi?id=32794
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Replaces patch 2/5 3/5
Regression introduced by f8585c60831a8e5ddebce18bdd7e78d217a822c5
broke bounds checking for text displayed in input fields.
Since this makes each TEXT_WIDTH value only be used once, just use
them directly instead of storing the result in a variable.
Signed-off-by: Alan Coopersmith alan.coopersm
Refactor code assuming compiler is smart enough to optimize out any
that reduce to + 0 or - 0 if building without XPM defined.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
New in v2 of this series. Simplifies things a little for patch 5/5.
greeter/Login.c | 39
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
New in v2 of this series.
greeter/Login.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/greeter/Login.c b/greeter/Login.c
index 545f937..90b72fc 100644
--- a/greeter/Login.c
+++ b/greeter
= __container_of(pos-member.next, pos, member); \
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http
);
Was the original intent malloc(sizeof(CARD16) * (i + 1)) ?
That might be a bit clearer than letting the reader wonder why 2?
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
in from and executed
said task. it shall not be missed.
- to-fro → to/from
- list_for_each_entry_safe example fixed to actually use
list_for_each_entry_safe
- throught he - through the
Looks good to me.
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Xfuncproto.h.in | 19 ---
1 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in
index fd9f29b..97e925b 100644
--- a/Xfuncproto.h.in
+++ b/Xfuncproto.h.in
@@ -98,15 +98,9
of fscanf(%1024s), with buffer 'file'
Array size is 1024 bytes
at line 707 of mkfontscale.c in function 'readFontScale'.
[ This bug was found by the Parfait 0.3.6 bug checking tool.
For more information see http://labs.oracle.com/projects/parfait/ ]
Signed-off-by: Alan Coopersmith
checking tool.
For more information see http://labs.oracle.com/projects/parfait/ ]
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
list.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/list.c b/list.c
index fdf81d3..a10b5ed 100644
--- a/list.c
+++ b
-VideoModePtr = malloc(sizeof(CARD16) * (i + 1));
memcpy(block-VideoModePtr, modes, sizeof(CARD16) * i);
block-VideoModePtr[i] = 0x;
Thanks
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle
-users/2001/august/msg00086.html
http://stackoverflow.com/questions/923822/whats-the-use-of-do-while0-when-we-define-a-macro
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
to load rules file %s...\n, name);
+rules = XkbRF_Load(name, locale, wantDesc, wantRules);
+if (rules)
+{
+VMSG(7, Success.\n);
+};
Extra ; after }
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window
, the 32k buffers are allocated only when FD's are opened to
use them, instead of for the maximum possible number of FD's.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
common.c | 16
decode11.c | 11 +++
fd.c | 11 +++
fd.h
,
}
}
- entry[i]-parameter_signature = str_dup(real_sig);
+ entry[i]-parameter_signature = strdup(real_sig);
fill_in_entrypoint_offset(entry[i]-dispatch_stub, offset);
entry[i]-dispatch_offset = offset;
}
Reviewed-by: Alan Coopersmith alan.coopersm
changes locked down farther in
advance of the server release.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http
{
XKBLAYOUT,
XKBVARIANT,
XKBOPTIONS,
-/* The next two have become ServerFlags options */
-VTSYSREQ,
/* Obsolete keyboard tokens */
SERVERNUM,
LEFTALT,
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform
On 03/ 3/11 11:07 AM, Adam Jackson wrote:
Solaris 7 and older are not supported; Solaris 8 and later have (and
use) pthreads.
Signed-off-by: Adam Jackson a...@redhat.com
Acked-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith-alan.coopersm...@oracle.com
is consistent with the other
IntToXXX converters in this file.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/Converters.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/Converters.c b/src/Converters.c
index 95dd06b..6574ce0 100644
--- a/src/Converters.c
It's the only thing built in that directory, so we can use AM_CFLAGS
and drop the requirement for AM_PROG_CC_C_O in configure.ac
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
configure.ac |3 ---
util/Makefile.am |2 +-
2 files changed, 1 insertions(+), 4 deletions
No calls from libXmu were used, just one instance of one simple macro
that made the code harder to understand, so stop requiring it and
linking directly to it. (Of course, libXaw still depends on it, so
it will still be loaded indirectly.)
Signed-off-by: Alan Coopersmith alan.coopersm
when comparing
IPv4 IPv6), and we're already inside the if block to see if a -from was
passed at all.
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
(3Xt). The
result is that they can't be automatically followed from manpage
sanitizers such as dwww or emacs.
Signed-off-by: Gaetan Nadon mems...@videotron.ca
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith-alan.coopersm...@oracle.com
() + keepaliveDormancy * 1000;
}
! else if (timeOutTime (int)(GetTimeInMillis() - timeOutTime) = 0)
{
if (state == XDM_RUN_SESSION)
{
Please feel free to contact me with any questions.
-paul
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle
).
Which means that the exit flag doesn't get a chance to break the loop
until/unless there's an actual XEvent.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/Event.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/src/Event.c b/src/Event.c
index
Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives
(recently finished).
Long term, at least some of those libraries are likely to end up in future
katamaris, so perhaps this would be better replacing xcb-util with the new
modules that split out from it.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris
On 03/ 7/11 03:00 AM, walter harms wrote:
Am 06.03.2011 21:53, schrieb Alan Coopersmith:
From: Jordan Hayes jor...@bitway.com
https://bugs.freedesktop.org/show_bug.cgi?id=34715
XtAppNextEvent() doesn't return until there's an actual XEvent to be
handled; it handles Xt-internal events
. I'd thought they'd died completely,
but heard a few rattles of noise otherwise indicating they weren't
completely dead yet.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
On 03/ 7/11 10:57 AM, Cyril Brulebois wrote:
Hi Alan,
Alan Coopersmith alan.coopersm...@oracle.com (12/01/2011):
Now that we don't need to separately strlen the format string, put it
directly into the function call to clear gcc warnings of:
Initialize.c:397: warning: format not a string
Simple test case just compares the results of snprintf to a static buffer
with the new buffer returned by XtAsprintf.
Test run currently fails due to correctly detecting the bug in null
terminating the XtAsprintf returned string.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
On 03/ 8/11 07:09 AM, Cyril Brulebois wrote:
Don't write the null terminator to a random place, this can trigger some
segfault in XtOpenDisplay() and other annoyances.
- new_string[len] = '\0';
+ (*new_string)[len] = '\0';
Oops! Sorry. Yes.
Reviewed-by: Alan Coopersmith
. Seems like
we've accepted the glib test harness code as our common test code base for
in-tree unit tests.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel
, draw-info[i].id, client, 0,
DixReadAccess);
if (rc != Success)
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel
://patchwork.freedesktop.org/patch/4422/
Guess it must be right if you both independently came to the same fix. 8-)
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel
On 03/ 9/11 03:23 PM, Dave Airlie wrote:
This is a repost of the 3 unreviewed patches post comments by Alan.
I've dropped the patch I overlapped with ajax.
For the series:
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith-alan.coopersm
On 03/ 8/11 01:14 PM, Alan Coopersmith wrote:
On 03/ 8/11 07:09 AM, Cyril Brulebois wrote:
Don't write the null terminator to a random place, this can trigger some
segfault in XtOpenDisplay() and other annoyances.
-new_string[len] = '\0';
+(*new_string)[len] = '\0';
Oops! Sorry
think Daniel is right, since it's i 0,
not i = 0.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org
malloc debugging flags for various platforms to try to catch errors
with uninitialized memory (such as the recently fixed failure to terminate
the string).
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
v2: Thanks to suggestions from many on #xorg-devel IRC, set malloc debugging
On 03/10/11 06:19 AM, Gaetan Nadon wrote:
On Thu, 2011-03-10 at 10:47 +0100, Julien Cristau wrote:
On Wed, Mar 9, 2011 at 20:19:16 -0800, Alan Coopersmith wrote:
+# Memory checking support
+case $host_os in
+ solaris*)
+AC_CHECK_LIB([umem], [umem_alloc
On 03/10/11 04:27 AM, Cyril Brulebois wrote:
Alan Coopersmith alan.coopersm...@oracle.com (09/03/2011):
Only two simple test cases to start with:
v2: Thanks to suggestions from many on #xorg-devel IRC, set malloc debugging
environment variables for common platforms (only tested on Solaris
Solaris make won't substitute $ in explicit rules, only implicit ones
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
hw/xfree86/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am
index c23b1fd
around
realpath(3) developed on Debian. And it looks like Fedora was the only
one of the major distros not to have it. Anyway...
Well, as one of the major users of this script, I appreciate readlink over
realpath, since I only have readlink on Solaris as well.
--
-Alan Coopersmith
On 03/14/11 06:09 AM, Jon TURNEY wrote:
On 11/03/2011 22:37, Alan Coopersmith wrote:
Makefile.am |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ad5fefcc7a0a0beb1c02270d9f28c8b28da61199
Author: Alan Coopersmith alan.coopersm...@oracle.com
Date: Fri Mar 11 14
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
test/Event.c | 88 ++
test/Makefile.am |2 +-
2 files changed, 89 insertions(+), 1 deletions(-)
create mode 100644 test/Event.c
diff --git a/test/Event.c b/test/Event.c
malloc debugging flags for various platforms to try to catch errors
with uninitialized memory (such as the recently fixed failure to terminate
the string).
Requires xorg-macros 1.13 for XORG_ENABLE_UNIT_TESTS and XORG_WITH_GLIB.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
v3: Use
On 03/14/11 08:46 PM, Gaetan Nadon wrote:
On Mon, 2011-03-14 at 19:27 -0700, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
mailto:alan.coopersm...@oracle.com
---
test/Event.c | 88
++
test
On 03/14/11 08:53 PM, Gaetan Nadon wrote:
On Mon, 2011-03-14 at 19:27 -0700, Alan Coopersmith wrote:
v3: Use test macros from xorg-macros 1.1.3
Improved GNU libc detection for malloc debug environment variables
Fix MALLOC_PERTURB_ value to not be 0 or ~0 comment about why.
Need
= dnet;
- *(mybuf - 1) = '\0';
-}
-
*mybuf ++= '\0';
_host_len = strlen(_host);
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
, then it exits
with a fatal error.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info
analysis fixes I've been thinking we're
due for a 1.4.2 soon - thanks for taking care of it.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org
pictures there, never interacting with any
graphics hardware, so the output isn't displayed anywhere.
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org
with the developers there than on the general end-user support
mailing list of xorg@... Those projects probably also cross over into the
area covered by the dri-devel mailing list as well, since the DRI/DRM drivers
on the kernel side are covered there.
-Alan Coopersmith-alan.coopersm
])
+]) # XORG_WITH_W3M
# XORG_WITH_ASCIIDOC([MIN-VERSION], [DEFAULT])
#
--
-Alan Coopersmith-alan.coopersm...@oracle.com
Oracle Solaris Platform Engineering: X Window System
___
xorg-devel@lists.x.org: X.Org
On 03/21/11 05:39 PM, Gaetan Nadon wrote:
On Mon, 2011-03-21 at 16:59 -0700, Alan Coopersmith wrote:
Isn't w3m just one of the choices XMLTO might be using? I'm not sure we
want
to try to replicate all the XMLTO configure options in every one of our
modules.
There is also links and lynx
801 - 900 of 4927 matches
Mail list logo
