On Wed, Apr 21, 2010 at 09:28:40AM +0200, Takashi Iwai wrote:
> At Wed, 21 Apr 2010 16:31:29 +1000,
> Peter Hutterer wrote:
> >
> > On Wed, Apr 21, 2010 at 08:16:40AM +0200, Takashi Iwai wrote:
> > > At Wed, 21 Apr 2010 14:16:41 +1000,
> > > Peter Hutterer wrote:
> > > >
> > > > Thank you for the
[
We've been discussing off-list how best to make MAXSCREENS die. Now I
think the rationales and discussion need to be public, archived, and
reviewed by people who understand the server's history. Hope you don't
mind, Tiago. The code in question is here:
http://cgit.freedesktop.org/~vignatti/x
Several DDXes allow each screen to have at most one (or in some cases,
exactly one) installed colormap. These all use the same pattern: Declare
a global-lifetime array of MAXSCREENS ColormapPtrs, and index it by
screen number. This patch converts most of those to use screen privates
instead.
mi/mi
On Wed, Apr 21, 2010 at 08:36:59PM -0700, Keith Packard wrote:
> On Wed, 21 Apr 2010 16:51:17 -0700, "Pierre-Loup A. Griffais"
> wrote:
>
> > Since the revert is already pushed, here's a new version of the change as
> > Peter
> > pushed it including the teardown crash fix.
>
> Is this fixing som
Most DGA requests allow at most one client to be using DGA on each
screen. Instead of keeping track of the current client in a
MAXSCREEN-sized array, track it in a per-screen private.
Signed-off-by: Jamey Sharp
---
hw/xfree86/dixmods/extmod/xf86dga2.c | 70 ++
1
The DIX-layer Xv implementation provides a DDX-private hook for
per-screen data, which the xfree86 DDX was already using.
This extends that use to include offscreen surface records, replacing a
globally-allocated array that depended on MAXSCREENS.
Signed-off-by: Jamey Sharp
---
hw/xfree86/commo
On Wed, 21 Apr 2010 16:51:17 -0700, "Pierre-Loup A. Griffais"
wrote:
> Since the revert is already pushed, here's a new version of the change as
> Peter
> pushed it including the teardown crash fix.
Is this fixing some known issue? Or is it just that it seems sub-optimal
to change things arou
While VT-switched, FB access is disabled and should remain so. Trying to switch
modes in that state would re-enable it, potentially causing crashes if trying
to access it before the driver has recovered from the mode switch.
Thanks,
- Pierre-Loup
>From 4d526e470faeaa658cd2cb362d3132384baa478b Mo
Since the revert is already pushed, here's a new version of the change as Peter
pushed it including the teardown crash fix.
Thanks,
- Pierre-Loup
On 04/20/2010 06:47 PM, Peter Hutterer wrote:
This commit leads to a segfault on the very first XTS test case.
Backtrace:
0: /opt/xorg/bin/Xorg (x
On Wed, Apr 21, 2010 at 06:43:34PM +0300, Vignatti Tiago (Nokia-D/Helsinki)
wrote:
> On Wed, Apr 21, 2010 at 12:19:07AM +0200, ext Peter Hutterer wrote:
> >
> > stack the reviewed patches into a for-keith branch, push them to your $HOME
> > on people.freedesktop.org and then send Keith a pull req
Generates the git module version according to the "git describe HEAD"
If not building under git, #undef XORG_GIT_VERSION is written
Signed-off-by: Gaetan Nadon
---
xorg-macros.m4.in | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/xorg-macros.m4.in b/xorg-
On Wed, 2010-04-21 at 16:01 -0400, Gaetan Nadon wrote:
> On Wed, 2010-04-21 at 06:03 -0700, Dan Nicholson wrote:
>
> > On Tue, Apr 20, 2010 at 11:10 AM, Gaetan Nadon wrote:
> > > On Mon, 2010-04-19 at 21:34 -0700, Dan Nicholson wrote:
> > >
> > > On Mon, Apr 19, 2010 at 5:54 PM, Peter Hutterer
On Wed, 2010-04-21 at 06:03 -0700, Dan Nicholson wrote:
> On Tue, Apr 20, 2010 at 11:10 AM, Gaetan Nadon wrote:
> > On Mon, 2010-04-19 at 21:34 -0700, Dan Nicholson wrote:
> >
> > On Mon, Apr 19, 2010 at 5:54 PM, Peter Hutterer
> > wrote:
> >> On Mon, Apr 19, 2010 at 11:00:08PM +0200, Julien Cri
On Wed, 2010-04-21 at 16:06 +1000, Peter Hutterer wrote:
> On Mon, Apr 19, 2010 at 10:01:06PM -0400, Gaetan Nadon wrote:
> > On Tue, 2010-04-20 at 10:54 +1000, Peter Hutterer wrote:
> >
> > > On Mon, Apr 19, 2010 at 11:00:08PM +0200, Julien Cristau wrote:
> > > > On Mon, Apr 19, 2010 at 14:52:55
Reviewed-by: Jeremy Huddleston
On Apr 19, 2010, at 10:58, Tiago Vignatti wrote:
> Both dev and dev->button are already used before their checking were being
> performed. So check on the beginning.
>
> Signed-off-by: Tiago Vignatti
> ---
> Xi/xiquerydevice.c |5 -
> 1 files changed, 4 in
Reviewed-by: Jeremy Huddleston
On Apr 19, 2010, at 10:58, Tiago Vignatti wrote:
> just moved the srv assignment to before it's being used.
> ---
> xkb/xkbout.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/xkb/xkbout.c b/xkb/xkbout.c
> index 68ede90..9daac9a 1006
Reviewed-by: Jeremy Huddleston
On Apr 19, 2010, at 10:58, Tiago Vignatti wrote:
> ---
> xkb/xkbEvents.c |3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/xkb/xkbEvents.c b/xkb/xkbEvents.c
> index 33741e9..9755f98 100644
> --- a/xkb/xkbEvents.c
> +++ b/xkb/xkbEvents.
This patch also adds this change which isn't really described by the commit
description:
grab = mouse->deviceGrab.grab;
but you forgot to change this:
GrabPtr grab = mouse->deviceGrab.grab;
to
GrabPtr grab;
On Apr 19, 2010, at 10:58, Tiago Vignatti wrote:
> mo
On Wed, 21 Apr 2010 18:28:13 +0300, Tiago Vignatti
wrote:
> This issue was introduced in the first dump of the code in 2004. I haven't
> check what's the correct fix for it so I simply kept the behaviour of someone
> calling this and removed the unreachable code.
>
> Signed-off-by: Tiago Vignatt
Oh, so that was the reason behind the "This has been free()d before" comment
next to the FreePicture calls in the earlier version of that code. Sorry I
didn't track that down before reinstating them. Since FreeAllResources always
cleans up before CloseDownDevices, the attached patch should fix t
On Wed, 2010-04-21 at 11:22 +1000, Peter Hutterer wrote:
> On Tue, Apr 20, 2010 at 08:32:46PM -0400, Gaetan Nadon wrote:
> > Provides a common configure option for all x.org modules.
> > Script friendly for turning on debug in several modules.
> > Integrates easily into existing modules debug code
Matt Turner wrote:
On Wed, Apr 21, 2010 at 4:40 AM, Pauli Nieminen
wrote:
From: Tiago Vignatti
Signed-off-by: Tiago Vignatti
Signed-off-by: Pauli Nieminen
The whole series looks like it's got the _ext_-pauli... in the email address.
it's correct. This is the address of nokia's subcontra
On Wed, Apr 21, 2010 at 10:11 AM, Simon Thum wrote:
> Am 19.04.2010 20:26, schrieb Jamey Sharp:
>> We actually have proofs or proof sketches for parts of XCB, so for
>> example I am Confident that pure XCB applications will never fail to
>> insert GetInputFocus requests when needed to maintain seq
Twas brillig at 11:40:37 21.04.2010 UTC+03 when
ext-pauli.niemi...@nokia.com did gyre and gimble:
PN> diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c
PN> index 17df130..e8fd749 100644
PN> --- a/hw/xfree86/dri2/dri2ext.c
PN> +++ b/hw/xfree86/dri2/dri2ext.c
PN> @@ -42,7 +42,
On Wed, Apr 21, 2010 at 4:40 AM, Pauli Nieminen
wrote:
> From: Tiago Vignatti
>
> Signed-off-by: Tiago Vignatti
> Signed-off-by: Pauli Nieminen
The whole series looks like it's got the _ext_-pauli... in the email address.
Matt
___
xorg-devel@lists.x
On Wed, Apr 21, 2010 at 9:00 AM, Mark Kettenis wrote:
>> Date: Wed, 21 Apr 2010 15:34:48 +0300
>> From: Tiago Vignatti
>>
>> On Wed, Apr 21, 2010 at 11:53:04AM +0200, ext Mark Kettenis wrote:
>> >
>> > I'll reiterate an opinion stated here before. We should really try to
>> > *reduce* the number
Am 19.04.2010 20:26, schrieb Jamey Sharp:
> Yes, I used to know someone who used Promela/Spin, and that would be awesome.
>
> We actually have proofs or proof sketches for parts of XCB, so for
> example I am Confident that pure XCB applications will never fail to
> insert GetInputFocus requests wh
On 20 April 2010 23:44, Peter Hutterer wrote:
> On Tue, Apr 20, 2010 at 11:29:28PM +0100, David Gerard wrote:
[ re: http://www.x.org/wiki/JhBuildInstructions ]
>> Yes, if you look at the page you'll see I grovelled through setting it
>> up from scratch on several distros!
>> (I even tried on Sol
This issue was introduced in the first dump of the code in 2004. I haven't
check what's the correct fix for it so I simply kept the behaviour of someone
calling this and removed the unreachable code.
Signed-off-by: Tiago Vignatti
---
Keith, this patch is the last in my queue of Coverity findings.
On Wed, Apr 21, 2010 at 12:19:07AM +0200, ext Peter Hutterer wrote:
>
> stack the reviewed patches into a for-keith branch, push them to your $HOME
> on people.freedesktop.org and then send Keith a pull request.
>
> what I usually do is
> 'git request-pull master git://people.freedesktop.org/~wh
Signed-off-by: Jeremy Huddleston
---
mi/miexpose.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/mi/miexpose.c b/mi/miexpose.c
index 1c9c3a4..1a7cd0c 100644
--- a/mi/miexpose.c
+++ b/mi/miexpose.c
@@ -551,6 +551,9 @@ miPaintWindow(WindowPtr pWin, RegionPtr prgn, int
Hi Keith,
You will see here three sets of work, in this order:
- the death to Multibuffer extension
- a tiny patch to remove unused macro in configure
- several fix from Coverity static analysis tool
Thanks,
The following changes since commit b3ab978df861c08298f57529e3db980489055c35:
Keith Pa
On Wed, Apr 21, 2010 at 02:18:11PM +0200, Florian Mickler wrote:
> and which automagically selects all necessary protocols, extensions,
> fonts, and whatnot to make it work with your selections and after that
> you just start building and it fetches everything and compiles and so
> on... it probabl
On 21/04/10 15:32 +0200, Vignatti Tiago wrote:
> On Wed, Apr 21, 2010 at 03:00:52PM +0200, Mark Kettenis wrote:
> >
> > So instead you decide to increase the maintenance burden on everybody
> > else by making the code harder to read and requiring them to remember
> > to wrap new code that depends
On Wed, Apr 21, 2010 at 03:00:52PM +0200, ext Mark Kettenis wrote:
>
> So instead you decide to increase the maintenance burden on everybody
> else by making the code harder to read and requiring them to remember
> to wrap new code that depends on libdrm in more #ifdefs.
As I said, it's a trade-o
This patch adds the control of the embedded LED on the top-left corner
of new Synaptics devices. For LED control, it requires the patch to
Linux synaptics input driver,
https://patchwork.kernel.org/patch/93858/
When a sysfs file /sys/class/leds/psmouse::synaptics exists, the driver
assume
On Tue, Apr 20, 2010 at 11:06 PM, Peter Hutterer
wrote:
>
> would also be good checking through Matthias' script from radeonhd for any
> obvious use-cases that this patch doesn't cover. It certainly seems more
> complex.
Another way to handle this would be distributing a script from the
macro. So
On Tue, Apr 20, 2010 at 11:10 AM, Gaetan Nadon wrote:
> On Mon, 2010-04-19 at 21:34 -0700, Dan Nicholson wrote:
>
> On Mon, Apr 19, 2010 at 5:54 PM, Peter Hutterer
> wrote:
>> On Mon, Apr 19, 2010 at 11:00:08PM +0200, Julien Cristau wrote:
>>> On Mon, Apr 19, 2010 at 14:52:55 -0400, Gaetan Nadon
> Date: Wed, 21 Apr 2010 15:34:48 +0300
> From: Tiago Vignatti
>
> On Wed, Apr 21, 2010 at 11:53:04AM +0200, ext Mark Kettenis wrote:
> >
> > I'll reiterate an opinion stated here before. We should really try to
> > *reduce* the number of #ifdefs in the code base, not introduce new
> > ones.
>
On Wed, Apr 21, 2010 at 11:53:04AM +0200, ext Mark Kettenis wrote:
>
> I'll reiterate an opinion stated here before. We should really try to
> *reduce* the number of #ifdefs in the code base, not introduce new
> ones.
In general you're right. We prefer clear code without these ugly #ifdefs all
a
On Wed, 21 Apr 2010 13:37:51 +0200
Dirk Wallenstein wrote:
> Well, I don't want to challenge the tinderbox, I'm just pondering how
> the whole module-set could be augmented by some functions that are
> located a bit above git. And it needn't be full-fledged as I was saying.
> I mean, ..., full-fl
Well, I don't want to challenge the tinderbox, I'm just pondering how
the whole module-set could be augmented by some functions that are
located a bit above git. And it needn't be full-fledged as I was saying.
I mean, ..., full-fledged would probably constitute of a pedestal with a
monitor, some bu
> "Simon" == Simon Thum writes:
Simon> Hi all,
>> For absolute input devices (E.G. touchscreens) in multi-head setups, we
>> need a way to bind the device to an randr output. This adds the
>> infrastructure to evdev to allow us to do so.
Simon> I like the idea, but just if you haven't c
On 20-04-10 11:15, Michel Dänzer wrote:
One unexpected thing I found was that the (x,y) of the drawable, when it
was a pixmap, was not (0,0) but an apparently random number. This may
point to a problem with what I have done, but it is worked around (see
xf86xv.c:1819).
Are you using XAA?
Hi all,
> For absolute input devices (E.G. touchscreens) in multi-head setups, we
> need a way to bind the device to an randr output. This adds the
> infrastructure to evdev to allow us to do so.
I like the idea, but just if you haven't considered it: more or less the
same thing could be done in
> From: Pauli Nieminen
> Date: Wed, 21 Apr 2010 11:40:37 +0300
I'll reiterate an opinion stated here before. We should really try to
*reduce* the number of #ifdefs in the code base, not introduce new
ones.
> diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c
> index 8d2acf0..e60b3a4 1
This patch adds the support for Synaptics Clickpad devices.
It requires the change in Linux kernel synaptics input driver, found in
https://patchwork.kernel.org/patch/92435/
The kernel patch is already included in linux-input GIT tree, which
will hit Linus tree sooner or later.
When the ke
Signed-off-by: Pauli Nieminen
---
hw/xfree86/dri2/dri2.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c
index e60b3a4..255c112 100644
--- a/hw/xfree86/dri2/dri2.c
+++ b/hw/xfree86/dri2/dri2.c
@@ -864,18 +864,14 @
From: Tiago Vignatti
Signed-off-by: Tiago Vignatti
Signed-off-by: Pauli Nieminen
---
v3:
- Add error path that reports failed initialization to log.
hw/xfree86/dri2/dri2.c| 15 +--
hw/xfree86/dri2/dri2.h|2 +-
hw/xfree86/dri2/dri2ext.c |2 ++
3 files changed, 16
From: Tiago Vignatti
With this new hook drmAuthMagic becomes useless and should be deprecated.
You might want to implement AuthMagic on driver side instead.
Attention: ABI being break.
Signed-off-by: Tiago Vignatti
Signed-off-by: Pauli Nieminen
---
v3:
- Bump DRI2INFOREC_VERSION because xserv
From: Tiago Vignatti
Some drivers use DRI protocol but implement their own kernel rendering
manager. For these drivers, libdrm becomes useless.
Signed-off-by: Tiago Vignatti
Tested-by: Gaetan Nadon
Reviewed-by: Pauli Nieminen
---
configure.ac |8 +---
include/xorg-config.
On Wed, Apr 21, 2010 at 02:28:30AM +0700, Mikhail Gusarov wrote:
>
> There's 'repo' by Android people. Seem to be quite independent from
> android and doing exactly this (cloning bunch of repos and keeping track
> of them).
That's interesting. In particular that there is a global configuration,
w
At Wed, 21 Apr 2010 16:31:29 +1000,
Peter Hutterer wrote:
>
> On Wed, Apr 21, 2010 at 08:16:40AM +0200, Takashi Iwai wrote:
> > At Wed, 21 Apr 2010 14:16:41 +1000,
> > Peter Hutterer wrote:
> > >
> > > Thank you for the patch. Just as a heads-up, I'd like to wait with this
> > > until there's at
At Wed, 21 Apr 2010 16:53:14 +1000,
Peter Hutterer wrote:
>
> On Wed, Apr 21, 2010 at 08:26:41AM +0200, Takashi Iwai wrote:
> > At Wed, 21 Apr 2010 14:16:29 +1000,
> > Peter Hutterer wrote:
> > >
> > > On Thu, Apr 15, 2010 at 06:12:11PM +0200, Takashi Iwai wrote:
> > > > This patch adds the contr
On Die, 2010-04-20 at 21:16 +0100, David Gerard wrote:
> On 18 April 2010 17:21, Joel Feiner wrote:
>
> > Or you could use build.sh or jhbuild or moral equivalent. For testing, I
> > have an entire X system checked out and use jhbuild to update it. It also
> > automatically saves your work (vi
On Die, 2010-04-20 at 14:25 -0400, Adam Jackson wrote:
> Nothing terribly exciting, just ported to 1.8 branch which lacks some of
> the additional swap control work.
>
> ---
>
> The following changes since commit 7d5e6012df237c0d9d4741ca275751bc49f731ed:
> Julien Cristau (1):
> vfb: ad
56 matches
Mail list logo
