What kind of situation trigger the alloc_surface & free_surface function in video.c (video-driver)

2010-08-10 Thread Cui, Hunk
Hi, guys, Now I am researching about allocate the video overlay memory, some confuse to inquire. In xf86-video-geode -> lx_video.c -> LXInitOffscreenImages: alloc_surface = LXAllocateSurface; free_surface = LXFreeSurface; In xf86-video-ati

[PATCH build] Add -L command-line option to list build components.

2010-08-10 Thread Trevor Woerner
From: Trevor Woerner I don't know if others have a better way of doing this, but sometimes it would be nice to sit in the top-most directory and perform arbitrary git commands in all modules which are being built. E.g.: for module in `util/modular/build.sh -L`; do pushd $module git statu

Re: [PATCH app-bitmap 4/4] Remove unused file bitmap.icon

2010-08-10 Thread Alan Coopersmith
Gaetan Nadon wrote: > The file originally came with the the rest of the source in 2003 > Two years later it was added to EXTRA_DIST without explanantion > It has never been installed and is not present in Debian distro > It's not used during configuration and not used by the build. I can't see any

Re: [PATCH app-bitmap 3/4] man: remove whitespace as per git diff --check

2010-08-10 Thread Alan Coopersmith
Gaetan Nadon wrote: > Signed-off-by: Gaetan Nadon > --- > man/bitmap.man | 102 > > 1 files changed, 51 insertions(+), 51 deletions(-) > > diff --git a/man/bitmap.man b/man/bitmap.man > index 14a248e..3b5d585 100644 > --- a/man/bitmap.ma

Re: [PATCH app-bitmap 2/4] make: reshuffle lines and shorten the makefile

2010-08-10 Thread Alan Coopersmith
Gaetan Nadon wrote: > The previous patch did some aesthetic damage to it. > > Signed-off-by: Gaetan Nadon > --- > Makefile.am | 56 > 1 files changed, 20 insertions(+), 36 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index

Re: [PATCH app-bitmap 1/4] config: simplify building of shadow man pages

2010-08-10 Thread Alan Coopersmith
Gaetan Nadon wrote: > Store the shadow files in git as any other man page. We generated them in the autotool conversion because that's what was done in Imake - though in Imake, there were different rules for different platforms (some created the shadow files like we do now, others made symlinks or

Re: libX11 1.3.5 ?

2010-08-10 Thread Alan Coopersmith
Adam Jackson wrote: > On Mon, 2010-08-09 at 21:58 -0700, Alan Coopersmith wrote: > >> If anyone wants to suggest any more fixes or quibble about content >> for 1.3.5, please speak up soon, otherwise I'll push a release in a >> day or two. (And if that one has problems, we can always make a 1.3.6.

[PATCH app-bitmap 4/4] Remove unused file bitmap.icon

2010-08-10 Thread Gaetan Nadon
The file originally came with the the rest of the source in 2003 Two years later it was added to EXTRA_DIST without explanantion It has never been installed and is not present in Debian distro It's not used during configuration and not used by the build. Signed-off-by: Gaetan Nadon --- Makefile.

[PATCH app-bitmap 3/4] man: remove whitespace as per git diff --check

2010-08-10 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon --- man/bitmap.man | 102 1 files changed, 51 insertions(+), 51 deletions(-) diff --git a/man/bitmap.man b/man/bitmap.man index 14a248e..3b5d585 100644 --- a/man/bitmap.man +++ b/man/bitmap.man @@ -1,14 +1,14 @

[PATCH app-bitmap 2/4] make: reshuffle lines and shorten the makefile

2010-08-10 Thread Gaetan Nadon
The previous patch did some aesthetic damage to it. Signed-off-by: Gaetan Nadon --- Makefile.am | 56 1 files changed, 20 insertions(+), 36 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9afde64..6771ce9 100644 --- a/Makefile

[PATCH app-bitmap 1/4] config: simplify building of shadow man pages

2010-08-10 Thread Gaetan Nadon
Store the shadow files in git as any other man page. Move man pages to man dir and use the common makefile Local fix for bug 5628 in commit d8f719a352cd4d4ace60566b73a077175940a351 is not required as the problem has been fixed in util-macros d9062e4077ebfd0985baf8418f3d0f111b9ddbba Signed-off-by:

Re: X11R7.6 katamari planning

2010-08-10 Thread Julien Cristau
On Tue, Aug 10, 2010 at 00:02:38 -0700, Alan Coopersmith wrote: > It's getting to be about that time again, so we should begin > working on the 7.6 katamari releases. > > To start things off, a proposed schedule: > > August 20: > - Xorg-server 1.9.0 release according to > http://www.x.org

Re: [PATCH] xace: Invalid reference to out-of-scope data.

2010-08-10 Thread Alan Coopersmith
Chris Wilson wrote: > The callback data passed by reference to the hook was allocated on stack > within the scope of the case statement. The compiler is free to reuse > any of that stack space whilst making the function call so we may end up > passing garbage into the callback. > > References: >

Re: [PATCH 1/3] evdev: Revert "Set all valuators for relative motion events (#24737)"

2010-08-10 Thread Chase Douglas
On Tue, 2010-08-10 at 22:31 +0200, Bartosz Brachaczek wrote: > It isn't necessary to post zero-deltas to X Server. In order not to post > uninitialized "v" array we should rather simply initialize it. > > This reverts commit c1f16a4f59a584ab4546c2f16e20b06703042057. On a cursory glance this seems

[PATCH 3/3] evdev: Don't post REL_MISC events as axis motion. (#24737)

2010-08-10 Thread Bartosz Brachaczek
Some devices, notably A4Tech X-750F, send unknown events with non-zero value after almost every other event which kernel interprets as REL_MISC. It results in a motion event sent between all key press/release events, which is incorrect and may unnecessarily trigger drag'n'drop actions. X.Org Bug 2

[PATCH 2/3] evdev: Initialize valuators array. (#24737)

2010-08-10 Thread Bartosz Brachaczek
The array needs to be filled with zeros, otherwise we may end up sending it with random values if non-zero values aren't in one row (which is the case for A4Tech X-750F which sends REL_MISC events without a reason). X.Org Bug 24737 Signed-off-by

[PATCH 1/3] evdev: Revert "Set all valuators for relative motion events (#24737)"

2010-08-10 Thread Bartosz Brachaczek
It isn't necessary to post zero-deltas to X Server. In order not to post uninitialized "v" array we should rather simply initialize it. This reverts commit c1f16a4f59a584ab4546c2f16e20b06703042057. Signed-off-by: Bartosz Brachaczek --- src/evdev.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH] xace: Invalid reference to out-of-scope data.

2010-08-10 Thread Chris Wilson
The callback data passed by reference to the hook was allocated on stack within the scope of the case statement. The compiler is free to reuse any of that stack space whilst making the function call so we may end up passing garbage into the callback. References: Bug 18451 - Xorg server 1.5.2 SE

[PATCH xset] Spelling fix in help docs.

2010-08-10 Thread Robert Hooker
From: Bryce Harrington Reviewed-by: Robert Hooker Signed-off-by: Bryce Harrington --- xset.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xset.c b/xset.c index d2ec956..17c7b39 100644 --- a/xset.c +++ b/xset.c @@ -1660,8 +1660,8 @@ usage(char *fmt, ...) #ifdef F

Re: protocol & driver releases needed for Xorg 1.9

2010-08-10 Thread Alan Coopersmith
Matt Turner wrote: >> xf86-video-glide: >>24 commits since 1.2.24, including: >> Matt Turner: >> Use libc instead of deprecated libc wrappers for malloc/calloc/free. > > I think this is supposed to be xf86-video-glint, instead of glide. > (And 1.2.4 instead of 1.2.24) Yeah - I fail

Re: protocol & driver releases needed for Xorg 1.9

2010-08-10 Thread Matt Turner
> xf86-video-glide: >        24 commits since 1.2.24, including: >   Matt Turner: >      Use libc instead of deprecated libc wrappers for malloc/calloc/free. I think this is supposed to be xf86-video-glint, instead of glide. (And 1.2.4 instead of 1.2.24) Given a bit of guidance on how to sign and

Re: [PATCH v2] input: constify valuators passed in by input drivers.

2010-08-10 Thread Keith Packard
On Tue, 10 Aug 2010 15:05:48 +1000, Daniel Stone wrote: > malloc() in a signal handler ftl - I guess you could just have a > static int copied_valuators[MAX_VALUATORS]. Good catch. -- keith.pack...@intel.com pgpGDYC7WnjRH.pgp Description: PGP signature ___

Re: [PATCH] qxl: Fix build against video ABI 8

2010-08-10 Thread Adam Jackson
On Tue, 2010-08-10 at 18:11 +1000, Christopher James Halse Rogers wrote: > PaintWindowBackground and PaintWindowBorder haven't been > used in a while and have been removed from the Screen > struct in Xserver 1.9. Applied, thanks! - ajax signature.asc Description: This is a digitally signed mess

Re: [PATCH] xace: Invalid reference to out-of-scope data.

2010-08-10 Thread Adam Jackson
On Tue, 2010-08-10 at 09:38 +0100, Chris Wilson wrote: > diff --git a/Xext/xace.c b/Xext/xace.c > index e10d837..c757cad 100644 > --- a/Xext/xace.c > +++ b/Xext/xace.c This hunk looks correct. > diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c > index b2daec7..3cbaa08 1006

Re: protocol & driver releases needed for Xorg 1.9

2010-08-10 Thread Adam Jackson
On Tue, 2010-08-10 at 00:34 -0700, Alan Coopersmith wrote: > glproto: Pushed 1.4.12. > kbproto: Pushed 1.0.5. > renderproto: Fixed the spec to reflect what we actually decided for recursive alpha maps (they're undefined, don't do that), and pushed 0.11.1. > videoproto: Pushed 2.3.1. > x11p

Re: [PATCH] xace: Invalid reference to out-of-scope data.

2010-08-10 Thread Alan Coopersmith
Chris Wilson wrote: > The callback data passed by reference to the hook was allocated on stack > within the scope of the case statement. The compiler is free to reuse > any of that stack space whilst making the function call so we may end up > passing garbage into the callback. Did the hw/xfree86/

Re: [PATCH] render: Avoid infinite loops in alpha map handling (#23581)

2010-08-10 Thread Adam Jackson
On Fri, 2010-05-21 at 09:08 -0700, Keith Packard wrote: > On Tue, 11 May 2010 14:12:52 -0400, Adam Jackson wrote: > > > I just want it to not trivially crash my server. I could care less > > about correctness for this. > > How about this? > > From 50be5e8ff00e734506d2bb0c25054d7648f0cf1e Mon S

Re: [PATCH v2] input: constify valuators passed in by input drivers.

2010-08-10 Thread Adam Jackson
On Tue, 2010-08-10 at 15:05 +1000, Daniel Stone wrote: > On Tue, Aug 10, 2010 at 01:59:13PM +1000, Peter Hutterer wrote: > > GPE modifies the valuators array passed in. Which means any driver using > > e.g. xf86PostButtonEventP(..., valuators) twice to emulate a button click > > will provide garbag

Re: libX11 1.3.5 ?

2010-08-10 Thread Adam Jackson
On Mon, 2010-08-09 at 21:58 -0700, Alan Coopersmith wrote: > If anyone wants to suggest any more fixes or quibble about content > for 1.3.5, please speak up soon, otherwise I'll push a release in a > day or two. (And if that one has problems, we can always make a 1.3.6.) The compose sequence upd

[PATCH build] Add -L command-line option to list build components.

2010-08-10 Thread Trevor Woerner
From: Trevor Woerner I don't know if others have a better way of doing this, but sometimes it would be nice to sit in the top-most directory and perform arbitrary git commands in all modules which are being built. E.g.: for module in `util/modular/build.sh -L`; do pushd $module git statu

Re: [PATCH build] Add -L command-line option to list components to build.

2010-08-10 Thread Pat Kane
I think the lines # Create the log file directory $SUDO mkdir -p ${DESTDIR}${PREFIX}/var/log should be inside of if [ -z "$LISTONLY" ]; then Reviewed-by: Patrick E. Kane Pat --- On Mon, Aug 9, 2010 at 11:39 PM, Trevor Woerner wrote: > From: Trevor Woerner > > I don't know if others

How to set Xfbdev background to transparent?

2010-08-10 Thread vrushali shinde
Hello All, Could anyone tell me how to set Xfbdev bacground as transperent? In InitRootWindow() function, I tried setting pWin->background.pixel = 0xFF00; //argb (a-00 r-00 g-ff b-00). This sets the background as green and seems like the alpha is not used. Could anyone tell me the place in XOrg

Re: [PATCH] rootless: fix uninitialized private key assert in non-rootless modes on cygwin

2010-08-10 Thread Jon TURNEY
On 10/08/2010 05:33, Keith Packard wrote: On Sat, 7 Aug 2010 14:32:26 +0100, Jon TURNEY wrote: +if (!rootlessWindowPrivateKeyRec.initialized) +return FALSE; + Please use the function 'dixPrivateKeyRegistered' instead of looking inside the structure. Thanks for pointing out th

Re: Kdrive performance degraded for gtkperf with EXA

2010-08-10 Thread vrushali shinde
Hello Adam, Thank you for the explaination. I will check for the overhead in setting hardware acceleration. If the overhead cant be reduced, I will try to set software rendering for the small operations and check if "Xfbdev with exa" still drops performance compared to only "Xfbdev" for gtkperf. I

[PATCH] xace: Invalid reference to out-of-scope data.

2010-08-10 Thread Chris Wilson
The callback data passed by reference to the hook was allocated on stack within the scope of the case statement. The compiler is free to reuse any of that stack space whilst making the function call so we may end up passing garbage into the callback. References: Bug 18451 - Xorg server 1.5.2 SE

[PATCH] qxl: Fix build against video ABI 8

2010-08-10 Thread Christopher James Halse Rogers
PaintWindowBackground and PaintWindowBorder haven't been used in a while and have been removed from the Screen struct in Xserver 1.9. Signed-off-by: Christopher James Halse Rogers --- src/qxl.h|2 ++ src/qxl_driver.c |7 ++- 2 files changed, 8 insertions(+), 1 deletions(-)

protocol & driver releases needed for Xorg 1.9

2010-08-10 Thread Alan Coopersmith
According to the schedule posted on http://www.x.org/wiki/Server19Branch we are now 10 days from the release of Xorg-server 1.9. Looking through the modules with changes in git since their last release, it looks like releases should happen in the next week or two for these if they should go out wi

Re[2]: Multikey autorepetition

2010-08-10 Thread Антон Ерофеевский
> > Антон has even written a patch to implement it! > > > > Is there any X guru who could explain why such behaviour would break > > totally the X11 paradigm... or review the patch? > > Peter maybe? > > Key repeat is defined in the XKB protocol spec somewhere. I don't remember > off-heart but if

X11R7.6 katamari planning

2010-08-10 Thread Alan Coopersmith
It's getting to be about that time again, so we should begin working on the 7.6 katamari releases. To start things off, a proposed schedule: August 20: - Xorg-server 1.9.0 release according to http://www.x.org/wiki/Server19Branch - Driver & protocol updates needed for 1.9.0 should

Re: [PATCH] Cygwin/X: Fix glxWinCreateDrawable() for API change

2010-08-10 Thread Colin Harrison
Hi, I've had to use these changes myself since commit 9de0e31746d5f0d9d39d11c94ec3cbc04a9935fc (dri2: Take an XID for tracking the DRI2 drawable, 11 May 2010), so am very happy to add 'Tested-by' and 'Reviewed-by' to Jon's patch. Thanks, Colin Harrison ___