[PATCH v3] dix: copy the valuators passed into GPE/GKVE/GProxE.

2010-08-12 Thread Peter Hutterer
GPE and friends modify the valuators array passed in. Which means any driver using e.g. xf86PostButtonEventP(..., valuators) twice to emulate a button click will provide garbage data on the second run. This is currently affecting the wacom driver, xf86PostButtonEventP() with valuators is required

[PULL] A few more XQuartz cleanups

2010-08-12 Thread Jeremy Huddleston
These were some general changes found during the XQuartz RandR work that I'd like to see land in 1.9 even though RandR will be landing post 1.9. The miext/rootless changes are in code specific to XQuartz (via #ifdef) and won't affect XWin. The following changes since commit 71af1f71c0492c36570

Re: [PATCH 3/3] evdev: Don't post REL_MISC events as axis motion. (#24737)

2010-08-12 Thread Peter Hutterer
On Tue, Aug 10, 2010 at 10:32:08PM +0200, Bartosz Brachaczek wrote: > Some devices, notably A4Tech X-750F, send unknown events with non-zero > value after almost every other event which kernel interprets as REL_MISC. > It results in a motion event sent between all key press/release events, > which

[PULL] PointerKeys fixes, two crashers for 1.9

2010-08-12 Thread Peter Hutterer
Keith, Please pull from the repo below, it's the second time for the (hopefully last) PointerKeys fixes. The two patches by Alan and Jesse fix a crash each, one when removing the mouse, the other one when the keyboard driver is configured in the xorg.conf - a simple enough fix to sneak it in. C

Re: [RFC] use CLOCK_MONOTONIC_COARSE posix timer instead of CLOCK_MONOTONIC when calling the function of clock_gettime in xserver/os/util.c

2010-08-12 Thread ykzhao
On Fri, 2010-08-13 at 11:32 +0800, Julien Cristau wrote: > On Thu, Aug 12, 2010 at 09:47:23 +0800, ykzhao wrote: > > > when playing flash h.264 cif video workload, the cpu C0 usage is reduced > > from 43% to 42% while the video quality is not affected. > > > Is 43% vs 42% a really significant win

Re: [PATCH:xf86-input-keyboard] Close device fd when called with DEVICE_CLOSE

2010-08-12 Thread Peter Hutterer
On Thu, Aug 12, 2010 at 08:24:12PM -0700, Alan Coopersmith wrote: > Peter Hutterer wrote: > > On Wed, Aug 11, 2010 at 07:54:59PM -0700, Alan Coopersmith wrote: > >> From: Aaron Zang > >> > >> Fixes Solaris bug 6886424: > >> VT - keyboard and mouse do not work when switching to vt7 > >> http://bu

Re: fpit and max X position for calibration (fwd)

2010-08-12 Thread Piotr Gluszenia Slawinski
-- Forwarded message -- Date: Fri, 13 Aug 2010 04:51:38 +0200 (CEST) From: Piotr Gluszenia Slawinski To: x...@freedesktop.org Subject: Re: fpit and max X position for calibration On Fri, 13 Aug 2010, Piotr Gluszenia Slawinski wrote: > >I've upgraded to xorg 1.8.2 and 1.2.4

RE: How to calculate the video overlay size? (xf86-video-geode & xf86-video-ati)

2010-08-12 Thread Cui, Hunk
Hi, Maarten & Alex, Through communicate with community guys on IRC (#xorg-devel channel), I have got some info about how to calculate the DstPitch size. I known the color data is split into chroma and luma channels, and the chroma channel is only sampled half as often, the docume

Re: [RFC] use CLOCK_MONOTONIC_COARSE posix timer instead of CLOCK_MONOTONIC when calling the function of clock_gettime in xserver/os/util.c

2010-08-12 Thread Julien Cristau
On Thu, Aug 12, 2010 at 09:47:23 +0800, ykzhao wrote: > when playing flash h.264 cif video workload, the cpu C0 usage is reduced > from 43% to 42% while the video quality is not affected. > Is 43% vs 42% a really significant win? How close is it to measurement noise? Cheers, Julien

Re: [PATCH:xf86-input-keyboard] Close device fd when called with DEVICE_CLOSE

2010-08-12 Thread Alan Coopersmith
Peter Hutterer wrote: > On Wed, Aug 11, 2010 at 07:54:59PM -0700, Alan Coopersmith wrote: >> From: Aaron Zang >> >> Fixes Solaris bug 6886424: >> VT - keyboard and mouse do not work when switching to vt7 >> http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6886424 >> >> Signed-off-by: A

Re: [PATCH xf86-input-keyboard] Don't set AutoRepeat if we're not actually using it.

2010-08-12 Thread Alan Coopersmith
Peter Hutterer wrote: > Autorepeat was removed from the driver with version 1.4.0. So there is not > much point in setting this option anymore. > > Signed-off-by: Peter Hutterer > --- > src/kbd.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/src/kbd.c b/src/kbd.

Re: [PATCH] DeepCopyPointerClasses should not copy kbdfeed->CtrlProc

2010-08-12 Thread Alan Coopersmith
Peter Hutterer wrote: > I'm not quite comfortable with this patch, I don't think it solves the right > issue. the devicePrivate is copied into the MD as well, so that should in > theory work (though I admit much of that code was achieved by > trial-and-error). Looks more like a dangling pointer tha

Re: [PATCH:xf86-input-mouse] MouseCtrl doesn't need to save values we never use

2010-08-12 Thread Pat Kane
The change does not break my Solaris 10 build. Reviewed-by: Patrick E. Kane Pat On Thu, Aug 12, 2010 at 8:33 PM, Peter Hutterer wrote: > On Wed, Aug 11, 2010 at 09:43:24PM -0700, Alan Coopersmith wrote: >> Makes it into a no-op, like evdev's PtrCtrl function, now that >> mouse acceleratio

Re: [PATCH] xfree86: parser: Fix using heap memory for driver names. (Fixes #17438)

2010-08-12 Thread Peter Hutterer
On Wed, Aug 04, 2010 at 11:55:22PM -0700, Jesse Adkins wrote: > I also put this patch in bugzilla, in case it might help somebody in the > future. > > While I'm at it, can I get some thoughts about logging this as a warning or > informational. What about deprecating this feature? > From e82132c1d

Re: [PATCH:xf86-input-mouse] MouseCtrl doesn't need to save values we never use

2010-08-12 Thread Peter Hutterer
On Wed, Aug 11, 2010 at 09:43:24PM -0700, Alan Coopersmith wrote: > Makes it into a no-op, like evdev's PtrCtrl function, now that > mouse acceleration is completely handled in dix. > > Signed-off-by: Alan Coopersmith > --- > src/mouse.c | 18 +++--- > src/xf86OSmouse.h |

Re: [PATCH:xf86-input-keyboard] sun_kbd: Add mappings for Hangul and Hanja keys on Korean keyboard

2010-08-12 Thread Peter Hutterer
On Wed, Aug 11, 2010 at 07:56:37PM -0700, Alan Coopersmith wrote: > From: Osamu Sayama > > Fixes Sun bug 6897086: > Hangul and Hanja keys on Korean PC 105 keyboard are not recognized > http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6897086 > > Signed-off-by: Alan Coopersmith > -

Re: [PATCH:xf86-input-keyboard] Close device fd when called with DEVICE_CLOSE

2010-08-12 Thread Peter Hutterer
On Wed, Aug 11, 2010 at 07:54:59PM -0700, Alan Coopersmith wrote: > From: Aaron Zang > > Fixes Solaris bug 6886424: > VT - keyboard and mouse do not work when switching to vt7 > http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6886424 > > Signed-off-by: Alan Coopersmith > --- > src

[PATCH keyboard] Remove unused keyboardOptions.

2010-08-12 Thread Peter Hutterer
These have been unused since May 2009 when the struct that used them was removed from the driver. See fe8d1f70fc7edce4f030766159aebae8f8a89ffc. Signed-off-by: Peter Hutterer --- src/kbd.c | 34 -- 1 files changed, 0 insertions(+), 34 deletions(-) diff --git a/s

[PATCH xf86-input-keyboard] Don't set AutoRepeat if we're not actually using it.

2010-08-12 Thread Peter Hutterer
Autorepeat was removed from the driver with version 1.4.0. So there is not much point in setting this option anymore. Signed-off-by: Peter Hutterer --- src/kbd.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/kbd.c b/src/kbd.c index a9d4890..3aab07d 100644 --- a/sr

Re: [PATCH] DeepCopyPointerClasses should not copy kbdfeed->CtrlProc

2010-08-12 Thread Peter Hutterer
On Thu, Aug 12, 2010 at 12:09:00AM -0700, Alan Coopersmith wrote: > The pointer drivers that have anything other than a no-op there assume > the device passed to CtrlProc on has their flavor of devicePrivate, > which the Virtual Core Pointer won't. > > Fixes Solaris bug 6950572: > X mouse driver

Re: [PATCH] Use GetMaster instead of direct u.master access in core procs

2010-08-12 Thread Peter Hutterer
On Thu, Aug 12, 2010 at 12:09:02AM -0700, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > > Requested by whot during IRC conversation of previous patches. > Also not tested beyond verifying "xset m" seemed to work > with a single physical mouse system. Reviewed-by: Peter Hutter

Re: [RFC] use CLOCK_MONOTONIC_COARSE posix timer instead of CLOCK_MONOTONIC when calling the function of clock_gettime in xserver/os/util.c

2010-08-12 Thread ykzhao
On Thu, 2010-08-12 at 22:47 +0800, Adam Jackson wrote: > On Thu, 2010-08-12 at 09:47 +0800, ykzhao wrote: > > > We tried one debug patch that uses the CLOCK_MONOTONIC_COARSE timer > > instead of CLOCK_MONOTONIC in xserver/os/utils.c. > > It sure would be nice if CLOCK_MONOTONIC_COARSE were docum

[PATCH damageproto 2/2] Add XDamageSubtractAndTrigger operation

2010-08-12 Thread James Jones
XDamageSubtractAndTrigger behaves exactly like XDamageSubtract except it receives an optional fence sync object. If the value of this object is not None, it is triggered by X once all the rendering associated with the damage regions being subtracted has completed. Signed-off-by: James Jones Revi

[PATCH damageproto 1/2] Document changes in damage proto version 1.2

2010-08-12 Thread James Jones
Signed-off-by: James Jones Reviewed-by: Pierre-Loup Griffais Reviewed-by: Aaron Plattner Reviewed-by: Robert Morell --- damageproto.txt | 57 +- 1 files changed, 55 insertions(+), 2 deletions(-) diff --git a/damageproto.txt b/damageproto.t

[PATCH damageproto 0/2] Add XDamageSubtractAndTrigger

2010-08-12 Thread James Jones
Adds the XDamageSubtractAndTrigger() request and bumps the damage protocol to version 1.2. Now with protocol spec updates including overview, justification, and intended usage of the new reqeust. James Jones (2): Document changes in damage proto version 1.2 Add XDamageSubtractAndTrigger opera

[PATCH xextproto 4/4] Add protocol for XSyncAwaitFence()

2010-08-12 Thread James Jones
Add the fence sync object equivalent of XSyncAwait() Signed-off-by: James Jones Reviewed-by: Aaron Plattner --- syncproto.h | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/syncproto.h b/syncproto.h index 7e0a568..1453e44 100644 --- a/syncproto.h +++ b/syncpr

[PATCH xextproto 3/4] Add XSyncQueryFence()

2010-08-12 Thread James Jones
Allows callers to query whether a given fence sync object is currently triggered or not. Signed-off-by: James Jones Reviewed-by: Aaron Plattner --- syncproto.h | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/syncproto.h b/syncproto.h index c3

[PATCH xextproto 2/4] Initial Fence Sync support

2010-08-12 Thread James Jones
Defines the protocol for creation and basic management of binary state sync objects. The following operations are defined: -Creation -Destruction -Trigger -Reset Signed-off-by: James Jones Reviewed-by: Aaron Plattner --- syncconst.h |6 -- syncproto.h | 56 +++

[PATCH xextproto 1/4] Document changes in XSync version 3.1

2010-08-12 Thread James Jones
Signed-off-by: James Jones Reviewed-by: Pierre-Loup Griffais Reviewed-by: Aaron Plattner Reviewed-by: Robert Morell --- specs/sync.xml | 219 +-- 1 files changed, 211 insertions(+), 8 deletions(-) diff --git a/specs/sync.xml b/specs/sync.xm

[PATCH xextproto 0/4] XSync Fence Objects (rev. 2)

2010-08-12 Thread James Jones
Adds support for binary sync objects. Objects are set to "triggered" using X commands that are executed relative to X rendering commands. Clients can wait for fence sync objcts to reach the triggered state using XSync APIs or using interop functionality in other APIs. This allows for efficient c

Re: Multikey autorepetition

2010-08-12 Thread Peter Hutterer
On Tue, Aug 10, 2010 at 11:27:01AM +0400, Антон Ерофеевский wrote: > > > Антон has even written a patch to implement it! > > > > > > Is there any X guru who could explain why such behaviour would break > > > totally the X11 paradigm... or review the patch? > > > Peter maybe? > > > > Key repeat is

Re: [PATCH] xfree86: parser: Fix using heap memory for driver names. (Fixes #17438)

2010-08-12 Thread Peter Hutterer
On Thu, Aug 05, 2010 at 11:28:54AM -0700, Alan Coopersmith wrote: > Jesse Adkins wrote: > > I also put this patch in bugzilla, in case it might help somebody in the > > future. > > > > While I'm at it, can I get some thoughts about logging this as a warning > > or informational. What about depreca

Re: input thread [was Re: [PATCH v2] input: constify valuators passed in by input drivers.]

2010-08-12 Thread Adam Jackson
On Thu, 2010-08-12 at 12:48 -0300, Fernando Carrijo wrote: > Adam Jackson wrote: > > > I do eventually want to see each ScreenRec factored out to its own > > thread. Right now in Xinerama rendering is serialized across all > > screens, which is terrible. > > > > If you did that, you'd have one

Re: input thread [was Re: [PATCH v2] input: constify valuators passed in by input drivers.]

2010-08-12 Thread Keith Packard
On Thu, 12 Aug 2010 16:38:53 +0300, "Vignatti Tiago (Nokia-MS/Helsinki)" wrote: > Each client can be thought as a reader... unless we remove all this bunch of > global structures shared among them. So several readers, right? From the perspective of the server, we have a single reader thread doi

Re: Fwd: Profiling Xorg

2010-08-12 Thread Pat Kane
BTW, here is an interesting line from the Bugs section of the manual: The profiled program must call "exit"(2) or return normally for the profiling information to be saved in the gmon.out file. Pat --- On Thu, Aug 12, 2010 at 11:26 AM, Pat Kane wrote: > The NetBSD gprof(1) man

Re: Fwd: Profiling Xorg

2010-08-12 Thread Pat Kane
The NetBSD gprof(1) man page says to use the -pg flag: http://netbsd.gw.com/cgi-bin/man-cgi?gprof+1+NetBSD-current On Thu, Aug 12, 2010 at 12:43 AM, Daniel Stone wrote: > On Thu, Aug 12, 2010 at 07:17:36AM +0200, Matthew Fincham wrote: >> I sent the email below to the Xorg mailing list,

Re: input thread [was Re: [PATCH v2] input: constify valuators passed in by input drivers.]

2010-08-12 Thread Fernando Carrijo
Adam Jackson wrote: > I do eventually want to see each ScreenRec factored out to its own > thread. Right now in Xinerama rendering is serialized across all > screens, which is terrible. > > If you did that, you'd have one thread for dispatch and core object > model, one for input, and one per G

Re: [RFC] use CLOCK_MONOTONIC_COARSE posix timer instead of CLOCK_MONOTONIC when calling the function of clock_gettime in xserver/os/util.c

2010-08-12 Thread Adam Jackson
On Thu, 2010-08-12 at 09:47 +0800, ykzhao wrote: > We tried one debug patch that uses the CLOCK_MONOTONIC_COARSE timer > instead of CLOCK_MONOTONIC in xserver/os/utils.c. It sure would be nice if CLOCK_MONOTONIC_COARSE were documented in the manual page for clock_gettime(). This is the first I'

Re: input thread [was Re: [PATCH v2] input: constify valuators passed in by input drivers.]

2010-08-12 Thread Adam Jackson
On Thu, 2010-08-12 at 16:17 +0300, Vignatti Tiago (Nokia-MS/Helsinki) wrote: > On Wed, Aug 11, 2010 at 08:04:08PM +0200, ext Adam Jackson wrote: > > > > Pipes are about as cheap of a notification mechanism as you can get and > > still be portable. On Linux the eventfd() API is a bit cheaper if al

Re: input thread [was Re: [PATCH v2] input: constify valuators passed in by input drivers.]

2010-08-12 Thread Vignatti Tiago (Nokia-MS/Helsinki)
On Wed, Aug 11, 2010 at 08:04:08PM +0200, ext Adam Jackson wrote: > > Pipes are about as cheap of a notification mechanism as you can get and > still be portable. On Linux the eventfd() API is a bit cheaper if all > you need is signaling across thread boundaries, which looks to be the > case for

Re: input thread [was Re: [PATCH v2] input: constify valuators passed in by input drivers.]

2010-08-12 Thread Vignatti Tiago (Nokia-MS/Helsinki)
On Wed, Aug 11, 2010 at 08:50:32PM +0200, ext Keith Packard wrote: > On Wed, 11 Aug 2010 14:04:08 -0400, Adam Jackson wrote: > > > Threads will help when we're in D state, but only to the extent that > > they're not blocked by the main server. If the server is holding a read > > lock for the inp

Re: What kind of situation trigger the alloc_surface & free_surface function in video.c (video-driver)

2010-08-12 Thread Alex Deucher
On Wed, Aug 11, 2010 at 11:06 PM, Cui, Hunk wrote: > Hi, Alex, >        Many thanks for your hints, about the xawtv, only know it is a > television viewer-X11 application, I will try to it, any other info, I will > reform to you. :) I think it might have only used it in conjunction with the old

Re: How to calculate the video overlay size? (xf86-video-geode & xf86-video-ati)

2010-08-12 Thread Maarten Maathuis
On Thu, Aug 12, 2010 at 12:15 PM, Cui, Hunk wrote: > Hi, Alex, > >> > In xf86-video-geode: >> >        lx_video.c -> LXCopyPlanar function, some codes make me confuse, >> > >> > ( >> > http://cgit.freedesktop.org/xorg/driver/xf86-video-geode/tree/src/lx_vid >> > eo.c#n224 ) >> >    YSrcPitch = (wi

RE: How to calculate the video overlay size? (xf86-video-geode & xf86-video-ati)

2010-08-12 Thread Cui, Hunk
Hi, Alex, > > In xf86-video-geode: > >        lx_video.c -> LXCopyPlanar function, some codes make me confuse, > > > > ( > > http://cgit.freedesktop.org/xorg/driver/xf86-video-geode/tree/src/lx_vid > > eo.c#n224 ) > >    YSrcPitch = (width + 3) & ~3; > >    YDstPitch = (width + 31) & ~31; > > > >

RE: what is the effect of RADEON_ALIGN (macros) in ATI-driver?

2010-08-12 Thread Cui, Hunk
Hi, Matt, Congratulations Matt! :-) Thank you for your help. Now I have a clear concept to understanding it. :) Following documents give me more help: http://www.ibm.com/developerworks/library/pa-dalign/ http://en.wikipedia.org/wiki/Data_structure_alignment

Re: [PATCH] DeepCopyPointerClasses should not copy kbdfeed->CtrlProc

2010-08-12 Thread Daniel Stone
On Thu, Aug 12, 2010 at 12:09:00AM -0700, Alan Coopersmith wrote: > The pointer drivers that have anything other than a no-op there assume > the device passed to CtrlProc on has their flavor of devicePrivate, > which the Virtual Core Pointer won't. > > Fixes Solaris bug 6950572: > X mouse driver

[PATCH] Stop checking or calling PtrCtrlProcs

2010-08-12 Thread Alan Coopersmith
None of them do anything useful now that pointer acceleration is entirely handled in the server. (Does not completely nuke yet, since that would be an API/ABI break.) Signed-off-by: Alan Coopersmith --- Discussed with daniels & whot on IRC, not deeply tested, but xset m seems to work as expect

[PATCH] Use GetMaster instead of direct u.master access in core procs

2010-08-12 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- Requested by whot during IRC conversation of previous patches. Also not tested beyond verifying "xset m" seemed to work with a single physical mouse system. dix/devices.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --gi

[PATCH] DeepCopyPointerClasses should not copy kbdfeed->CtrlProc

2010-08-12 Thread Alan Coopersmith
The pointer drivers that have anything other than a no-op there assume the device passed to CtrlProc on has their flavor of devicePrivate, which the Virtual Core Pointer won't. Fixes Solaris bug 6950572: X mouse driver crashes Xorg during unplug-plug the usb mouse device http://bugs.opensolaris.